<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>88657</bug_id>
          
          <creation_ts>2012-06-08 07:08:32 -0700</creation_ts>
          <short_desc>[WK2] Missing API to check whether WebKitTestRunner is being used</short_desc>
          <delta_ts>2012-09-21 14:18:16 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>59201</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Mario Sanchez Prada">mario</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>andersca</cc>
    
    <cc>benjamin</cc>
    
    <cc>cgarcia</cc>
    
    <cc>mrobinson</cc>
    
    <cc>sam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>644639</commentid>
    <comment_count>0</comment_count>
    <who name="Mario Sanchez Prada">mario</who>
    <bug_when>2012-06-08 07:08:32 -0700</bug_when>
    <thetext>In WK1, some ports use specific functions in WK1 to detect when DumpRenderTree is being used (see DumpRenderTreeSupport{Gtk|Qt}::setDumpRenderTreeModeEnabled), so they can make interesting decisions when initializing the WebView, such as installing mock clients instead of the &quot;good ones&quot; (e.g. GeolocationClientMock).

However, that feature seems to be missing in WK2 (or at least I could not find it) and I think it would be very useful too for similar situations, hence this bug. Maybe there&apos;s already a way to do this, in that case feel free to point it out and/or close this bug. Thanks

(CCing people I think might be interested on this)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>644652</commentid>
    <comment_count>1</comment_count>
      <attachid>146565</attachid>
    <who name="Mario Sanchez Prada">mario</who>
    <bug_when>2012-06-08 07:30:25 -0700</bug_when>
    <thetext>Created attachment 146565
Patch proposal</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>644689</commentid>
    <comment_count>2</comment_count>
    <who name="Mario Sanchez Prada">mario</who>
    <bug_when>2012-06-08 08:30:30 -0700</bug_when>
    <thetext>This doesn&apos;t depend on 59201. It *blocks* 59201</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>673334</commentid>
    <comment_count>3</comment_count>
    <who name="Mario Sanchez Prada">mario</who>
    <bug_when>2012-07-19 02:28:36 -0700</bug_when>
    <thetext>Ping reviewers?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>725075</commentid>
    <comment_count>4</comment_count>
      <attachid>146565</attachid>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2012-09-20 19:04:22 -0700</bug_when>
    <thetext>Comment on attachment 146565
Patch proposal

View in context: https://bugs.webkit.org/attachment.cgi?id=146565&amp;action=review

&gt; Source/WebKit2/ChangeLog:9
&gt; +        New API to allow declaring that WebKitTestRunner is running (on
&gt; +        initialization) and checking that value from the WebProcess.

But why?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>725748</commentid>
    <comment_count>5</comment_count>
    <who name="Mario Sanchez Prada">mario</who>
    <bug_when>2012-09-21 13:18:52 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; (From update of attachment 146565 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=146565&amp;action=review
&gt; 
&gt; &gt; Source/WebKit2/ChangeLog:9
&gt; &gt; +        New API to allow declaring that WebKitTestRunner is running (on
&gt; &gt; +        initialization) and checking that value from the WebProcess.
&gt; 
&gt; But why?

The reason is to do something similar to what it&apos;s done in WK1, where you need to  know when WebKit is running for its normal use case or when it&apos;s running for serving the DumpRenderTree, since the kind of geolocation provider that must use is different.

In the former case, the normal geolocation provider (e.g. Geoclue based) will be used, but for layout tests we need a special kind of geolocation provider (the mock provider) which allows us also to specify the position, so we can later check that the actual and expected results are the same.

As you can see in the patch for bug 59201, this new API is used in WebPage.cpp precisely to know when we will use the normal geolocation provider or the mock provider, so that&apos;s the reason of this API.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>725812</commentid>
    <comment_count>6</comment_count>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2012-09-21 14:11:44 -0700</bug_when>
    <thetext>&gt; The reason is to do something similar to what it&apos;s done in WK1, where you need to  know when WebKit is running for its normal use case or when it&apos;s running for serving the DumpRenderTree, since the kind of geolocation provider that must use is different.
&gt; 
&gt; In the former case, the normal geolocation provider (e.g. Geoclue based) will be used, but for layout tests we need a special kind of geolocation provider (the mock provider) which allows us also to specify the position, so we can later check that the actual and expected results are the same.
&gt; 
&gt; As you can see in the patch for bug 59201, this new API is used in WebPage.cpp precisely to know when we will use the normal geolocation provider or the mock provider, so that&apos;s the reason of this API.

This is not how you are supposed to do those tests.

Even if we had to change a client, that should be done through the injected bundle.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>725819</commentid>
    <comment_count>7</comment_count>
    <who name="Mario Sanchez Prada">mario</who>
    <bug_when>2012-09-21 14:18:16 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; [...]
&gt; This is not how you are supposed to do those tests.
&gt; 
&gt; Even if we had to change a client, that should be done through the injected bundle.

You are right. This is all conceptually broken, now I see it.

Thanks for the explanations. I&apos;m now closing this bug</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>146565</attachid>
            <date>2012-06-08 07:30:25 -0700</date>
            <delta_ts>2012-09-20 19:04:22 -0700</delta_ts>
            <desc>Patch proposal</desc>
            <filename>0001-2012-06-08-Mario-Sanchez-Prada-msanchez-igalia.com.patch</filename>
            <type>text/plain</type>
            <size>8079</size>
            <attacher name="Mario Sanchez Prada">mario</attacher>
            
              <data encoding="base64">RnJvbSAwYmIwMzlmYTkzOTgyNWQ3YThkYjRlOGIyYzliZjRjZGFiMGQ3YmZiIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu
Y29tPgpEYXRlOiBGcmksIDggSnVuIDIwMTIgMTY6MTk6MDUgKzAyMDAKU3ViamVjdDogW1BBVENI
IDEvMl0gMjAxMi0wNi0wOCAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5j
b20+CgogICAgICAgIFtXSzJdIE1pc3NpbmcgQVBJIHRvIGNoZWNrIHdoZXRoZXIgV2ViS2l0VGVz
dFJ1bm5lciBpcyBiZWluZyB1c2VkCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTg4NjU3CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoK
ICAgICAgICBOZXcgQVBJIHRvIGFsbG93IGRlY2xhcmluZyB0aGF0IFdlYktpdFRlc3RSdW5uZXIg
aXMgcnVubmluZyAob24KICAgICAgICBpbml0aWFsaXphdGlvbikgYW5kIGNoZWNraW5nIHRoYXQg
dmFsdWUgZnJvbSB0aGUgV2ViUHJvY2Vzcy4KCiAgICAgICAgKiBXZWJQcm9jZXNzL0luamVjdGVk
QnVuZGxlL0FQSS9jL1dLQnVuZGxlLmNwcDoKICAgICAgICAoV0tCdW5kbGVTZXRUZXN0UnVubmVy
TW9kZUVuYWJsZWQpOgogICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9X
S0J1bmRsZVByaXZhdGUuaDoKICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5q
ZWN0ZWRCdW5kbGUuY3BwOgogICAgICAgIChXZWJLaXQ6OkluamVjdGVkQnVuZGxlOjp3ZWJDb25u
ZWN0aW9uVG9VSVByb2Nlc3MpOgogICAgICAgIChXZWJLaXQpOgogICAgICAgIChXZWJLaXQ6Oklu
amVjdGVkQnVuZGxlOjpzZXRUZXN0UnVubmVyTW9kZUVuYWJsZWQpOgogICAgICAgIChXZWJLaXQ6
OkluamVjdGVkQnVuZGxlOjppc1Rlc3RSdW5uZXJNb2RlRW5hYmxlZCk6CiAgICAgICAgKiBXZWJQ
cm9jZXNzL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlLmg6CiAgICAgICAgKEluamVjdGVk
QnVuZGxlKToKCjIwMTItMDYtMDggIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtc2FuY2hlekBpZ2Fs
aWEuY29tPgoKICAgICAgICBbV0syXSBNaXNzaW5nIEFQSSB0byBjaGVjayB3aGV0aGVyIFdlYktp
dFRlc3RSdW5uZXIgaXMgYmVpbmcgdXNlZAogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD04ODY1NwoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh
KS4KCiAgICAgICAgRGVjbGFyZSB0aGF0IFdLVFIgaXMgcnVubmluZyB3aGVuIGluaXRpYWxpemlu
ZyB0aGUgaW5qZWN0ZWQgYnVuZGxlLgoKICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvSW5qZWN0
ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwOgogICAgICAgIChXVFI6OkluamVjdGVkQnVuZGxl
Ojppbml0aWFsaXplKTogQ2FsbCB0byBXS0J1bmRsZVNldFRlc3RSdW5uZXJNb2RlRW5hYmxlZCgp
LgotLS0KIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAg
IHwgICAyMSArKysrKysrKysrKysrKysrKysrKwogLi4uL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5k
bGUvQVBJL2MvV0tCdW5kbGUuY3BwICAgfCAgICA1ICsrKysrCiAuLi4vSW5qZWN0ZWRCdW5kbGUv
QVBJL2MvV0tCdW5kbGVQcml2YXRlLmggICAgICAgICB8ICAgIDEgKwogLi4uL1dlYlByb2Nlc3Mv
SW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwICAgfCAgIDEwICsrKysrKysrKysKIC4u
Li9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlLmggICAgIHwgICAgNCAr
KysrCiBUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8
ICAgMTIgKysrKysrKysrKysKIC4uLi9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHAg
ICAgICAgICAgICAgIHwgICAgNCArKysrCiA3IGZpbGVzIGNoYW5nZWQsIDU3IGluc2VydGlvbnMo
KykKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0
Mi9DaGFuZ2VMb2cKaW5kZXggMzg0ZGI4OC4uN2I0MzYzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsx
LDI0IEBACisyMDEyLTA2LTA4ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlh
LmNvbT4KKworICAgICAgICBbV0syXSBNaXNzaW5nIEFQSSB0byBjaGVjayB3aGV0aGVyIFdlYktp
dFRlc3RSdW5uZXIgaXMgYmVpbmcgdXNlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9ODg2NTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBOZXcgQVBJIHRvIGFsbG93IGRlY2xhcmluZyB0aGF0IFdlYktpdFRl
c3RSdW5uZXIgaXMgcnVubmluZyAob24KKyAgICAgICAgaW5pdGlhbGl6YXRpb24pIGFuZCBjaGVj
a2luZyB0aGF0IHZhbHVlIGZyb20gdGhlIFdlYlByb2Nlc3MuCisKKyAgICAgICAgKiBXZWJQcm9j
ZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlLmNwcDoKKyAgICAgICAgKFdLQnVuZGxl
U2V0VGVzdFJ1bm5lck1vZGVFbmFibGVkKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL0luamVjdGVk
QnVuZGxlL0FQSS9jL1dLQnVuZGxlUHJpdmF0ZS5oOgorICAgICAgICAqIFdlYlByb2Nlc3MvSW5q
ZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwOgorICAgICAgICAoV2ViS2l0OjpJbmplY3Rl
ZEJ1bmRsZTo6d2ViQ29ubmVjdGlvblRvVUlQcm9jZXNzKToKKyAgICAgICAgKFdlYktpdCk6Cisg
ICAgICAgIChXZWJLaXQ6OkluamVjdGVkQnVuZGxlOjpzZXRUZXN0UnVubmVyTW9kZUVuYWJsZWQp
OgorICAgICAgICAoV2ViS2l0OjpJbmplY3RlZEJ1bmRsZTo6aXNUZXN0UnVubmVyTW9kZUVuYWJs
ZWQpOgorICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUu
aDoKKyAgICAgICAgKEluamVjdGVkQnVuZGxlKToKKwogMjAxMi0wNi0wNyAgQW5keSBFc3RlcyAg
PGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW1dlYktpdDJdIEV4cGxpY2l0bHkgaW5jbHVk
ZSBDb3JlRm91bmRhdGlvbi5oIGluIGNvbmZpZy5oCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0
Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlLmNwcCBiL1NvdXJjZS9X
ZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGUuY3BwCmluZGV4
IGJiYjZhZGIuLjdlN2MyYmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv
SW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dl
YlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGUuY3BwCkBAIC0xMjYsNiArMTI2
LDExIEBAIHZvaWQgV0tCdW5kbGVSZW1vdmVBbGxVc2VyQ29udGVudChXS0J1bmRsZVJlZiBidW5k
bGVSZWYsIFdLQnVuZGxlUGFnZUdyb3VwUmVmIHBhCiAgICAgdG9JbXBsKGJ1bmRsZVJlZiktPnJl
bW92ZUFsbFVzZXJDb250ZW50KHRvSW1wbChwYWdlR3JvdXBSZWYpKTsKIH0KIAordm9pZCBXS0J1
bmRsZVNldFRlc3RSdW5uZXJNb2RlRW5hYmxlZChXS0J1bmRsZVJlZiBidW5kbGVSZWYsIGJvb2wg
ZW5hYmxlZCkKK3sKKyAgICB0b0ltcGwoYnVuZGxlUmVmKS0+c2V0VGVzdFJ1bm5lck1vZGVFbmFi
bGVkKGVuYWJsZWQpOworfQorCiB2b2lkIFdLQnVuZGxlT3ZlcnJpZGVCb29sUHJlZmVyZW5jZUZv
clRlc3RSdW5uZXIoV0tCdW5kbGVSZWYgYnVuZGxlUmVmLCBXS0J1bmRsZVBhZ2VHcm91cFJlZiBw
YWdlR3JvdXBSZWYsIFdLU3RyaW5nUmVmIHByZWZlcmVuY2UsIGJvb2wgZW5hYmxlZCkKIHsKICAg
ICB0b0ltcGwoYnVuZGxlUmVmKS0+b3ZlcnJpZGVCb29sUHJlZmVyZW5jZUZvclRlc3RSdW5uZXIo
dG9JbXBsKHBhZ2VHcm91cFJlZiksIHRvSW1wbChwcmVmZXJlbmNlKS0+c3RyaW5nKCksIGVuYWJs
ZWQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRs
ZS9BUEkvYy9XS0J1bmRsZVByaXZhdGUuaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5q
ZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVQcml2YXRlLmgKaW5kZXggY2NkYTM2Ny4uNjBiOTNm
ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9B
UEkvYy9XS0J1bmRsZVByaXZhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0lu
amVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlUHJpdmF0ZS5oCkBAIC02NCw2ICs2NCw3IEBAIFdL
X0VYUE9SVCB2b2lkIFdLQnVuZGxlUmVtb3ZlVXNlclN0eWxlU2hlZXRzKFdLQnVuZGxlUmVmIGJ1
bmRsZSwgV0tCdW5kbGVQYWdlR3JvCiBXS19FWFBPUlQgdm9pZCBXS0J1bmRsZVJlbW92ZUFsbFVz
ZXJDb250ZW50KFdLQnVuZGxlUmVmIGJ1bmRsZSwgV0tCdW5kbGVQYWdlR3JvdXBSZWYgcGFnZUdy
b3VwKTsKIAogLy8gV2lsbCBtYWtlIFdlYlByb2Nlc3MgaWdub3JlIHRoaXMgcHJlZmVyZW5jZSB1
bnRpbCBhIHByZWZlcmVuY2VzIGNoYW5nZSBub3RpZmljYXRpb24sIG9ubHkgZm9yIFdlYktpdFRl
c3RSdW5uZXIgdXNlLgorV0tfRVhQT1JUIHZvaWQgV0tCdW5kbGVTZXRUZXN0UnVubmVyTW9kZUVu
YWJsZWQoV0tCdW5kbGVSZWYgYnVuZGxlUmVmLCBib29sIGVuYWJsZWQpOwogV0tfRVhQT1JUIHZv
aWQgV0tCdW5kbGVPdmVycmlkZUJvb2xQcmVmZXJlbmNlRm9yVGVzdFJ1bm5lcihXS0J1bmRsZVJl
ZiBidW5kbGUsIFdLQnVuZGxlUGFnZUdyb3VwUmVmIHBhZ2VHcm91cCwgV0tTdHJpbmdSZWYgcHJl
ZmVyZW5jZSwgYm9vbCBlbmFibGVkKTsKIAogV0tfRVhQT1JUIHZvaWQgV0tCdW5kbGVTZXRBbGxv
d1VuaXZlcnNhbEFjY2Vzc0Zyb21GaWxlVVJMcyhXS0J1bmRsZVJlZiBidW5kbGUsIFdLQnVuZGxl
UGFnZUdyb3VwUmVmIHBhZ2VHcm91cCwgYm9vbCBlbmFibGVkKTsKZGlmZiAtLWdpdCBhL1NvdXJj
ZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwIGIv
U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5j
cHAKaW5kZXggYzZlOWE2MC4uNDI1YjVkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2Vi
UHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHAKKysrIGIvU291cmNlL1dl
YktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHAKQEAgLTEw
OSw2ICsxMDksMTYgQEAgV2ViQ29ubmVjdGlvbiogSW5qZWN0ZWRCdW5kbGU6OndlYkNvbm5lY3Rp
b25Ub1VJUHJvY2VzcygpIGNvbnN0CiAgICAgcmV0dXJuIFdlYlByb2Nlc3M6OnNoYXJlZCgpLndl
YkNvbm5lY3Rpb25Ub1VJUHJvY2VzcygpOwogfQogCit2b2lkIEluamVjdGVkQnVuZGxlOjpzZXRU
ZXN0UnVubmVyTW9kZUVuYWJsZWQoYm9vbCBlbmFibGVkKQoreworICAgIG1fdGVzdFJ1bm5lck1v
ZGVFbmFibGVkID0gZW5hYmxlZDsKK30KKworYm9vbCBJbmplY3RlZEJ1bmRsZTo6aXNUZXN0UnVu
bmVyTW9kZUVuYWJsZWQoKQoreworICAgIHJldHVybiBtX3Rlc3RSdW5uZXJNb2RlRW5hYmxlZDsK
K30KKwogdm9pZCBJbmplY3RlZEJ1bmRsZTo6c2V0U2hvdWxkVHJhY2tWaXNpdGVkTGlua3MoYm9v
bCBzaG91bGRUcmFja1Zpc2l0ZWRMaW5rcykKIHsKICAgICBXZWJQcm9jZXNzOjpzaGFyZWQoKS5z
ZXRTaG91bGRUcmFja1Zpc2l0ZWRMaW5rcyhzaG91bGRUcmFja1Zpc2l0ZWRMaW5rcyk7CmRpZmYg
LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0luamVjdGVk
QnVuZGxlLmggYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0luamVj
dGVkQnVuZGxlLmgKaW5kZXggNWJhMWEyZi4uMDNlNTUxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5oCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuaApA
QCAtMTAwLDYgKzEwMCw4IEBAIHB1YmxpYzoKICAgICBXZWJDb25uZWN0aW9uKiB3ZWJDb25uZWN0
aW9uVG9VSVByb2Nlc3MoKSBjb25zdDsKIAogICAgIC8vIFRlc3RSdW5uZXIgb25seSBTUEkKKyAg
ICB2b2lkIHNldFRlc3RSdW5uZXJNb2RlRW5hYmxlZChib29sKTsKKyAgICBib29sIGlzVGVzdFJ1
bm5lck1vZGVFbmFibGVkKCk7CiAgICAgdm9pZCBzZXRTaG91bGRUcmFja1Zpc2l0ZWRMaW5rcyhi
b29sKTsKICAgICB2b2lkIHJlbW92ZUFsbFZpc2l0ZWRMaW5rcygpOwogICAgIHZvaWQgYWN0aXZh
dGVNYWNGb250QXNjZW50SGFjaygpOwpAQCAtMTcwLDYgKzE3Miw4IEBAIHByaXZhdGU6CiAgICAg
UmVmUHRyPFNhbmRib3hFeHRlbnNpb24+IG1fc2FuZGJveEV4dGVuc2lvbjsKIAogICAgIEluamVj
dGVkQnVuZGxlQ2xpZW50IG1fY2xpZW50OworCisgICAgYm9vbCBtX3Rlc3RSdW5uZXJNb2RlRW5h
YmxlZDsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hh
bmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGQ4YWE5ZDMuLmNjY2ZjNjYgMTAwNjQ0Ci0t
LSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBA
QAorMjAxMi0wNi0wOCAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+
CisKKyAgICAgICAgW1dLMl0gTWlzc2luZyBBUEkgdG8gY2hlY2sgd2hldGhlciBXZWJLaXRUZXN0
UnVubmVyIGlzIGJlaW5nIHVzZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTg4NjU3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgRGVjbGFyZSB0aGF0IFdLVFIgaXMgcnVubmluZyB3aGVuIGluaXRpYWxpemlu
ZyB0aGUgaW5qZWN0ZWQgYnVuZGxlLgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9Jbmpl
Y3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHA6CisgICAgICAgIChXVFI6OkluamVjdGVkQnVu
ZGxlOjppbml0aWFsaXplKTogQ2FsbCB0byBXS0J1bmRsZVNldFRlc3RSdW5uZXJNb2RlRW5hYmxl
ZCgpLgorCiAyMDEyLTA2LTA3ICBLaW51a28gWWFzdWRhICA8a2ludWtvQGNocm9taXVtLm9yZz4K
IAogICAgICAgICBjaGVjay13ZWJraXQtc3R5bGUgbmVlZHMgdG8gYmUgdGF1Z2h0IGFib3V0IDxw
dWJsaWMvRm9vLmg+CmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVk
QnVuZGxlL0luamVjdGVkQnVuZGxlLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0
ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwCmluZGV4IGM5YzNmZWMuLmJmMjg2MDEgMTAwNjQ0
Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5k
bGUuY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0
ZWRCdW5kbGUuY3BwCkBAIC05Niw2ICs5NiwxMCBAQCB2b2lkIEluamVjdGVkQnVuZGxlOjppbml0
aWFsaXplKFdLQnVuZGxlUmVmIGJ1bmRsZSwgV0tUeXBlUmVmIGluaXRpYWxpemF0aW9uVXNlcgog
CiAgICAgYWN0aXZhdGVGb250cygpOwogICAgIFdLQnVuZGxlQWN0aXZhdGVNYWNGb250QXNjZW50
SGFjayhtX2J1bmRsZSk7CisKKyAgICAvLyBEZWNsYXJlIHRoYXQgV0tUUiBpcyBydW5uaW5nIHNv
IHdoZW4gY3JlYXRpbmcgdGhlIFdlYlBhZ2UKKyAgICAvLyBtb2NrIGNsaWVudHMgYXJlIHVzZWQg
aW5zdGVhZCBvZiBwcm9wZXIgb25lcy4KKyAgICBXS0J1bmRsZVNldFRlc3RSdW5uZXJNb2RlRW5h
YmxlZChtX2J1bmRsZSwgdHJ1ZSk7CiB9CiAKIHZvaWQgSW5qZWN0ZWRCdW5kbGU6OmRpZENyZWF0
ZVBhZ2UoV0tCdW5kbGVQYWdlUmVmIHBhZ2UpCi0tIAoxLjcuMTAuMgoK
</data>
<flag name="review"
          id="153878"
          type_id="1"
          status="-"
          setter="benjamin"
    />
          </attachment>
      

    </bug>

</bugzilla>