88642 2012-06-08 03:21:55 -0700 [BlackBerry] Wrong mimetype for empty file link 2012-06-11 20:45:00 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mawu mawu charles.wei rwlbuis tonikitoo webkit.review.bot oldest_to_newest 644546 0 mawu 2012-06-08 03:21:55 -0700 For empty file link, we shouldn't give "application/octet-stream" which will lead to download. 644550 1 146534 mawu 2012-06-08 03:39:09 -0700 Created attachment 146534 Patch 644567 2 146534 rwlbuis 2012-06-08 04:33:01 -0700 Comment on attachment 146534 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146534&action=review Change is correct but might be able to clean it up. > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:625 > + mimeType = "text/plain"; It seems like you can change the if if if if to if else if else sections. What do you think? This avoids testing for isNull() when you already know the outcome based on the previous statement/assignment. 645667 3 mawu 2012-06-10 19:28:06 -0700 (In reply to comment #2) > (From update of attachment 146534 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=146534&action=review > > Change is correct but might be able to clean it up. > > > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:625 > > + mimeType = "text/plain"; > > It seems like you can change the if if if if to if else if else sections. What do you think? This avoids testing for isNull() when you already know the outcome based on the previous statement/assignment. yes, could add else if some place. 645671 4 146764 mawu 2012-06-10 19:31:22 -0700 Created attachment 146764 Patch 645956 5 146764 rwlbuis 2012-06-11 06:49:31 -0700 Comment on attachment 146764 Patch LGTM. 646595 6 146764 webkit.review.bot 2012-06-11 20:44:56 -0700 Comment on attachment 146764 Patch Clearing flags on attachment: 146764 Committed r120035: <http://trac.webkit.org/changeset/120035> 646596 7 webkit.review.bot 2012-06-11 20:45:00 -0700 All reviewed patches have been landed. Closing bug. 146534 2012-06-08 03:39:09 -0700 2012-06-10 19:31:09 -0700 Patch bug-88642-20120608183905.patch text/plain 1721 mawu U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5ODE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2ZkMTIwZTcxOTliYTBj Zjg5OTNmMWY0ODI1YTM3ZjhkYjljNTcwMS4uNzhmNzVkYjE0MWZmOWQ0OTIwNDVhOWU2ZGE1OGIx OGIxOWY4MWNiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA2LTA4ICBNYXJ5 IFd1ICA8bWFyeS53dUB0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgW0JsYWNrQmVycnld IFdyb25nIG1pbWV0eXBlIGZvciBlbXB0eSBmaWxlIGxpbmsKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4NjQyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUklNIFBSIyAxNjQxNjQKKworICAgICAgICBGb3Ig ZW1wdHkgZmlsZSBsaW5rLCB3ZSBzaG91bGRuJ3QgZ2l2ZSAiYXBwbGljYXRpb24vb2N0ZXQtc3Ry ZWFtIgorICAgICAgICB3aGljaCB3aWxsIGxlYWQgdG8gZG93bmxvYWQuCisKKyAgICAgICAgUmV2 aWV3ZWQgaW50ZXJuYWxseSBieSBDaGFybGVzIFdlaS4KKworICAgICAgICAqIHBsYXRmb3JtL25l dHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5ldHdv cmtKb2I6OnNlbmRSZXNwb25zZUlmTmVlZGVkKToKKwogMjAxMi0wNi0wOCAgS2VudCBUYW11cmEg IDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTW92ZSBmb3JtLXJlbGF0ZWQgZnVuY3Rp b25zIG9mIERvY3VtZW50IHRvIEZvcm1Db250cm9sbGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAKaW5kZXgg ZDU0MzYxNjNjZjBlNmVhOTljMmFlOTFhMjkwZjQ0NmQzZjZjMTJiZC4uNjVmMjRjNmEwN2Y4NjE1 MDQ3ZTg0NThlMzY0MjA1OGI1ZjhmM2IwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcApAQCAtNjIwLDYg KzYyMCw5IEBAIHZvaWQgTmV0d29ya0pvYjo6c2VuZFJlc3BvbnNlSWZOZWVkZWQoKQogICAgICAg ICBtaW1lVHlwZSA9ICJhcHBsaWNhdGlvbi94LWZ0cC1kaXJlY3RvcnkiOwogICAgIGlmIChtaW1l VHlwZS5pc051bGwoKSkKICAgICAgICAgbWltZVR5cGUgPSBleHRyYWN0TUlNRVR5cGVGcm9tTWVk aWFUeXBlKG1fY29udGVudFR5cGUpOworICAgIGlmIChtaW1lVHlwZS5pc051bGwoKSAmJiAhbV9k YXRhUmVjZWl2ZWQpCisgICAgICAgIC8vIEZvciBlbXB0eSBjb250ZW50LCB3ZSBzaG91bGRuJ3Qg ZG93bmxvYWQuCisgICAgICAgIG1pbWVUeXBlID0gInRleHQvcGxhaW4iOwogICAgIGlmIChtaW1l VHlwZS5pc051bGwoKSkKICAgICAgICAgbWltZVR5cGUgPSBNSU1FVHlwZVJlZ2lzdHJ5OjpnZXRN SU1FVHlwZUZvclBhdGgodXJsRmlsZW5hbWUpOwogICAgIG1fcmVzcG9uc2Uuc2V0TWltZVR5cGUo bWltZVR5cGUpOwo= 146764 2012-06-10 19:31:22 -0700 2012-06-11 20:44:56 -0700 Patch bug-88642-20120611103119.patch text/plain 1995 mawu U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5ODE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2ZkMTIwZTcxOTliYTBj Zjg5OTNmMWY0ODI1YTM3ZjhkYjljNTcwMS4uNzhmNzVkYjE0MWZmOWQ0OTIwNDVhOWU2ZGE1OGIx OGIxOWY4MWNiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA2LTA4ICBNYXJ5 IFd1ICA8bWFyeS53dUB0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgW0JsYWNrQmVycnld IFdyb25nIG1pbWV0eXBlIGZvciBlbXB0eSBmaWxlIGxpbmsKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4NjQyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUklNIFBSIyAxNjQxNjQKKworICAgICAgICBGb3Ig ZW1wdHkgZmlsZSBsaW5rLCB3ZSBzaG91bGRuJ3QgZ2l2ZSAiYXBwbGljYXRpb24vb2N0ZXQtc3Ry ZWFtIgorICAgICAgICB3aGljaCB3aWxsIGxlYWQgdG8gZG93bmxvYWQuCisKKyAgICAgICAgUmV2 aWV3ZWQgaW50ZXJuYWxseSBieSBDaGFybGVzIFdlaS4KKworICAgICAgICAqIHBsYXRmb3JtL25l dHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5ldHdv cmtKb2I6OnNlbmRSZXNwb25zZUlmTmVlZGVkKToKKwogMjAxMi0wNi0wOCAgS2VudCBUYW11cmEg IDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTW92ZSBmb3JtLXJlbGF0ZWQgZnVuY3Rp b25zIG9mIERvY3VtZW50IHRvIEZvcm1Db250cm9sbGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAKaW5kZXgg ZDU0MzYxNjNjZjBlNmVhOTljMmFlOTFhMjkwZjQ0NmQzZjZjMTJiZC4uNjAxMDc2MzllZDE3MDZl M2E2YTYwYWM5NmIxNDVjZTRkM2JhYjBhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcApAQCAtNjE4LDEw ICs2MTgsMTUgQEAgdm9pZCBOZXR3b3JrSm9iOjpzZW5kUmVzcG9uc2VJZk5lZWRlZCgpCiAgICAg U3RyaW5nIG1pbWVUeXBlID0gbV9zbmlmZmVkTWltZVR5cGU7CiAgICAgaWYgKG1faXNGVFAgJiYg bV9pc0ZUUERpcikKICAgICAgICAgbWltZVR5cGUgPSAiYXBwbGljYXRpb24veC1mdHAtZGlyZWN0 b3J5IjsKLSAgICBpZiAobWltZVR5cGUuaXNOdWxsKCkpCisgICAgZWxzZSBpZiAobWltZVR5cGUu aXNOdWxsKCkpCiAgICAgICAgIG1pbWVUeXBlID0gZXh0cmFjdE1JTUVUeXBlRnJvbU1lZGlhVHlw ZShtX2NvbnRlbnRUeXBlKTsKLSAgICBpZiAobWltZVR5cGUuaXNOdWxsKCkpCi0gICAgICAgIG1p bWVUeXBlID0gTUlNRVR5cGVSZWdpc3RyeTo6Z2V0TUlNRVR5cGVGb3JQYXRoKHVybEZpbGVuYW1l KTsKKyAgICBpZiAobWltZVR5cGUuaXNOdWxsKCkpIHsKKyAgICAgICAgaWYgKG1fZGF0YVJlY2Vp dmVkKQorICAgICAgICAgICAgbWltZVR5cGUgPSBNSU1FVHlwZVJlZ2lzdHJ5OjpnZXRNSU1FVHlw ZUZvclBhdGgodXJsRmlsZW5hbWUpOworICAgICAgICBlbHNlCisgICAgICAgICAgICAvLyBGb3Ig ZW1wdHkgY29udGVudCwgd2Ugc2hvdWxkbid0IGRvd25sb2FkLgorICAgICAgICAgICAgbWltZVR5 cGUgPSAidGV4dC9wbGFpbiI7CisgICAgfQogICAgIG1fcmVzcG9uc2Uuc2V0TWltZVR5cGUobWlt ZVR5cGUpOwogCiAgICAgLy8gU2V0IGVuY29kaW5nIGZyb20gQ29udGVudC1UeXBlIGhlYWRlci4K