88626 2012-06-07 23:30:30 -0700 Add app_abi option for DumpRenderTree_apk 2012-06-08 11:44:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 88658 1 james.wei james.wei abarth dpranke jrg peter tony wangxianzhu webkit.review.bot oldest_to_newest 644380 0 james.wei 2012-06-07 23:30:30 -0700 Add app_abi option for DumpRenderTree_apk 644382 1 146489 james.wei 2012-06-07 23:30:58 -0700 Created attachment 146489 Patch 644672 2 146489 peter 2012-06-08 07:59:19 -0700 Comment on attachment 146489 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146489&action=review LGTM from for Android's perspective, but please wait for a reviewer before submitting. Do you think it'd be useful to file a meta bug tracking changes you make to WebKit for supporting Android x86? It's great work! > Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:443 > + '--app_abi=<(android_app_abi)' One nit: I'd prefer to stay in line with other arguments passed to generate_native_test.py (with the exception of -DPRODUCT_DIR) and have the argument's name and value on separate lines. - '--app_abi=<(android_app_abi)' + '--app_abi', + '<(android_app_abi)', 644690 3 146577 james.wei 2012-06-08 08:33:46 -0700 Created attachment 146577 Patch 644691 4 146489 james.wei 2012-06-08 08:35:29 -0700 Comment on attachment 146489 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146489&action=review >> Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:443 >> + '--app_abi=<(android_app_abi)' > > One nit: I'd prefer to stay in line with other arguments passed to generate_native_test.py (with the exception of -DPRODUCT_DIR) and have the argument's name and value on separate lines. > > - '--app_abi=<(android_app_abi)' > + '--app_abi', > + '<(android_app_abi)', fixed.thanks for the reviewing. 644692 5 james.wei 2012-06-08 08:37:37 -0700 (In reply to comment #2) > Do you think it'd be useful to file a meta bug tracking changes you make to WebKit for supporting Android x86? It's great work! > Good idea. Although I don't know how many patches needed to enable android x86, it is useful to file a meta bug to track all the bugs. 644696 6 peter 2012-06-08 08:45:29 -0700 (In reply to comment #5) > Good idea. Although I don't know how many patches needed to enable android x86, it is useful to file a meta bug to track all the bugs. It'd be good for the general overview. Thank you very much! LGTM. Could a reviewer have a formal look, please? 644879 7 146577 abarth 2012-06-08 11:31:49 -0700 Comment on attachment 146577 Patch rs=me 644903 8 146577 webkit.review.bot 2012-06-08 11:44:54 -0700 Comment on attachment 146577 Patch Clearing flags on attachment: 146577 Committed r119851: <http://trac.webkit.org/changeset/119851> 644904 9 webkit.review.bot 2012-06-08 11:44:59 -0700 All reviewed patches have been landed. Closing bug. 146489 2012-06-07 23:30:58 -0700 2012-06-08 08:35:28 -0700 Patch bug-88626-20120608143104.patch text/plain 1354 james.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5ODAwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDhhYTlkM2RmZTE2NTI2ZGJjNTU2YTM4Y2U1NjJmNGVm ZWVkMWY5ZS4uYjI5ZGNjMzg2NjdmMTYxNDdiNWFhZTMxNWU3ZDA5NzcyZWE5YzNjOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDEyLTA2LTA3ICBXZWkgSmFtZXMgIDxqYW1lcy53ZWlAaW50ZWwuY29tPgorCisgICAg ICAgIEFkZCBhcHBfYWJpIG9wdGlvbiBmb3IgRHVtcFJlbmRlclRyZWVfYXBrCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODYyNgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvRHVt cFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVlLmd5cDoKKwogMjAxMi0wNi0wNyAgS2ludWtv IFlhc3VkYSAgPGtpbnVrb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgY2hlY2std2Via2l0LXN0 eWxlIG5lZWRzIHRvIGJlIHRhdWdodCBhYm91dCA8cHVibGljL0Zvby5oPgpkaWZmIC0tZ2l0IGEv VG9vbHMvRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVlLmd5 cCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVuZGVyVHJl ZS5neXAKaW5kZXggYzEwMmU1ZmNiYWMzODdjZWE3ODUwZTZlZTMyZTU5MWZkNjQ0OTljOC4uMGU5 MmRiNjRjNTNjNTRkMTg4NmNlMGM5MDBjZDA2ZTY3ZGY1OTUyOCAxMDA2NDQKLS0tIGEvVG9vbHMv RHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVlLmd5cAorKysg Yi9Ub29scy9EdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5neXAvRHVtcFJlbmRlclRyZWUu Z3lwCkBAIC00MzksNyArNDM5LDggQEAKICAgICAgICAgICAgICAgICAgICAgICAgICc8KFBST0RV Q1RfRElSKS9EdW1wUmVuZGVyVHJlZV9hcGsnLAogICAgICAgICAgICAgICAgICAgICAgICAgJy0t YW50LWFyZ3MnLAogICAgICAgICAgICAgICAgICAgICAgICAgJy1EUFJPRFVDVF9ESVI9PChhbnRf YnVpbGRfb3V0KScsCi0gICAgICAgICAgICAgICAgICAgICAgICAnLS1hbnQtY29tcGlsZScKKyAg ICAgICAgICAgICAgICAgICAgICAgICctLWFudC1jb21waWxlJywKKyAgICAgICAgICAgICAgICAg ICAgICAgICctLWFwcF9hYmk9PChhbmRyb2lkX2FwcF9hYmkpJwogICAgICAgICAgICAgICAgICAg ICBdLAogICAgICAgICAgICAgICAgIH1dLAogICAgICAgICAgICAgfV0sCg== 146577 2012-06-08 08:33:46 -0700 2012-06-08 11:44:54 -0700 Patch bug-88626-20120608233353.patch text/plain 1383 james.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5ODAwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDhhYTlkM2RmZTE2NTI2ZGJjNTU2YTM4Y2U1NjJmNGVm ZWVkMWY5ZS4uNWU2ZDBjMTc3OTU1M2U2MDkxZTc2MzVmMjdiZjQxNTllZTM2OTRiNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDEyLTA2LTA4ICBXZWkgSmFtZXMgIDxqYW1lcy53ZWlAaW50ZWwuY29tPgorCisgICAg ICAgIEFkZCBhcHBfYWJpIG9wdGlvbiBmb3IgRHVtcFJlbmRlclRyZWVfYXBrCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODYyNgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvRHVt cFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVlLmd5cDoKKwogMjAxMi0wNi0wNyAgS2ludWtv IFlhc3VkYSAgPGtpbnVrb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgY2hlY2std2Via2l0LXN0 eWxlIG5lZWRzIHRvIGJlIHRhdWdodCBhYm91dCA8cHVibGljL0Zvby5oPgpkaWZmIC0tZ2l0IGEv VG9vbHMvRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVlLmd5 cCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVuZGVyVHJl ZS5neXAKaW5kZXggYzEwMmU1ZmNiYWMzODdjZWE3ODUwZTZlZTMyZTU5MWZkNjQ0OTljOC4uOWEx NWNkMWMwMjdlN2ZlMDQyODEyNGU1NTZjODZkYmJlM2I5NjYyMCAxMDA2NDQKLS0tIGEvVG9vbHMv RHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVlLmd5cAorKysg Yi9Ub29scy9EdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5neXAvRHVtcFJlbmRlclRyZWUu Z3lwCkBAIC00MzksNyArNDM5LDkgQEAKICAgICAgICAgICAgICAgICAgICAgICAgICc8KFBST0RV Q1RfRElSKS9EdW1wUmVuZGVyVHJlZV9hcGsnLAogICAgICAgICAgICAgICAgICAgICAgICAgJy0t YW50LWFyZ3MnLAogICAgICAgICAgICAgICAgICAgICAgICAgJy1EUFJPRFVDVF9ESVI9PChhbnRf YnVpbGRfb3V0KScsCi0gICAgICAgICAgICAgICAgICAgICAgICAnLS1hbnQtY29tcGlsZScKKyAg ICAgICAgICAgICAgICAgICAgICAgICctLWFudC1jb21waWxlJywKKyAgICAgICAgICAgICAgICAg ICAgICAgICctLWFwcF9hYmknLAorICAgICAgICAgICAgICAgICAgICAgICAgJzwoYW5kcm9pZF9h cHBfYWJpKScsCiAgICAgICAgICAgICAgICAgICAgIF0sCiAgICAgICAgICAgICAgICAgfV0sCiAg ICAgICAgICAgICB9XSwK