88617 2012-06-07 22:01:46 -0700 Spellchecker crash in async scenario. 2012-06-11 01:17:36 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 morrita morrita rniwa webkit.review.bot oldest_to_newest 644317 0 morrita 2012-06-07 22:01:46 -0700 From http://code.google.com/p/chromium/issues/detail?id=131656 644319 1 morrita 2012-06-07 22:04:02 -0700 Note that this affects only Chromium since it is the only port who uses async spellchecker. 644330 2 146478 morrita 2012-06-07 22:15:27 -0700 Created attachment 146478 Patch 644774 3 146478 tony 2012-06-08 10:11:49 -0700 Comment on attachment 146478 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146478&action=review > Source/WebCore/ChangeLog:3 > + TextCheckingcNeed a short description and bug URL (OOPS!) Typo? 645666 4 morrita 2012-06-10 19:27:27 -0700 (In reply to comment #3) > (From update of attachment 146478 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=146478&action=review > > > Source/WebCore/ChangeLog:3 > > + TextCheckingcNeed a short description and bug URL (OOPS!) > > Typo? Oops apparently. Thanks for the catch. Will fix and land. 645695 5 146772 morrita 2012-06-10 20:52:57 -0700 Created attachment 146772 Patch for landing 645824 6 146772 webkit.review.bot 2012-06-11 01:17:32 -0700 Comment on attachment 146772 Patch for landing Clearing flags on attachment: 146772 Committed r119960: <http://trac.webkit.org/changeset/119960> 645826 7 webkit.review.bot 2012-06-11 01:17:36 -0700 All reviewed patches have been landed. Closing bug. 146478 2012-06-07 22:15:27 -0700 2012-06-10 20:52:52 -0700 Patch bug-88617-20120608141526.patch text/plain 1614 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5Nzk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDcyY2E1ZDU4NDMwYWY0 Mjk4ZjJmMTdkZjg0ZDgwOThkMGMxNWI5Yy4uMjVlNDkyZjIwOWU1Mjg1YWNmNjM1ODA1YTJlOWFm NGEyNWU3OWE3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA2LTA3ICBNT1JJ VEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgorCisgICAgICAgIFRleHRDaGVja2luZ2NO ZWVkIGEgc2hvcnQgZGVzY3JpcHRpb24gYW5kIGJ1ZyBVUkwgKE9PUFMhKQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODg2MTcKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTcGVsbENoZWNrUmVxdWVzdDo6aW52 b2tlUmVxdWVzdCgpIGNhbiBiZSByZWFjaGVkIGFmdGVyIHRoZSBmcmFtZSBpcyBkZXRhY2hlZC4K KyAgICAgICAgU3BlbGxDaGVja1JlcXVlc3Qgc2hvdWxkIGlnbm9yZSBzdWNoIGEgcmVxdWVzdCBz aW5jZSBUZXh0Q2hlY2tlckNsaWVudCBpcyBub3QgYXZhaWxhYmxlCisgICAgICAgIGZvciBkZXRh Y2hlZCBGcmFtZXMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBJdCdzIGhhcmQgdG8gcmVwcm9k dWNlIHRoaXMuCisKKyAgICAgICAgKiBlZGl0aW5nL1NwZWxsQ2hlY2tlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpTcGVsbENoZWNrZXI6Omludm9rZVJlcXVlc3QpOgorCiAyMDEyLTA2LTA3ICBW aWN0b3IgQ2FyYnVuZSAgPHZpY3RvckByb3NlZHUub3JnPgogCiAgICAgICAgIGFkZFRleHRUcmFj ayBzaG91bGQgc2V0IHRyYWNrIG1vZGUgdG8gSElEREVOCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9lZGl0aW5nL1NwZWxsQ2hlY2tlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1Nw ZWxsQ2hlY2tlci5jcHAKaW5kZXggODAwNzIwZjc1NzU1ZTE5ZDFjNDJmOGVjMzhhZWY3MTBkNTQ5 NDdkZi4uYzg0NDIzN2U3YTM0ZmQyN2M0NjUxMDkxMmQ2NjlmYzY4ZmYxMWI4MyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9TcGVsbENoZWNrZXIuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2VkaXRpbmcvU3BlbGxDaGVja2VyLmNwcApAQCAtMTc4LDYgKzE3OCwxMCBAQCB2b2lk IFNwZWxsQ2hlY2tlcjo6cmVxdWVzdENoZWNraW5nRm9yKFBhc3NSZWZQdHI8U3BlbGxDaGVja1Jl cXVlc3Q+IHJlcXVlc3QpCiB2b2lkIFNwZWxsQ2hlY2tlcjo6aW52b2tlUmVxdWVzdChQYXNzUmVm UHRyPFNwZWxsQ2hlY2tSZXF1ZXN0PiByZXF1ZXN0KQogewogICAgIEFTU0VSVCghbV9wcm9jZXNz aW5nUmVxdWVzdCk7CisgICAgaWYgKCFjbGllbnQoKSkgeworICAgICAgICByZXF1ZXN0LT5kaWRD YW5jZWwoKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KIAogICAgIG1fcHJvY2Vzc2luZ1JlcXVl c3QgPSByZXF1ZXN0OwogICAgIGNsaWVudCgpLT5yZXF1ZXN0Q2hlY2tpbmdPZlN0cmluZyhtX3By b2Nlc3NpbmdSZXF1ZXN0KTsK 146772 2012-06-10 20:52:57 -0700 2012-06-11 01:17:32 -0700 Patch for landing bug-88617-20120611125256.patch text/plain 1601 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5OTQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmU5MWY2ZTUyY2ZlMGUw ZWQ2OTMyMjM4NWRkMzdhMWVhYjRkNzgzMC4uZWU3MTNjMzY0ODBjMDNlOTA5NTBiOWQwYWViMTVl OTkwM2NkYjg4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA2LTA3ICBNT1JJ VEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgorCisgICAgICAgIFNwZWxsY2hlY2tlciBj cmFzaCBpbiBhc3luYyBzY2VuYXJpby4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTg4NjE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgVG9ueSBDaGFuZy4K KworICAgICAgICBTcGVsbENoZWNrUmVxdWVzdDo6aW52b2tlUmVxdWVzdCgpIGNhbiBiZSByZWFj aGVkIGFmdGVyIHRoZSBmcmFtZSBpcyBkZXRhY2hlZC4KKyAgICAgICAgU3BlbGxDaGVja1JlcXVl c3Qgc2hvdWxkIGlnbm9yZSBzdWNoIGEgcmVxdWVzdCBzaW5jZSBUZXh0Q2hlY2tlckNsaWVudCBp cyBub3QgYXZhaWxhYmxlCisgICAgICAgIGZvciBkZXRhY2hlZCBGcmFtZXMuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzLiBJdCdzIGhhcmQgdG8gcmVwcm9kdWNlIHRoaXMuCisKKyAgICAgICAgKiBl ZGl0aW5nL1NwZWxsQ2hlY2tlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTcGVsbENoZWNrZXI6 Omludm9rZVJlcXVlc3QpOgorCiAyMDEyLTA2LTEwICBZb3NoaWZ1bWkgSW5vdWUgIDx5b3NpbkBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Zvcm1zXSBJbnRyb2R1Y2UgRGVjaW1hbCBiZWhpbmQg dGhlIElucHV0TnVtYmVyIHR5cGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcv U3BlbGxDaGVja2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvU3BlbGxDaGVja2VyLmNw cAppbmRleCA4MDA3MjBmNzU3NTVlMTlkMWM0MmY4ZWMzOGFlZjcxMGQ1NDk0N2RmLi5jODQ0MjM3 ZTdhMzRmZDI3YzQ2NTEwOTEyZDY2OWZjNjhmZjExYjgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9lZGl0aW5nL1NwZWxsQ2hlY2tlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGlu Zy9TcGVsbENoZWNrZXIuY3BwCkBAIC0xNzgsNiArMTc4LDEwIEBAIHZvaWQgU3BlbGxDaGVja2Vy OjpyZXF1ZXN0Q2hlY2tpbmdGb3IoUGFzc1JlZlB0cjxTcGVsbENoZWNrUmVxdWVzdD4gcmVxdWVz dCkKIHZvaWQgU3BlbGxDaGVja2VyOjppbnZva2VSZXF1ZXN0KFBhc3NSZWZQdHI8U3BlbGxDaGVj a1JlcXVlc3Q+IHJlcXVlc3QpCiB7CiAgICAgQVNTRVJUKCFtX3Byb2Nlc3NpbmdSZXF1ZXN0KTsK KyAgICBpZiAoIWNsaWVudCgpKSB7CisgICAgICAgIHJlcXVlc3QtPmRpZENhbmNlbCgpOworICAg ICAgICByZXR1cm47CisgICAgfQogCiAgICAgbV9wcm9jZXNzaW5nUmVxdWVzdCA9IHJlcXVlc3Q7 CiAgICAgY2xpZW50KCktPnJlcXVlc3RDaGVja2luZ09mU3RyaW5nKG1fcHJvY2Vzc2luZ1JlcXVl c3QpOwo=