88613 2012-06-07 21:25:39 -0700 [chromium] WEBP image blue and red color channels reversed on Android 2012-06-08 01:50:24 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://developers.google.com/speed/webp/gallery1 P2 Normal --- 1 noel.gordon noel.gordon abarth pascal.massimino tkent webkit.review.bot oldest_to_newest 644297 0 noel.gordon 2012-06-07 21:25:39 -0700 The JPEG images (on the left) on this URL, and the WEBP images (right), should look identical. On Chrome Android, the red and blue channels are reversed. 644300 1 noel.gordon 2012-06-07 21:30:46 -0700 Skia android is LITTLE_ENDIAN, but it stores pixels RGBA, see https://bugs.webkit.org/show_bug.cgi?id=75861#c6 644321 2 146476 noel.gordon 2012-06-07 22:06:19 -0700 Created attachment 146476 Patch 644332 3 noel.gordon 2012-06-07 22:18:21 -0700 http://b/6311532 644339 4 noel.gordon 2012-06-07 22:31:52 -0700 Tools/Scripts/new-run-webkit-tests --chromium --release fast/images/webp-image-decoding.html Works for me locally. 644342 5 146476 tkent 2012-06-07 22:35:16 -0700 Comment on attachment 146476 Patch rubber stamped. 644371 6 pascal.massimino 2012-06-07 23:23:54 -0700 shouldn't the test be on "SK_A32_SHIFT" instead of "SK_B32_SHIFT" ? 644378 7 noel.gordon 2012-06-07 23:29:41 -0700 BGRA and RGBA -> the A shift is identical on a little-endian CPU, right? 644389 8 noel.gordon 2012-06-07 23:43:56 -0700 Or for example, see bug 78540 644411 9 pascal.massimino 2012-06-08 00:17:50 -0700 i'm fine with either ways, it's just that i saw the test being #ifndef SK_A32_SHIFT ... #endif at skia/include/core/SkPostConfig.h:165 your pick! 644428 10 noel.gordon 2012-06-08 00:40:53 -0700 Yes it's a little confusing, but but 78540 is your friend. 644430 11 146476 webkit.review.bot 2012-06-08 00:42:58 -0700 Comment on attachment 146476 Patch Clearing flags on attachment: 146476 Committed r119807: <http://trac.webkit.org/changeset/119807> 644431 12 webkit.review.bot 2012-06-08 00:43:03 -0700 All reviewed patches have been landed. Closing bug. 644433 13 pascal.massimino 2012-06-08 00:46:30 -0700 Fine with me, if just for the (important) sake of coherency. Thanks for fixing this Noel! 644479 14 noel.gordon 2012-06-08 01:50:24 -0700 No worries. 146476 2012-06-07 22:06:19 -0700 2012-06-08 00:42:57 -0700 Patch bug-88613-20120608150617.patch text/plain 1667 noel.gordon U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NzkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDcyY2E1ZDU4NDMwYWY0 Mjk4ZjJmMTdkZjg0ZDgwOThkMGMxNWI5Yy4uMGJhNzZhZTdiZDU4ZjFiNzJiZDNmODIzNDMyOWFl MmIxZDY1NzhlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTA3ICBOb2Vs IEdvcmRvbiAgPG5vZWwuZ29yZG9uQGdtYWlsLmNvbT4KKworICAgICAgICBbY2hyb21pdW1dIFdF QlAgaW1hZ2UgYmx1ZSBhbmQgcmVkIGNvbG9yIGNoYW5uZWxzIHJldmVyc2VkIG9uIEFuZHJvaWQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4NjEzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLiBDb3ZlcmVkIGJ5IHRlc3QgZmFzdC9pbWFnZXMvd2VicC1pbWFnZS1kZWNvZGluZy5odG1s IHRob3VnaCBJJ20KKyAgICAgICAgbm90IHN1cmUgd2hlcmUvaG93IHRoZSBBbmRyb2lkcyBydW4g dGhlaXIgbGF5b3V0IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMv d2VicC9XRUJQSW1hZ2VEZWNvZGVyLmNwcDoKKyAgICAgICAgKG91dHB1dE1vZGUpOiBEZXRlY3Qg bGl0dGxlLWVuZGlhbiBTa2lhIHdpdGggYSBibHVlIHBpeGVsIHNoaWZ0IChha2EgQW5kcm9pZCkK KyAgICAgICAgd2hpY2ggc2VlbXMgdG8gYmUgdGhlIHdheSBmb3IgdGhlbSBwZXIgYnVnIDc1ODYx LgorCiAyMDEyLTA2LTA3ICBWaWN0b3IgQ2FyYnVuZSAgPHZpY3RvckByb3NlZHUub3JnPgogCiAg ICAgICAgIGFkZFRleHRUcmFjayBzaG91bGQgc2V0IHRyYWNrIG1vZGUgdG8gSElEREVOCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy93ZWJwL1dFQlBJ bWFnZURlY29kZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMv d2VicC9XRUJQSW1hZ2VEZWNvZGVyLmNwcAppbmRleCBiOGQzYjQxNjNiNjFiNTc4M2QwYmE3MDBh MDQxMjliNzFiZTgyNWMyLi4wODJlMzNkZGIyYTM2MGUzODg4ZDc5YjAzYTljMjFjY2RiOGMwM2My IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy93ZWJw L1dFQlBJbWFnZURlY29kZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdl LWRlY29kZXJzL3dlYnAvV0VCUEltYWdlRGVjb2Rlci5jcHAKQEAgLTM5LDYgKzM5LDggQEAKIAog I2lmIENQVShCSUdfRU5ESUFOKSB8fCBDUFUoTUlERExFX0VORElBTikKIGlubGluZSBXRUJQX0NT UF9NT0RFIG91dHB1dE1vZGUoKSB7IHJldHVybiBNT0RFX1JHQkE7IH0KKyNlbGlmIFVTRShTS0lB KSAmJiBTS19CMzJfU0hJRlQKK2lubGluZSBXRUJQX0NTUF9NT0RFIG91dHB1dE1vZGUoKSB7IHJl dHVybiBNT0RFX1JHQkE7IH0KICNlbHNlIC8vIExJVFRMRV9FTkRJQU4sIG91dHB1dCBCR1JBIHBp eGVscy4KIGlubGluZSBXRUJQX0NTUF9NT0RFIG91dHB1dE1vZGUoKSB7IHJldHVybiBNT0RFX0JH UkE7IH0KICNlbmRpZgo=