88590 2012-06-07 16:27:14 -0700 Style build architectures like build versions for non-layout test failures 2012-06-07 19:19:52 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth dglazkov dpranke tony webkit.review.bot oldest_to_newest 644042 0 ojan 2012-06-07 16:27:14 -0700 Style build architectures like build versions for non-layout test failures 644043 1 146412 ojan 2012-06-07 16:27:59 -0700 Created attachment 146412 Patch 644044 2 146412 tony 2012-06-07 16:29:57 -0700 Comment on attachment 146412 Patch Why is the indenting in this file crazy? 644052 3 ojan 2012-06-07 16:37:53 -0700 (In reply to comment #2) > (From update of attachment 146412 [details]) > Why is the indenting in this file crazy? It's trying to be clever with grouping for showing descendant relationships. I'm not a huge fan, but my change is consistent with it, e.g. .parent { } .parent .child { } .parent .child:hover { } 644103 4 abarth 2012-06-07 17:17:12 -0700 > Why is the indenting in this file crazy? It's dglazkov-style! If you think it's crazy, please feel free to make it non-crazy. 644221 5 146412 webkit.review.bot 2012-06-07 19:19:47 -0700 Comment on attachment 146412 Patch Clearing flags on attachment: 146412 Committed r119784: <http://trac.webkit.org/changeset/119784> 644222 6 webkit.review.bot 2012-06-07 19:19:52 -0700 All reviewed patches have been landed. Closing bug. 146412 2012-06-07 16:27:59 -0700 2012-06-07 19:19:47 -0700 Patch bug-88590-20120607162759.patch text/plain 1710 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NzU2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzdiZTE5NWViNzRlYTNlMGVkMDE3Y2Q1MzBjZTE0Yjhi YzRhZmU1Yi4uMjgzZjMxODI3OTEzNTJhYmZkY2U1MGMxZmVmNzZhMzBjMWI0OTkyYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4 IEBACiAyMDEyLTA2LTA3ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKKyAgICAg ICAgU3R5bGUgYnVpbGQgYXJjaGl0ZWN0dXJlcyBsaWtlIGJ1aWxkIHZlcnNpb25zIGZvciBub24t bGF5b3V0IHRlc3QgZmFpbHVyZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTg4NTkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgU2luY2Ugd2Ugc2hvdyB0aGUgbGlzdCBvZiBmYWlsaW5nIHRlc3RzIGFmdGVy IHRoZSBhcmNoaXRlY3R1cmUsIHdlIHdhbnQgdGhlCisgICAgICAgIGJ1aWxkdHlwZSBhbmQgYXJj aGl0ZWN0dXJlIHRvIGJlIGdyb3VwZWQgdG9nZXRoZXIgdmlzdWFsbHkuCisKKyAgICAgICAgKiBC dWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0 RmFpbHVyZXMvc3R5bGVzL2ZhaWx1cmVzLmNzczoKKyAgICAgICAgKC5lZmZlY3RzIGEuZmFpbGlu Zy1idWlsZGVyPnNwYW4uYXJjaGl0ZWN0dXJlKToKKworMjAxMi0wNi0wNyAgT2phbiBWYWZhaSAg PG9qYW5AY2hyb21pdW0ub3JnPgorCiAgICAgICAgIEZpeCByZWNlbnQgbnVsbCBwb2ludGVyIGVy cm9yIHJlZ3Jlc3Npb24gaW4gdGhlIGZsYWtpbmVzcyBkYXNoYm9hcmQKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4NTczCiAKZGlmZiAtLWdpdCBhL1Rv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1s L1Rlc3RGYWlsdXJlcy9zdHlsZXMvZmFpbHVyZXMuY3NzIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3N0eWxl cy9mYWlsdXJlcy5jc3MKaW5kZXggMDNjNWMzODZiZjQxMzdlMzdlNmYzNWMwZjEyYjE5YjRjNGNi MmRhMi4uZmU4MThjNmIzMTBiNzMzZWIyMzZlOTY2NjE0NjUxNzEyZjMyNjRmMyAxMDA2NDQKLS0t IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGlj X2h0bWwvVGVzdEZhaWx1cmVzL3N0eWxlcy9mYWlsdXJlcy5jc3MKKysrIGIvVG9vbHMvQnVpbGRT bGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1 cmVzL3N0eWxlcy9mYWlsdXJlcy5jc3MKQEAgLTQ4LDYgKzQ4LDExIEBAIGEuZmFpbGluZy1idWls ZGVyIHsKICAgICAgICAgcGFkZGluZzogMCAycHg7CiAgICAgfQogCisgICAgLmVmZmVjdHMgYS5m YWlsaW5nLWJ1aWxkZXI+c3Bhbi5hcmNoaXRlY3R1cmUgeworICAgICAgICBiYWNrZ3JvdW5kLWNv bG9yOiAjNTU1OworICAgICAgICBjb2xvcjogV2hpdGU7CisgICAgfQorCiAgICAgYS5mYWlsaW5n LWJ1aWxkZXI+c3Bhbi5ncmFwaGljcyB7CiAgICAgICAgIHBhZGRpbmc6IDAgMnB4OwogICAgIH0K