88573 2012-06-07 13:43:27 -0700 Fix recent null pointer error regression in the flakiness dashboard 2012-06-07 14:32:43 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan dpranke tony oldest_to_newest 643856 0 ojan 2012-06-07 13:43:27 -0700 Fix recent null pointer error regression in the flakiness dashboard 643859 1 146377 ojan 2012-06-07 13:43:57 -0700 Created attachment 146377 Patch 643863 2 146377 dpranke 2012-06-07 13:49:56 -0700 Comment on attachment 146377 Patch looks fine to me, but my JS-fu isn't terribly strong. Is it possible for something in the test to throw an exception that would cause doXHR not to be reassigned back to oldDoXHR? i.e. does that need to wrapped in a try/finally like you would in python? 643872 3 ojan 2012-06-07 13:58:51 -0700 (In reply to comment #2) > (From update of attachment 146377 [details]) > looks fine to me, but my JS-fu isn't terribly strong. Is it possible for something in the test to throw an exception that would cause doXHR not to be reassigned back to oldDoXHR? i.e. does that need to wrapped in a try/finally like you would in python? yes. good idea. 643923 4 ojan 2012-06-07 14:32:43 -0700 Committed r119754: <http://trac.webkit.org/changeset/119754> 146377 2012-06-07 13:43:57 -0700 2012-06-07 13:49:56 -0700 Patch bug-88573-20120607134357.patch text/plain 3771 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NzQ1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDkyNDQ5NmJiMjA1MTQwNGZhZWVmMWZhMzU0Y2VlYjkx YTkzMDJhMC4uOWI0MzgxMjc0ZmQ5ZjVhZTExOGJhYWU4ZDU5ZDNlYjA4NGY0NTcwYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEyLTA2LTA3ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgRml4IHJlY2VudCBudWxsIHBvaW50ZXIgZXJyb3IgcmVncmVzc2lvbiBpbiB0aGUgZmxha2lu ZXNzIGRhc2hib2FyZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODg1NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFRlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvYnVpbGRlcnMuanM6Cisg ICAgICAgIChyZXF1ZXN0QnVpbGRlckxpc3QpOgorICAgICAgICAqIFRlc3RSZXN1bHRTZXJ2ZXIv c3RhdGljLWRhc2hib2FyZHMvZmxha2luZXNzX2Rhc2hib2FyZF91bml0dGVzdHMuanM6CisKIDIw MTItMDYtMDcgIERhbmllbCBFcmF0ICA8ZGVyYXRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtj aHJvbWl1bV0gQWRkIExheW91dFRlc3RDb250cm9sbGVyOjpzZXRUZXh0U3VicGl4ZWxQb3NpdGlv bmluZygpIGZvciBMaW51eC4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3Rh dGljLWRhc2hib2FyZHMvYnVpbGRlcnMuanMgYi9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRp Yy1kYXNoYm9hcmRzL2J1aWxkZXJzLmpzCmluZGV4IGMwYWEwNDliY2Y3YWViYzNlMzQxOWIyZDFi NjE4MDFjNTEwODFmY2EuLjlkMzU2NzQyM2ViMGYwNzRiNThlNmZkYTc5YmJjMTE1NDYyZTE5MzAg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvYnVp bGRlcnMuanMKKysrIGIvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9i dWlsZGVycy5qcwpAQCAtMTE3LDE0ICsxMTcsOSBAQCBmdW5jdGlvbiBhc3NvY2lhdGVCdWlsZGVy c1dpdGhNYXN0ZXIoYnVpbGRlcnMsIG1hc3RlcikKICAgICB9KTsKIH0KIAotZnVuY3Rpb24gcmVx dWVzdEJ1aWxkZXJMaXN0KGJ1aWxkZXJHcm91cHMsIGJ1aWxkZXJGaWx0ZXIsIG1hc3RlciwgZ3Jv dXBOYW1lLCBncm91cEVudW0sIGJ1aWxkZXJHcm91cCkKK2Z1bmN0aW9uIGRvWEhSKHVybCwgb25M b2FkLCBidWlsZGVyR3JvdXBzLCBncm91cE5hbWUpCiB7Ci0gICAgaWYgKCEoZ3JvdXBOYW1lIGlu IGJ1aWxkZXJHcm91cHMpKQotICAgICAgICBidWlsZGVyR3JvdXBzW2dyb3VwTmFtZV0gPSBidWls ZGVyR3JvdXA7Ci0KLSAgICB2YXIgb25Mb2FkID0gcGFydGlhbChvbkJ1aWxkZXJMaXN0TG9hZCwg YnVpbGRlckdyb3VwcywgYnVpbGRlckZpbHRlciwgbWFzdGVyLCBncm91cE5hbWUsIGdyb3VwRW51 bSk7CiAgICAgdmFyIHhociA9IG5ldyBYTUxIdHRwUmVxdWVzdCgpOwotICAgIHZhciB1cmwgPSBt YXN0ZXIuYnVpbGRlckpzb25QYXRoKCk7CiAgICAgeGhyLm9wZW4oJ0dFVCcsIHVybCwgdHJ1ZSk7 CiAgICAgeGhyLm9ubG9hZCA9IGZ1bmN0aW9uKCkgewogICAgICAgICBpZiAoeGhyLnN0YXR1cyA9 PSAyMDApCkBAIC0xMzQsNiArMTI5LDE0IEBAIGZ1bmN0aW9uIHJlcXVlc3RCdWlsZGVyTGlzdChi dWlsZGVyR3JvdXBzLCBidWlsZGVyRmlsdGVyLCBtYXN0ZXIsIGdyb3VwTmFtZSwgZ3JvCiAgICAg fTsKICAgICB4aHIub25lcnJvciA9IGZ1bmN0aW9uKCkgeyBvbkVycm9yTG9hZGluZ0J1aWxkZXJM aXN0KHVybCwgYnVpbGRlckdyb3VwcywgZ3JvdXBOYW1lKTsgfTsKICAgICB4aHIuc2VuZCgpOwor fQorCitmdW5jdGlvbiByZXF1ZXN0QnVpbGRlckxpc3QoYnVpbGRlckdyb3VwcywgYnVpbGRlckZp bHRlciwgbWFzdGVyLCBncm91cE5hbWUsIGdyb3VwRW51bSwgYnVpbGRlckdyb3VwKQoreworICAg IGlmICghYnVpbGRlckdyb3Vwc1tncm91cE5hbWVdKQorICAgICAgICBidWlsZGVyR3JvdXBzW2dy b3VwTmFtZV0gPSBidWlsZGVyR3JvdXA7CisgICAgdmFyIG9uTG9hZCA9IHBhcnRpYWwob25CdWls ZGVyTGlzdExvYWQsIGJ1aWxkZXJHcm91cHMsIGJ1aWxkZXJGaWx0ZXIsIG1hc3RlciwgZ3JvdXBO YW1lLCBncm91cEVudW0pOworICAgIGRvWEhSKG1hc3Rlci5idWlsZGVySnNvblBhdGgoKSwgb25M b2FkLCBidWlsZGVyR3JvdXBzLCBncm91cE5hbWUpOwogICAgIGJ1aWxkZXJHcm91cHNbZ3JvdXBO YW1lXS5leHBlY3RlZEdyb3VwcyArPSAxOwogfQogCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0UmVz dWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2ZsYWtpbmVzc19kYXNoYm9hcmRfdW5pdHRlc3Rz LmpzIGIvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9mbGFraW5lc3Nf ZGFzaGJvYXJkX3VuaXR0ZXN0cy5qcwppbmRleCAyZjdiZTE0NjUxMTdlNjQwMjM1ZjUxNDBiYzcz MWNmMGNiNGZlY2NlLi40MmFkMDBmNDUxMDg1ZjcyYzY5MWQ1Mzc5YWYxMDU5NTQ3MWE0MmQwIDEw MDY0NAotLS0gYS9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2ZsYWtp bmVzc19kYXNoYm9hcmRfdW5pdHRlc3RzLmpzCisrKyBiL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIv c3RhdGljLWRhc2hib2FyZHMvZmxha2luZXNzX2Rhc2hib2FyZF91bml0dGVzdHMuanMKQEAgLTY2 MSw2ICs2NjEsMjQgQEAgdGVzdCgnYnVpbGRlckdyb3VwRXhwZWN0ZWRHcm91cHMnLCA0LCBmdW5j dGlvbigpIHsKICAgICBlcXVhbCh0ZXN0QnVpbGRlckdyb3Vwc1snQFRvVCAtIGR1bW15Lm9yZydd Lmdyb3VwcywgMyk7CiB9KTsKIAordGVzdCgncmVxdWVzdEJ1aWxkZXJMaXN0QWRkc0J1aWxkZXJH cm91cEVudHJ5JywgMiwgZnVuY3Rpb24oKSB7CisgICAgdmFyIHRlc3RCdWlsZGVyR3JvdXBzID0g eyAnQFRvVCAtIGR1bW15Lm9yZyc6IG51bGwgfTsKKworICAgIHZhciBvbGREb1hIUiA9IGRvWEhS OworICAgIGRvWEhSID0gZnVuY3Rpb24oKSB7fTsKKyAgICB2YXIgYnVpbGRlckZpbHRlciA9IG51 bGw7CisgICAgdmFyIG1hc3RlciA9IHsgYnVpbGRlckpzb25QYXRoOiBmdW5jdGlvbigpIHt9IH07 CisgICAgdmFyIGdyb3VwTmFtZSA9ICdAVG9UIC0gZHVtbXkub3JnJzsKKyAgICB2YXIgZ3JvdXBF bnVtID0gbnVsbDsKKyAgICB2YXIgYnVpbGRlckdyb3VwID0geyBleHBlY3RlZEdyb3VwczogMCB9 OworICAgIHJlcXVlc3RCdWlsZGVyTGlzdCh0ZXN0QnVpbGRlckdyb3VwcywgYnVpbGRlckZpbHRl ciwgbWFzdGVyLCBncm91cE5hbWUsIGdyb3VwRW51bSwgYnVpbGRlckdyb3VwKTsKKworICAgIGVx dWFsKHRlc3RCdWlsZGVyR3JvdXBzWydAVG9UIC0gZHVtbXkub3JnJ10sIGJ1aWxkZXJHcm91cCk7 CisgICAgZXF1YWwodGVzdEJ1aWxkZXJHcm91cHNbJ0BUb1QgLSBkdW1teS5vcmcnXS5leHBlY3Rl ZEdyb3VwcywgMSk7CisKKyAgICBkb1hIUiA9IG9sZERvWEhSOworfSkKKwogdGVzdCgnc29ydFRl c3RzJywgNCwgZnVuY3Rpb24oKSB7CiAgICAgdmFyIHRlc3QxID0gY3JlYXRlUmVzdWx0c09iamVj dEZvclRlc3QoJ2Zvby90ZXN0MS5odG1sJywgJ2R1bW15QnVpbGRlcicpOwogICAgIHZhciB0ZXN0 MiA9IGNyZWF0ZVJlc3VsdHNPYmplY3RGb3JUZXN0KCdmb28vdGVzdDIuaHRtbCcsICdkdW1teUJ1 aWxkZXInKTsK