<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>88568</bug_id>
          
          <creation_ts>2012-06-07 11:58:30 -0700</creation_ts>
          <short_desc>[Qt] Qt DRT should load external resources - cleanup</short_desc>
          <delta_ts>2012-06-07 15:02:04 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Zoltan Horvath">zoltan</reporter>
          <assigned_to name="Zoltan Horvath">zoltan</assigned_to>
          <cc>morrita</cc>
    
    <cc>rniwa</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>643765</commentid>
    <comment_count>0</comment_count>
    <who name="Zoltan Horvath">zoltan</who>
    <bug_when>2012-06-07 11:58:30 -0700</bug_when>
    <thetext>Make things more straighforward to load external URLs in DRT.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>643770</commentid>
    <comment_count>1</comment_count>
      <attachid>146349</attachid>
    <who name="Zoltan Horvath">zoltan</who>
    <bug_when>2012-06-07 12:00:05 -0700</bug_when>
    <thetext>Created attachment 146349
proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>643948</commentid>
    <comment_count>2</comment_count>
      <attachid>146349</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-06-07 15:01:57 -0700</bug_when>
    <thetext>Comment on attachment 146349
proposed patch

Clearing flags on attachment: 146349

Committed r119757: &lt;http://trac.webkit.org/changeset/119757&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>643949</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-06-07 15:02:04 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>146349</attachid>
            <date>2012-06-07 12:00:05 -0700</date>
            <delta_ts>2012-06-07 15:01:57 -0700</delta_ts>
            <desc>proposed patch</desc>
            <filename>external.patch</filename>
            <type>text/plain</type>
            <size>2841</size>
            <attacher name="Zoltan Horvath">zoltan</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9x
dC9DaGFuZ2VMb2cKaW5kZXggNTE0Y2JhMS4uZmM4MzY1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNSBAQAorMjAxMi0wNi0wNyAgWm9sdGFuIEhvcnZhdGggIDx6b2x0YW5Ad2Via2l0Lm9y
Zz4KKworICAgICAgICBbUXRdIFF0IERSVCBzaG91bGQgbG9hZCBleHRlcm5hbCByZXNvdXJjZXMg
LSBjbGVhbnVwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD04ODU2OAorCisgICAgICAgIE1ha2UgdGhpbmdzIG1vcmUgc3RyYWlnaGZvcndhcmQgdG8gbG9h
ZCBleHRlcm5hbCBVUkxzIGluIERSVC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50UXQuY3Bw
OgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXJDbGllbnRRdDo6ZGlzcGF0Y2hXaWxsU2Vu
ZFJlcXVlc3QpOgorCiAyMDEyLTA2LTA2ICBab2x0YW4gSG9ydmF0aCAgPHpvbHRhbkB3ZWJraXQu
b3JnPgogCiAgICAgICAgIFtRdF0gUXQgRFJUIC8gV1RSIHNob3VsZCBiZSBhYmxlIHRvIGxvYWQg
ZXh0ZXJuYWwgcmVzb3VyY2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVT
dXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50UXQuY3BwIGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3Jl
U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFF0LmNwcAppbmRleCA1NWY0ZmRlLi44ZmEyMDljIDEw
MDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xp
ZW50UXQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2Fk
ZXJDbGllbnRRdC5jcHAKQEAgLTEwNDAsOCArMTA0MCw2IEBAIHN0YXRpYyBib29sIGhvc3RJc1Vz
ZWRCeVNvbWVUZXN0c1RvR2VuZXJhdGVFcnJvcihjb25zdCBRU3RyaW5nJiBob3N0KQogCiB2b2lk
IEZyYW1lTG9hZGVyQ2xpZW50UXQ6OmRpc3BhdGNoV2lsbFNlbmRSZXF1ZXN0KFdlYkNvcmU6OkRv
Y3VtZW50TG9hZGVyKiwgdW5zaWduZWQgbG9uZyBpZGVudGlmaWVyLCBXZWJDb3JlOjpSZXNvdXJj
ZVJlcXVlc3QmIG5ld1JlcXVlc3QsIGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVzcG9uc2UmIHJl
ZGlyZWN0UmVzcG9uc2UpCiB7Ci0gICAgUVVybCB1cmwgPSBuZXdSZXF1ZXN0LnVybCgpOwotCiAg
ICAgaWYgKGR1bXBSZXNvdXJjZUxvYWRDYWxsYmFja3MpCiAgICAgICAgIHByaW50ZigiJXMgLSB3
aWxsU2VuZFJlcXVlc3QgJXMgcmVkaXJlY3RSZXNwb25zZSAlc1xuIiwKICAgICAgICAgICAgICAg
IHFQcmludGFibGUoZHVtcEFzc2lnbmVkVXJsc1tpZGVudGlmaWVyXSksCkBAIC0xMDU5LDE5ICsx
MDU3LDIxIEBAIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRRdDo6ZGlzcGF0Y2hXaWxsU2VuZFJlcXVl
c3QoV2ViQ29yZTo6RG9jdW1lbnRMb2FkZXIqLCB1bnNpCiAgICAgICAgIHJldHVybjsKICAgICB9
CiAKKyAgICBRVXJsIHVybCA9IG5ld1JlcXVlc3QudXJsKCk7CiAgICAgUVN0cmluZyBob3N0ID0g
dXJsLmhvc3QoKTsKLSAgICBRU3RyaW5nIHVybExvd2VyU2NoZW1lID0gdXJsLnNjaGVtZSgpLnRv
TG93ZXIoKTsKKyAgICBRU3RyaW5nIHVybFNjaGVtZSA9IHVybC5zY2hlbWUoKS50b0xvd2VyKCk7
CiAKICAgICBpZiAoUVdlYlBhZ2VQcml2YXRlOjpkcnRSdW4KICAgICAgICAgJiYgIWhvc3QuaXNF
bXB0eSgpCi0gICAgICAgICYmICh1cmxMb3dlclNjaGVtZSA9PSBRTGF0aW4xU3RyaW5nKCJodHRw
IikgfHwgdXJsTG93ZXJTY2hlbWUgPT0gUUxhdGluMVN0cmluZygiaHR0cHMiKSkpIHsKKyAgICAg
ICAgJiYgKHVybFNjaGVtZSA9PSBRTGF0aW4xU3RyaW5nKCJodHRwIikgfHwgdXJsU2NoZW1lID09
IFFMYXRpbjFTdHJpbmcoImh0dHBzIikpKSB7CiAKLSAgICAgICAgUVVybCB0ZXN0VVJMID0gbV9m
cmFtZS0+cGFnZSgpLT5tYWluRnJhbWUoKS0+ZG9jdW1lbnQoKS0+dXJsKCk7CisgICAgICAgIFFV
cmwgdGVzdFVSTCA9IG1fd2ViRnJhbWUtPnBhZ2UoKS0+bWFpbkZyYW1lKCktPnJlcXVlc3RlZFVy
bCgpOwogICAgICAgICBRU3RyaW5nIHRlc3RIb3N0ID0gdGVzdFVSTC5ob3N0KCk7CisgICAgICAg
IFFTdHJpbmcgdGVzdFVSTFNjaGVtZSA9IHRlc3RVUkwuc2NoZW1lKCkudG9Mb3dlcigpOwogCiAg
ICAgICAgIGlmICghaXNMb2NhbGhvc3QoaG9zdCkKICAgICAgICAgICAgICYmICFob3N0SXNVc2Vk
QnlTb21lVGVzdHNUb0dlbmVyYXRlRXJyb3IoaG9zdCkKLSAgICAgICAgICAgICYmICgodXJsTG93
ZXJTY2hlbWUgIT0gUUxhdGluMVN0cmluZygiaHR0cCIpICYmIHVybExvd2VyU2NoZW1lICE9IFFM
YXRpbjFTdHJpbmcoImh0dHBzIikpIHx8IHRlc3RIb3N0LmlzRW1wdHkoKSB8fCBpc0xvY2FsaG9z
dCh0ZXN0SG9zdCkpKSB7CisgICAgICAgICAgICAmJiAoKHRlc3RVUkxTY2hlbWUgIT0gUUxhdGlu
MVN0cmluZygiaHR0cCIpICYmIHRlc3RVUkxTY2hlbWUgIT0gUUxhdGluMVN0cmluZygiaHR0cHMi
KSkgfHwgaXNMb2NhbGhvc3QodGVzdEhvc3QpKSkgewogICAgICAgICAgICAgcHJpbnRmKCJCbG9j
a2VkIGFjY2VzcyB0byBleHRlcm5hbCBVUkwgJXNcbiIsIHFQcmludGFibGUoZHJ0RGVzY3JpcHRp
b25TdWl0YWJsZUZvclRlc3RSZXN1bHQobmV3UmVxdWVzdC51cmwoKSkpKTsKICAgICAgICAgICAg
IGJsb2NrUmVxdWVzdChuZXdSZXF1ZXN0KTsKICAgICAgICAgICAgIHJldHVybjsK
</data>

          </attachment>
      

    </bug>

</bugzilla>