88563 2012-06-07 11:39:35 -0700 [BlackBerry] Show correct fullscreen button image (media controls) 2012-11-02 12:43:57 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Other CLOSED FIXED P2 Normal --- 1 mfeil mfeil tonikitoo webkit.review.bot oldest_to_newest 643739 0 mfeil 2012-06-07 11:39:35 -0700 The "enter" fullscreen button image is currently being rendered all the time. This needs to be changed so that the "exit" fullscreen button image is rendered when the video is fullscreen. PR159306 643749 1 146343 mfeil 2012-06-07 11:46:08 -0700 Created attachment 146343 Patch 644237 2 146343 tonikitoo 2012-06-07 19:57:31 -0700 Comment on attachment 146343 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146343&action=review > Source/WebCore/ChangeLog:15 > + I am not providing a test due to the simplicity of this patch > + and the relative difficulty and maintainability issues associated > + with testing how an image is rendered. > + I am not in love with this justification, but it is ok to go without a test for this case :) 644248 3 146343 webkit.review.bot 2012-06-07 20:06:40 -0700 Comment on attachment 146343 Patch Clearing flags on attachment: 146343 Committed r119789: <http://trac.webkit.org/changeset/119789> 644249 4 webkit.review.bot 2012-06-07 20:06:46 -0700 All reviewed patches have been landed. Closing bug. 757482 5 mfeil 2012-11-02 12:43:57 -0700 Closing bug for patch that landed a long time ago. 146343 2012-06-07 11:46:08 -0700 2012-06-07 20:06:40 -0700 Patch bug-88563-20120607144606.patch text/plain 2625 mfeil U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTYyNjIyNTg3NzE3ODNh YzhhZjRhNjc1MTY3N2M1NDI3MGEwZDI5MC4uNThiNzZhMzUwMmRiZTNmN2RiNDBmMTI2NmQ3ZjA5 ZDJlNDI1ZDM2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA2LTA3ICBNYXgg RmVpbCAgPG1mZWlsQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFNob3cgY29ycmVj dCBmdWxsc2NyZWVuIGJ1dHRvbiBpbWFnZSAobWVkaWEgY29udHJvbHMpCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODU2MworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBSMTU5MzA2OiBTaG93ICJleGl0IiBm dWxsc2NyZWVuIGJ1dHRvbiBpbWFnZSBpbnN0ZWFkIG9mICJlbnRlciIKKyAgICAgICAgZnVsbHNj cmVlbiBidXR0b24gaW1hZ2Ugd2hlbiBpbiBmdWxsc2NyZWVuIG1vZGUgKEhUTUw1IG1lZGlhCisg ICAgICAgIGNvbnRyb2xzKS4KKworICAgICAgICBJIGFtIG5vdCBwcm92aWRpbmcgYSB0ZXN0IGR1 ZSB0byB0aGUgc2ltcGxpY2l0eSBvZiB0aGlzIHBhdGNoCisgICAgICAgIGFuZCB0aGUgcmVsYXRp dmUgZGlmZmljdWx0eSBhbmQgbWFpbnRhaW5hYmlsaXR5IGlzc3VlcyBhc3NvY2lhdGVkCisgICAg ICAgIHdpdGggdGVzdGluZyBob3cgYW4gaW1hZ2UgaXMgcmVuZGVyZWQuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ibGFja2JlcnJ5L1JlbmRlclRoZW1lQmxhY2tCZXJyeS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJUaGVtZUJsYWNrQmVycnk6OnBhaW50TWVkaWFGdWxsc2NyZWVuQnV0dG9u KToKKwogMjAxMi0wNi0wNyAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29t PgogCiAgICAgICAgIFdvcmtlciB0ZWFyLWRvd24gY2FuIHJlLWVudGVyIEpTQyBkdXJpbmcgR0Mg ZmluYWxpemF0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2Jl cnJ5L1JlbmRlclRoZW1lQmxhY2tCZXJyeS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9i bGFja2JlcnJ5L1JlbmRlclRoZW1lQmxhY2tCZXJyeS5jcHAKaW5kZXggNGJhNjA1NTNkNmY3YWU5 YTA3NTZkOTZmMmU1YmJlMGZkOWM5NmMxMS4uYjE3OWU3ODBlNGY2NTJhMTRlNThlZjgzNDVkZGRm Yzg2MTNmM2Y4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYmxhY2tiZXJy eS9SZW5kZXJUaGVtZUJsYWNrQmVycnkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2JsYWNrYmVycnkvUmVuZGVyVGhlbWVCbGFja0JlcnJ5LmNwcApAQCAtODUyLDEyICs4NTIsMTkg QEAgYm9vbCBSZW5kZXJUaGVtZUJsYWNrQmVycnk6OnBhaW50TWVkaWFNdXRlQnV0dG9uKFJlbmRl ck9iamVjdCogb2JqZWN0LCBjb25zdCBQYWkKIGJvb2wgUmVuZGVyVGhlbWVCbGFja0JlcnJ5Ojpw YWludE1lZGlhRnVsbHNjcmVlbkJ1dHRvbihSZW5kZXJPYmplY3QqIG9iamVjdCwgY29uc3QgUGFp bnRJbmZvJiBwYWludEluZm8sIGNvbnN0IEludFJlY3QmIHJlY3QpCiB7CiAjaWYgRU5BQkxFKFZJ REVPKQotICAgIGlmICghdG9QYXJlbnRNZWRpYUVsZW1lbnQob2JqZWN0KSkKKyAgICBIVE1MTWVk aWFFbGVtZW50KiBtZWRpYUVsZW1lbnQgPSB0b1BhcmVudE1lZGlhRWxlbWVudChvYmplY3QpOwor ICAgIGlmICghbWVkaWFFbGVtZW50KQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICBzdGF0 aWMgSW1hZ2UqIG1lZGlhRnVsbHNjcmVlbiA9IEltYWdlOjpsb2FkUGxhdGZvcm1SZXNvdXJjZSgi ZnVsbHNjcmVlbiIpLmxlYWtSZWYoKTsKKyAgICBzdGF0aWMgSW1hZ2UqIG1lZGlhRW50ZXJGdWxs c2NyZWVuID0gSW1hZ2U6OmxvYWRQbGF0Zm9ybVJlc291cmNlKCJmdWxsc2NyZWVuIikubGVha1Jl ZigpOworICAgIHN0YXRpYyBJbWFnZSogbWVkaWFFeGl0RnVsbHNjcmVlbiA9IEltYWdlOjpsb2Fk UGxhdGZvcm1SZXNvdXJjZSgiZXhpdF9mdWxsc2NyZWVuIikubGVha1JlZigpOwogCi0gICAgcmV0 dXJuIHBhaW50TWVkaWFCdXR0b24ocGFpbnRJbmZvLmNvbnRleHQsIHJlY3QsIG1lZGlhRnVsbHNj cmVlbik7CisgICAgSW1hZ2UqIGJ1dHRvbkltYWdlID0gbWVkaWFFbnRlckZ1bGxzY3JlZW47Cisj aWYgRU5BQkxFKEZVTExTQ1JFRU5fQVBJKQorICAgIGlmIChtZWRpYUVsZW1lbnQtPmRvY3VtZW50 KCktPndlYmtpdElzRnVsbFNjcmVlbigpICYmIG1lZGlhRWxlbWVudC0+ZG9jdW1lbnQoKS0+d2Vi a2l0Q3VycmVudEZ1bGxTY3JlZW5FbGVtZW50KCkgPT0gbWVkaWFFbGVtZW50KQorICAgICAgICBi dXR0b25JbWFnZSA9IG1lZGlhRXhpdEZ1bGxzY3JlZW47CisjZW5kaWYKKyAgICByZXR1cm4gcGFp bnRNZWRpYUJ1dHRvbihwYWludEluZm8uY29udGV4dCwgcmVjdCwgYnV0dG9uSW1hZ2UpOwogI2Vs c2UKICAgICBVTlVTRURfUEFSQU0ob2JqZWN0KTsKICAgICBVTlVTRURfUEFSQU0ocGFpbnRJbmZv KTsK