88562 2012-06-07 11:36:10 -0700 [Chromium] Move didStartWorkerRunLoop to Platform.h 2012-06-07 17:49:04 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 82948 1 pilgrim pilgrim abarth fishd haraken jamesr japhet jochen webkit.review.bot oldest_to_newest 643732 0 pilgrim 2012-06-07 11:36:10 -0700 [Chromium] Move didStartWorkerRunLoop to Platform.h 643733 1 146340 pilgrim 2012-06-07 11:36:50 -0700 Created attachment 146340 Patch 644075 2 146340 abarth 2012-06-07 16:52:58 -0700 Comment on attachment 146340 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146340&action=review > Source/WebCore/WebCore.gyp/WebCore.gyp:1846 > + 'defines': [ > + 'WEBKIT_IMPLEMENTATION=1', > + ], Ah, this worked better than webcore_prerequisites, I take it? 644141 3 146340 webkit.review.bot 2012-06-07 17:48:58 -0700 Comment on attachment 146340 Patch Clearing flags on attachment: 146340 Committed r119777: <http://trac.webkit.org/changeset/119777> 644142 4 webkit.review.bot 2012-06-07 17:49:04 -0700 All reviewed patches have been landed. Closing bug. 146340 2012-06-07 11:36:50 -0700 2012-06-07 17:48:57 -0700 Patch bug-88562-20120607143600.patch text/plain 6255 pilgrim SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExOTc0MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA2LTA3ICBNYXJrIFBp bGdyaW0gIDxwaWxncmltQGNocm9taXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIE1vdmUg ZGlkU3RhcnRXb3JrZXJSdW5Mb29wIHRvIFBsYXRmb3JtLmgKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4NTYyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGFydCBvZiBhIHJlZmFjdG9yaW5nIHNlcmllcy4g U2VlIHRyYWNraW5nIGJ1ZyA4Mjk0OC4KKworICAgICAgICAqIFdlYkNvcmUuZ3lwL1dlYkNvcmUu Z3lwOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1dvcmtlclNjcmlwdENvbnRyb2xsZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6V29ya2VyU2NyaXB0Q29udHJvbGxlcjo6fldvcmtlclNjcmlwdENv bnRyb2xsZXIpOgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL1BsYXRmb3JtU3VwcG9ydC5o OgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgICogd29ya2Vycy9Xb3JrZXJUaHJlYWQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6V29ya2VyVGhyZWFkOjp3b3JrZXJUaHJlYWQpOgorCiAyMDEy LTA2LTA3ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAgICAg ICAgV29ya2VyIHRlYXItZG93biBjYW4gcmUtZW50ZXIgSlNDIGR1cmluZyBHQyBmaW5hbGl6YXRp b24KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCShyZXZpc2lvbiAx MTk3MzkpCisrKyBTb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cAkod29ya2lu ZyBjb3B5KQpAQCAtMTg0MSw2ICsxODQxLDkgQEAKICAgICB7CiAgICAgICAndGFyZ2V0X25hbWUn OiAnd2ViY29yZV9yZW1haW5pbmcnLAogICAgICAgJ3R5cGUnOiAnc3RhdGljX2xpYnJhcnknLAor ICAgICAgJ2RlZmluZXMnOiBbCisgICAgICAgICdXRUJLSVRfSU1QTEVNRU5UQVRJT049MScsCisg ICAgICBdLAogICAgICAgJ2RlcGVuZGVuY2llcyc6IFsKICAgICAgICAgJ3dlYmNvcmVfcHJlcmVx dWlzaXRlcycsCiAgICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL3RoaXJkX3BhcnR5L3Y4LWkx OG4vYnVpbGQvYWxsLmd5cDp2OC1pMThuJywKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L1dvcmtlclNjcmlwdENvbnRyb2xsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1dvcmtlclNjcmlwdENvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiAxMTk3 MzkpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9Xb3JrZXJTY3JpcHRDb250cm9sbGVy LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDcsNiArNDcsMTEgQEAKICNpbmNsdWRlICJXb3JrZXJU aHJlYWQuaCIKICNpbmNsdWRlIDx2OC5oPgogCisjaWYgUExBVEZPUk0oQ0hST01JVU0pCisjaW5j bHVkZSA8cHVibGljL1BsYXRmb3JtLmg+CisjaW5jbHVkZSA8cHVibGljL1dlYldvcmtlclJ1bkxv b3AuaD4KKyNlbmRpZgorCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIFdvcmtlclNjcmlwdENvbnRy b2xsZXI6OldvcmtlclNjcmlwdENvbnRyb2xsZXIoV29ya2VyQ29udGV4dCogd29ya2VyQ29udGV4 dCkKQEAgLTY5LDcgKzc0LDcgQEAgV29ya2VyU2NyaXB0Q29udHJvbGxlcjo6fldvcmtlclNjcmlw dENvbgogICAgIC8vIFRoZSBjb3JyZXNwb25kaW5nIGNhbGwgdG8gZGlkU3RhcnRXb3JrZXJSdW5M b29wIGlzIGluCiAgICAgLy8gV29ya2VyVGhyZWFkOjp3b3JrZXJUaHJlYWQoKS4KICAgICAvLyBT ZWUgaHR0cDovL3dlYmtpdC5vcmcvYi84MzEwNCNjMTQgZm9yIHdoeSB0aGlzIGlzIGhlcmUuCi0g ICAgUGxhdGZvcm1TdXBwb3J0OjpkaWRTdG9wV29ya2VyUnVuTG9vcCgmbV93b3JrZXJDb250ZXh0 LT50aHJlYWQoKS0+cnVuTG9vcCgpKTsKKyAgICBXZWJLaXQ6OlBsYXRmb3JtOjpjdXJyZW50KCkt PmRpZFN0b3BXb3JrZXJSdW5Mb29wKFdlYktpdDo6V2ViV29ya2VyUnVuTG9vcCgmbV93b3JrZXJD b250ZXh0LT50aHJlYWQoKS0+cnVuTG9vcCgpKSk7CiAjZW5kaWYKICAgICBtX3Byb3h5LmNsZWFy KCk7CiAgICAgbV9pc29sYXRlLT5FeGl0KCk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9jaHJvbWl1bS9QbGF0Zm9ybVN1cHBvcnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9jaHJvbWl1bS9QbGF0Zm9ybVN1cHBvcnQuaAkocmV2aXNpb24gMTE5NzM5KQor KysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUGxhdGZvcm1TdXBwb3J0LmgJKHdv cmtpbmcgY29weSkKQEAgLTgxLDcgKzgxLDYgQEAgY2xhc3MgSW50UmVjdDsKIGNsYXNzIEtVUkw7 CiBjbGFzcyBTZXJpYWxpemVkU2NyaXB0VmFsdWU7CiBjbGFzcyBXaWRnZXQ7Ci1jbGFzcyBXb3Jr ZXJSdW5Mb29wOwogCiBzdHJ1Y3QgQ29va2llOwogc3RydWN0IEZvbnRSZW5kZXJTdHlsZTsKQEAg LTMzMSw5ICszMzAsNiBAQCBwdWJsaWM6CiAgICAgLy8gVmlzaXRlZCBsaW5rcyAtLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KICAgICBzdGF0aWMg TGlua0hhc2ggdmlzaXRlZExpbmtIYXNoKGNvbnN0IFVDaGFyKiB1cmwsIHVuc2lnbmVkIGxlbmd0 aCk7CiAgICAgc3RhdGljIExpbmtIYXNoIHZpc2l0ZWRMaW5rSGFzaChjb25zdCBLVVJMJiBiYXNl LCBjb25zdCBBdG9taWNTdHJpbmcmIGF0dHJpYnV0ZVVSTCk7Ci0KLSAgICBzdGF0aWMgdm9pZCBk aWRTdGFydFdvcmtlclJ1bkxvb3AoV29ya2VyUnVuTG9vcCopOwotICAgIHN0YXRpYyB2b2lkIGRp ZFN0b3BXb3JrZXJSdW5Mb29wKFdvcmtlclJ1bkxvb3AqKTsKIH07CiAKIH0gLy8gbmFtZXNwYWNl IFdlYkNvcmUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyVGhyZWFkLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlclRocmVhZC5jcHAJKHJl dmlzaW9uIDExOTczOSkKKysrIFNvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyVGhyZWFkLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMjAsNyArMjAsNyBAQAogICogUFJPRklUUzsgT1IgQlVTSU5F U1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZIFRIRU9SWQogICogT0Yg TElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JU CiAgKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBX QVkgT1VUIE9GIFRIRSBVU0UKLSAqIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBP RiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuIAorICogT0YgVEhJUyBTT0ZUV0FSRSwg RVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KICAqCiAg Ki8KIApAQCAtNDcsNiArNDcsMTEgQEAKICNpbmNsdWRlICJEYXRhYmFzZVRyYWNrZXIuaCIKICNl bmRpZgogCisjaWYgUExBVEZPUk0oQ0hST01JVU0pCisjaW5jbHVkZSA8cHVibGljL1BsYXRmb3Jt Lmg+CisjaW5jbHVkZSA8cHVibGljL1dlYldvcmtlclJ1bkxvb3AuaD4KKyNlbmRpZgorCiBuYW1l c3BhY2UgV2ViQ29yZSB7CiAKIHN0YXRpYyBNdXRleCYgdGhyZWFkQ291bnRNdXRleCgpCkBAIC0x NDQsNyArMTQ5LDcgQEAgdm9pZCBXb3JrZXJUaHJlYWQ6OndvcmtlclRocmVhZCgpCiAjaWYgUExB VEZPUk0oQ0hST01JVU0pCiAgICAgLy8gVGhlIGNvcnJlc3BvbmRpbmcgY2FsbCB0byBkaWRTdG9w V29ya2VyUnVuTG9vcCBpcyBpbgogICAgIC8vIH5Xb3JrZXJTY3JpcHRDb250cm9sbGVyLgotICAg IFBsYXRmb3JtU3VwcG9ydDo6ZGlkU3RhcnRXb3JrZXJSdW5Mb29wKCZtX3J1bkxvb3ApOworICAg IFdlYktpdDo6UGxhdGZvcm06OmN1cnJlbnQoKS0+ZGlkU3RhcnRXb3JrZXJSdW5Mb29wKFdlYktp dDo6V2ViV29ya2VyUnVuTG9vcCgmbV9ydW5Mb29wKSk7CiAjZW5kaWYKIAogICAgIFdvcmtlclNj cmlwdENvbnRyb2xsZXIqIHNjcmlwdCA9IG1fd29ya2VyQ29udGV4dC0+c2NyaXB0KCk7CkluZGV4 OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gMTE5NzQxKQorKysgU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAor MjAxMi0wNi0wNyAgTWFyayBQaWxncmltICA8cGlsZ3JpbUBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgW0Nocm9taXVtXSBNb3ZlIGRpZFN0YXJ0V29ya2VyUnVuTG9vcCB0byBQbGF0Zm9ybS5oCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODU2MgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBhcnQgb2YgYSBy ZWZhY3RvcmluZyBzZXJpZXMuIFNlZSB0cmFja2luZyBidWcgODI5NDguCisKKyAgICAgICAgKiBz cmMvUGxhdGZvcm1TdXBwb3J0LmNwcDoKKyAgICAgICAgKFdlYkNvcmUpOgorCiAyMDEyLTA2LTA3 ICBEYW5pZWwgRXJhdCAgPGRlcmF0QGNocm9taXVtLm9yZz4KIAogICAgICAgICBBZGQgc2V0dGlu ZyB0byBlbmFibGUgc3VicGl4ZWwtcG9zaXRpb25lZCB0ZXh0IG9uIExpbnV4LgpJbmRleDogU291 cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvUGxhdGZvcm1TdXBwb3J0LmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9QbGF0Zm9ybVN1cHBvcnQuY3BwCShyZXZpc2lv biAxMTk3MzkpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9QbGF0Zm9ybVN1cHBvcnQu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC05Niw3ICs5Niw2IEBACiAjaW5jbHVkZSA8cHVibGljL1dl YkNvb2tpZS5oPgogI2luY2x1ZGUgPHB1YmxpYy9XZWJDb29raWVKYXIuaD4KICNpbmNsdWRlIDxw dWJsaWMvV2ViTWltZVJlZ2lzdHJ5Lmg+Ci0jaW5jbHVkZSA8cHVibGljL1dlYldvcmtlclJ1bkxv b3AuaD4KICNpbmNsdWRlIDx3dGYvQXNzZXJ0aW9ucy5oPgogCiAvLyBXZSBhcmUgcGFydCBvZiB0 aGUgV2ViS2l0IGltcGxlbWVudGF0aW9uLgpAQCAtNzIxLDE2ICs3MjAsNiBAQCBib29sIFBsYXRm b3JtU3VwcG9ydDo6cG9wdXBzQWxsb3dlZChOUFAKIH0KIAogI2lmIEVOQUJMRShXT1JLRVJTKQot dm9pZCBQbGF0Zm9ybVN1cHBvcnQ6OmRpZFN0YXJ0V29ya2VyUnVuTG9vcChXb3JrZXJSdW5Mb29w KiBsb29wKQotewotICAgIFdlYktpdDo6UGxhdGZvcm06OmN1cnJlbnQoKS0+ZGlkU3RhcnRXb3Jr ZXJSdW5Mb29wKFdlYldvcmtlclJ1bkxvb3AobG9vcCkpOwotfQotCi12b2lkIFBsYXRmb3JtU3Vw cG9ydDo6ZGlkU3RvcFdvcmtlclJ1bkxvb3AoV29ya2VyUnVuTG9vcCogbG9vcCkKLXsKLSAgICBX ZWJLaXQ6OlBsYXRmb3JtOjpjdXJyZW50KCktPmRpZFN0b3BXb3JrZXJSdW5Mb29wKFdlYldvcmtl clJ1bkxvb3AobG9vcCkpOwotfQotCiBXb3JrZXJDb250ZXh0UHJveHkqIFdvcmtlckNvbnRleHRQ cm94eTo6Y3JlYXRlKFdvcmtlciogd29ya2VyKQogewogICAgIHJldHVybiBXZWJXb3JrZXJDbGll bnRJbXBsOjpjcmVhdGVXb3JrZXJDb250ZXh0UHJveHkod29ya2VyKTsK