88559 2012-06-07 11:19:57 -0700 Web Inspector: keyboard shortcut for Dock to Right 2012-06-08 06:27:34 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED DUPLICATE 76917 P2 Normal --- 0 paulirish dsam2912 apavlov bweinstein dsam2912 joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 643718 0 paulirish 2012-06-07 11:19:57 -0700 Developers absolutely love Dock to Right. The #1 request I've heard for the past two weeks is a keyboard shortcut for toggling that checkbox setting. 644442 1 apavlov 2012-06-08 00:59:22 -0700 *** This bug has been marked as a duplicate of bug 76917 *** 644566 2 dsam2912 2012-06-08 04:32:59 -0700 Reopening to attach new patch. 644568 3 146539 dsam2912 2012-06-08 04:33:05 -0700 Created attachment 146539 Patch 644569 4 dsam2912 2012-06-08 04:34:45 -0700 *** This bug has been marked as a duplicate of bug 76917 *** 644571 5 dsam2912 2012-06-08 04:35:49 -0700 (In reply to comment #3) > Created an attachment (id=146539) [details] > Patch oops!, didn't notice the duplicate change before uploading patch. Will upload it in 76917. 644575 6 pfeldman 2012-06-08 04:41:56 -0700 I don't think we need a shortcut. I have a wip patch that alters undock action when Ctrl is down while hovering over the undock button. 644623 7 146539 vsevik 2012-06-08 06:27:34 -0700 Comment on attachment 146539 Patch Clearing r? 146539 2012-06-08 04:33:05 -0700 2012-06-08 06:27:34 -0700 Patch bug-88559-20120608170211.patch text/plain 3488 dsam2912 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExOTgxOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA2LTA4ICBTYW0gRCAg PGRzYW0yOTEyQGdtYWlsLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBrZXlib2FyZCBz aG9ydGN1dCBmb3IgRG9jayB0byBSaWdodAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODg1NTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZGRlZCBrZXlib2FyZCBzaG9ydGN1dCB0byB0b2dnbGUgZG9ja2lu ZyB0byByaWdodC4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFVJIENoYW5nZS4KKworICAgICAg ICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU2V0dGluZ3MuanM6CisgICAgICAgICogaW5zcGVjdG9y L2Zyb250LWVuZC9TZXR0aW5nc1NjcmVlbi5qczoKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQt ZW5kL2luc3BlY3Rvci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5fcmVnaXN0ZXJTaG9ydGN1 dHMpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLmRvY3VtZW50S2V5RG93bik6CisKIDIwMTItMDYt MDggIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIE1vdmUgZm9y bS1yZWxhdGVkIGZ1bmN0aW9ucyBvZiBEb2N1bWVudCB0byBGb3JtQ29udHJvbGxlcgpJbmRleDog U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TZXR0aW5ncy5qcwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NldHRpbmdzLmpzCShyZXZp c2lvbiAxMTk4MTYpCisrKyBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NldHRp bmdzLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0xMzYsNiArMTM2LDI0IEBAIFdlYkluc3BlY3Rvci5T ZXR0aW5nLnByb3RvdHlwZSA9IHsKICAgICAgICAgdGhpcy5fZXZlbnRTdXBwb3J0LnJlbW92ZUV2 ZW50TGlzdGVuZXIodGhpcy5fbmFtZSwgbGlzdGVuZXIsIHRoaXNPYmplY3QpOwogICAgIH0sCiAK KyAgICAvKioKKyAgICAgKiBAcGFyYW0ge0V2ZW50fSBldmVudAorICAgICAqIEByZXR1cm4ge2Jv b2xlYW59CisgICAgICovCisgICAgaGFuZGxlU2hvcnRjdXQ6IGZ1bmN0aW9uKGV2ZW50KQorICAg IHsKKyAgICAgICAgaWYgKGV2ZW50LmtleUlkZW50aWZpZXIgPT09ICJVKzAwNDQiKSB7IC8vIGZv ciBEIGtleSAKKyAgICAgICAgICAgIGlmIChldmVudC5jdHJsS2V5ICYmICFldmVudC5tZXRhS2V5 ICYmICFldmVudC5hbHRLZXkgJiYgIWV2ZW50LnNoaWZ0S2V5KSB7CisgICAgICAgICAgICAgICAg Ly8gVG9nZ2xlIGRvY2tpbmcgdG8gcmlnaHQvYm90dG9tLiAKKyAgICAgICAgICAgICAgICB0aGlz LnNldCghdGhpcy5nZXQoKSk7CisgICAgICAgICAgICAgICAgdGhpcy5pbnB1dEVsZW1lbnQuY2hl Y2tlZCA9ICF0aGlzLmlucHV0RWxlbWVudC5jaGVja2VkOworICAgICAgICAgICAgICAgIGV2ZW50 LmNvbnN1bWUodHJ1ZSk7CisgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7ICAKKyAgICAgICAg ICAgIH0KKyAgICAgICAgfQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgfSwKKwogICAgIGdl dCBuYW1lKCkKICAgICB7CiAgICAgICAgIHJldHVybiB0aGlzLl9uYW1lOwpJbmRleDogU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TZXR0aW5nc1NjcmVlbi5qcwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NldHRpbmdzU2NyZWVuLmpz CShyZXZpc2lvbiAxMTk4MTYpCisrKyBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L1NldHRpbmdzU2NyZWVuLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0yMTEsNiArMjExLDcgQEAgV2Vi SW5zcGVjdG9yLlNldHRpbmdzU2NyZWVuLnByb3RvdHlwZSA9CiAgICAgICAgIGlucHV0LnR5cGUg PSAiY2hlY2tib3giOwogICAgICAgICBpbnB1dC5uYW1lID0gbmFtZTsKICAgICAgICAgaW5wdXQu Y2hlY2tlZCA9IHNldHRpbmcuZ2V0KCk7CisgICAgICAgIHNldHRpbmcuaW5wdXRFbGVtZW50ID0g aW5wdXQ7CiAKICAgICAgICAgZnVuY3Rpb24gbGlzdGVuZXIoKQogICAgICAgICB7CkluZGV4OiBT b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcwkocmV2 aXNpb24gMTE5ODE2KQorKysgU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNw ZWN0b3IuanMJKHdvcmtpbmcgY29weSkKQEAgLTY2Nyw2ICs2NjcsOSBAQCBXZWJJbnNwZWN0b3Iu X3JlZ2lzdGVyU2hvcnRjdXRzID0gZnVuY3RpCiB7CiAgICAgdmFyIHNob3J0Y3V0ID0gV2ViSW5z cGVjdG9yLktleWJvYXJkU2hvcnRjdXQ7CiAgICAgdmFyIHNlY3Rpb24gPSBXZWJJbnNwZWN0b3Iu c2hvcnRjdXRzU2NyZWVuLnNlY3Rpb24oV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJBbGwgUGFuZWxz IikpOworCisgICAgc2VjdGlvbi5hZGRLZXkoc2hvcnRjdXQuc2hvcnRjdXRUb1N0cmluZygiZCIs IHNob3J0Y3V0Lk1vZGlmaWVycy5DdHJsT3JNZXRhKSwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJE b2NrIHRvIFJpZ2h0IikpOworICAgIAogICAgIHZhciBrZXlzID0gWwogICAgICAgICBzaG9ydGN1 dC5zaG9ydGN1dFRvU3RyaW5nKCJdIiwgc2hvcnRjdXQuTW9kaWZpZXJzLkN0cmxPck1ldGEpLAog ICAgICAgICBzaG9ydGN1dC5zaG9ydGN1dFRvU3RyaW5nKCJbIiwgc2hvcnRjdXQuTW9kaWZpZXJz LkN0cmxPck1ldGEpCkBAIC03MjYsNyArNzI5LDkgQEAgV2ViSW5zcGVjdG9yLmRvY3VtZW50S2V5 RG93biA9IGZ1bmN0aW9uKAogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAgICAgfQot CisgICAgCisgICAgaWYgKFdlYkluc3BlY3Rvci5zZXR0aW5ncy5kb2NrVG9SaWdodC5oYW5kbGVT aG9ydGN1dChldmVudCkpCisgICAgICAgIHJldHVybjsKICAgICBpZiAoV2ViSW5zcGVjdG9yLnNl YXJjaENvbnRyb2xsZXIuaGFuZGxlU2hvcnRjdXQoZXZlbnQpKQogICAgICAgICByZXR1cm47CiAg ICAgaWYgKFdlYkluc3BlY3Rvci5hZHZhbmNlZFNlYXJjaENvbnRyb2xsZXIuaGFuZGxlU2hvcnRj dXQoZXZlbnQpKQo=