88551 2012-06-07 10:36:18 -0700 run-webkit-tests --lint-test-files gives an error when run on linux 2012-06-07 12:45:09 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan dpranke dpranke rniwa tony oldest_to_newest 643674 0 ojan 2012-06-07 10:36:18 -0700 $ run-webkit-tests --lint-test-files Traceback (most recent call last): File "/media/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 454, in <module> sys.exit(main()) File "/media/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 449, in main return run(port, options, args) File "/media/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 95, in run return lint(port, options) File "/media/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 65, in lint test_expectations.TestExpectations(port_to_lint, is_lint_mode=True) File "/media/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py", line 732, in __init__ self._expectations = self._parser.parse(port.test_expectations()) File "/media/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium.py", line 319, in test_expectations return self._filesystem.read_text_file(expectations_path) File "/media/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem.py", line 218, in read_text_file with codecs.open(path, 'r', 'utf8') as f: File "/usr/lib/python2.6/codecs.py", line 870, in open file = __builtin__.open(filename, mode, buffering) IOError: [Errno 2] No such file or directory: '/media/src/chromium/src/third_party/WebKit/LayoutTests/platform/google-chrome-linux32/TestExpectations' Failed to execute Tools/Scripts/new-run-webkit-tests at /work/chromium/src/third_party/WebKit/Tools/Scripts/run-webkit-tests line 122. It works fine if I pass --platform=chromium-linux though. So, this isn't blocking me gardening or anything. 643679 1 tony 2012-06-07 10:41:33 -0700 I think we should just remove the google-chrome support from NRWT. When it was added, I was under the impression that someone (the release managers?) would check in results on the branch. In practice, they just suppress failures in TestExpectations. 643798 2 dpranke 2012-06-07 12:33:13 -0700 (In reply to comment #1) > I think we should just remove the google-chrome support from NRWT. When it was added, I was under the impression that someone (the release managers?) would check in results on the branch. In practice, they just suppress failures in TestExpectations. I agree, now that we can pass in additional expectation files on the command line, it should just be a matter of updating the bots to pass in the right command line flags and then we can remove this. That, however, is not the problem here. rniwa's renaming of test_expectations.txt -> TestExpectations didn't handle these ports properly. Patch momentarily. 643801 3 146361 dpranke 2012-06-07 12:36:43 -0700 Created attachment 146361 Patch 643806 4 dpranke 2012-06-07 12:45:09 -0700 Committed r119747: <http://trac.webkit.org/changeset/119747> 146361 2012-06-07 12:36:43 -0700 2012-06-07 12:37:36 -0700 Patch bug-88551-20120607123642.patch text/plain 2669 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NjU3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2RmMjY0M2ZkN2Q1NDZlNmUwOWZmYzg3M2U2YmQ5MzBi NWY1MDllMC4uYjgyYjhlZGFhOTU4OGZhYmU5NzhmMjY3YzE2MDljZTAwNWYzNTJkYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTA2LTA3ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIHJ1bi13ZWJraXQtdGVzdHMgLS1saW50LXRlc3QtZmlsZXMgZ2l2ZXMgYW4gZXJyb3Ig d2hlbiBydW4gb24gbGludXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTg4NTUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgV2Ugd2VyZW4ndCBtYXBwaW5nIHRoZSBleHBlY3RhdGlvbnMgcHJvcGVybHkgZm9y IHRoZQorICAgICAgICBnb29nbGUtY2hyb21lIHBvcnRzLgorCisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlLnB5OgorICAgICAgICAoUG9ydC5wYXRoX3Rv X3Rlc3RfZXhwZWN0YXRpb25zX2ZpbGUpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvZ29vZ2xlX2Nocm9tZV91bml0dGVzdC5weToKKyAgICAgICAgKFRlc3RH b29nbGVDaHJvbWVQb3J0LnRlc3RfcGF0aF90b19leHBlY3RhdGlvbnMpOgorCiAyMDEyLTA1LTI5 ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIHdlYmtpdHB5 OiBhZGQgc3VwcG9ydCBmb3IgYW4gb3JkZXJlZCBkaWN0IG9mIHRlc3QgZXhwZWN0YXRpb25zCmRp ZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Jhc2Uu cHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Jhc2UucHkKaW5k ZXggYmE1ZTA5M2NlM2U4ZTFkNzU1ODM0NjVkMGY5NzYwNWRhOTdhZTc4ZS4uZDBlZjQ3MDVkZTFi ZGFlNmE5NzlkNGY3MzY2NWYyYTE2ZTI0ZDkwOSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZS5weQpAQCAtNjkxLDcgKzY5MSw3IEBAIGNsYXNz IFBvcnQob2JqZWN0KToKIAogICAgICAgICAjIHRlc3RfZXhwZWN0YXRpb25zIGFyZSBhbHdheXMg aW4gbWFjLyBub3QgbWFjLWxlb3BhcmQvIGJ5IGNvbnZlbnRpb24sIGhlbmNlIHdlIHVzZSBwb3J0 X25hbWUgaW5zdGVhZCBvZiBuYW1lKCkuCiAgICAgICAgIHBvcnRfbmFtZSA9IHNlbGYucG9ydF9u YW1lCi0gICAgICAgIGlmIHBvcnRfbmFtZS5zdGFydHN3aXRoKCdjaHJvbWl1bScpOgorICAgICAg ICBpZiBwb3J0X25hbWUuc3RhcnRzd2l0aCgnY2hyb21pdW0nKSBvciBwb3J0X25hbWUuc3RhcnRz d2l0aCgnZ29vZ2xlLWNocm9tZScpOgogICAgICAgICAgICAgcG9ydF9uYW1lID0gJ2Nocm9taXVt JwogCiAgICAgICAgIGJhc2VsaW5lX3BhdGggPSBzZWxmLl93ZWJraXRfYmFzZWxpbmVfcGF0aChw b3J0X25hbWUpCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9wb3J0L2dvb2dsZV9jaHJvbWVfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9wb3J0L2dvb2dsZV9jaHJvbWVfdW5pdHRlc3QucHkKaW5kZXggOWQzNjUz YWU1MWFjYzBlY2E3OTQ1ZGQxNDhhZjJiOWJmNDQxYTA1YS4uYzg4YTMxMDhlZGMxZmM5NGM1NzQz ZGFkMmFmYmIzZGFkMDIxNDIyMCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcG9ydC9nb29nbGVfY2hyb21lX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZ29vZ2xlX2Nocm9tZV91bml0dGVzdC5w eQpAQCAtNjcsNiArNjcsMTEgQEAgY2xhc3MgVGVzdEdvb2dsZUNocm9tZVBvcnQodW5pdHRlc3Qu VGVzdENhc2UpOgogICAgICAgICBzZWxmLl92ZXJpZnlfZXhwZWN0YXRpb25zX292ZXJyaWRlcygn Z29vZ2xlLWNocm9tZS1saW51eDMyJykKICAgICAgICAgc2VsZi5fdmVyaWZ5X2V4cGVjdGF0aW9u c19vdmVycmlkZXMoJ2dvb2dsZS1jaHJvbWUtbGludXg2NCcpCiAKKyAgICBkZWYgdGVzdF9wYXRo X3RvX2V4cGVjdGF0aW9ucyhzZWxmKToKKyAgICAgICAgcG9ydF9mYWN0b3J5ID0gUG9ydEZhY3Rv cnkoTW9ja1N5c3RlbUhvc3QoKSkKKyAgICAgICAgZm9yIHBvcnRfbmFtZSBpbiAoJ2dvb2dsZS1j aHJvbWUtbGludXgzMicsICdnb29nbGUtY2hyb21lLWxpbnV4NjQnLCAnZ29vZ2xlLWNocm9tZS1t YWMnLCAnZ29vZ2xlLWNocm9tZS13aW4nKToKKyAgICAgICAgICAgIHNlbGYuYXNzZXJ0VHJ1ZShw b3J0X2ZhY3RvcnkuZ2V0KHBvcnRfbmFtZSkucGF0aF90b190ZXN0X2V4cGVjdGF0aW9uc19maWxl KCkuZW5kc3dpdGgoJ3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMnKSkKKwogCiBp ZiBfX25hbWVfXyA9PSAnX19tYWluX18nOgogICAgIHVuaXR0ZXN0Lm1haW4oKQo=