88533 2012-06-07 06:58:53 -0700 [Chromium] features.gypi should have the correct definitions for Android 2012-06-08 02:12:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 88564 88636 88637 66687 1 peter peter abarth webkit.review.bot oldest_to_newest 643509 0 peter 2012-06-07 06:58:53 -0700 [Chromium] features.gypi should have the correct definitions for Android 643519 1 146282 peter 2012-06-07 07:06:51 -0700 Created attachment 146282 Patch 643561 2 146282 peter 2012-06-07 08:00:58 -0700 Comment on attachment 146282 Patch Confirmed that this doesn't break the Android build. It's a no-op for other platforms. 643700 3 146282 webkit.review.bot 2012-06-07 11:04:26 -0700 Comment on attachment 146282 Patch Rejecting attachment 146282 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: WebCore::EUpdateLayout) const': Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1358: error: enumeration value 'CSSPropertyWebkitOverflowScrolling' not handled in switch CXX(target) out/Debug/obj.target/webcore_remaining/Source/WebCore/css/CSSFontFace.o CXX(target) out/Debug/obj.target/webcore_remaining/Source/WebCore/css/CSSFontFaceRule.o make: *** [out/Debug/obj.target/webcore_remaining/Source/WebCore/css/CSSComputedStyleDeclaration.o] Error 1 make: *** Waiting for unfinished jobs.... Full output: http://queues.webkit.org/results/12923059 643755 4 146282 peter 2012-06-07 11:50:11 -0700 Comment on attachment 146282 Patch Fixed that issue in r119743. 643825 5 146282 webkit.review.bot 2012-06-07 13:08:21 -0700 Comment on attachment 146282 Patch Clearing flags on attachment: 146282 Committed r119749: <http://trac.webkit.org/changeset/119749> 643826 6 webkit.review.bot 2012-06-07 13:08:25 -0700 All reviewed patches have been landed. Closing bug. 146282 2012-06-07 07:06:51 -0700 2012-06-07 13:08:21 -0700 Patch bug-88533-20120607150649.patch text/plain 4676 peter U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5Njk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDZhYjMwNmIyOTRiMzkxNzFmMTYyMTBlMmRiNWFmZWIxN2JkNDgwYjAuLjI5YmVlMzAwYTlkNTA1 ZjlhYzY5MmY3ZTFmYTQxM2M0MDdjNmI5NjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTItMDYtMDcgIFBldGVyIEJldmVybG9vICA8cGV0ZXJAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gZmVhdHVyZXMuZ3lwaSBzaG91bGQgaGF2ZSB0 aGUgY29ycmVjdCBkZWZpbml0aW9ucyBmb3IgQW5kcm9pZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODg1MzMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIGFsbCBmZWF0dXJlcyB3aGljaCBhcmUgZW5h YmxlZCBvbiBBbmRyb2lkIGJ1dCBkaXNhYmxlZCBvbiBvdGhlciBwbGF0Zm9ybXMsCisgICAgICAg IG9yIGFyZSBkaXNhYmxlZCBvbiBBbmRyb2lkIHdoaWxlIGVuYWJsZWQgb24gb3RoZXIgcGxhdGZv cm1zLCBjb25kaXRpb25hbC4gVGhpcworICAgICAgICBhbHNvIG1lYW5zIHRoYXQgdGhlIHNlbGVj dGlvbiBvZiBjb2RlIGNvbXBpbGVkIGZvciBBbmRyb2lkIHdpbGwgc2xpZ2h0bHkgY2hhbmdlLgor CisgICAgICAgIFRoaXMgY2hhbmdlIGFsc28gcmVtb3ZlcyB0aGUgZW5hYmxlX3ZpZXdwb3J0IHZh cmlhYmxlIGFzIHRoZSB2YWx1ZSBvZiB0aGlzIGlzCisgICAgICAgIG5vIGxvbmdlciByZXNwZWN0 ZWQgYnkgV2ViS2l0IC0gaXQncyBlbmFibGVkIGJ5IGRlZmF1bHQgZm9yIGFsbCBvZiBDaHJvbWl1 bS4KKyAgICAgICAgRnVydGhlcm1vcmUsIEVOQUJMRV9PVkVSRkxPV19TQ1JPTExJTkcgaXMgbm93 IGxpc3RlZCBpbiBmZWF0dXJlcy5neXBpIGFnYWluLgorCisgICAgICAgICogZmVhdHVyZXMuZ3lw aToKKwogMjAxMi0wNi0wNyAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5j b20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjExOTY4OS4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaSBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vZmVhdHVyZXMuZ3lwaQppbmRleCA1ZGJjNDQ5Y2FlNjk3YWNmZjliYTkwMjU5OTAw ZDZkNmMzOWJhZDQzLi42ZGU4ZTdlMDkxZjc2OWM2ZDExZTYyOGJhYzRhZThkZGYyY2IxMmM3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkKKysrIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5neXBpCkBAIC02MywyOSArNjMsMTggQEAKICAg ICAgICdFTkFCTEVfSUNPTkRBVEFCQVNFPTAnLAogICAgICAgJ0VOQUJMRV9JRlJBTUVfU0VBTUxF U1M9MScsCiAgICAgICAnRU5BQkxFX0lOREVYRURfREFUQUJBU0U9MScsCi0gICAgICAnRU5BQkxF X0lOUFVUX1NQRUVDSD0xJywKICAgICAgICdFTkFCTEVfSU5QVVRfVFlQRV9EQVRFPTEnLAotICAg ICAgJ0VOQUJMRV9JTlBVVF9UWVBFX0RBVEVUSU1FPTAnLAotICAgICAgJ0VOQUJMRV9JTlBVVF9U WVBFX0RBVEVUSU1FTE9DQUw9MCcsCi0gICAgICAnRU5BQkxFX0lOUFVUX1RZUEVfTU9OVEg9MCcs Ci0gICAgICAnRU5BQkxFX0lOUFVUX1RZUEVfVElNRT0wJywKLSAgICAgICdFTkFCTEVfSU5QVVRf VFlQRV9XRUVLPTAnLAogICAgICAgJ0VOQUJMRV9KQVZBU0NSSVBUX0RFQlVHR0VSPTEnLAotICAg ICAgJ0VOQUJMRV9KQVZBU0NSSVBUX0kxOE5fQVBJPTEnLAogICAgICAgJ0VOQUJMRV9MRUdBQ1lf Q1NTX1ZFTkRPUl9QUkVGSVhFUz0wJywKLSAgICAgICdFTkFCTEVfTEVHQUNZX05PVElGSUNBVElP TlM9MScsCiAgICAgICAnRU5BQkxFX0xFR0FDWV9XRUJLSVRfQkxPQl9CVUlMREVSPTEnLAogICAg ICAgJ0VOQUJMRV9MSU5LX1BSRUZFVENIPTEnLAogICAgICAgJ0VOQUJMRV9MSU5LX1BSRVJFTkRF Uj0xJywKICAgICAgICdFTkFCTEVfTUVESUFfU09VUkNFPTEnLAogICAgICAgJ0VOQUJMRV9NRURJ QV9TVEFUSVNUSUNTPTEnLAotICAgICAgJ0VOQUJMRV9NRURJQV9TVFJFQU09MScsCiAgICAgICAn RU5BQkxFX01FVEVSX1RBRz0xJywKICAgICAgICdFTkFCTEVfTUhUTUw9MScsCiAgICAgICAnRU5B QkxFX01JQ1JPREFUQT0wJywKICAgICAgICdFTkFCTEVfTVVUQVRJT05fT0JTRVJWRVJTPTwoZW5h YmxlX211dGF0aW9uX29ic2VydmVycyknLAotICAgICAgJ0VOQUJMRV9OT1RJRklDQVRJT05TPTEn LAotICAgICAgJ0VOQUJMRV9PUklFTlRBVElPTl9FVkVOVFM9MCcsCiAgICAgICAnRU5BQkxFX1BB R0VfVklTSUJJTElUWV9BUEk9MScsCiAgICAgICAnRU5BQkxFX1BPSU5URVJfTE9DSz0xJywKICAg ICAgICdFTkFCTEVfUFJPR1JFU1NfVEFHPTEnLApAQCAtOTYsNyArODUsNiBAQAogICAgICAgJ0VO QUJMRV9TQU5EQk9YPTEnLAogICAgICAgJ0VOQUJMRV9TQ1JJUFRFRF9TUEVFQ0g9MScsCiAgICAg ICAnRU5BQkxFX1NIQURPV19ET009MScsCi0gICAgICAnRU5BQkxFX1NIQVJFRF9XT1JLRVJTPTEn LAogICAgICAgJ0VOQUJMRV9TTU9PVEhfU0NST0xMSU5HPTEnLAogICAgICAgJ0VOQUJMRV9TUUxf REFUQUJBU0U9MScsCiAgICAgICAnRU5BQkxFX1NUWUxFX1NDT1BFRD0xJywKQEAgLTEzMyw3ICsx MjEsNiBAQAogICAgICAgJ3VzZV9hY2NlbGVyYXRlZF9jb21wb3NpdGluZyUnOiAxLAogICAgICAg J2VuYWJsZV9za2lhX3RleHQlJzogMSwKICAgICAgICdlbmFibGVfc3ZnJSc6IDEsCi0gICAgICAn ZW5hYmxlX3ZpZXdwb3J0JSc6IDAsCiAgICAgICAnZW5hYmxlX3RvdWNoX2V2ZW50cyUnOiAxLAog ICAgICAgJ2VuYWJsZV90b3VjaF9pY29uX2xvYWRpbmclJyA6IDAsCiAgICAgICAnZW5hYmxlX211 dGF0aW9uX29ic2VydmVycyUnOiAxLApAQCAtMTQ3LDE3ICsxMzQsNDQgQEAKICAgICAgICAgJ2Zl YXR1cmVfZGVmaW5lcyc6IFsKICAgICAgICAgICAnRU5BQkxFX0NBTEVOREFSX1BJQ0tFUj0wJywK ICAgICAgICAgICAnRU5BQkxFX0ZPTlRfQk9PU1RJTkc9MScsCisgICAgICAgICAgJ0VOQUJMRV9J TlBVVF9TUEVFQ0g9MCcsCisgICAgICAgICAgJ0VOQUJMRV9JTlBVVF9UWVBFX0RBVEVUSU1FPTEn LAorICAgICAgICAgICdFTkFCTEVfSU5QVVRfVFlQRV9EQVRFVElNRUxPQ0FMPTEnLAorICAgICAg ICAgICdFTkFCTEVfSU5QVVRfVFlQRV9NT05USD0xJywKKyAgICAgICAgICAnRU5BQkxFX0lOUFVU X1RZUEVfVElNRT0xJywKKyAgICAgICAgICAnRU5BQkxFX0lOUFVUX1RZUEVfV0VFSz0xJywKKyAg ICAgICAgICAnRU5BQkxFX0pBVkFTQ1JJUFRfSTE4Tl9BUEk9MCcsCisgICAgICAgICAgJ0VOQUJM RV9MRUdBQ1lfTk9USUZJQ0FUSU9OUz0wJywKICAgICAgICAgICAnRU5BQkxFX01FRElBX0NBUFRV UkU9MScsCisgICAgICAgICAgJ0VOQUJMRV9NRURJQV9TVFJFQU09MCcsCisgICAgICAgICAgJ0VO QUJMRV9OT1RJRklDQVRJT05TPTAnLAorICAgICAgICAgICdFTkFCTEVfT1JJRU5UQVRJT05fRVZF TlRTPTEnLAorICAgICAgICAgICdFTkFCTEVfT1ZFUkZMT1dfU0NST0xMSU5HPTEnLAogICAgICAg ICAgICdFTkFCTEVfUEFHRV9QT1BVUD0wJywKKyAgICAgICAgICAnRU5BQkxFX1NIQVJFRF9XT1JL RVJTPTAnLAogICAgICAgICAgICdFTkFCTEVfV0VCX0FVRElPPTAnLAogICAgICAgICAgICdXVEZf VVNFX05BVElWRV9GVUxMU0NSRUVOX1ZJREVPPTEnLAogICAgICAgICBdLAorICAgICAgICAnZW5h YmxlX3RvdWNoX2ljb25fbG9hZGluZyc6IDEsCiAgICAgICB9LCB7CiAgICAgICAgICdmZWF0dXJl X2RlZmluZXMnOiBbCiAgICAgICAgICAgJ0VOQUJMRV9DQUxFTkRBUl9QSUNLRVI9MScsCiAgICAg ICAgICAgJ0VOQUJMRV9GT05UX0JPT1NUSU5HPTAnLAorICAgICAgICAgICdFTkFCTEVfSU5QVVRf U1BFRUNIPTEnLAorICAgICAgICAgICdFTkFCTEVfSU5QVVRfVFlQRV9EQVRFVElNRT0wJywKKyAg ICAgICAgICAnRU5BQkxFX0lOUFVUX1RZUEVfREFURVRJTUVMT0NBTD0wJywKKyAgICAgICAgICAn RU5BQkxFX0lOUFVUX1RZUEVfTU9OVEg9MCcsCisgICAgICAgICAgJ0VOQUJMRV9JTlBVVF9UWVBF X1RJTUU9MCcsCisgICAgICAgICAgJ0VOQUJMRV9JTlBVVF9UWVBFX1dFRUs9MCcsCisgICAgICAg ICAgJ0VOQUJMRV9KQVZBU0NSSVBUX0kxOE5fQVBJPTEnLAorICAgICAgICAgICdFTkFCTEVfTEVH QUNZX05PVElGSUNBVElPTlM9MScsCiAgICAgICAgICAgJ0VOQUJMRV9NRURJQV9DQVBUVVJFPTAn LAorICAgICAgICAgICdFTkFCTEVfTUVESUFfU1RSRUFNPTEnLAorICAgICAgICAgICdFTkFCTEVf Tk9USUZJQ0FUSU9OUz0xJywKKyAgICAgICAgICAnRU5BQkxFX09SSUVOVEFUSU9OX0VWRU5UUz0w JywKKyAgICAgICAgICAnRU5BQkxFX09WRVJGTE9XX1NDUk9MTElORz0wJywKICAgICAgICAgICAn RU5BQkxFX1BBR0VfUE9QVVA9MScsCisgICAgICAgICAgJ0VOQUJMRV9TSEFSRURfV09SS0VSUz0x JywKICAgICAgICAgICAnRU5BQkxFX1dFQl9BVURJTz0xJywKICAgICAgICAgXSwKICAgICAgIH1d LAo=