88524 2012-06-07 04:37:17 -0700 check-webkit-style needs to be taught about <public/Foo.h> 2012-06-07 21:24:41 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kinuko kinuko abarth dpranke levin ojan webkit.review.bot oldest_to_newest 643411 0 kinuko 2012-06-07 04:37:17 -0700 Currently check-webkit-style considers any headers included with <> (i.e. is_system==True) as non-primary headers, but some platform implementation includes its primary header placed under Platform/.../public with <>. check-webkit-style warns include_order for those files. Examples: Source/WebCore/platform/chromium/support/WebHTTPBody.cpp Source/WebCore/platform/chromium/support/WebHTTPLoadInfo.cpp Source/WebCore/platform/chromium/support/WebURL.cpp Source/WebCore/platform/chromium/support/WebURLError.cpp Source/WebCore/platform/chromium/support/WebURLRequest.cpp Source/WebCore/platform/chromium/support/WebURLResponse.cpp Running check-webkit-style on any of these files generates include_order error: Source/WebCore/platform/chromium/support/WebHTTPBody.cpp:33: Alphabetical sorting problem. [build/include_order] [4] 643413 1 146253 kinuko 2012-06-07 04:41:04 -0700 Created attachment 146253 Patch 644295 2 kinuko 2012-06-07 21:24:41 -0700 Committed r119794: <http://trac.webkit.org/changeset/119794> 146253 2012-06-07 04:41:04 -0700 2012-06-07 09:07:13 -0700 Patch bug-88524-20120607204103.patch text/plain 4579 kinuko U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MzUyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzhiNTAyMGYzZjI1NTc5NTUwMzUzYTBiMjJkNDMwYWM5 YzkzYjQzYS4uMDMzYThmYWNkMzJkNWZhNzQ1YzdlZjA3Mjc5ZTA0MmUxZGY1YTk1ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTA2LTA3ICBLaW51a28gWWFzdWRhICA8a2ludWtvQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBjaGVjay13ZWJraXQtc3R5bGUgbmVlZHMgdG8gYmUgdGF1Z2h0IGFib3V0IDxwdWJs aWMvRm9vLmg+CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD04ODUyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6CisgICAgICAgIChfY2xh c3NpZnlfaW5jbHVkZSk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy cy9jcHBfdW5pdHRlc3QucHk6CisgICAgICAgIChPcmRlck9mSW5jbHVkZXNUZXN0LnRlc3RfcHVi bGljX3ByaW1hcnlfaGVhZGVyKToKKyAgICAgICAgKE9yZGVyT2ZJbmNsdWRlc1Rlc3QudGVzdF9j bGFzc2lmeV9pbmNsdWRlKToKKwogMjAxMi0wNi0wMiAgWmVubyBBbGJpc3NlciAgPHplbm9Ad2Vi a2l0Lm9yZz4KIAogICAgICAgICBGaXggYW5kIGVuYWJsZSBXZWJHTCBmb3IgV2ViS2l0MiBvbiBR dC4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3Bw LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKaW5kZXgg MWVlYTQ5NzNmODE4YjlhOWE2NWRjODdhZDNmMmI3YmYzZWI1MmRhNi4uYWFhZDg1ZDVjYWFiZWQy YzIxZjI0NWRiYzQ3YWY4Mzg3NTRjYTJjYSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9z dHlsZS9jaGVja2Vycy9jcHAucHkKQEAgLTI2MzIsNyArMjYzMiw3IEBAIGRlZiBfY2xhc3NpZnlf aW5jbHVkZShmaWxlbmFtZSwgaW5jbHVkZSwgaXNfc3lzdGVtLCBpbmNsdWRlX3N0YXRlKToKICAg ICAiIiIKIAogICAgICMgSWYgaXQgaXMgYSBzeXN0ZW0gaGVhZGVyIHdlIGtub3cgaXQgaXMgY2xh c3NpZmllZCBhcyBfT1RIRVJfSEVBREVSLgotICAgIGlmIGlzX3N5c3RlbToKKyAgICBpZiBpc19z eXN0ZW0gYW5kIG5vdCBpbmNsdWRlLnN0YXJ0c3dpdGgoJ3B1YmxpYy8nKToKICAgICAgICAgcmV0 dXJuIF9PVEhFUl9IRUFERVIKIAogICAgICMgSWYgdGhlIGluY2x1ZGUgaXMgbmFtZWQgY29uZmln LmggdGhlbiB0aGlzIGlzIFdlYkNvcmUvY29uZmlnLmguCmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CmluZGV4IGNiYTkxNzEw ODUwOTAzMzRhYzRjY2NjNGFjODZmMjIyMzIzNzMxMTIuLjE2NzVjNzAxMDg0MGIwYTJkZmIxM2I5 ZjRjNzdiM2U2M2EwZmQxMjAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5 bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv c3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CkBAIC0yNjk2LDYgKzI2OTYsMzAgQEAgY2xh c3MgT3JkZXJPZkluY2x1ZGVzVGVzdChDcHBTdHlsZVRlc3RCYXNlKToKIAogICAgICAgICBvcy5w YXRoLmlzZmlsZSA9IHNlbGYub3NfcGF0aF9pc2ZpbGVfb3JpZwogCisgICAgZGVmIHRlc3RfcHVi bGljX3ByaW1hcnlfaGVhZGVyKHNlbGYpOgorICAgICAgICAjIFN5c3RlbSBoZWFkZXIgaXMgbm90 IGNvbnNpZGVyZWQgYSBwcmltYXJ5IGhlYWRlci4KKyAgICAgICAgc2VsZi5hc3NlcnRfbGFuZ3Vh Z2VfcnVsZXNfY2hlY2soJ2Zvby5jcHAnLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAnI2luY2x1ZGUgImNvbmZpZy5oIlxuJworICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAnI2luY2x1ZGUgPG90aGVyL2Zvby5oPlxuJworICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnXG4nCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICcjaW5jbHVkZSAiYS5oIlxuJywKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgJ0FscGhhYmV0aWNhbCBzb3J0aW5nIHByb2JsZW0u ICBbYnVpbGQvaW5jbHVkZV9vcmRlcl0gWzRdJykKKworICAgICAgICAjIC4uLmV4Y2VwdCB0aGF0 IGl0IHN0YXJ0cyB3aXRoIHB1YmxpYy8uCisgICAgICAgIHNlbGYuYXNzZXJ0X2xhbmd1YWdlX3J1 bGVzX2NoZWNrKCdmb28uY3BwJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgJyNpbmNsdWRlICJjb25maWcuaCJcbicKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgJyNpbmNsdWRlIDxwdWJsaWMvZm9vLmg+XG4nCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICdcbicKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgJyNpbmNsdWRlICJhLmgiXG4nLAorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAnJykKKworICAgICAgICAjIEV2ZW4gaWYgaXQgc3RhcnRz IHdpdGggcHVibGljLyBpdHMgYmFzZSBwYXJ0IG11c3QgbWF0Y2ggd2l0aCB0aGUgc291cmNlIGZp bGUgbmFtZS4KKyAgICAgICAgc2VsZi5hc3NlcnRfbGFuZ3VhZ2VfcnVsZXNfY2hlY2soJ2Zvby5j cHAnLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnI2luY2x1ZGUg ImNvbmZpZy5oIlxuJworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAn I2luY2x1ZGUgPHB1YmxpYy9mb29wLmg+XG4nCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICdcbicKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgJyNpbmNsdWRlICJhLmgiXG4nLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAnQWxwaGFiZXRpY2FsIHNvcnRpbmcgcHJvYmxlbS4gIFtidWlsZC9pbmNsdWRlX29y ZGVyXSBbNF0nKQogCiAgICAgZGVmIHRlc3RfY2hlY2tfd3RmX2luY2x1ZGVzKHNlbGYpOgogICAg ICAgICBzZWxmLmFzc2VydF9sYW5ndWFnZV9ydWxlc19jaGVjaygnZm9vLmNwcCcsCkBAIC0yNzUx LDYgKzI3NzUsMTkgQEAgY2xhc3MgT3JkZXJPZkluY2x1ZGVzVGVzdChDcHBTdHlsZVRlc3RCYXNl KToKICAgICAgICAgICAgICAgICAgICAgICAgICBjbGFzc2lmeV9pbmNsdWRlKCdmb28uY3BwJywK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdtb2NfZm9vLmNwcCcs CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBGYWxzZSwgaW5jbHVk ZV9zdGF0ZSkpCisgICAgICAgICMgPHB1YmxpYy9mb28uaD4gbXVzdCBiZSBjb25zaWRlcmVkIGFz IHByaW1hcnkgZXZlbiBpZiBpc19zeXN0ZW0gaXMgVHJ1ZS4KKyAgICAgICAgc2VsZi5hc3NlcnRF cXVhbChjcHBfc3R5bGUuX1BSSU1BUllfSEVBREVSLAorICAgICAgICAgICAgICAgICAgICAgICAg IGNsYXNzaWZ5X2luY2x1ZGUoJ2Zvby9mb28uY3BwJywKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICdwdWJsaWMvZm9vLmgnLAorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgVHJ1ZSwgaW5jbHVkZV9zdGF0ZSkpCisgICAgICAgIHNlbGYu YXNzZXJ0RXF1YWwoY3BwX3N0eWxlLl9PVEhFUl9IRUFERVIsCisgICAgICAgICAgICAgICAgICAg ICAgICAgY2xhc3NpZnlfaW5jbHVkZSgnZm9vLmNwcCcsCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAnZm9vLmgnLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgVHJ1ZSwgaW5jbHVkZV9zdGF0ZSkpCisgICAgICAgIHNlbGYuYXNzZXJ0 RXF1YWwoY3BwX3N0eWxlLl9PVEhFUl9IRUFERVIsCisgICAgICAgICAgICAgICAgICAgICAgICAg Y2xhc3NpZnlfaW5jbHVkZSgnZm9vLmNwcCcsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAncHVibGljL2Zvb3AuaCcsCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBUcnVlLCBpbmNsdWRlX3N0YXRlKSkKICAgICAgICAgIyBRdCBwcml2 YXRlIEFQSXMgdXNlIF9wLmggc3VmZml4LgogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKGNwcF9z dHlsZS5fUFJJTUFSWV9IRUFERVIsCiAgICAgICAgICAgICAgICAgICAgICAgICAgY2xhc3NpZnlf aW5jbHVkZSgnZm9vLmNwcCcsCg==