88511 2012-06-07 01:18:19 -0700 [GTK] deviceScaleFactor setting is not honored 2012-06-07 08:24:51 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 spena webkit-unassigned alex mrobinson spena webkit.review.bot oldest_to_newest 643310 0 spena 2012-06-07 01:18:19 -0700 There's currently no way to update the deviceScaleFactor using the internal settings in the GTK port. 643352 1 spena 2012-06-07 02:31:48 -0700 Besides the WebKitWebSettings not being connected, the GraphicsContext is currently ignoring the deviceScaleFactor setting. This was fixed in Chromium in bug #88136. The test LayoutTests/fast/hidpi/device-scale-factor-paint.html was added there, and is currently failing in the GTK port. 643390 2 spena 2012-06-07 03:49:43 -0700 I don't think we need to update the WebKitWebSettings, but simply make the GraphicContext honor the device scale factor property when drawing the WebView, as the Chromium port does in bug #88136. 643402 3 146250 spena 2012-06-07 04:07:46 -0700 Created attachment 146250 Patch 643405 4 spena 2012-06-07 04:18:06 -0700 CCing Álex and Martin since they're working around this part 643539 5 146250 gustavo 2012-06-07 07:30:42 -0700 Comment on attachment 146250 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146250&action=review > Source/WebKit/gtk/ChangeLog:9 > + method of the ChromeClientGTk, since it was previously The t in Gtk is upper. I'd remove everything after the comma =). 643551 6 146289 spena 2012-06-07 07:43:56 -0700 Created attachment 146289 Patch 643568 7 146289 webkit.review.bot 2012-06-07 08:24:47 -0700 Comment on attachment 146289 Patch Clearing flags on attachment: 146289 Committed r119726: <http://trac.webkit.org/changeset/119726> 643569 8 webkit.review.bot 2012-06-07 08:24:51 -0700 All reviewed patches have been landed. Closing bug. 146250 2012-06-07 04:07:46 -0700 2012-06-07 07:43:44 -0700 Patch bug-88511-20120607130745.patch text/plain 1625 spena U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5Njg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggNTJlYjFlNDI2 ODVhNDU1ZmQ0YTRjOGI3M2RmM2QzZGI0YzU3NzZlMi4uNjNmMDI5YjFjNGE1NGJlMzVkNGM4ZDBj ZWRlYWJjNDEwZTk4MDNhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEy LTA2LTA3ICBTaW1vbiBQZW5hICA8c3BlbmFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBk ZXZpY2VTY2FsZUZhY3RvciBzZXR0aW5nIGlzIG5vdCBob25vcmVkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODUxMQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhvbm9yIHRoZSBkZXZpY2VTY2FsZUZhY3Rv ciBwcm9wZXJ0eSBpbiB0aGUgcGFpbnRXZWJWaWV3CisgICAgICAgIG1ldGhvZCBvZiB0aGUgQ2hy b21lQ2xpZW50R1RrLCBzaW5jZSBpdCB3YXMgcHJldmlvdXNseQorICAgICAgICBpZ25vcmVkIGJ5 IHRoZSBHcmFwaGljQ29udGV4IGluIHRoZSBHVEsgcG9ydC4KKworICAgICAgICAqIFdlYkNvcmVT dXBwb3J0L0Nocm9tZUNsaWVudEd0ay5jcHA6CisgICAgICAgIChXZWJLaXQ6OnBhaW50V2ViVmll dyk6CisKIDIwMTItMDYtMDQgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVu aUBsaW51eC5pbnRlbC5jb20+CiAKICAgICAgICAgW0dUS10gTWVtb3J5IGxlYWsgaW4gV2ViS2l0 V2ViVmlldwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvQ2hy b21lQ2xpZW50R3RrLmNwcCBiL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Nocm9t ZUNsaWVudEd0ay5jcHAKaW5kZXggNjU1YmY3ODdiZjhhMGY2M2YzNTA0YTk5ZmNiNWY4M2I5YzRi ZjJjYy4uZGI3NDVkMmFiZWQxYTUzN2YzODVmNjI3MWUwMTVkOWE2ZWMzOWQ1ZiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50R3RrLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRHdGsuY3Bw CkBAIC01MTQsNiArNTE0LDcgQEAgc3RhdGljIHZvaWQgcGFpbnRXZWJWaWV3KFdlYktpdFdlYlZp ZXcqIHdlYlZpZXcsIEZyYW1lKiBmcmFtZSwgUmVnaW9uIGRpcnR5UmVnaW8KIAogICAgIFJlZlB0 cjxjYWlyb190PiBiYWNraW5nU3RvcmVDb250ZXh0ID0gYWRvcHRSZWYoY2Fpcm9fY3JlYXRlKHdl YlZpZXctPnByaXYtPmJhY2tpbmdTdG9yZS0+Y2Fpcm9TdXJmYWNlKCkpKTsKICAgICBHcmFwaGlj c0NvbnRleHQgZ2MoYmFja2luZ1N0b3JlQ29udGV4dC5nZXQoKSk7CisgICAgZ2MuYXBwbHlEZXZp Y2VTY2FsZUZhY3RvcihmcmFtZS0+cGFnZSgpLT5kZXZpY2VTY2FsZUZhY3RvcigpKTsKICAgICBm b3IgKHNpemVfdCBpID0gMDsgaSA8IHJlY3RzLnNpemUoKTsgaSsrKSB7CiAgICAgICAgIGNvbnN0 IEludFJlY3QmIHJlY3QgPSByZWN0c1tpXTsKIAo= 146289 2012-06-07 07:43:56 -0700 2012-06-07 08:24:47 -0700 Patch bug-88511-20120607164354.patch text/plain 1546 spena U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggNTJlYjFlNDI2 ODVhNDU1ZmQ0YTRjOGI3M2RmM2QzZGI0YzU3NzZlMi4uMGVjOTA0MGIwNDY4ZmFmNDk5OTY4Y2Vl MTFjNGI4ZTdiYTJhMDljZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEy LTA2LTA3ICBTaW1vbiBQZW5hICA8c3BlbmFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBk ZXZpY2VTY2FsZUZhY3RvciBzZXR0aW5nIGlzIG5vdCBob25vcmVkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODUxMQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhvbm9yIHRoZSBkZXZpY2VTY2FsZUZhY3Rv ciBwcm9wZXJ0eSBpbiB0aGUgcGFpbnRXZWJWaWV3CisgICAgICAgIG1ldGhvZCBvZiB0aGUgQ2hy b21lQ2xpZW50R3RrLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50R3Rr LmNwcDoKKyAgICAgICAgKFdlYktpdDo6cGFpbnRXZWJWaWV3KToKKwogMjAxMi0wNi0wNCAgU3Vk YXJzYW5hIE5hZ2luZW5pICA8c3VkYXJzYW5hLm5hZ2luZW5pQGxpbnV4LmludGVsLmNvbT4KIAog ICAgICAgICBbR1RLXSBNZW1vcnkgbGVhayBpbiBXZWJLaXRXZWJWaWV3CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRHdGsuY3BwIGIvU291 cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50R3RrLmNwcAppbmRleCA2 NTViZjc4N2JmOGEwZjYzZjM1MDRhOTlmY2I1ZjgzYjljNGJmMmNjLi5kYjc0NWQyYWJlZDFhNTM3 ZjM4NWY2MjcxZTAxNWQ5YTZlYzM5ZDVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9X ZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3Rr L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEd0ay5jcHAKQEAgLTUxNCw2ICs1MTQsNyBAQCBz dGF0aWMgdm9pZCBwYWludFdlYlZpZXcoV2ViS2l0V2ViVmlldyogd2ViVmlldywgRnJhbWUqIGZy YW1lLCBSZWdpb24gZGlydHlSZWdpbwogCiAgICAgUmVmUHRyPGNhaXJvX3Q+IGJhY2tpbmdTdG9y ZUNvbnRleHQgPSBhZG9wdFJlZihjYWlyb19jcmVhdGUod2ViVmlldy0+cHJpdi0+YmFja2luZ1N0 b3JlLT5jYWlyb1N1cmZhY2UoKSkpOwogICAgIEdyYXBoaWNzQ29udGV4dCBnYyhiYWNraW5nU3Rv cmVDb250ZXh0LmdldCgpKTsKKyAgICBnYy5hcHBseURldmljZVNjYWxlRmFjdG9yKGZyYW1lLT5w YWdlKCktPmRldmljZVNjYWxlRmFjdG9yKCkpOwogICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwg cmVjdHMuc2l6ZSgpOyBpKyspIHsKICAgICAgICAgY29uc3QgSW50UmVjdCYgcmVjdCA9IHJlY3Rz W2ldOwogCg==