88505 2012-06-06 22:58:16 -0700 REGRESSION(r119683): it broke webkit-unit-test WebLayerTreeViewThreadedTest.InstrumentationCallbacks on mac (Requested by loislo on #webkit). 2012-06-06 23:02:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 87747 1 webkit.review.bot webkit.review.bot enne loislo oldest_to_newest 643234 0 webkit.review.bot 2012-06-06 22:58:16 -0700 http://trac.webkit.org/changeset/119683 broke the build: it broke webkit-unit-test WebLayerTreeViewThreadedTest.InstrumentationCallbacks on mac (Requested by loislo on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 643236 1 146202 webkit.review.bot 2012-06-06 22:59:11 -0700 Created attachment 146202 ROLLOUT of r119683 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 643238 2 146202 loislo 2012-06-06 23:01:36 -0700 Comment on attachment 146202 ROLLOUT of r119683 Clearing flags on attachment: 146202 Committed r119685: <http://trac.webkit.org/changeset/119685> 643239 3 loislo 2012-06-06 23:01:53 -0700 All reviewed patches have been landed. Closing bug. 643240 4 loislo 2012-06-06 23:02:59 -0700 the log: [----------] 1 test from WebLayerTreeViewThreadedTest [ RUN ] WebLayerTreeViewThreadedTest.InstrumentationCallbacks unknown file: Failure Unexpected mock function call - returning directly. Function call: willBeginFrame() Google Mock tried the following 1 expectation, but it didn't match: /Volumes/data/b/WebKit-BuildSlave/chromium-mac-release/build/Source/WebKit/chromium/tests/WebLayerTreeViewTest.cpp:212: EXPECT_CALL(m_client, willBeginFrame())... Expected: the expectation is active Actual: it is retired Expected: to be called once Actual: called once - saturated and retired unknown file: Failure Unexpected mock function call - returning directly. Function call: willCommit() Google Mock tried the following 1 expectation, but it didn't match: /Volumes/data/b/WebKit-BuildSlave/chromium-mac-release/build/Source/WebKit/chromium/tests/WebLayerTreeViewTest.cpp:213: EXPECT_CALL(m_client, willCommit())... Expected: the expectation is active Actual: it is retired Expected: to be called once Actual: called once - saturated and retired unknown file: Failure Unexpected mock function call - returning directly. Function call: didCommit() Google Mock tried the following 1 expectation, but it didn't match: /Volumes/data/b/WebKit-BuildSlave/chromium-mac-release/build/Source/WebKit/chromium/tests/WebLayerTreeViewTest.cpp:214: EXPECT_CALL(m_client, didCommit())... Expected: the expectation is active Actual: it is retired Expected: to be called once Actual: called once - saturated and retired /Volumes/data/b/WebKit-BuildSlave/chromium-mac-release/build/Source/WebKit/chromium/tests/WebLayerTreeViewTest.cpp:215: Failure Mock function called more times than expected - returning directly. Function call: didBeginFrame() Expected: to be called once Actual: called twice - over-saturated and active [ FAILED ] WebLayerTreeViewThreadedTest.InstrumentationCallbacks (1 ms) [----------] 1 test from WebLayerTreeViewThreadedTest (1 ms total) 146202 2012-06-06 22:59:11 -0700 2012-06-06 23:01:36 -0700 ROLLOUT of r119683 bug-88505-20120607060346.patch text/plain 4929 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5Njg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDA1YzE0MGIyODJkZGIy MGQzYjIxMWJkNjg3ODA0ZDMyYzJmNDA0Mi4uOTQ3NzY1OTMwZjZhMjYyMGY0YzM1OGZkYjE4OTM5 YTlkMzdmZDVjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTA2ICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KKworICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTE5NjgzLgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC8xMTk2ODMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTg4NTA1CisKKyAgICAgICAgaXQgYnJva2Ugd2Via2l0LXVuaXQtdGVzdAorICAg ICAgICBXZWJMYXllclRyZWVWaWV3VGhyZWFkZWRUZXN0Lkluc3RydW1lbnRhdGlvbkNhbGxiYWNr cyBvbiBtYWMKKyAgICAgICAgKFJlcXVlc3RlZCBieSBsb2lzbG8gb24gI3dlYmtpdCkuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3QuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6Q0NMYXllclRyZWVIb3N0Ojppbml0aWFsaXplTGF5ZXJSZW5k ZXJlcik6CisgICAgICAgIChXZWJDb3JlOjpDQ0xheWVyVHJlZUhvc3Q6OnNldFZpc2libGUpOgor CiAyMDEyLTA2LTA2ICBSb2JlcnQgS3JvZWdlciAgPHJqa3JvZWdlQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBbQ2hyb21pdW1dIFJlLWVuYWJsZSBoYW5kbGluZyBvZiBzbW9vdGggc2Nyb2xsaW5n IG9uIENocm9taXVtIExpbnV4L1dpbmRvd3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg YjYxN2NiZTZmMjBjNGVmYzZiOWVkMWQ1YjU3ZGVlMTRlNGU0MmE0ZC4uMDYyYzRlMzFhNzUyYmUy ZjdmMzU5ODNhZWVkOTZkOTI3ODk4YmNlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxOCBAQAorMjAxMi0wNi0wNiAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJv dEBnbWFpbC5jb20+CisKKyAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjExOTY4My4K KyAgICAgICAgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTE5NjgzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODUwNQorCisgICAgICAg IGl0IGJyb2tlIHdlYmtpdC11bml0LXRlc3QKKyAgICAgICAgV2ViTGF5ZXJUcmVlVmlld1RocmVh ZGVkVGVzdC5JbnN0cnVtZW50YXRpb25DYWxsYmFja3Mgb24gbWFjCisgICAgICAgIChSZXF1ZXN0 ZWQgYnkgbG9pc2xvIG9uICN3ZWJraXQpLgorCisgICAgICAgICogdGVzdHMvQ0NMYXllclRyZWVI b3N0VGVzdC5jcHA6CisgICAgICAgIChXVEY6Ok1vY2tMYXllclRyZWVIb3N0OjpjcmVhdGUpOgor ICAgICAgICAqIHRlc3RzL0NhbnZhczJETGF5ZXJDaHJvbWl1bVRlc3QuY3BwOgorICAgICAgICAo Q2FudmFzMkRMYXllckNocm9taXVtVGVzdDo6ZnVsbExpZmVjeWNsZVRlc3QpOgorCiAyMDEyLTA2 LTA2ICBSb2JlcnQgS3JvZWdlciAgPHJqa3JvZWdlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBb Q2hyb21pdW1dIFJlLWVuYWJsZSBoYW5kbGluZyBvZiBzbW9vdGggc2Nyb2xsaW5nIG9uIENocm9t aXVtIExpbnV4L1dpbmRvd3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3QuY3BwCmluZGV4IDkw MDIwMDEyZmFlMjI1NjU4ZmU0ODFmMzBmYzIzYTk2M2EwMDU3YWMuLmZhMGViNjRjMzY1YjE4ZGUw ZDk2OWZjODNlOWI0ODM1YTM4NjkzNGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0LmNw cApAQCAtMTQ5LDYgKzE0OSwxMSBAQCB2b2lkIENDTGF5ZXJUcmVlSG9zdDo6aW5pdGlhbGl6ZUxh eWVyUmVuZGVyZXIoKQogCiAgICAgbV9jb250ZW50c1RleHR1cmVNYW5hZ2VyID0gVGV4dHVyZU1h bmFnZXI6OmNyZWF0ZSgwLCAwLCBtX3Byb3h5LT5sYXllclJlbmRlcmVyQ2FwYWJpbGl0aWVzKCku bWF4VGV4dHVyZVNpemUpOwogCisgICAgLy8gRklYTUU6IFRoaXMgaXMgdGhlIHNhbWUgYXMgc2V0 Q29udGVudHNNZW1vcnlBbGxvY2F0aW9uTGltaXRCeXRlcywgYnV0CisgICAgLy8gd2UncmUgaW4g dGhlIG1pZGRsZSBvZiBhIGNvbW1pdCBoZXJlIGFuZCBkb24ndCB3YW50IHRvIGZvcmNlIGFub3Ro ZXIuCisgICAgbV9tZW1vcnlBbGxvY2F0aW9uQnl0ZXMgPSBUZXh0dXJlTWFuYWdlcjo6aGlnaExp bWl0Qnl0ZXMoZGV2aWNlVmlld3BvcnRTaXplKCkpOworICAgIG1fbWVtb3J5QWxsb2NhdGlvbklz Rm9yRGlzcGxheSA9IHRydWU7CisKICAgICBtX2xheWVyUmVuZGVyZXJJbml0aWFsaXplZCA9IHRy dWU7CiAKICAgICBtX3NldHRpbmdzLmRlZmF1bHRUaWxlU2l6ZSA9IEludFNpemUobWluKG1fc2V0 dGluZ3MuZGVmYXVsdFRpbGVTaXplLndpZHRoKCksIG1fcHJveHktPmxheWVyUmVuZGVyZXJDYXBh YmlsaXRpZXMoKS5tYXhUZXh0dXJlU2l6ZSksCkBAIC00MDAsNiArNDA1LDE1IEBAIHZvaWQgQ0NM YXllclRyZWVIb3N0OjpzZXRWaXNpYmxlKGJvb2wgdmlzaWJsZSkKICAgICAgICAgcmV0dXJuOwog CiAgICAgbV92aXNpYmxlID0gdmlzaWJsZTsKKworICAgIC8vIEZJWE1FOiBSZW1vdmUgdGhpcyBz dHVmZiwgaXQgaXMgaGVyZSBqdXN0IGZvciB0aGUgbTIwIG1lcmdlLgorICAgIGlmICghbV92aXNp YmxlICYmIG1fbGF5ZXJSZW5kZXJlckluaXRpYWxpemVkKSB7CisgICAgICAgIGlmIChtX3Byb3h5 LT5sYXllclJlbmRlcmVyQ2FwYWJpbGl0aWVzKCkuY29udGV4dEhhc0NhY2hlZEZyb250QnVmZmVy KQorICAgICAgICAgICAgc2V0Q29udGVudHNNZW1vcnlBbGxvY2F0aW9uTGltaXRCeXRlcygwKTsK KyAgICAgICAgZWxzZQorICAgICAgICAgICAgc2V0Q29udGVudHNNZW1vcnlBbGxvY2F0aW9uTGlt aXRCeXRlcyhtX2NvbnRlbnRzVGV4dHVyZU1hbmFnZXItPnByZWZlcnJlZE1lbW9yeUxpbWl0Qnl0 ZXMoKSk7CisgICAgfQorCiAgICAgc2V0TmVlZHNGb3JjZWRDb21taXQoKTsKIH0KIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9DQ0xheWVyVHJlZUhvc3RUZXN0LmNw cCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NMYXllclRyZWVIb3N0VGVzdC5jcHAK aW5kZXggMjZmY2ExODY0NGE1NjM4ZjQ5Y2Y2MjFkNTU3MDEzMjA0NDkwM2NlZi4uYWEyN2U4OGY3 ZGMzZWQ4MDgwMjEwNjQ5Y2NkMGJlMzAwMjdjZjBiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9jaHJvbWl1bS90ZXN0cy9DQ0xheWVyVHJlZUhvc3RUZXN0LmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9zdFRlc3QuY3BwCkBAIC0yMjcsNyArMjI3 LDYgQEAgcHVibGljOgogCiAgICAgICAgIC8vIExheWVyVHJlZUhvc3RJbXBsIHdvbid0IGRyYXcg aWYgaXQgaGFzIDF4MSB2aWV3cG9ydC4KICAgICAgICAgbGF5ZXJUcmVlSG9zdC0+c2V0Vmlld3Bv cnRTaXplKEludFNpemUoMSwgMSkpOwotICAgICAgICBsYXllclRyZWVIb3N0LT5zZXRDb250ZW50 c01lbW9yeUFsbG9jYXRpb25MaW1pdEJ5dGVzKFRleHR1cmVNYW5hZ2VyOjpoaWdoTGltaXRCeXRl cyhsYXllclRyZWVIb3N0LT52aWV3cG9ydFNpemUoKSkpOwogCiAgICAgICAgIGxheWVyVHJlZUhv c3QtPnJvb3RMYXllcigpLT5zZXRMYXllckFuaW1hdGlvbkRlbGVnYXRlKHRlc3RIb29rcyk7CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ2FudmFzMkRMYXllckNo cm9taXVtVGVzdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NhbnZhczJETGF5 ZXJDaHJvbWl1bVRlc3QuY3BwCmluZGV4IDE4MDBhMTkzZDRlZDA3MTk3MDMzMTE5YzNjODI2YWNj NzdmZTE1MTMuLmE1NjUxNDZhNWQ0OTE5NjViN2IxYWQyNWQ2ZmU2OWM1MTUxNTQwZjkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ2FudmFzMkRMYXllckNocm9taXVt VGVzdC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9DYW52YXMyRExheWVy Q2hyb21pdW1UZXN0LmNwcApAQCAtMTI1LDcgKzEyNSw2IEBAIHByb3RlY3RlZDoKICAgICAgICAg V2ViQ29tcG9zaXRvcjo6aW5pdGlhbGl6ZSh0aHJlYWQuZ2V0KCkpOwogCiAgICAgICAgIE93blB0 cjxGYWtlQ0NMYXllclRyZWVIb3N0PiBsYXllclRyZWVIb3N0KEZha2VDQ0xheWVyVHJlZUhvc3Q6 OmNyZWF0ZSgpKTsKLSAgICAgICAgbGF5ZXJUcmVlSG9zdC0+c2V0Q29udGVudHNNZW1vcnlBbGxv Y2F0aW9uTGltaXRCeXRlcyhUZXh0dXJlTWFuYWdlcjo6aGlnaExpbWl0Qnl0ZXMobGF5ZXJUcmVl SG9zdC0+dmlld3BvcnRTaXplKCkpKTsKICAgICAgICAgLy8gRm9yY2UgYW4gdXBkYXRlLCBzbyB0 aGF0IHdlIGdldCBhIHZhbGlkIFRleHR1cmVNYW5hZ2VyLgogICAgICAgICBsYXllclRyZWVIb3N0 LT51cGRhdGVMYXllcnModXBkYXRlcik7CiAK