88491 2012-06-06 21:09:15 -0700 [EFL] [DRT] DRT enables WebAudio when WebAudio feature is enabled. 2012-06-07 22:37:29 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 dw.im webkit-unassigned gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 643152 0 dw.im 2012-06-06 21:09:15 -0700 WebAudio feature has been implemented on EFL port. DRT should enable WebAudio when WebAudio feature is enabled, so that the WebAudio feature could be tested by the Layouttest. 643160 1 146188 dw.im 2012-06-06 21:15:59 -0700 Created attachment 146188 Patch 643161 2 146188 gyuyoung.kim 2012-06-06 21:17:09 -0700 Comment on attachment 146188 Patch Looks fine. 644177 3 146188 webkit.review.bot 2012-06-07 18:33:42 -0700 Comment on attachment 146188 Patch Clearing flags on attachment: 146188 Committed r119780: <http://trac.webkit.org/changeset/119780> 644178 4 webkit.review.bot 2012-06-07 18:33:46 -0700 All reviewed patches have been landed. Closing bug. 644276 5 146188 rakuco 2012-06-07 20:53:30 -0700 Comment on attachment 146188 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146188&action=review > Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:720 > + else if (equals(key, "WebKitWebAudioEnabled")) > + ewk_view_setting_web_audio_set(browser->mainView(), toBool(value)); You probably need to reset this to a sane default in DumpRenderTreeChrome::resetDefaultsToConsistentValues(). 644345 6 dw.im 2012-06-07 22:37:29 -0700 (In reply to comment #5) > (From update of attachment 146188 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=146188&action=review > > > Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:720 > > + else if (equals(key, "WebKitWebAudioEnabled")) > > + ewk_view_setting_web_audio_set(browser->mainView(), toBool(value)); > > You probably need to reset this to a sane default in DumpRenderTreeChrome::resetDefaultsToConsistentValues(). I see what you are saying. I will file that bug now. And, I think I need to fix the test cases. I will file that also. 146188 2012-06-06 21:15:59 -0700 2012-06-07 20:53:30 -0700 Patch patch_88491_0607.patch text/plain 1704 dw.im ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhMGE4 YzQzLi4wYTkwZTNjIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDYtMDYgIERvbmd3b28gSW0gIDxkdy5pbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBbRFJUXSBEUlQgZW5hYmxlcyBXZWJBdWRpbyB3 aGVuIFdlYkF1ZGlvIGZlYXR1cmUgaXMgZW5hYmxlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4NDkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRFJUIHNob3VsZCBlbmFibGUgV2ViQXVkaW8gd2hlbiBX ZWJBdWRpbyBmZWF0dXJlIGlzIGVuYWJsZWQsCisgICAgICAgIHNvIHRoYXQgdGhlIFdlYkF1ZGlv IGZlYXR1cmUgY291bGQgYmUgdGVzdGVkIGJ5IHRoZSBMYXlvdXR0ZXN0LgorCisgICAgICAgICog RHVtcFJlbmRlclRyZWUvZWZsL0xheW91dFRlc3RDb250cm9sbGVyRWZsLmNwcDogRW5hYmxlIFdl YkF1ZGlvIHdoZW4gV2ViQXVkaW8gZmVhdHVyZSBpcyBlbmFibGVkLgorICAgICAgICAoTGF5b3V0 VGVzdENvbnRyb2xsZXI6Om92ZXJyaWRlUHJlZmVyZW5jZSk6CisKIDIwMTItMDYtMDQgIENoYXNl IFBoaWxsaXBzICA8Y21wQGdvb2dsZS5jb20+CiAKICAgICAgICAgTWFrZSBhIGJ1aWxkZXIgZ3Jv dXAgc3VwcG9ydCtleHBlY3QgbXVsdGlwbGUgbG9hZHMuCmRpZmYgLS1naXQgYS9Ub29scy9EdW1w UmVuZGVyVHJlZS9lZmwvTGF5b3V0VGVzdENvbnRyb2xsZXJFZmwuY3BwIGIvVG9vbHMvRHVtcFJl bmRlclRyZWUvZWZsL0xheW91dFRlc3RDb250cm9sbGVyRWZsLmNwcAppbmRleCAwZThhNjZlLi5i N2FhNTMwIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvTGF5b3V0VGVzdENv bnRyb2xsZXJFZmwuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9MYXlvdXRUZXN0 Q29udHJvbGxlckVmbC5jcHAKQEAgLTcxNiw2ICs3MTYsOCBAQCB2b2lkIExheW91dFRlc3RDb250 cm9sbGVyOjpvdmVycmlkZVByZWZlcmVuY2UoSlNTdHJpbmdSZWYga2V5LCBKU1N0cmluZ1JlZiB2 YWx1ZQogICAgICAgICBEdW1wUmVuZGVyVHJlZVN1cHBvcnRFZmw6OnNldExvYWRzU2l0ZUljb25z SWdub3JpbmdJbWFnZUxvYWRpbmdTZXR0aW5nKGJyb3dzZXItPm1haW5WaWV3KCksIHRvQm9vbCh2 YWx1ZSkpOwogICAgIGVsc2UgaWYgKGVxdWFscyhrZXksICJXZWJLaXRDU1NHcmlkTGF5b3V0RW5h YmxlZCIpKQogICAgICAgICBEdW1wUmVuZGVyVHJlZVN1cHBvcnRFZmw6OnNldENTU0dyaWRMYXlv dXRFbmFibGVkKGJyb3dzZXItPm1haW5WaWV3KCksIHRvQm9vbCh2YWx1ZSkpOworICAgIGVsc2Ug aWYgKGVxdWFscyhrZXksICJXZWJLaXRXZWJBdWRpb0VuYWJsZWQiKSkKKyAgICAgICAgZXdrX3Zp ZXdfc2V0dGluZ193ZWJfYXVkaW9fc2V0KGJyb3dzZXItPm1haW5WaWV3KCksIHRvQm9vbCh2YWx1 ZSkpOwogICAgIGVsc2UKICAgICAgICAgZnByaW50ZihzdGRlcnIsICJMYXlvdXRUZXN0Q29udHJv bGxlcjo6b3ZlcnJpZGVQcmVmZXJlbmNlIHRyaWVkIHRvIG92ZXJyaWRlIHVua25vd24gcHJlZmVy ZW5jZSAnJXMnLlxuIiwgdmFsdWUtPnVzdHJpbmcoKS51dGY4KCkuZGF0YSgpKTsKIH0K