88469 2012-06-06 16:49:03 -0700 [chromium] In each composited frame, didDraw() should only be called on layers for which willDraw() was called 2012-06-07 08:09:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 88516 1 danakj danakj cc-bugs enne jamesr piman webkit.review.bot wjmaclean oldest_to_newest 642946 0 danakj 2012-06-06 16:49:03 -0700 [chromium] In each composited frame, didDraw() should only be called on layers for which willDraw() was called 642947 1 146143 danakj 2012-06-06 16:50:06 -0700 Created attachment 146143 Patch 642957 2 146143 jamesr 2012-06-06 16:55:16 -0700 Comment on attachment 146143 Patch R=me 643265 3 146143 webkit.review.bot 2012-06-06 23:54:21 -0700 Comment on attachment 146143 Patch Clearing flags on attachment: 146143 Committed r119689: <http://trac.webkit.org/changeset/119689> 643266 4 webkit.review.bot 2012-06-06 23:54:26 -0700 All reviewed patches have been landed. Closing bug. 643347 5 webkit.review.bot 2012-06-07 02:24:29 -0700 Re-opened since this is blocked by 88516 643562 6 danakj 2012-06-07 08:07:56 -0700 Problem was the test created a layer with id 0. 643563 7 danakj 2012-06-07 08:09:50 -0700 Committed r119725: <http://trac.webkit.org/changeset/119725> 146143 2012-06-06 16:50:06 -0700 2012-06-06 23:54:21 -0700 Patch bug-88469-20120606195003.patch text/plain 6756 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGZkZjE1M2Q4M2Q3ZWRj NjM5NmEzZmNjM2JiMTA5ZWJlZGZkMmU2Mi4uMmI3NDA3MjE4ODdhY2NhZGIxYWEzOTg4YTRjZTk3 N2Y0OWU3MGZiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA2LTA2ICBEYW5h IEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gSW4g ZWFjaCBjb21wb3NpdGVkIGZyYW1lLCBkaWREcmF3KCkgc2hvdWxkIG9ubHkgYmUgY2FsbGVkIG9u IGxheWVycyBmb3Igd2hpY2ggd2lsbERyYXcoKSB3YXMgY2FsbGVkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODQ2OQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVuaXQgdGVzdDogQ0NMYXllclRyZWVIb3N0 SW1wbFRlc3QuZGlkRHJhd05vdENhbGxlZE9uU2Npc3NvcmVkTGF5ZXIKKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdEltcGwuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6c2hvdWxkRHJhd0xheWVyKToKKyAgICAgICAgKFdlYkNvcmUpOgorICAg ICAgICAoV2ViQ29yZTo6Q0NMYXllclRyZWVIb3N0SW1wbDo6Y2FsY3VsYXRlUmVuZGVyUGFzc2Vz KToKKyAgICAgICAgKFdlYkNvcmU6OkNDTGF5ZXJUcmVlSG9zdEltcGw6OmRpZERyYXdBbGxMYXll cnMpOgorCiAyMDEyLTA2LTAxICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgQ2hhbmdlIG92ZXJyaWRlU2l6ZXMgdG8gYmUgY29udGVudC1ib3ggaW5zdGVhZCBvZiBi b3JkZXItYm94CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4IDAyYjNhOTU2N2E5ZTRhODYz YzRlZDYzNDdjNjljYzQxMTc2NjljY2EuLmZmNDdlZGE2ZDA1YmM1NmJiM2NiNmIyNDIwMzJjOWJm ZDljZDRlNmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIw MTItMDYtMDYgIERhbmEgSmFuc2VucyAgPGRhbmFrakBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAg W2Nocm9taXVtXSBJbiBlYWNoIGNvbXBvc2l0ZWQgZnJhbWUsIGRpZERyYXcoKSBzaG91bGQgb25s eSBiZSBjYWxsZWQgb24gbGF5ZXJzIGZvciB3aGljaCB3aWxsRHJhdygpIHdhcyBjYWxsZWQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4NDY5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB0ZXN0cy9DQ0xh eWVyVHJlZUhvc3RJbXBsVGVzdC5jcHA6CisKIDIwMTItMDYtMDUgIFJ5b3N1a2UgTml3YSAgPHJu aXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUm9sbCBDaHJvbWl1bSBERVBTIGZyb20gcjE0MDQ5 MiB0byByMTQwNTI4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0SW1wbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3RJbXBsLmNwcAppbmRl eCBkNzhkNDI5ZjI5NmE1MWVjYjAxNmI3MjNmZjRhYjBjODQ3YWJkZjBmLi41YjEzZTFiOGVjYjU2 ZjgxMWI2MTY3NGVhMjgxMTRlYTRjNzAwMzZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3RJbXBsLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJl ZUhvc3RJbXBsLmNwcApAQCAtMjYxLDYgKzI2MSwxMSBAQCB2b2lkIENDTGF5ZXJUcmVlSG9zdElt cGw6OmNhbGN1bGF0ZVJlbmRlclN1cmZhY2VMYXllckxpc3QoQ0NMYXllckxpc3QmIHJlbmRlclN1 cgogICAgIH0KIH0KIAorc3RhdGljIGlubGluZSBib29sIHNob3VsZERyYXdMYXllcihDQ0xheWVy SW1wbCogbGF5ZXIpCit7CisgICAgcmV0dXJuICFsYXllci0+dmlzaWJsZUxheWVyUmVjdCgpLmlz RW1wdHkoKSAmJiAhbGF5ZXItPnNjaXNzb3JSZWN0KCkuaXNFbXB0eSgpOworfQorCiBib29sIEND TGF5ZXJUcmVlSG9zdEltcGw6OmNhbGN1bGF0ZVJlbmRlclBhc3NlcyhDQ1JlbmRlclBhc3NMaXN0 JiBwYXNzZXMsIENDTGF5ZXJMaXN0JiByZW5kZXJTdXJmYWNlTGF5ZXJMaXN0KQogewogICAgIEFT U0VSVChwYXNzZXMuaXNFbXB0eSgpKTsKQEAgLTMwNSw3ICszMTAsNyBAQCBib29sIENDTGF5ZXJU cmVlSG9zdEltcGw6OmNhbGN1bGF0ZVJlbmRlclBhc3NlcyhDQ1JlbmRlclBhc3NMaXN0JiBwYXNz ZXMsIENDTGF5ZQogICAgICAgICBpZiAoaXQucmVwcmVzZW50c0NvbnRyaWJ1dGluZ1JlbmRlclN1 cmZhY2UoKSAmJiAhaXQtPnJlbmRlclN1cmZhY2UoKS0+c2Npc3NvclJlY3QoKS5pc0VtcHR5KCkp IHsKICAgICAgICAgICAgIENDUmVuZGVyUGFzcyogY29udHJpYnV0aW5nUmVuZGVyUGFzcyA9IHN1 cmZhY2VQYXNzTWFwLmdldChpdC0+cmVuZGVyU3VyZmFjZSgpKTsKICAgICAgICAgICAgIHBhc3Mt PmFwcGVuZFF1YWRzRm9yUmVuZGVyU3VyZmFjZUxheWVyKCppdCwgY29udHJpYnV0aW5nUmVuZGVy UGFzcywgJm9jY2x1c2lvblRyYWNrZXIpOwotICAgICAgICB9IGVsc2UgaWYgKGl0LnJlcHJlc2Vu dHNJdHNlbGYoKSAmJiAhaXQtPnZpc2libGVMYXllclJlY3QoKS5pc0VtcHR5KCkgJiYgIWl0LT5z Y2lzc29yUmVjdCgpLmlzRW1wdHkoKSkgeworICAgICAgICB9IGVsc2UgaWYgKGl0LnJlcHJlc2Vu dHNJdHNlbGYoKSAmJiBzaG91bGREcmF3TGF5ZXIoKml0KSkgewogICAgICAgICAgICAgaXQtPndp bGxEcmF3KG1fbGF5ZXJSZW5kZXJlci5nZXQoKSwgY29udGV4dCgpKTsKICAgICAgICAgICAgIHBh c3MtPmFwcGVuZFF1YWRzRm9yTGF5ZXIoKml0LCAmb2NjbHVzaW9uVHJhY2tlciwgaGFkTWlzc2lu Z1RpbGVzKTsKICAgICAgICAgfQpAQCAtNDM1LDcgKzQ0MCw3IEBAIHZvaWQgQ0NMYXllclRyZWVI b3N0SW1wbDo6ZGlkRHJhd0FsbExheWVycyhjb25zdCBGcmFtZURhdGEmIGZyYW1lKQogCiAgICAg Q0NMYXllckl0ZXJhdG9yVHlwZSBlbmQgPSBDQ0xheWVySXRlcmF0b3JUeXBlOjplbmQoJmZyYW1l LnJlbmRlclN1cmZhY2VMYXllckxpc3QpOwogICAgIGZvciAoQ0NMYXllckl0ZXJhdG9yVHlwZSBp dCA9IENDTGF5ZXJJdGVyYXRvclR5cGU6OmJlZ2luKCZmcmFtZS5yZW5kZXJTdXJmYWNlTGF5ZXJM aXN0KTsgaXQgIT0gZW5kOyArK2l0KSB7Ci0gICAgICAgIGlmIChpdC5yZXByZXNlbnRzSXRzZWxm KCkgJiYgIWl0LT52aXNpYmxlTGF5ZXJSZWN0KCkuaXNFbXB0eSgpKQorICAgICAgICBpZiAoaXQu cmVwcmVzZW50c0l0c2VsZigpICYmIHNob3VsZERyYXdMYXllcigqaXQpKQogICAgICAgICAgICAg aXQtPmRpZERyYXcoKTsKICAgICB9CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9zdEltcGxUZXN0LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vdGVzdHMvQ0NMYXllclRyZWVIb3N0SW1wbFRlc3QuY3BwCmluZGV4IGU2MjMxZDM0ZjEx N2E4NjE5OGExZWY1ZjI2NmNlODc2YTg4NzllYmUuLjlhMzMzMjI3YmM0ZjcxYjFhODE2NGVhM2M1 YzRlMjA2NzRjOGRjZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMv Q0NMYXllclRyZWVIb3N0SW1wbFRlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v dGVzdHMvQ0NMYXllclRyZWVIb3N0SW1wbFRlc3QuY3BwCkBAIC00NTQsNiArNDU0LDEyIEBAIHB1 YmxpYzoKICAgICBib29sIGRpZERyYXdDYWxsZWQoKSBjb25zdCB7IHJldHVybiBtX2RpZERyYXdD YWxsZWQ7IH0KICAgICBib29sIHdpbGxEcmF3Q2FsbGVkKCkgY29uc3QgeyByZXR1cm4gbV93aWxs RHJhd0NhbGxlZDsgfQogCisgICAgdm9pZCBjbGVhckRpZERyYXdDaGVjaygpCisgICAgeworICAg ICAgICBtX2RpZERyYXdDYWxsZWQgPSBmYWxzZTsKKyAgICAgICAgbV93aWxsRHJhd0NhbGxlZCA9 IGZhbHNlOworICAgIH0KKwogcHJvdGVjdGVkOgogICAgIGV4cGxpY2l0IERpZERyYXdDaGVja0xh eWVyKGludCBpZCkKICAgICAgICAgOiBDQ1RpbGVkTGF5ZXJJbXBsKGlkKQpAQCAtMTQxMSw2ICsx NDE3LDU5IEBAIFRFU1RfRihDQ0xheWVyVHJlZUhvc3RJbXBsVGVzdCwgY29udHJpYnV0aW5nTGF5 ZXJFbXB0eVNjaXNzb3JOb1BhcnRpYWxTd2FwKQogICAgIH0KIH0KIAorVEVTVF9GKENDTGF5ZXJU cmVlSG9zdEltcGxUZXN0LCBkaWREcmF3Tm90Q2FsbGVkT25TY2lzc29yZWRMYXllcikKK3sKKyAg ICBDQ1NldHRpbmdzIHNldHRpbmdzOworICAgIHNldHRpbmdzLnBhcnRpYWxTd2FwRW5hYmxlZCA9 IHRydWU7CisKKyAgICBSZWZQdHI8Q0NHcmFwaGljc0NvbnRleHQ+IGNvbnRleHQgPSBDQ0dyYXBo aWNzQ29udGV4dDo6Y3JlYXRlM0QoR3JhcGhpY3NDb250ZXh0M0RQcml2YXRlOjpjcmVhdGVHcmFw aGljc0NvbnRleHRGcm9tV2ViQ29udGV4dChhZG9wdFB0cihuZXcgUGFydGlhbFN3YXBDb250ZXh0 KCkpLCBHcmFwaGljc0NvbnRleHQzRDo6UmVuZGVyRGlyZWN0bHlUb0hvc3RXaW5kb3cpKTsKKyAg ICBPd25QdHI8Q0NMYXllclRyZWVIb3N0SW1wbD4gbXlIb3N0SW1wbCA9IENDTGF5ZXJUcmVlSG9z dEltcGw6OmNyZWF0ZShzZXR0aW5ncywgdGhpcyk7CisgICAgbXlIb3N0SW1wbC0+aW5pdGlhbGl6 ZUxheWVyUmVuZGVyZXIoY29udGV4dC5yZWxlYXNlKCksIFVudGhyb3R0bGVkVXBsb2FkZXIpOwor ICAgIG15SG9zdEltcGwtPnNldFZpZXdwb3J0U2l6ZShJbnRTaXplKDEwLCAxMCkpOworCisgICAg bXlIb3N0SW1wbC0+c2V0Um9vdExheWVyKERpZERyYXdDaGVja0xheWVyOjpjcmVhdGUoMCkpOwor ICAgIERpZERyYXdDaGVja0xheWVyKiByb290ID0gc3RhdGljX2Nhc3Q8RGlkRHJhd0NoZWNrTGF5 ZXIqPihteUhvc3RJbXBsLT5yb290TGF5ZXIoKSk7CisgICAgcm9vdC0+c2V0TWFza3NUb0JvdW5k cyh0cnVlKTsKKworICAgIHJvb3QtPmFkZENoaWxkKERpZERyYXdDaGVja0xheWVyOjpjcmVhdGUo MSkpOworICAgIERpZERyYXdDaGVja0xheWVyKiBsYXllciA9IHN0YXRpY19jYXN0PERpZERyYXdD aGVja0xheWVyKj4ocm9vdC0+Y2hpbGRyZW4oKVswXS5nZXQoKSk7CisKKyAgICBDQ0xheWVyVHJl ZUhvc3RJbXBsOjpGcmFtZURhdGEgZnJhbWU7CisKKyAgICBFWFBFQ1RfRkFMU0Uocm9vdC0+d2ls bERyYXdDYWxsZWQoKSk7CisgICAgRVhQRUNUX0ZBTFNFKHJvb3QtPmRpZERyYXdDYWxsZWQoKSk7 CisgICAgRVhQRUNUX0ZBTFNFKGxheWVyLT53aWxsRHJhd0NhbGxlZCgpKTsKKyAgICBFWFBFQ1Rf RkFMU0UobGF5ZXItPmRpZERyYXdDYWxsZWQoKSk7CisKKyAgICAvLyBXZSBzaG91bGQgZHJhdyBl dmVyeXRoaW5nIHRoZSBmaXJzdCBmcmFtZS4KKyAgICBFWFBFQ1RfVFJVRShteUhvc3RJbXBsLT5w cmVwYXJlVG9EcmF3KGZyYW1lKSk7CisgICAgbXlIb3N0SW1wbC0+ZHJhd0xheWVycyhmcmFtZSk7 CisgICAgbXlIb3N0SW1wbC0+ZGlkRHJhd0FsbExheWVycyhmcmFtZSk7CisKKyAgICBFWFBFQ1Rf VFJVRShyb290LT53aWxsRHJhd0NhbGxlZCgpKTsKKyAgICBFWFBFQ1RfVFJVRShyb290LT5kaWRE cmF3Q2FsbGVkKCkpOworICAgIEVYUEVDVF9UUlVFKGxheWVyLT53aWxsRHJhd0NhbGxlZCgpKTsK KyAgICBFWFBFQ1RfVFJVRShsYXllci0+ZGlkRHJhd0NhbGxlZCgpKTsKKworICAgIHJvb3QtPmNs ZWFyRGlkRHJhd0NoZWNrKCk7CisgICAgbGF5ZXItPmNsZWFyRGlkRHJhd0NoZWNrKCk7CisKKyAg ICBFWFBFQ1RfRkFMU0Uocm9vdC0+d2lsbERyYXdDYWxsZWQoKSk7CisgICAgRVhQRUNUX0ZBTFNF KHJvb3QtPmRpZERyYXdDYWxsZWQoKSk7CisgICAgRVhQRUNUX0ZBTFNFKGxheWVyLT53aWxsRHJh d0NhbGxlZCgpKTsKKyAgICBFWFBFQ1RfRkFMU0UobGF5ZXItPmRpZERyYXdDYWxsZWQoKSk7CisK KyAgICAvLyBEcmF3aW5nIGFnYWluLCB3ZSBzaG91bGQgc2Npc3NvciBvdXQgZXZlcnl0aGluZyBz aW5jZSB0aGVyZSBpcyBubyBkYW1hZ2UuCisgICAgRVhQRUNUX1RSVUUobXlIb3N0SW1wbC0+cHJl cGFyZVRvRHJhdyhmcmFtZSkpOworICAgIG15SG9zdEltcGwtPmRyYXdMYXllcnMoZnJhbWUpOwor ICAgIG15SG9zdEltcGwtPmRpZERyYXdBbGxMYXllcnMoZnJhbWUpOworCisgICAgRVhQRUNUX0ZB TFNFKHJvb3QtPndpbGxEcmF3Q2FsbGVkKCkpOworICAgIEVYUEVDVF9GQUxTRShyb290LT5kaWRE cmF3Q2FsbGVkKCkpOworICAgIEVYUEVDVF9GQUxTRShsYXllci0+d2lsbERyYXdDYWxsZWQoKSk7 CisgICAgRVhQRUNUX0ZBTFNFKGxheWVyLT5kaWREcmF3Q2FsbGVkKCkpOworfQorCiAvLyBNYWtl IHN1cmUgdGhhdCBjb250ZXh0IGxvc3Qgbm90aWZpY2F0aW9ucyBhcmUgcHJvcGFnYXRlZCB0aHJv dWdoIHRoZSB0cmVlLgogY2xhc3MgQ29udGV4dExvc3ROb3RpZmljYXRpb25DaGVja0xheWVyIDog cHVibGljIENDTGF5ZXJJbXBsIHsKIHB1YmxpYzoK