88446 2012-06-06 13:07:59 -0700 Web Inspector: [Chromium] profiler - differentiate between native code (program) and idle time 2012-12-20 00:46:32 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 103120 0 paulirish eustas apavlov bweinstein caseq eustas joepeck keishi loislo mnaganov pfeldman pmuellr rik webkit webkit.review.bot yurys oldest_to_newest 642728 0 paulirish 2012-06-06 13:07:59 -0700 The term (program) in the profiler is unclear to developers. It accounts for native code execution (captured by about:profiler in chromium) as well as idle time. Is it possible to identify what is real idle time? A common use case is: * User starts recording a profiler session * User does an action which could use optimization * User stops recording What often happens is that the added time to manually start/stop the profiler in the GUI adds so much idle time that (program) can have %s of 90% or more. This makes the remaining percentages quite small and the user has to find "very expensive" operations that are taking < 1%. "(idle)" would would help clarify this situation as well as perhaps an ability to filter out Idle time from the profiling totals. From mnaganov: > Idle time is still native code time, so they both are combined in (program). To distinguish between them, we could tell the profiler that certain native functions it sees on the call stack actually mean idleness. 643330 1 mnaganov 2012-06-07 01:49:56 -0700 I think this only relates to the Chromium port, as the JSC version already displays distinct entries for "(idle)" and "(program)" 778031 2 webkit 2012-11-28 10:27:04 -0800 The "(program)" is incredibly confusing for web developers, especially new ones. Just today, I had to tell a new web dev to ignore that, which caused much confusion. I came to realize even my understanding was incorrect. It appears that "(program)" is made up of several aspects, including idle time, native code, and globally executed JavaScript. In general, idle time isn't useful for debugging purposes. Likewise, native time isn't particularly useful without knowing how the JavaScript code is interacting with it. At the very least, separating these three out would give some clarity (though I would whole-heartedly love to eliminate idle and native code completely - just not useful enough). 793601 3 179933 eustas 2012-12-18 06:57:25 -0800 Created attachment 179933 Patch 793740 4 179933 pfeldman 2012-12-18 09:43:21 -0800 Comment on attachment 179933 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179933&action=review > Source/WebCore/ChangeLog:10 > + injected as a top level node ti profile. to profile. 794320 5 180084 eustas 2012-12-18 21:11:21 -0800 Created attachment 180084 Patch 794322 6 179933 eustas 2012-12-18 21:13:02 -0800 Comment on attachment 179933 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179933&action=review >> Source/WebCore/ChangeLog:10 >> + injected as a top level node ti profile. > > to profile. Fixed. 794359 7 180084 webkit.review.bot 2012-12-18 22:43:12 -0800 Comment on attachment 180084 Patch Clearing flags on attachment: 180084 Committed r138118: <http://trac.webkit.org/changeset/138118> 179933 2012-12-18 06:57:25 -0800 2012-12-18 21:13:02 -0800 Patch bug-88446-20121218185442.patch text/plain 2962 eustas U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MDE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2E4MGQyNTYzMDliYjZl MWFkODE5NGJjNjIwY2IxNTUyNjQzODNkZC4uZjdiMWE0MWFlMDYyNzlkMjZhZDVmOTAwY2U3ZTNh YWMwODRjOTM2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEyLTE4ICBFdWdl bmUgS2x5dWNobmlrb3YgIDxldXN0YXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFtDaHJvbWl1bV0gcHJvZmlsZXIgLSBkaWZmZXJlbnRpYXRlIGJldHdlZW4gbmF0aXZl IGNvZGUgKHByb2dyYW0pIGFuZCBpZGxlIHRpbWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTg4NDQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTm93IGlkbGVUaW1lIGlzIHN1cHBsaWVkIGluIHByb2ZpbGUg b2JqZWN0LiBJbiB0aGlzIHBhdGNoLCBpZGxlVGltZSwKKyAgICAgICAgaWYgYW55LCBpcyBzdWJ0 cmFjdGVkIGZyb20gIihwcm9ncmFtKSIgbm9kZSwgYW5kIG5ldyBub2RlICIoaWRsZSkiIGlzCisg ICAgICAgIGluamVjdGVkIGFzIGEgdG9wIGxldmVsIG5vZGUgdGkgcHJvZmlsZS4KKworICAgICAg ICAqIGluc3BlY3Rvci9mcm9udC1lbmQvQ1BVUHJvZmlsZVZpZXcuanM6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuQ1BVUHJvZmlsZVZpZXcucHJvZmlsZUNhbGxiYWNrKTogQ2FsbCBfaW5qZWN0SWRs ZVRpbWVOb2RlCisgICAgICAgIGlmIG5vbi16ZXJvIGlkbGVUaW1lIGlzIHNwZWNpZmllZC4KKyAg ICAgICAgKFdlYkluc3BlY3Rvci5DUFVQcm9maWxlVmlldy5wcm90b3R5cGUuX2luamVjdElkbGVU aW1lTm9kZSk6IExvb2t1cCBmb3IKKyAgICAgICAgIihwcm9ncmFtKSIgbm9kZSwgbW9kaWZ5IGl0 LCBhZGQgIihpZGxlKSIgbm9kZS4KKwogMjAxMi0xMi0xOCAgQWxleGFuZGVyIFBhdmxvdiAgPGFw YXZsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIx MzgwMTEuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NQ VVByb2ZpbGVWaWV3LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9DUFVQ cm9maWxlVmlldy5qcwppbmRleCBmYjQyZGMyMTQ2NTY2NjcxMjQ3NDdiNGI5ZGUzY2U5ODFmZGNm MzM5Li4wN2RmOTg0YTBlMWQ3ZjhmNzJiMTc3ZjJiYmRhZjU0MTBiMDgyNzY1IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NQVVByb2ZpbGVWaWV3LmpzCisr KyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ1BVUHJvZmlsZVZpZXcuanMK QEAgLTk0LDYgKzk0LDEwIEBAIFdlYkluc3BlY3Rvci5DUFVQcm9maWxlVmlldyA9IGZ1bmN0aW9u KHByb2ZpbGUpCiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KICAgICAgICAgdGhpcy5w cm9maWxlLmhlYWQgPSBwcm9maWxlLmhlYWQ7CisKKyAgICAgICAgaWYgKHByb2ZpbGUuaWRsZVRp bWUpCisgICAgICAgICAgICB0aGlzLl9pbmplY3RJZGxlVGltZU5vZGUoKTsKKwogICAgICAgICB0 aGlzLl9hc3NpZ25QYXJlbnRzSW5Qcm9maWxlKCk7CiAgICAgICAgIHRoaXMuX2NoYW5nZVZpZXco KTsKICAgICAgICAgdGhpcy5fdXBkYXRlUGVyY2VudEJ1dHRvbigpOwpAQCAtNTM2LDYgKzU0MCwz OSBAQCBXZWJJbnNwZWN0b3IuQ1BVUHJvZmlsZVZpZXcucHJvdG90eXBlID0gewogICAgICAgICB9 CiAgICAgfSwKIAorICAgIF9pbmplY3RJZGxlVGltZU5vZGU6IGZ1bmN0aW9uKCkKKyAgICB7Cisg ICAgICAgIHZhciBwcm9maWxlID0gdGhpcy5wcm9maWxlOworICAgICAgICB2YXIgaWRsZVRpbWUg PSBwcm9maWxlLmlkbGVUaW1lOworICAgICAgICB2YXIgbm9kZXMgPSBwcm9maWxlLmhlYWQuY2hp bGRyZW47CisKKyAgICAgICAgdmFyIHByb2dyYW1Ob2RlID0ge3NlbGZUaW1lOiAwfTsKKyAgICAg ICAgZm9yICh2YXIgaSA9IG5vZGVzLmxlbmd0aCAtIDE7IGkgPj0gMDsgLS1pKSB7CisgICAgICAg ICAgICBpZiAobm9kZXNbaV0uZnVuY3Rpb25OYW1lID09PSAiKHByb2dyYW0pIikgeworICAgICAg ICAgICAgICAgIHByb2dyYW1Ob2RlID0gbm9kZXNbaV07CisgICAgICAgICAgICAgICAgYnJlYWs7 CisgICAgICAgICAgICB9CisgICAgICAgIH0KKyAgICAgICAgdmFyIHByb2dyYW1UaW1lID0gcHJv Z3JhbU5vZGUuc2VsZlRpbWU7CisgICAgICAgIGlmIChpZGxlVGltZSA+IHByb2dyYW1UaW1lKQor ICAgICAgICAgICAgaWRsZVRpbWUgPSBwcm9ncmFtVGltZTsKKyAgICAgICAgcHJvZ3JhbVRpbWUg PSBwcm9ncmFtVGltZSAtIGlkbGVUaW1lOworICAgICAgICBwcm9ncmFtTm9kZS5zZWxmVGltZSA9 IHByb2dyYW1UaW1lOworICAgICAgICBwcm9ncmFtTm9kZS50b3RhbFRpbWUgPSBwcm9ncmFtVGlt ZTsKKyAgICAgICAgdmFyIGlkbGVOb2RlID0geworICAgICAgICAgICAgZnVuY3Rpb25OYW1lOiAi KGlkbGUpIiwKKyAgICAgICAgICAgIHVybDogbnVsbCwKKyAgICAgICAgICAgIGxpbmVOdW1iZXI6 IDAsCisgICAgICAgICAgICB0b3RhbFRpbWU6IGlkbGVUaW1lLAorICAgICAgICAgICAgc2VsZlRp bWU6IGlkbGVUaW1lLAorICAgICAgICAgICAgbnVtYmVyT2ZDYWxsczogMCwKKyAgICAgICAgICAg IHZpc2libGU6IHRydWUsCisgICAgICAgICAgICBjYWxsVUlEOiAwLAorICAgICAgICAgICAgY2hp bGRyZW46IFtdCisgICAgICAgIH07CisgICAgICAgIG5vZGVzLnB1c2goaWRsZU5vZGUpOworICAg IH0sCisKICAgICBfX3Byb3RvX186IFdlYkluc3BlY3Rvci5WaWV3LnByb3RvdHlwZQogfQogCg== 180084 2012-12-18 21:11:21 -0800 2012-12-18 22:43:12 -0800 Patch bug-88446-20121219090837.patch text/plain 3030 eustas U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmQyYzUwZTBhMTg2OWJm NGNmZTY5MjIyNzhiMzA5ZDJiNzM0ZGRiYS4uMGUxNWUwYWM2YzQxYzdhNzlhNjk0OTM3MDk4YzA4 ZjUyMzBlZDFiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEyLTE4ICBFdWdl bmUgS2x5dWNobmlrb3YgIDxldXN0YXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFtDaHJvbWl1bV0gcHJvZmlsZXIgLSBkaWZmZXJlbnRpYXRlIGJldHdlZW4gbmF0aXZl IGNvZGUgKHByb2dyYW0pIGFuZCBpZGxlIHRpbWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTg4NDQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTm93IGlkbGVUaW1lIGlzIHN1cHBsaWVkIGluIHByb2ZpbGUg b2JqZWN0LiBJbiB0aGlzIHBhdGNoLCBpZGxlVGltZSwKKyAgICAgICAgaWYgYW55LCBpcyBzdWJ0 cmFjdGVkIGZyb20gIihwcm9ncmFtKSIgbm9kZSwgYW5kIG5ldyBub2RlICIoaWRsZSkiIGlzCisg ICAgICAgIGluamVjdGVkIGFzIGEgdG9wIGxldmVsIG5vZGUgdG8gcHJvZmlsZS4KKworICAgICAg ICAqIGluc3BlY3Rvci9mcm9udC1lbmQvQ1BVUHJvZmlsZVZpZXcuanM6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuQ1BVUHJvZmlsZVZpZXcucHJvZmlsZUNhbGxiYWNrKTogQ2FsbCBfaW5qZWN0SWRs ZVRpbWVOb2RlCisgICAgICAgIGlmIG5vbi16ZXJvIGlkbGVUaW1lIGlzIHNwZWNpZmllZC4KKyAg ICAgICAgKFdlYkluc3BlY3Rvci5DUFVQcm9maWxlVmlldy5wcm90b3R5cGUuX2luamVjdElkbGVU aW1lTm9kZSk6IExvb2t1cCBmb3IKKyAgICAgICAgIihwcm9ncmFtKSIgbm9kZSwgbW9kaWZ5IGl0 LCBhZGQgIihpZGxlKSIgbm9kZS4KKwogMjAxMi0xMi0xOCAgQW50b24gVmF5dm9kICA8YXZheXZv ZEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVGV4dCBBdXRvc2l6aW5nOiBjb250YWluZXJzIHdp ZGVyIHRoYW4gdGhlaXIgZW5jbG9zaW5nIGNsdXN0ZXJzIHNob3VsZCBiZSBhdXRvc2l6ZWQgYXMg c2VwYXJhdGUgY2x1c3RlcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvQ1BVUHJvZmlsZVZpZXcuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL0NQVVByb2ZpbGVWaWV3LmpzCmluZGV4IGZiNDJkYzIxNDY1NjY2NzEyNDc0N2I0Yjlk ZTNjZTk4MWZkY2YzMzkuLjA3ZGY5ODRhMGUxZDdmOGY3MmIxNzdmMmJiZGFmNTQxMGIwODI3NjUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ1BVUHJvZmls ZVZpZXcuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9DUFVQcm9m aWxlVmlldy5qcwpAQCAtOTQsNiArOTQsMTAgQEAgV2ViSW5zcGVjdG9yLkNQVVByb2ZpbGVWaWV3 ID0gZnVuY3Rpb24ocHJvZmlsZSkKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQogICAg ICAgICB0aGlzLnByb2ZpbGUuaGVhZCA9IHByb2ZpbGUuaGVhZDsKKworICAgICAgICBpZiAocHJv ZmlsZS5pZGxlVGltZSkKKyAgICAgICAgICAgIHRoaXMuX2luamVjdElkbGVUaW1lTm9kZSgpOwor CiAgICAgICAgIHRoaXMuX2Fzc2lnblBhcmVudHNJblByb2ZpbGUoKTsKICAgICAgICAgdGhpcy5f Y2hhbmdlVmlldygpOwogICAgICAgICB0aGlzLl91cGRhdGVQZXJjZW50QnV0dG9uKCk7CkBAIC01 MzYsNiArNTQwLDM5IEBAIFdlYkluc3BlY3Rvci5DUFVQcm9maWxlVmlldy5wcm90b3R5cGUgPSB7 CiAgICAgICAgIH0KICAgICB9LAogCisgICAgX2luamVjdElkbGVUaW1lTm9kZTogZnVuY3Rpb24o KQorICAgIHsKKyAgICAgICAgdmFyIHByb2ZpbGUgPSB0aGlzLnByb2ZpbGU7CisgICAgICAgIHZh ciBpZGxlVGltZSA9IHByb2ZpbGUuaWRsZVRpbWU7CisgICAgICAgIHZhciBub2RlcyA9IHByb2Zp bGUuaGVhZC5jaGlsZHJlbjsKKworICAgICAgICB2YXIgcHJvZ3JhbU5vZGUgPSB7c2VsZlRpbWU6 IDB9OworICAgICAgICBmb3IgKHZhciBpID0gbm9kZXMubGVuZ3RoIC0gMTsgaSA+PSAwOyAtLWkp IHsKKyAgICAgICAgICAgIGlmIChub2Rlc1tpXS5mdW5jdGlvbk5hbWUgPT09ICIocHJvZ3JhbSki KSB7CisgICAgICAgICAgICAgICAgcHJvZ3JhbU5vZGUgPSBub2Rlc1tpXTsKKyAgICAgICAgICAg ICAgICBicmVhazsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQorICAgICAgICB2YXIgcHJvZ3Jh bVRpbWUgPSBwcm9ncmFtTm9kZS5zZWxmVGltZTsKKyAgICAgICAgaWYgKGlkbGVUaW1lID4gcHJv Z3JhbVRpbWUpCisgICAgICAgICAgICBpZGxlVGltZSA9IHByb2dyYW1UaW1lOworICAgICAgICBw cm9ncmFtVGltZSA9IHByb2dyYW1UaW1lIC0gaWRsZVRpbWU7CisgICAgICAgIHByb2dyYW1Ob2Rl LnNlbGZUaW1lID0gcHJvZ3JhbVRpbWU7CisgICAgICAgIHByb2dyYW1Ob2RlLnRvdGFsVGltZSA9 IHByb2dyYW1UaW1lOworICAgICAgICB2YXIgaWRsZU5vZGUgPSB7CisgICAgICAgICAgICBmdW5j dGlvbk5hbWU6ICIoaWRsZSkiLAorICAgICAgICAgICAgdXJsOiBudWxsLAorICAgICAgICAgICAg bGluZU51bWJlcjogMCwKKyAgICAgICAgICAgIHRvdGFsVGltZTogaWRsZVRpbWUsCisgICAgICAg ICAgICBzZWxmVGltZTogaWRsZVRpbWUsCisgICAgICAgICAgICBudW1iZXJPZkNhbGxzOiAwLAor ICAgICAgICAgICAgdmlzaWJsZTogdHJ1ZSwKKyAgICAgICAgICAgIGNhbGxVSUQ6IDAsCisgICAg ICAgICAgICBjaGlsZHJlbjogW10KKyAgICAgICAgfTsKKyAgICAgICAgbm9kZXMucHVzaChpZGxl Tm9kZSk7CisgICAgfSwKKwogICAgIF9fcHJvdG9fXzogV2ViSW5zcGVjdG9yLlZpZXcucHJvdG90 eXBlCiB9CiAK