88416 2012-06-06 07:49:25 -0700 Web Inspector: reuse edge_count field of heap snapshot to store retained size 2012-06-07 06:09:38 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 alph alph apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 642460 0 alph 2012-06-06 07:49:25 -0700 The edge_count field is unused after node first edge indexes have been built. Store node retained size in there instead of allocating an extra array for it. 642467 1 146031 alph 2012-06-06 07:53:32 -0700 Created attachment 146031 Patch 642540 2 146031 loislo 2012-06-06 09:37:27 -0700 Comment on attachment 146031 Patch lgtm 643475 3 146031 webkit.review.bot 2012-06-07 06:09:33 -0700 Comment on attachment 146031 Patch Clearing flags on attachment: 146031 Committed r119714: <http://trac.webkit.org/changeset/119714> 643476 4 webkit.review.bot 2012-06-07 06:09:38 -0700 All reviewed patches have been landed. Closing bug. 146031 2012-06-06 07:53:32 -0700 2012-06-07 06:09:33 -0700 Patch bug-88416-20120606185330.patch text/plain 5253 alph U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmRmOWIwYWM1NGE5Nzc1 OGJkM2Y0ODdmMGU2ZWRmYjYxMDY5ZGYxMi4uMmY1ODFmNWI4ZjJjNGFlODA4NGY4Yjc5NjFiZDg2 YmQzMTMwMGY0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTA2ICBBbGV4 ZWkgRmlsaXBwb3YgIDxhbGV4ZWlmQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiByZXVzZSBlZGdlX2NvdW50IGZpZWxkIG9mIGhlYXAgc25hcHNob3QgdG8gc3RvcmUgcmV0 YWluZWQgc2l6ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODg0MTYKKworICAgICAgICBUaGUgZWRnZV9jb3VudCBmaWVsZCBpcyB1bnVzZWQgYWZ0ZXIg bm9kZSBmaXJzdCBlZGdlIGluZGV4ZXMgaGF2ZSBiZWVuIGJ1aWx0LgorICAgICAgICBTdG9yZSBu b2RlIHJldGFpbmVkIHNpemUgaW4gdGhlcmUgaW5zdGVhZCBvZiBhbGxvY2F0aW5nIGFuIGV4dHJh IGFycmF5IGZvciBpdC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvSGVhcFNuYXBzaG90LmpzOgorICAgICAgICAo V2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdE5vZGUucHJvdG90eXBlLnJldGFpbmVkU2l6ZSk6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90LnByb3RvdHlwZS5fY2FsY3VsYXRlUmV0 YWluZWRTaXplcyk6CisKIDIwMTItMDYtMDYgIFRvciBBcm5lIFZlc3Riw7ggIDx0b3IuYXJuZS52 ZXN0Ym9Abm9raWEuY29tPgogCiAgICAgICAgIEZpeCBhIGZldyBzcGVsbGluZyBtaXN0YWtlcyBp biBJY29uRGF0YWJhc2UgbG9nZ2luZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3QuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL0hlYXBTbmFwc2hvdC5qcwppbmRleCA1N2IyMTU1NzRjZjkyYjhkZjI1YjYxOThk NTJiYzM0NmMzNjNlMDYzLi4wNDE0YzJjYjU1OTQzNDNjOTU2ZDdlZGMxOTQxYzkzNjdlNTg4M2I0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFw c2hvdC5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFw c2hvdC5qcwpAQCAtNTA4LDcgKzUwOCw4IEBAIFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3ROb2Rl LnByb3RvdHlwZSA9IHsKIAogICAgIHJldGFpbmVkU2l6ZTogZnVuY3Rpb24oKQogICAgIHsKLSAg ICAgICAgcmV0dXJuIHRoaXMuX3NuYXBzaG90Ll9yZXRhaW5lZFNpemVzW3RoaXMubm9kZUluZGV4 IC8gdGhpcy5fc25hcHNob3QuX25vZGVGaWVsZENvdW50XTsKKyAgICAgICAgdmFyIHNuYXBzaG90 ID0gdGhpcy5fc25hcHNob3Q7CisgICAgICAgIHJldHVybiBzbmFwc2hvdC5fbm9kZXNbdGhpcy5u b2RlSW5kZXggKyBzbmFwc2hvdC5fbm9kZVJldGFpbmVkU2l6ZU9mZnNldF07CiAgICAgfSwKIAog ICAgIHJldGFpbmVyczogZnVuY3Rpb24oKQpAQCAtMTI3NywxNiArMTI3OCwxOSBAQCBXZWJJbnNw ZWN0b3IuSGVhcFNuYXBzaG90LnByb3RvdHlwZSA9IHsKICAgICAgICAgdmFyIG5vZGVTZWxmU2l6 ZU9mZnNldCA9IHRoaXMuX25vZGVTZWxmU2l6ZU9mZnNldDsKICAgICAgICAgdmFyIG5vZGVGaWVs ZENvdW50ID0gdGhpcy5fbm9kZUZpZWxkQ291bnQ7CiAgICAgICAgIHZhciBkb21pbmF0b3JzVHJl ZSA9IHRoaXMuX2RvbWluYXRvcnNUcmVlOwotICAgICAgICB2YXIgcmV0YWluZWRTaXplcyA9IHRo aXMuX3JldGFpbmVkU2l6ZXMgPSBuZXcgVWludDMyQXJyYXkobm9kZUNvdW50KTsKLSAgICAgICAg dmFyIHJvb3ROb2RlT3JkaW5hbCA9IHRoaXMuX3Jvb3ROb2RlSW5kZXggLyBub2RlRmllbGRDb3Vu dDsKKyAgICAgICAgLy8gUmV1c2Ugbm93IHVudXNlZCBlZGdlX2NvdW50IGZpZWxkIHRvIHN0b3Jl IHJldGFpbmVkIHNpemUuCisgICAgICAgIHZhciBub2RlUmV0YWluZWRTaXplT2Zmc2V0ID0gdGhp cy5fbm9kZVJldGFpbmVkU2l6ZU9mZnNldCA9IHRoaXMuX25vZGVFZGdlQ291bnRPZmZzZXQ7Cisg ICAgICAgIGRlbGV0ZSB0aGlzLl9ub2RlRWRnZUNvdW50T2Zmc2V0OwogCi0gICAgICAgIHJldGFp bmVkU2l6ZXNbcm9vdE5vZGVPcmRpbmFsXSA9IG5vZGVzW3RoaXMuX3Jvb3ROb2RlSW5kZXggKyBu b2RlU2VsZlNpemVPZmZzZXRdOwotICAgICAgICAvLyBQcm9wYWdhdGUgcmV0YWluZWQgc2l6ZXMg Zm9yIGVhY2ggbm9kZSBleGNsdWRpbmcgcm9vdCwgYXMgaXQgcmVmZXJzIHRvIHNlbGYuCisgICAg ICAgIGZvciAodmFyIG5vZGVJbmRleCA9IDAsIGwgPSBub2Rlcy5sZW5ndGg7IG5vZGVJbmRleCA8 IGw7IG5vZGVJbmRleCArPSBub2RlRmllbGRDb3VudCkKKyAgICAgICAgICAgIG5vZGVzW25vZGVJ bmRleCArIG5vZGVSZXRhaW5lZFNpemVPZmZzZXRdID0gbm9kZXNbbm9kZUluZGV4ICsgbm9kZVNl bGZTaXplT2Zmc2V0XTsKKworICAgICAgICAvLyBQcm9wYWdhdGUgcmV0YWluZWQgc2l6ZXMgZm9y IGVhY2ggbm9kZSBleGNsdWRpbmcgcm9vdC4KICAgICAgICAgZm9yICh2YXIgcG9zdE9yZGVySW5k ZXggPSAwOyBwb3N0T3JkZXJJbmRleCA8IG5vZGVDb3VudCAtIDE7ICsrcG9zdE9yZGVySW5kZXgp IHsKICAgICAgICAgICAgIHZhciBub2RlT3JkaW5hbCA9IHBvc3RPcmRlckluZGV4Mk5vZGVPcmRp bmFsW3Bvc3RPcmRlckluZGV4XTsKLSAgICAgICAgICAgIHZhciBkb21pbmF0b3JPcmRpbmFsID0g ZG9taW5hdG9yc1RyZWVbbm9kZU9yZGluYWxdOwotICAgICAgICAgICAgcmV0YWluZWRTaXplc1tu b2RlT3JkaW5hbF0gKz0gbm9kZXNbbm9kZU9yZGluYWwgKiBub2RlRmllbGRDb3VudCArIG5vZGVT ZWxmU2l6ZU9mZnNldF07Ci0gICAgICAgICAgICByZXRhaW5lZFNpemVzW2RvbWluYXRvck9yZGlu YWxdICs9IHJldGFpbmVkU2l6ZXNbbm9kZU9yZGluYWxdOworICAgICAgICAgICAgdmFyIG5vZGVJ bmRleCA9IG5vZGVPcmRpbmFsICogbm9kZUZpZWxkQ291bnQ7CisgICAgICAgICAgICB2YXIgZG9t aW5hdG9ySW5kZXggPSBkb21pbmF0b3JzVHJlZVtub2RlT3JkaW5hbF0gKiBub2RlRmllbGRDb3Vu dDsKKyAgICAgICAgICAgIG5vZGVzW2RvbWluYXRvckluZGV4ICsgbm9kZVJldGFpbmVkU2l6ZU9m ZnNldF0gKz0gbm9kZXNbbm9kZUluZGV4ICsgbm9kZVJldGFpbmVkU2l6ZU9mZnNldF07CiAgICAg ICAgIH0KICAgICB9LAogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYzg3MjIzYmJhNWFiYTY1ZGU5ZDlkMzI2ODIzMmM0MDRj MTMyYTJkMi4uZGQ2YWNlNzY0MTk1NGMxNjA4NzdhMmQzNDM2MmUzZWY3ZTkwMDVhYSAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDEyLTA2LTA2ICBBbGV4ZWkgRmlsaXBwb3YgIDxhbGV4ZWlmQGNo cm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiByZXVzZSBlZGdlX2NvdW50IGZp ZWxkIG9mIGhlYXAgc25hcHNob3QgdG8gc3RvcmUgcmV0YWluZWQgc2l6ZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODg0MTYKKworICAgICAgICBUaGUg ZWRnZV9jb3VudCBmaWVsZCBpcyB1bnVzZWQgYWZ0ZXIgbm9kZSBmaXJzdCBlZGdlIGluZGV4ZXMg aGF2ZSBiZWVuIGJ1aWx0LgorICAgICAgICBTdG9yZSBub2RlIHJldGFpbmVkIHNpemUgaW4gdGhl cmUgaW5zdGVhZCBvZiBhbGxvY2F0aW5nIGFuIGV4dHJhIGFycmF5IGZvciBpdC4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9wcm9m aWxlci9oZWFwLXNuYXBzaG90Lmh0bWw6CisKIDIwMTItMDYtMDYgIElseWEgVGlraG9ub3Zza3kg IDxsb2lzbG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgdXBkYXRlIGNocm9t aXVtIHRlc3QgZXhwZWN0YXRpb25zLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9y L3Byb2ZpbGVyL2hlYXAtc25hcHNob3QuaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9wcm9m aWxlci9oZWFwLXNuYXBzaG90Lmh0bWwKaW5kZXggY2I2ODJlZjRkOTkxNDYzMWNkNDUzNjc1Nzc2 MzJjMTFiMTBhN2NmMi4uZmIzNmE5MDUyMjc5MzkzZDc0M2MyNTJjY2ZjZDBmMWI3M2RjYjg4ZiAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3Byb2ZpbGVyL2hlYXAtc25hcHNob3Qu aHRtbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvcHJvZmlsZXIvaGVhcC1zbmFwc2hvdC5o dG1sCkBAIC0xMzIsNyArMTMyLDcgQEAgZnVuY3Rpb24gdGVzdCgpCiAgICAgICAgICAgICB2YXIg c25hcHNob3QgPSBuZXcgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdChJbnNwZWN0b3JUZXN0LmNy ZWF0ZUhlYXBTbmFwc2hvdE1vY2soKSk7CiAgICAgICAgICAgICB2YXIgYWN0dWFsUmV0YWluZWRT aXplcyA9IG5ldyBBcnJheShzbmFwc2hvdC5ub2RlQ291bnQpOwogICAgICAgICAgICAgZm9yICh2 YXIgbm9kZU9yZGluYWwgPSAwOyBub2RlT3JkaW5hbCA8IHNuYXBzaG90Lm5vZGVDb3VudDsgKytu b2RlT3JkaW5hbCkKLSAgICAgICAgICAgICAgICBhY3R1YWxSZXRhaW5lZFNpemVzW25vZGVPcmRp bmFsXSA9IHNuYXBzaG90Ll9yZXRhaW5lZFNpemVzW25vZGVPcmRpbmFsXTsKKyAgICAgICAgICAg ICAgICBhY3R1YWxSZXRhaW5lZFNpemVzW25vZGVPcmRpbmFsXSA9IHNuYXBzaG90Ll9ub2Rlc1tu b2RlT3JkaW5hbCAqIHNuYXBzaG90Ll9ub2RlRmllbGRDb3VudCArIHNuYXBzaG90Ll9ub2RlUmV0 YWluZWRTaXplT2Zmc2V0XTsKICAgICAgICAgICAgIHZhciBleHBlY3RlZFJldGFpbmVkU2l6ZXMg PSBbMjAsIDIsIDgsIDEwLCA1LCA2XTsKICAgICAgICAgICAgIEluc3BlY3RvclRlc3QuYXNzZXJ0 RXF1YWxzKEpTT04uc3RyaW5naWZ5KGV4cGVjdGVkUmV0YWluZWRTaXplcyksIEpTT04uc3RyaW5n aWZ5KGFjdHVhbFJldGFpbmVkU2l6ZXMpLCAiUmV0YWluZWQgc2l6ZXMiKTsKICAgICAgICAgICAg IG5leHQoKTsK