88409 2012-06-06 05:00:30 -0700 Ensure consistent order of evaluation in LLInt slow paths 2012-06-06 11:59:57 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 wingo wingo barraclough fpizlo ggaren webkit.review.bot oldest_to_newest 642380 0 wingo 2012-06-06 05:00:30 -0700 The patch to be attached fixes a failure in fast/js/exception-sequencing-binops.html on x86-64 Linux systems with GCC 4.7. The RHS of a % was getting evaluated before the LHS, because the toNumber() calls were not separated by a sequence point. Pretty amusing that order of evaluation in JS depended on order of evaluation in C++, no? 642381 1 145992 wingo 2012-06-06 05:02:17 -0700 Created attachment 145992 Patch 642385 2 wingo 2012-06-06 05:11:05 -0700 Only the mac EWS will be relevant, as bug 88315 hasn't landed yet. 642568 3 145992 ggaren 2012-06-06 10:06:34 -0700 Comment on attachment 145992 Patch r=me 642668 4 145992 webkit.review.bot 2012-06-06 11:59:51 -0700 Comment on attachment 145992 Patch Clearing flags on attachment: 145992 Committed r119602: <http://trac.webkit.org/changeset/119602> 642669 5 webkit.review.bot 2012-06-06 11:59:57 -0700 All reviewed patches have been landed. Closing bug. 145992 2012-06-06 05:02:17 -0700 2012-06-06 11:59:51 -0700 Patch bug-88409-20120606140215.patch text/plain 5194 wingo U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz NTU4YmU5ODc3NmU3OGI2OGE0YWNjNzMxZWRiYWI2MDk1MjM2MGRlLi44MjE4YTg3OWM1NWYzZDRl NTUwYThlNTMyM2RiMTM3MDhiNzg2ZTJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyNyBAQAogMjAxMi0wNi0wNiAgQW5keSBXaW5nbyAgPHdpbmdvQGlnYWxpYS5jb20+CiAK KyAgICAgICAgRW5zdXJlIGNvbnNpc3RlbnQgb3JkZXIgb2YgZXZhbHVhdGlvbiBpbiBMTEludCBz bG93IHBhdGhzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD04ODQwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogbGxpbnQvTExJbnRTbG93UGF0aHMuY3BwOgorICAgICAgICAoc2xvd19wYXRoX211bCkKKyAg ICAgICAgKHNsb3dfcGF0aF9zdWIpCisgICAgICAgIChzbG93X3BhdGhfZGl2KQorICAgICAgICAo c2xvd19wYXRoX21vZCkKKyAgICAgICAgKHNsb3dfcGF0aF9sc2hpZnQpCisgICAgICAgIChzbG93 X3BhdGhfcnNoaWZ0KQorICAgICAgICAoc2xvd19wYXRoX3Vyc2hpZnQpCisgICAgICAgIChzbG93 X3BhdGhfYml0YW5kKQorICAgICAgICAoc2xvd19wYXRoX2JpdG9yKQorICAgICAgICAoc2xvd19w YXRoX2JpdHhvcik6IEF2b2lkIGNhbGxpbmcgdG9OdW1iZXIsIHRvSW50MzIsIG9yIHRvVUludDMy CisgICAgICAgIG11bHRpcGxlIHRpbWVzIHdpdGhvdXQgaW50ZXJ2ZW5pbmcgc2VxdWVuY2UgcG9p bnRzLiAgRml4ZXMKKyAgICAgICAgZmFzdC9qcy9leGNlcHRpb24tc2VxdWVuY2luZy1iaW5vcHMu aHRtbCB3aXRoIEdDQyA0Ljcgb24geDg2LTY0CisgICAgICAgIExpbnV4LCB3aGljaCByZW9yZGVy ZWQgZXZhbHVhdGlvbiBvZiB0aGUgYXJndW1lbnRzIHRvIGZtb2QuCisKKzIwMTItMDYtMDYgIEFu ZHkgV2luZ28gIDx3aW5nb0BpZ2FsaWEuY29tPgorCiAgICAgICAgIFtHVEtdIEVuYWJsZSB0aGUg TExJbnQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4 MzE1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9MTEludFNsb3dQ YXRocy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTExJbnRTbG93UGF0aHMuY3Bw CmluZGV4IGFjNTY3YmQ5ZjcyMWQ3OTJmNWYwZjQxZTNiYjRjZjM3ZWQ5MGU2YjUuLjcxMzNiMGQ4 NWIzODJkZTA1Yjk2NGJjMzBmOGY0NGZiOTE5ZDEyZDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9sbGludC9MTEludFNsb3dQYXRocy5jcHAKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2xsaW50L0xMSW50U2xvd1BhdGhzLmNwcApAQCAtNjIxLDY0ICs2MjEsODggQEAgTExJ TlRfU0xPV19QQVRIX0RFQ0woc2xvd19wYXRoX2FkZCkKICAgICBMTElOVF9SRVRVUk4oanNBZGRT bG93Q2FzZShleGVjLCB2MSwgdjIpKTsKIH0KIAorLy8gVGhlIGZvbGxvd2luZyBhcml0aG1ldGlj IGFuZCBiaXR3aXNlIG9wZXJhdGlvbnMgbmVlZCB0byBiZSBzdXJlIHRvIHJ1bgorLy8gdG9OdW1i ZXIoKSBvbiB0aGVpciBvcGVyYW5kcyBpbiBvcmRlci4gIChBIGNhbGwgdG8gdG9OdW1iZXIoKSBp cyBpZGVtcG90ZW50CisvLyBpZiBhbiBleGNlcHRpb24gaXMgYWxyZWFkeSBzZXQgb24gdGhlIEV4 ZWNTdGF0ZS4pCisKIExMSU5UX1NMT1dfUEFUSF9ERUNMKHNsb3dfcGF0aF9tdWwpCiB7CiAgICAg TExJTlRfQkVHSU4oKTsKLSAgICBMTElOVF9SRVRVUk4oanNOdW1iZXIoTExJTlRfT1BfQygyKS5q c1ZhbHVlKCkudG9OdW1iZXIoZXhlYykgKiBMTElOVF9PUF9DKDMpLmpzVmFsdWUoKS50b051bWJl cihleGVjKSkpOworICAgIGRvdWJsZSBhID0gTExJTlRfT1BfQygyKS5qc1ZhbHVlKCkudG9OdW1i ZXIoZXhlYyk7CisgICAgZG91YmxlIGIgPSBMTElOVF9PUF9DKDMpLmpzVmFsdWUoKS50b051bWJl cihleGVjKTsKKyAgICBMTElOVF9SRVRVUk4oanNOdW1iZXIoYSAqIGIpKTsKIH0KIAogTExJTlRf U0xPV19QQVRIX0RFQ0woc2xvd19wYXRoX3N1YikKIHsKICAgICBMTElOVF9CRUdJTigpOwotICAg IExMSU5UX1JFVFVSTihqc051bWJlcihMTElOVF9PUF9DKDIpLmpzVmFsdWUoKS50b051bWJlcihl eGVjKSAtIExMSU5UX09QX0MoMykuanNWYWx1ZSgpLnRvTnVtYmVyKGV4ZWMpKSk7CisgICAgZG91 YmxlIGEgPSBMTElOVF9PUF9DKDIpLmpzVmFsdWUoKS50b051bWJlcihleGVjKTsKKyAgICBkb3Vi bGUgYiA9IExMSU5UX09QX0MoMykuanNWYWx1ZSgpLnRvTnVtYmVyKGV4ZWMpOworICAgIExMSU5U X1JFVFVSTihqc051bWJlcihhIC0gYikpOwogfQogCiBMTElOVF9TTE9XX1BBVEhfREVDTChzbG93 X3BhdGhfZGl2KQogewogICAgIExMSU5UX0JFR0lOKCk7Ci0gICAgTExJTlRfUkVUVVJOKGpzTnVt YmVyKExMSU5UX09QX0MoMikuanNWYWx1ZSgpLnRvTnVtYmVyKGV4ZWMpIC8gTExJTlRfT1BfQygz KS5qc1ZhbHVlKCkudG9OdW1iZXIoZXhlYykpKTsKKyAgICBkb3VibGUgYSA9IExMSU5UX09QX0Mo MikuanNWYWx1ZSgpLnRvTnVtYmVyKGV4ZWMpOworICAgIGRvdWJsZSBiID0gTExJTlRfT1BfQygz KS5qc1ZhbHVlKCkudG9OdW1iZXIoZXhlYyk7CisgICAgTExJTlRfUkVUVVJOKGpzTnVtYmVyKGEg LyBiKSk7CiB9CiAKIExMSU5UX1NMT1dfUEFUSF9ERUNMKHNsb3dfcGF0aF9tb2QpCiB7CiAgICAg TExJTlRfQkVHSU4oKTsKLSAgICBMTElOVF9SRVRVUk4oanNOdW1iZXIoZm1vZChMTElOVF9PUF9D KDIpLmpzVmFsdWUoKS50b051bWJlcihleGVjKSwgTExJTlRfT1BfQygzKS5qc1ZhbHVlKCkudG9O dW1iZXIoZXhlYykpKSk7CisgICAgZG91YmxlIGEgPSBMTElOVF9PUF9DKDIpLmpzVmFsdWUoKS50 b051bWJlcihleGVjKTsKKyAgICBkb3VibGUgYiA9IExMSU5UX09QX0MoMykuanNWYWx1ZSgpLnRv TnVtYmVyKGV4ZWMpOworICAgIExMSU5UX1JFVFVSTihqc051bWJlcihmbW9kKGEsIGIpKSk7CiB9 CiAKIExMSU5UX1NMT1dfUEFUSF9ERUNMKHNsb3dfcGF0aF9sc2hpZnQpCiB7CiAgICAgTExJTlRf QkVHSU4oKTsKLSAgICBMTElOVF9SRVRVUk4oanNOdW1iZXIoTExJTlRfT1BfQygyKS5qc1ZhbHVl KCkudG9JbnQzMihleGVjKSA8PCAoTExJTlRfT1BfQygzKS5qc1ZhbHVlKCkudG9VSW50MzIoZXhl YykgJiAzMSkpKTsKKyAgICBpbnQzMl90IGEgPSBMTElOVF9PUF9DKDIpLmpzVmFsdWUoKS50b0lu dDMyKGV4ZWMpOworICAgIHVpbnQzMl90IGIgPSBMTElOVF9PUF9DKDMpLmpzVmFsdWUoKS50b1VJ bnQzMihleGVjKTsKKyAgICBMTElOVF9SRVRVUk4oanNOdW1iZXIoYSA8PCAoYiAmIDMxKSkpOwog fQogCiBMTElOVF9TTE9XX1BBVEhfREVDTChzbG93X3BhdGhfcnNoaWZ0KQogewogICAgIExMSU5U X0JFR0lOKCk7Ci0gICAgTExJTlRfUkVUVVJOKGpzTnVtYmVyKExMSU5UX09QX0MoMikuanNWYWx1 ZSgpLnRvSW50MzIoZXhlYykgPj4gKExMSU5UX09QX0MoMykuanNWYWx1ZSgpLnRvVUludDMyKGV4 ZWMpICYgMzEpKSk7CisgICAgaW50MzJfdCBhID0gTExJTlRfT1BfQygyKS5qc1ZhbHVlKCkudG9J bnQzMihleGVjKTsKKyAgICB1aW50MzJfdCBiID0gTExJTlRfT1BfQygzKS5qc1ZhbHVlKCkudG9V SW50MzIoZXhlYyk7CisgICAgTExJTlRfUkVUVVJOKGpzTnVtYmVyKGEgPj4gKGIgJiAzMSkpKTsK IH0KIAogTExJTlRfU0xPV19QQVRIX0RFQ0woc2xvd19wYXRoX3Vyc2hpZnQpCiB7CiAgICAgTExJ TlRfQkVHSU4oKTsKLSAgICBMTElOVF9SRVRVUk4oanNOdW1iZXIoTExJTlRfT1BfQygyKS5qc1Zh bHVlKCkudG9VSW50MzIoZXhlYykgPj4gKExMSU5UX09QX0MoMykuanNWYWx1ZSgpLnRvVUludDMy KGV4ZWMpICYgMzEpKSk7CisgICAgdWludDMyX3QgYSA9IExMSU5UX09QX0MoMikuanNWYWx1ZSgp LnRvVUludDMyKGV4ZWMpOworICAgIHVpbnQzMl90IGIgPSBMTElOVF9PUF9DKDMpLmpzVmFsdWUo KS50b1VJbnQzMihleGVjKTsKKyAgICBMTElOVF9SRVRVUk4oanNOdW1iZXIoYSA+PiAoYiAmIDMx KSkpOwogfQogCiBMTElOVF9TTE9XX1BBVEhfREVDTChzbG93X3BhdGhfYml0YW5kKQogewogICAg IExMSU5UX0JFR0lOKCk7Ci0gICAgTExJTlRfUkVUVVJOKGpzTnVtYmVyKExMSU5UX09QX0MoMiku anNWYWx1ZSgpLnRvSW50MzIoZXhlYykgJiBMTElOVF9PUF9DKDMpLmpzVmFsdWUoKS50b0ludDMy KGV4ZWMpKSk7CisgICAgaW50MzJfdCBhID0gTExJTlRfT1BfQygyKS5qc1ZhbHVlKCkudG9JbnQz MihleGVjKTsKKyAgICBpbnQzMl90IGIgPSBMTElOVF9PUF9DKDMpLmpzVmFsdWUoKS50b0ludDMy KGV4ZWMpOworICAgIExMSU5UX1JFVFVSTihqc051bWJlcihhICYgYikpOwogfQogCiBMTElOVF9T TE9XX1BBVEhfREVDTChzbG93X3BhdGhfYml0b3IpCiB7CiAgICAgTExJTlRfQkVHSU4oKTsKLSAg ICBMTElOVF9SRVRVUk4oanNOdW1iZXIoTExJTlRfT1BfQygyKS5qc1ZhbHVlKCkudG9JbnQzMihl eGVjKSB8IExMSU5UX09QX0MoMykuanNWYWx1ZSgpLnRvSW50MzIoZXhlYykpKTsKKyAgICBpbnQz Ml90IGEgPSBMTElOVF9PUF9DKDIpLmpzVmFsdWUoKS50b0ludDMyKGV4ZWMpOworICAgIGludDMy X3QgYiA9IExMSU5UX09QX0MoMykuanNWYWx1ZSgpLnRvSW50MzIoZXhlYyk7CisgICAgTExJTlRf UkVUVVJOKGpzTnVtYmVyKGEgfCBiKSk7CiB9CiAKIExMSU5UX1NMT1dfUEFUSF9ERUNMKHNsb3df cGF0aF9iaXR4b3IpCiB7CiAgICAgTExJTlRfQkVHSU4oKTsKLSAgICBMTElOVF9SRVRVUk4oanNO dW1iZXIoTExJTlRfT1BfQygyKS5qc1ZhbHVlKCkudG9JbnQzMihleGVjKSBeIExMSU5UX09QX0Mo MykuanNWYWx1ZSgpLnRvSW50MzIoZXhlYykpKTsKKyAgICBpbnQzMl90IGEgPSBMTElOVF9PUF9D KDIpLmpzVmFsdWUoKS50b0ludDMyKGV4ZWMpOworICAgIGludDMyX3QgYiA9IExMSU5UX09QX0Mo MykuanNWYWx1ZSgpLnRvSW50MzIoZXhlYyk7CisgICAgTExJTlRfUkVUVVJOKGpzTnVtYmVyKGEg XiBiKSk7CiB9CiAKIExMSU5UX1NMT1dfUEFUSF9ERUNMKHNsb3dfcGF0aF9jaGVja19oYXNfaW5z dGFuY2UpCg==