88391 2012-06-05 21:00:19 -0700 [EFL] Duplicated RenderThemeEfl creation for same page 2017-03-11 10:33:21 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 ryuan.choi ryuan.choi gyuyoung.kim gyuyoung.kim lucas.de.marchi mcatanzaro rakuco webkit.review.bot oldest_to_newest 642138 0 ryuan.choi 2012-06-05 21:00:19 -0700 In case of EFL(Qt port looks similar also), themeForPage with page create new RenderTheme every time although it is called with same page. 724532 1 164920 ryuan.choi 2012-09-20 08:13:49 -0700 Created attachment 164920 simpleApproach 725007 2 164920 jinwoo7.song 2012-09-20 17:27:54 -0700 Comment on attachment 164920 simpleApproach View in context: https://bugs.webkit.org/attachment.cgi?id=164920&action=review > Source/WebCore/ChangeLog:3 > + RenderThemeEfl is created more than one when themeForPage is called multiple time with same address of page. Conciseness may be served when the title is so corrected, 'Duplicated RenderThemeEfl creation for same page'. > Source/WebCore/platform/efl/RenderThemeEfl.cpp:431 > + return RenderThemeEfl::create(page); how about this? return page->theme() ? page->theme() : RenderThemeEfl::create(page); 725011 3 ryuan.choi 2012-09-20 17:37:25 -0700 (In reply to comment #2) > (From update of attachment 164920 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=164920&action=review > > > Source/WebCore/ChangeLog:3 > > + RenderThemeEfl is created more than one when themeForPage is called multiple time with same address of page. > > Conciseness may be served when the title is so corrected, 'Duplicated RenderThemeEfl creation for same page'. > I will change with '[EFL]' prefix. > > Source/WebCore/platform/efl/RenderThemeEfl.cpp:431 > > + return RenderThemeEfl::create(page); > > how about this? > return page->theme() ? page->theme() : RenderThemeEfl::create(page); OK. I will. 725024 4 165025 ryuan.choi 2012-09-20 17:55:19 -0700 Created attachment 165025 Patch 725319 5 rakuco 2012-09-21 02:42:03 -0700 Seems to be OK. 726395 6 165025 gyuyoung.kim 2012-09-23 23:08:51 -0700 Comment on attachment 165025 Patch Looks make sense. 726400 7 165025 webkit.review.bot 2012-09-23 23:28:23 -0700 Comment on attachment 165025 Patch Clearing flags on attachment: 165025 Committed r129328: <http://trac.webkit.org/changeset/129328> 726401 8 webkit.review.bot 2012-09-23 23:28:27 -0700 All reviewed patches have been landed. Closing bug. 726424 9 ryuan.choi 2012-09-24 00:30:33 -0700 The patch was reverted in Bug 97429 because of many crashes in layout tests, unit tests. 1286212 10 mcatanzaro 2017-03-11 10:33:21 -0800 Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this. 164920 2012-09-20 08:13:49 -0700 2012-09-20 17:55:11 -0700 simpleApproach bug-88391-20120921001313.patch text/plain 2131 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTBmN2QyZDBkOTljNjAx ODEzYWI2NmYyMmZhMDVkYWQ5Zjk0NTAxYy4uZmMxMmQ5MDgwODI3ZTAyYjkwZTA3YzQ1MDgwYWMx NWMxN2RmNDZhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA5LTIwICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBSZW5kZXJUaGVtZUVm bCBpcyBjcmVhdGVkIG1vcmUgdGhhbiBvbmUgd2hlbiB0aGVtZUZvclBhZ2UgaXMgY2FsbGVkIG11 bHRpcGxlIHRpbWUgd2l0aCBzYW1lIGFkZHJlc3Mgb2YgcGFnZS4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4MzkxCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT3RoZXIgcG9ydHMgcmV0dXJuIG9uZSBvciB0 d28gUmVuZGVyVGhlbWUgcmVnYXJkbGVzcyBvZiBwYWdlLgorICAgICAgICBCdXQsIFdlYktpdC9F ZmwgY2FuIGNyZWF0ZSBkaWZmZXJlbnQgdGhlbWUgZm9yIGVhY2ggcGFnZSBhbmQgdGhlbWVGb3JQ YWdlCisgICAgICAgIGNyZWF0ZXMgbmV3IFJlbmRlclRoZW1lIHdoZW5ldmVyIGl0IGlzIGNhbGxl ZCB3aXRoIHBhZ2UuCisgICAgICAgIFNvIG1vcmUgdGhhbiBvbmUgUmVuZGVyVGhlbWUgY2FuIGJl IGNyZWF0ZWQgZm9yIGEgcGFnZS4KKworICAgICAgICBUaGlzIHBhdGNoZXMgY2hlY2tzIHdoZXRo ZXIgcGFnZSBhbHJlYWR5IGhhcyBSZW5kZXJUaGVtZSBub3QgdG8gY3JlYXRlIG5ldworICAgICAg ICBSZW5kZXJUaGVtZSBmb3Igc2FtZSBwYWdlLgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL1Jl bmRlclRoZW1lRWZsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lOjp0aGVtZUZv clBhZ2UpOgorCiAyMDEyLTA5LTIwICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5z ZW5Abm9raWEuY29tPgogCiAgICAgICAgIFtUb3VjaEFkanVzdG1lbnRdIFNpbXBsaWZ5IGFuZCBp bXByb3ZlIGh5YnJpZCBkaXN0YW5jZSBmdW5jdGlvbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwCmluZGV4IGI5YTg5NjNjMmMwZDI0MDc4NzdmZjFl MDkyNDVlNWNlMTk5YTk2MDkuLjFjMzc4NWIyYzJmMzYwNTkyMWMxZWIyMzBmYjQ0NzYyYTM0MjNl MzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVm bC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNw cApAQCAtNDIwLDExICs0MjAsMTUgQEAgUGFzc1JlZlB0cjxSZW5kZXJUaGVtZT4gUmVuZGVyVGhl bWVFZmw6OmNyZWF0ZShQYWdlKiBwYWdlKQogCiBQYXNzUmVmUHRyPFJlbmRlclRoZW1lPiBSZW5k ZXJUaGVtZTo6dGhlbWVGb3JQYWdlKFBhZ2UqIHBhZ2UpCiB7Ci0gICAgaWYgKHBhZ2UpCi0gICAg ICAgIHJldHVybiBSZW5kZXJUaGVtZUVmbDo6Y3JlYXRlKHBhZ2UpOworICAgIGlmICghcGFnZSkg eworICAgICAgICBzdGF0aWMgUmVuZGVyVGhlbWUqIGZhbGxiYWNrID0gUmVuZGVyVGhlbWVFZmw6 OmNyZWF0ZSgwKS5sZWFrUmVmKCk7CisgICAgICAgIHJldHVybiBmYWxsYmFjazsKKyAgICB9CisK KyAgICBpZiAocGFnZS0+dGhlbWUoKSkKKyAgICAgICAgcmV0dXJuIHBhZ2UtPnRoZW1lKCk7CiAK LSAgICBzdGF0aWMgUmVuZGVyVGhlbWUqIGZhbGxiYWNrID0gUmVuZGVyVGhlbWVFZmw6OmNyZWF0 ZSgwKS5sZWFrUmVmKCk7Ci0gICAgcmV0dXJuIGZhbGxiYWNrOworICAgIHJldHVybiBSZW5kZXJU aGVtZUVmbDo6Y3JlYXRlKHBhZ2UpOwogfQogCiBzdGF0aWMgdm9pZCBhcHBseUNvbG9yQ2FsbGJh Y2sodm9pZCogZGF0YSwgRXZhc19PYmplY3QqLCBjb25zdCBjaGFyKiAvKiBzaWduYWwgKi8sIGNv bnN0IGNoYXIqIGNvbG9yQ2xhc3MpCg== 165025 2012-09-20 17:55:19 -0700 2012-09-23 23:28:23 -0700 Patch bug-88391-20120921095444.patch text/plain 1768 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWI4MmM0NWU4MjVlOTVj MjE5NmU0MGQ2YThkZTE1NDBlY2QzYjg3My4uNTdiNGE4MmM3N2QxYzY2NDc2MDE4YTAwYmVhM2Ex NDI2YjhkMTcyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA5LTIwICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBEdXBsaWNh dGVkIFJlbmRlclRoZW1lRWZsIGNyZWF0aW9uIGZvciBzYW1lIHBhZ2UKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4MzkxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT3RoZXIgcG9ydHMgcmV0dXJuIG9uZSBv ciB0d28gUmVuZGVyVGhlbWUgcmVnYXJkbGVzcyBvZiBwYWdlLgorICAgICAgICBCdXQsIFdlYktp dC9FZmwgY2FuIGNyZWF0ZSBkaWZmZXJlbnQgdGhlbWUgZm9yIGVhY2ggcGFnZSBhbmQKKyAgICAg ICAgdGhlbWVGb3JQYWdlIGNyZWF0ZXMgbmV3IFJlbmRlclRoZW1lIHdoZW5ldmVyIGl0IGlzIGNh bGxlZCB3aXRoIHBhZ2UuCisgICAgICAgIFNvIG1vcmUgdGhhbiBvbmUgUmVuZGVyVGhlbWUgY2Fu IGJlIGNyZWF0ZWQgZm9yIGEgcGFnZS4KKworICAgICAgICBUaGlzIHBhdGNoZXMgY2hlY2tzIHdo ZXRoZXIgcGFnZSBhbHJlYWR5IGhhcyBSZW5kZXJUaGVtZSBub3QgdG8gY3JlYXRlIG5ldworICAg ICAgICBSZW5kZXJUaGVtZSBmb3Igc2FtZSBwYWdlLgorCisgICAgICAgICogcGxhdGZvcm0vZWZs L1JlbmRlclRoZW1lRWZsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lOjp0aGVt ZUZvclBhZ2UpOgorCiAyMDEyLTA5LTIwICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgW2Nocm9taXVtXSBFbmFibGUgbW9yZSBjbGFuZyB3YXJuaW5ncwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHAKaW5kZXggYjlhODk2 M2MyYzBkMjQwNzg3N2ZmMWUwOTI0NWU1Y2UxOTlhOTYwOS4uNzc1MzQyYjMyNmI5OWE4NzQ1MTU3 ODdjZmRlMTMxZjlkNTJmZTFlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v ZWZsL1JlbmRlclRoZW1lRWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwv UmVuZGVyVGhlbWVFZmwuY3BwCkBAIC00MjEsNyArNDIxLDcgQEAgUGFzc1JlZlB0cjxSZW5kZXJU aGVtZT4gUmVuZGVyVGhlbWVFZmw6OmNyZWF0ZShQYWdlKiBwYWdlKQogUGFzc1JlZlB0cjxSZW5k ZXJUaGVtZT4gUmVuZGVyVGhlbWU6OnRoZW1lRm9yUGFnZShQYWdlKiBwYWdlKQogewogICAgIGlm IChwYWdlKQotICAgICAgICByZXR1cm4gUmVuZGVyVGhlbWVFZmw6OmNyZWF0ZShwYWdlKTsKKyAg ICAgICAgcmV0dXJuIHBhZ2UtPnRoZW1lKCkgPyBwYWdlLT50aGVtZSgpIDogUmVuZGVyVGhlbWVF Zmw6OmNyZWF0ZShwYWdlKTsKIAogICAgIHN0YXRpYyBSZW5kZXJUaGVtZSogZmFsbGJhY2sgPSBS ZW5kZXJUaGVtZUVmbDo6Y3JlYXRlKDApLmxlYWtSZWYoKTsKICAgICByZXR1cm4gZmFsbGJhY2s7 Cg==