88386 2012-06-05 18:40:49 -0700 shouldSuppressPaintingLayer shouldn't be called on every RenderLayers 2012-06-06 10:46:55 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All NEW P2 Normal --- 75001 1 jchaffraix jchaffraix eric jamesr simon.fraser webkit.review.bot oldest_to_newest 642083 0 jchaffraix 2012-06-05 18:40:49 -0700 After doing some archeology (see r16129), the code is used to avoid FOUCs by preventing paints to propagate to child RenderLayers (meaning that there will be a flash to white instead). It was later extended to allow for paints suppression. All the conditions that the function checks are tied to the document - the exception being that it checks for child layer - which means that instead of having a fixed cost per paint phase, it's a cost per RenderLayer::paintLayer. On http://dglazkov.github.com/performance-tests/biggrid.html, this is an ~8 - 10% cost as we need to do a lot of paintLayer calls. At the time the function was introduced, it's unclear if the painting went through a single point as it does now but we can easily move the code to the FrameView now. Patch forthcoming. 642110 1 145917 jchaffraix 2012-06-05 19:41:47 -0700 Created attachment 145917 Proposed change v1. 642121 2 145917 simon.fraser 2012-06-05 20:29:13 -0700 Comment on attachment 145917 Proposed change v1. What happens when there are compositing layers, which can enter painting on a non-root RenderLayer? Or do we never have compositing layers this early on? 642493 3 145917 simon.fraser 2012-06-06 08:23:54 -0700 Comment on attachment 145917 Proposed change v1. r- until we resolve the compositing issue. 642533 4 jchaffraix 2012-06-06 09:21:43 -0700 (In reply to comment #2) > (From update of attachment 145917 [details]) > What happens when there are compositing layers, which can enter painting on a non-root RenderLayer? Or do we never have compositing layers this early on? The compositing code is bypassing the checks for the owning layer already as RenderLayerBacking::paintContents calls directly RenderLayer::paintLayerContents. However you would not paint the descendant layers as you would need to go through RenderLayer::paintLayer. I don't think anything prevents us from having compositing layers during a potential FOUC so the logic needs to be changed. 642601 5 jchaffraix 2012-06-06 10:46:55 -0700 Mhh, it also looks like the new logic wouldn't repaint the RenderView or the document's element which means we wouldn't paint the background and do a "flash to white" like the old code. It doesn't sound like a good idea to change that. 145917 2012-06-05 19:41:47 -0700 2012-06-06 08:23:54 -0700 Proposed change v1. bug-88386-20120605194147.patch text/plain 6734 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTBiZTZmYmUwNzMwNTll ZmFhOTJhOTI4NzIwM2MwYjYyYzQyYmQ4Ny4uN2Y4OTMwODFkYzQ4YzAyZmUxMjg4OGUwMzQyMGFm ODFjYzNiOTBkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQwIEBACisyMDEyLTA2LTA1ICBKdWxp ZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgorCisgICAgICAgIHNob3VsZFN1 cHByZXNzUGFpbnRpbmdMYXllciBzaG91bGRuJ3QgYmUgY2FsbGVkIG9uIGV2ZXJ5IFJlbmRlckxh eWVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODgz ODYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQZXJm b3JtYW5jZSBjaGFuZ2UsIEZPVUNzIGFyZSBsaWtlbHkgbm90IHZlcnkgd2VsbCBjb3ZlcmVkIGlu IG91ciB0ZXN0cyBkdWUgdG8gdGhlIHJhY3kKKyAgICAgICAgbmF0dXJlIG9mIHRob3NlIGJ1Z3Mu CisKKyAgICAgICAgVGhlIGNvZGUgdGhhdCBtYWtlcyB1cCBzaG91bGRTdXBwcmVzc1BhaW50aW5n TGF5ZXIgd2FzIGxhbmRlZCBpbiByMTYxMjkgdG8gcHJldmVudAorICAgICAgICBGT1VDcyBieSBz dG9wcGluZyBwYWludGluZyBpZiB3ZSBkZXRlY3Qgc29tZSBiYWQgY29uZGl0aW9ucy4gc2hvdWxk U3VwcHJlc3NQYWludGluZ0xheWVyCisgICAgICAgIG1vc3RseSBjb250YWlucyBkb2N1bWVudC1s ZXZlbCBjaGVja3MgdGhhdCBhcmUgY29tbW9uIGZvciBldmVyeSBSZW5kZXJMYXllcnMgYW5kIG1h a2VzCisgICAgICAgIHRoZSBjb3N0IG9mIGNoZWNraW5nIGFsbCBvZiB0aGVtIHVubmVlZGVkLgor CisgICAgICAgIE15IHVuZGVyc3RhbmRpbmcgb2YgdGhlIGFyY2hpdGVjdHVyZSBhdCB0aGUgdGlt ZSB3YXMgdGhhdCBpdCB3YXMgZWFzaWVyIHRvIGNoZWNrIGZvcgorICAgICAgICBGT1VDcyBhdCB0 aGUgcmVuZGVyaW5nLyBsZXZlbCBhcyBzZXZlcmFsIGNhbGxlcnMgY291bGQgY2FsbCBwYWludGlu Zy4gSG93ZXZlciBub3dhZGF5cywKKyAgICAgICAgZXZlcnkgcGFpbnQgZXZlbnRzIGdvIHRocm91 Z2ggRnJhbWVWaWV3OjpwYWludENvbnRlbnQuCisKKyAgICAgICAgT24gaHR0cDovL2RnbGF6a292 LmdpdGh1Yi5jb20vcGVyZm9ybWFuY2UtdGVzdHMvYmlnZ3JpZC5odG1sLCBzaG91bGRTdXBwcmVz c1BhaW50aW5nTGF5ZXIKKyAgICAgICAgYWRkcyBhbiA4IC0gMTAlIG92ZXJoZWFkIHRvIHRoZSBw YWludCB0aW1lLgorCisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6c2hvdWRTdXBwcmVzc1BhaW50aW5nT25Sb290KToKKyAgICAgICAgTW92ZSB0aGUgY29k ZSBmcm9tIHNob3VsZFN1cHByZXNzUGFpbnRpbmdMYXllciBoZXJlLgorCisgICAgICAgIChXZWJD b3JlOjpGcmFtZVZpZXc6OnBhaW50Q29udGVudHMpOgorICAgICAgICBBZGRlZCBhIHNob3VkU3Vw cHJlc3NQYWludGluZ09uUm9vdCBjaGVjay4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJC bG9jay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6cGFpbnRDb250ZW50cyk6 CisgICAgICAgIFJlbW92ZWQgdGhlIGNoZWNrIGFzIGl0IGlzIG5vdyBjb3ZlcmVkIGJ5IHRoZSBv bmUgaW4gRnJhbWVWaWV3OjpwYWludENvbnRlbnRzLgorCisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpwYWludExheWVy KToKKyAgICAgICAgUmVtb3ZlZCBzaG91bGRTdXBwcmVzc1BhaW50aW5nTGF5ZXIgYW5kIHJlbGF0 ZWQgY29kZS4KKwogMjAxMi0wNi0wNSAgRXJpayBBcnZpZHNzb24gIDxhcnZAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFtWOF0gSW1wcm92ZSB2YXJpYWJsZSByZXNvbHV0aW9uIG9yZGVyIG9uIHdp bmRvdwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4IGIxMDM5MmI2YzRmMzdlNzJlNGMy NGJiNWViZTcyZWIwMmFhYzU1YjIuLmYzZjBlNzU5MjRlOThjZGQ2ZWJlZGFhZjdjYjk3ZDFjMDc4 MWQ1Y2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKQEAgLTMwMTksNiArMzAxOSwyMiBA QCB2b2lkIEZyYW1lVmlldzo6c2V0V2FzU2Nyb2xsZWRCeVVzZXIoYm9vbCB3YXNTY3JvbGxlZEJ5 VXNlcikKICAgICBtX3dhc1Njcm9sbGVkQnlVc2VyID0gd2FzU2Nyb2xsZWRCeVVzZXI7CiB9CiAK K3N0YXRpYyBib29sIHNob3VkU3VwcHJlc3NQYWludGluZ09uUm9vdChSZW5kZXJWaWV3KiByZW5k ZXJlcikKK3sKKyAgICAvLyBBdm9pZCBwYWludGluZyB0aGUgcm9vdCBsYXllciB3aGVuIHN0eWxl c2hlZXRzIGhhdmVuJ3QgbG9hZGVkLiBUaGlzIGVsaW1pbmF0ZXMgRk9VQy4KKyAgICAvLyBJdCdz IG9rIG5vdCB0byBkcmF3LCBiZWNhdXNlIGxhdGVyIG9uLCB3aGVuIGFsbCB0aGUgc3R5bGVzaGVl dHMgZG8gbG9hZCwgdXBkYXRlU3R5bGVTZWxlY3RvciBvbiB0aGUgRG9jdW1lbnQKKyAgICAvLyB3 aWxsIGRvIGEgZnVsbCByZXBhaW50KCkuCisgICAgaWYgKHJlbmRlcmVyLT5kb2N1bWVudCgpLT5k aWRMYXlvdXRXaXRoUGVuZGluZ1N0eWxlc2hlZXRzKCkpCisgICAgICAgIHJldHVybiB0cnVlOwor CisgICAgLy8gQXZvaWQgcGFpbnRpbmcgYWxsIGxheWVycyBpZiB0aGUgZG9jdW1lbnQgaXMgaW4g YSBzdGF0ZSB3aGVyZSB2aXN1YWwgdXBkYXRlcyBhcmVuJ3QgYWxsb3dlZC4KKyAgICAvLyBBIGZ1 bGwgcmVwYWludCB3aWxsIG9jY3VyIGluIERvY3VtZW50OjppbXBsaWNpdENsb3NlKCkgaWYgcGFp bnRpbmcgaXMgc3VwcHJlc3NlZCBoZXJlLgorICAgIGlmICghcmVuZGVyZXItPmRvY3VtZW50KCkt PnZpc3VhbFVwZGF0ZXNBbGxvd2VkKCkpCisgICAgICAgIHJldHVybiB0cnVlOworCisgICAgcmV0 dXJuIGZhbHNlOworfQorCiB2b2lkIEZyYW1lVmlldzo6cGFpbnRDb250ZW50cyhHcmFwaGljc0Nv bnRleHQqIHAsIGNvbnN0IEludFJlY3QmIHJlY3QpCiB7CiAgICAgaWYgKCFmcmFtZSgpKQpAQCAt MzA2NSw2ICszMDgxLDkgQEAgdm9pZCBGcmFtZVZpZXc6OnBhaW50Q29udGVudHMoR3JhcGhpY3ND b250ZXh0KiBwLCBjb25zdCBJbnRSZWN0JiByZWN0KQogICAgIGlmIChuZWVkc0xheW91dCgpKQog ICAgICAgICByZXR1cm47CiAKKyAgICBpZiAoc2hvdWRTdXBwcmVzc1BhaW50aW5nT25Sb290KHJv b3QpKQorICAgICAgICByZXR1cm47CisKICAgICBGb250Q2FjaGVQdXJnZVByZXZlbnRlciBmb250 Q2FjaGVQdXJnZVByZXZlbnRlcjsKIAogI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCmluZGV4IDgzMTMwYTg3OWJl OWQ2ZTliNzc1NmU0MjI5ZDI2ZWI1YmZlN2UyNTkuLmJkMmFiY2JhZTU2YTU1MjFmZjRlNzU2OGFk ODVkMzA5Nzk3ZWZiNGEgMTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJCbG9jay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNw cApAQCAtMjc2NCwxMSArMjc2NCw3IEBAIHZvaWQgUmVuZGVyQmxvY2s6OnBhaW50Q29sdW1uQ29u dGVudHMoUGFpbnRJbmZvJiBwYWludEluZm8sIGNvbnN0IExheW91dFBvaW50JiBwCiAKIHZvaWQg UmVuZGVyQmxvY2s6OnBhaW50Q29udGVudHMoUGFpbnRJbmZvJiBwYWludEluZm8sIGNvbnN0IExh eW91dFBvaW50JiBwYWludE9mZnNldCkKIHsKLSAgICAvLyBBdm9pZCBwYWludGluZyBkZXNjZW5k YW50cyBvZiB0aGUgcm9vdCBlbGVtZW50IHdoZW4gc3R5bGVzaGVldHMgaGF2ZW4ndCBsb2FkZWQu ICBUaGlzIGVsaW1pbmF0ZXMgRk9VQy4KLSAgICAvLyBJdCdzIG9rIG5vdCB0byBkcmF3LCBiZWNh dXNlIGxhdGVyIG9uLCB3aGVuIGFsbCB0aGUgc3R5bGVzaGVldHMgZG8gbG9hZCwgdXBkYXRlU3R5 bGVTZWxlY3RvciBvbiB0aGUgRG9jdW1lbnQKLSAgICAvLyB3aWxsIGRvIGEgZnVsbCByZXBhaW50 KCkuCi0gICAgaWYgKGRvY3VtZW50KCktPmRpZExheW91dFdpdGhQZW5kaW5nU3R5bGVzaGVldHMo KSAmJiAhaXNSZW5kZXJWaWV3KCkpCi0gICAgICAgIHJldHVybjsKKyAgICBBU1NFUlQoIWRvY3Vt ZW50KCktPmRpZExheW91dFdpdGhQZW5kaW5nU3R5bGVzaGVldHMoKSk7CiAKICAgICBpZiAoY2hp bGRyZW5JbmxpbmUoKSkKICAgICAgICAgbV9saW5lQm94ZXMucGFpbnQodGhpcywgcGFpbnRJbmZv LCBwYWludE9mZnNldCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyTGF5ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcApp bmRleCAwNWQ5YmE1NzdlMjZiNDk3MGRlNGUwYzRmMTJjMzM3MzFhNDE1MjM4Li5lMjk5NDc2OTA3 YWU0M2Y0MjRkOWI0NzNlY2IzYmQ4MmE3NDIyNjUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJMYXllci5jcHAKQEAgLTI4NDMsMjkgKzI4NDMsMTUgQEAgc3RhdGljIGJvb2wgc2hv dWxkRG9Tb2Z0d2FyZVBhaW50KGNvbnN0IFJlbmRlckxheWVyKiBsYXllciwgYm9vbCBwYWludGlu Z1JlZmxlY3QKICAgICByZXR1cm4gcGFpbnRpbmdSZWZsZWN0aW9uICYmICFsYXllci0+aGFzM0RU cmFuc2Zvcm0oKTsKIH0KICNlbmRpZgotICAgIAotc3RhdGljIGlubGluZSBib29sIHNob3VsZFN1 cHByZXNzUGFpbnRpbmdMYXllcihSZW5kZXJMYXllciogbGF5ZXIpCi17Ci0gICAgLy8gQXZvaWQg cGFpbnRpbmcgZGVzY2VuZGFudHMgb2YgdGhlIHJvb3QgbGF5ZXIgd2hlbiBzdHlsZXNoZWV0cyBo YXZlbid0IGxvYWRlZC4gVGhpcyBlbGltaW5hdGVzIEZPVUMuCi0gICAgLy8gSXQncyBvayBub3Qg dG8gZHJhdywgYmVjYXVzZSBsYXRlciBvbiwgd2hlbiBhbGwgdGhlIHN0eWxlc2hlZXRzIGRvIGxv YWQsIHVwZGF0ZVN0eWxlU2VsZWN0b3Igb24gdGhlIERvY3VtZW50Ci0gICAgLy8gd2lsbCBkbyBh IGZ1bGwgcmVwYWludCgpLgotICAgIGlmIChsYXllci0+cmVuZGVyZXIoKS0+ZG9jdW1lbnQoKS0+ ZGlkTGF5b3V0V2l0aFBlbmRpbmdTdHlsZXNoZWV0cygpICYmICFsYXllci0+cmVuZGVyZXIoKS0+ aXNSZW5kZXJWaWV3KCkgJiYgIWxheWVyLT5yZW5kZXJlcigpLT5pc1Jvb3QoKSkKLSAgICAgICAg cmV0dXJuIHRydWU7Ci0KLSAgICAvLyBBdm9pZCBwYWludGluZyBhbGwgbGF5ZXJzIGlmIHRoZSBk b2N1bWVudCBpcyBpbiBhIHN0YXRlIHdoZXJlIHZpc3VhbCB1cGRhdGVzIGFyZW4ndCBhbGxvd2Vk LgotICAgIC8vIEEgZnVsbCByZXBhaW50IHdpbGwgb2NjdXIgaW4gRG9jdW1lbnQ6OmltcGxpY2l0 Q2xvc2UoKSBpZiBwYWludGluZyBpcyBzdXBwcmVzc2VkIGhlcmUuCi0gICAgaWYgKCFsYXllci0+ cmVuZGVyZXIoKS0+ZG9jdW1lbnQoKS0+dmlzdWFsVXBkYXRlc0FsbG93ZWQoKSkKLSAgICAgICAg cmV0dXJuIHRydWU7Ci0KLSAgICByZXR1cm4gZmFsc2U7Ci19Ci0KIAogdm9pZCBSZW5kZXJMYXll cjo6cGFpbnRMYXllcihSZW5kZXJMYXllciogcm9vdExheWVyLCBHcmFwaGljc0NvbnRleHQqIGNv bnRleHQsCiAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBMYXlvdXRSZWN0JiBwYWludERp cnR5UmVjdCwgUGFpbnRCZWhhdmlvciBwYWludEJlaGF2aW9yLAogICAgICAgICAgICAgICAgICAg ICAgICAgUmVuZGVyT2JqZWN0KiBwYWludGluZ1Jvb3QsIFJlbmRlclJlZ2lvbiogcmVnaW9uLCBP dmVybGFwVGVzdFJlcXVlc3RNYXAqIG92ZXJsYXBUZXN0UmVxdWVzdHMsCiAgICAgICAgICAgICAg ICAgICAgICAgICBQYWludExheWVyRmxhZ3MgcGFpbnRGbGFncykKIHsKKyAgICBBU1NFUlQoIXJl bmRlcmVyKCktPmRvY3VtZW50KCktPmRpZExheW91dFdpdGhQZW5kaW5nU3R5bGVzaGVldHMoKSk7 CisgICAgQVNTRVJUKHJlbmRlcmVyKCktPmRvY3VtZW50KCktPnZpc3VhbFVwZGF0ZXNBbGxvd2Vk KCkpOworCiAjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogICAgIGlmIChpc0NvbXBv c2l0ZWQoKSkgewogICAgICAgICAvLyBUaGUgdXBkYXRpbmdDb250cm9sVGludHMoKSBwYWludGlu ZyBwYXNzIGdvZXMgdGhyb3VnaCBjb21wb3NpdGluZyBsYXllcnMsCkBAIC0yODc5LDkgKzI4NjUs NiBAQCB2b2lkIFJlbmRlckxheWVyOjpwYWludExheWVyKFJlbmRlckxheWVyKiByb290TGF5ZXIs IEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwKICAgICB9CiAjZW5kaWYKIAotICAgIGlmIChzaG91 bGRTdXBwcmVzc1BhaW50aW5nTGF5ZXIodGhpcykpCi0gICAgICAgIHJldHVybjsKLSAgICAKICAg ICAvLyBJZiB0aGlzIGxheWVyIGlzIHRvdGFsbHkgaW52aXNpYmxlIHRoZW4gdGhlcmUgaXMgbm90 aGluZyB0byBwYWludC4KICAgICBpZiAoIXJlbmRlcmVyKCktPm9wYWNpdHkoKSkKICAgICAgICAg cmV0dXJuOwo=