88374 2012-06-05 16:25:21 -0700 WebPage::windowIsVisible is incorrect during resumePainting 2012-06-06 00:56:31 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton adele andersca dino jer.noble mitz oldest_to_newest 641995 0 thorton 2012-06-05 16:25:21 -0700 A few methods in WKView do something like this: _data->_page->viewStateDidChange(WebPageProxy::ViewIsVisible); [self _updateWindowVisibility]; viewStateDidChange can end up calling resumePainting, which depends on the window visibility (windowIsVisible) being correctly set in order to unpause the requestAnimationFrame controller. The only other thing that depends on windowIsVisible is PluginView and friends, which seem unlikely to mind it being updated slightly earlier. The behavior as it stands now seems wrong, and will likely only serve to confuse future users of windowIsVisible. <rdar://problem/11587039> 641998 1 thorton 2012-06-05 16:30:06 -0700 I've tried and failed continuously to make a test for this. The mixture of fullscreen and rAF and WebKit2 and the different DrawingArea implementations is making it very hard, and potentially not possible (I can't cause the problem to reproduce in WKTR at all). 642006 2 thorton 2012-06-05 16:40:27 -0700 One effect of this is that Bing Maps stops updating if you full-screen it (http://binged.it/K9uLcw). 642014 3 145897 thorton 2012-06-05 16:53:16 -0700 Created attachment 145897 patch went a bit overboard with the changelog 642027 4 145897 simon.fraser 2012-06-05 17:14:03 -0700 Comment on attachment 145897 patch View in context: https://bugs.webkit.org/attachment.cgi?id=145897&action=review r=me as long as jer and/or anders is OK with this. > Source/WebKit2/ChangeLog:24 > + Will cause the second and third rAF calls to have no effect. Even after cancelFullScreen() is called, lowercase w 642035 5 jer.noble 2012-06-05 17:19:33 -0700 I'm fine with this. 642263 6 thorton 2012-06-06 00:55:31 -0700 Anders said it was OK on IRC before lunch yesterday, too. http://trac.webkit.org/changeset/119570 642265 7 thorton 2012-06-06 00:56:31 -0700 (In reply to comment #4) > (From update of attachment 145897 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=145897&action=review > > r=me as long as jer and/or anders is OK with this. > > > Source/WebKit2/ChangeLog:24 > > + Will cause the second and third rAF calls to have no effect. Even after cancelFullScreen() is called, > > lowercase w Aack, I missed this comment. I don't really see a follow-up commit to fix the ChangeLog, though? 145897 2012-06-05 16:53:16 -0700 2012-06-05 17:14:02 -0700 patch raf.diff text/plain 3858 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3ODlkODQzLi4wYjRmN2YxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzkg QEAKKzIwMTItMDYtMDUgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgV2ViUGFnZTo6d2luZG93SXNWaXNpYmxlIGlzIGluY29ycmVjdCBkdXJpbmcgcmVz dW1lUGFpbnRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg4Mzc0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMTU4NzAzOT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDdXJyZW50bHksIHdoZW4gY2hh bmdpbmcgd2luZG93IHZpc2liaWxpdHksIFdLVmlldyBjYWxscyB2aWV3U3RhdGVEaWRDaGFuZ2Uo Vmlld0lzVmlzaWJsZSkKKyAgICAgICAgYW5kIHRoZW4gX3VwZGF0ZVdpbmRvd1Zpc2liaWxpdHku IFRoaXMgbWVhbnMgdGhhdCBkdXJpbmcgdmlld1N0YXRlRGlkQ2hhbmdlLCB0aGUgV2ViUGFnZSdz CisgICAgICAgIHdpbmRvd0lzVmlzaWJsZSBzdGF0ZSBpcyBpbmNvcnJlY3QuCisKKyAgICAgICAg dmlld1N0YXRlRGlkQ2hhbmdlKFZpZXdJc1Zpc2libGUpIGNhbiBlbmQgdXAgaW4gKG9uZSBvZiB0 aGUgRHJhd2luZ0FyZWEgaW1wbGVtZW50YXRpb25zKTo6cmVzdW1lUGFpbnRpbmcoKSwKKyAgICAg ICAgd2hpY2ggdXNlcyB3aW5kb3dJc1Zpc2libGUgdG8gZGV0ZXJtaW5lIHdoZXRoZXIgb3Igbm90 IHRvIHVucGF1c2UgcmVxdWVzdEFuaW1hdGlvbkZyYW1lLgorCisgICAgICAgIFRoaXMgcmVzdWx0 cyBpbiBhIHN0YXRlIHdoZXJlLCB3aXRoIHNvbWUgY29uZmlndXJhdGlvbnMsIGRvaW5nIHRoZSBm b2xsb3dpbmc6CisKKyAgICAgICAgICAgIDEuIHJlcXVlc3RBbmltYXRpb25GcmFtZSgpCisgICAg ICAgICAgICAyLiByZXF1ZXN0RnVsbFNjcmVlbigpCisgICAgICAgICAgICAzLiByZXF1ZXN0QW5p bWF0aW9uRnJhbWUoKQorICAgICAgICAgICAgNC4gY2FuY2VsRnVsbFNjcmVlbigpCisgICAgICAg ICAgICA1LiByZXF1ZXN0QW5pbWF0aW9uRnJhbWUoKQorCisgICAgICAgIFdpbGwgY2F1c2UgdGhl IHNlY29uZCBhbmQgdGhpcmQgckFGIGNhbGxzIHRvIGhhdmUgbm8gZWZmZWN0LiBFdmVuIGFmdGVy IGNhbmNlbEZ1bGxTY3JlZW4oKSBpcyBjYWxsZWQsCisgICAgICAgIHRoZSBmYWN0IHRoYXQgd2Ug aGF2ZSBoYWQgdW5wYWlyZWQgc3VzcGVuZC9yZXN1bWVTY3JpcHRlZEFuaW1hdGlvbnMgd2lsbCBj YXVzZSB0aGUgc3VzcGVuZCBjb3VudAorICAgICAgICBvbiB0aGUgU2NyaXB0ZWRBbmltYXRpb25D b250cm9sbGVyIHRvIG5ldmVyIHJldHVybiB0byB6ZXJvLCB3aGljaCB3aWxsIGNhdXNlIHVzIHRv IG5ldmVyCisgICAgICAgIHJlY292ZXIgckFGIGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgVGhl IGZpeCBpcyB2ZXJ5IHNpbXBsZTogd2Ugc2hvdWxkIF91cGRhdGVXaW5kb3dWaXNpYmlsaXR5ICpi ZWZvcmUqIHZpZXdTdGF0ZURpZENoYW5nZSwgc28gdGhhdCBpdCBpcworICAgICAgICBhbHdheXMg Y29ycmVjdCBmb3IgYW55IGNvZGUgY2FsbGVkIHVuZGVybmVhdGggdGhhdCBtZXRob2QuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW06CisgICAgICAgICgtW1dLVmlldyB2 aWV3RGlkTW92ZVRvV2luZG93XSk6CisgICAgICAgICgtW1dLVmlldyBfd2luZG93RGlkT3JkZXJP ZmZTY3JlZW46XSk6CisgICAgICAgICgtW1dLVmlldyBfd2luZG93RGlkT3JkZXJPblNjcmVlbjpd KToKKwogMjAxMi0wNi0wNSAgSm9jZWx5biBUdXJjb3R0ZSAgPGpvY2VseW4udHVyY290dGVAbm9r aWEuY29tPgogCiAgICAgICAgIFdlYkxheWVyVHJlZVJlbmRlcmVyIGJlaGF2ZXMgd3JvbmdseSB3 aGVuIG5vIGNvbnRlbnRzU2NhbGUgaXMgc2V0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9tYWMvV0tWaWV3Lm1tCmluZGV4IGYwM2I5YTguLmFkZmIyY2QgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0KQEAgLTE4NzYsOSArMTg3Niw5IEBAIC0gKHZv aWQpdmlld0RpZE1vdmVUb1dpbmRvdwogICAgIC8vIHVwZGF0ZSB0aGUgYWN0aXZlIHN0YXRlLgog ICAgIGlmIChbc2VsZiB3aW5kb3ddKSB7CiAgICAgICAgIF9kYXRhLT5fd2luZG93SGFzVmFsaWRC YWNraW5nU3RvcmUgPSBOTzsKKyAgICAgICAgW3NlbGYgX3VwZGF0ZVdpbmRvd1Zpc2liaWxpdHld OwogICAgICAgICBfZGF0YS0+X3BhZ2UtPnZpZXdTdGF0ZURpZENoYW5nZShXZWJQYWdlUHJveHk6 OlZpZXdXaW5kb3dJc0FjdGl2ZSk7CiAgICAgICAgIF9kYXRhLT5fcGFnZS0+dmlld1N0YXRlRGlk Q2hhbmdlKFdlYlBhZ2VQcm94eTo6Vmlld0lzVmlzaWJsZSB8IFdlYlBhZ2VQcm94eTo6Vmlld0lz SW5XaW5kb3cpOwotICAgICAgICBbc2VsZiBfdXBkYXRlV2luZG93VmlzaWJpbGl0eV07CiAgICAg ICAgIFtzZWxmIF91cGRhdGVXaW5kb3dBbmRWaWV3RnJhbWVzXTsKIAogICAgICAgICBpZiAoIV9k YXRhLT5fZmxhZ3NDaGFuZ2VkRXZlbnRNb25pdG9yKSB7CkBAIC0xOTY3LDIwICsxOTY3LDIyIEBA IC0gKHZvaWQpX3dpbmRvd0RpZFJlc2l6ZTooTlNOb3RpZmljYXRpb24gKilub3RpZmljYXRpb24K IAogLSAodm9pZClfd2luZG93RGlkT3JkZXJPZmZTY3JlZW46KE5TTm90aWZpY2F0aW9uICopbm90 aWZpY2F0aW9uCiB7CisgICAgW3NlbGYgX3VwZGF0ZVdpbmRvd1Zpc2liaWxpdHldOworCiAgICAg Ly8gV2Ugd2FudCB0byBtYWtlIHN1cmUgdG8gdXBkYXRlIHRoZSBhY3RpdmUgc3RhdGUgd2hpbGUg aGlkZGVuLCBzbyBzaW5jZSB0aGUgdmlldyBpcyBhYm91dCB0byBiZSBoaWRkZW4sCiAgICAgLy8g d2UgaGlkZSBpdCBmaXJzdCBhbmQgdGhlbiB1cGRhdGUgdGhlIGFjdGl2ZSBzdGF0ZS4KICAgICBf ZGF0YS0+X3BhZ2UtPnZpZXdTdGF0ZURpZENoYW5nZShXZWJQYWdlUHJveHk6OlZpZXdJc1Zpc2li bGUpOwogICAgIF9kYXRhLT5fcGFnZS0+dmlld1N0YXRlRGlkQ2hhbmdlKFdlYlBhZ2VQcm94eTo6 Vmlld1dpbmRvd0lzQWN0aXZlKTsKLSAgICBbc2VsZiBfdXBkYXRlV2luZG93VmlzaWJpbGl0eV07 CiB9CiAKIC0gKHZvaWQpX3dpbmRvd0RpZE9yZGVyT25TY3JlZW46KE5TTm90aWZpY2F0aW9uICop bm90aWZpY2F0aW9uCiB7CisgICAgW3NlbGYgX3VwZGF0ZVdpbmRvd1Zpc2liaWxpdHldOworCiAg ICAgLy8gV2Ugd2FudCB0byBtYWtlIHN1cmUgdG8gdXBkYXRlIHRoZSBhY3RpdmUgc3RhdGUgd2hp bGUgaGlkZGVuLCBzbyBzaW5jZSB0aGUgdmlldyBpcyBhYm91dCB0byBiZWNvbWUgdmlzaWJsZSwK ICAgICAvLyB3ZSB1cGRhdGUgdGhlIGFjdGl2ZSBzdGF0ZSBmaXJzdCBhbmQgdGhlbiBtYWtlIGl0 IHZpc2libGUuCiAgICAgX2RhdGEtPl9wYWdlLT52aWV3U3RhdGVEaWRDaGFuZ2UoV2ViUGFnZVBy b3h5OjpWaWV3V2luZG93SXNBY3RpdmUpOwogICAgIF9kYXRhLT5fcGFnZS0+dmlld1N0YXRlRGlk Q2hhbmdlKFdlYlBhZ2VQcm94eTo6Vmlld0lzVmlzaWJsZSk7Ci0gICAgW3NlbGYgX3VwZGF0ZVdp bmRvd1Zpc2liaWxpdHldOwogfQogCiAtICh2b2lkKV93aW5kb3dEaWRDaGFuZ2VCYWNraW5nUHJv cGVydGllczooTlNOb3RpZmljYXRpb24gKilub3RpZmljYXRpb24K