88362 2012-06-05 13:48:04 -0700 DFG CFG simplification should not attempt to deref nodes inside of an unreachable subgraph 2012-06-05 14:40:38 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo webkit-unassigned msaboff oldest_to_newest 641862 0 fpizlo 2012-06-05 13:48:04 -0700 This is not only dangerous (you might go down an infinite deref recursion if you hit a dead cycle) but entirely unnecessary (the subgraph is going to get deleted anyway regardless of ref counts). 641869 1 145865 fpizlo 2012-06-05 13:53:40 -0700 Created attachment 145865 the patch Still trying to figure out the best way to test this. 641896 2 fpizlo 2012-06-05 14:32:45 -0700 Landed in http://trac.webkit.org/changeset/119526 641903 3 fpizlo 2012-06-05 14:40:38 -0700 *** Bug 87994 has been marked as a duplicate of this bug. *** 145865 2012-06-05 13:53:40 -0700 2012-06-05 13:55:55 -0700 the patch derefunreach_patch_1.diff text/plain 2238 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTE5NTE5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDEyLTA2LTA1ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHIENGRyBzaW1wbGlmaWNhdGlvbiBzaG91bGQgbm90IGF0dGVtcHQgdG8gZGVyZWYgbm9kZXMg aW5zaWRlIG9mIGFuIHVucmVhY2hhYmxlIHN1YmdyYXBoCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODM2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogZGZnL0RGR0NGR1NpbXBsaWZpY2F0aW9uUGhhc2Uu Y3BwOgorICAgICAgICAoSlNDOjpERkc6OkNGR1NpbXBsaWZpY2F0aW9uUGhhc2U6OmZpeFBoaXMp OgorICAgICAgICAoSlNDOjpERkc6OkNGR1NpbXBsaWZpY2F0aW9uUGhhc2U6OnJlbW92ZVBvdGVu dGlhbGx5RGVhZFBoaVJlZmVyZW5jZSk6CisKIDIwMTItMDYtMDUgIE1hcmsgSGFobmVuYmVyZyAg PG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBFbnRyeSBpbnRvIEpTQyBzaG91bGQg Q1JBU0goKSBpZiB0aGUgSGVhcCBpcyBidXN5CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR0NGR1NpbXBsaWZpY2F0aW9uUGhhc2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHQ0ZHU2ltcGxpZmljYXRpb25QaGFzZS5jcHAJKHJldmlzaW9u IDExOTUxNSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ0ZHU2ltcGxpZmljYXRp b25QaGFzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM4OSw3ICszODksNyBAQCBwcml2YXRlOgog ICAgICAgICAgICAgaWYgKG15Tm9kZS5vcCgpID09IEdldExvY2FsKQogICAgICAgICAgICAgICAg IG15Tm9kZUluZGV4ID0gbXlOb2RlLmNoaWxkMSgpLmluZGV4KCk7CiAgICAgICAgICAgICBmb3Ig KHVuc2lnbmVkIGogPSAwOyBqIDwgQWRqYWNlbmN5TGlzdDo6U2l6ZTsgKytqKQotICAgICAgICAg ICAgICAgIHJlbW92ZVBvdGVudGlhbGx5RGVhZFBoaVJlZmVyZW5jZShteU5vZGVJbmRleCwgcGhp Tm9kZSwgaik7CisgICAgICAgICAgICAgICAgcmVtb3ZlUG90ZW50aWFsbHlEZWFkUGhpUmVmZXJl bmNlKG15Tm9kZUluZGV4LCBwaGlOb2RlLCBqLCBzb3VyY2VCbG9jay0+aXNSZWFjaGFibGUpOwog I2lmIERGR19FTkFCTEUoREVCVUdfUFJPUEFHQVRJT05fVkVSQk9TRSkKICAgICAgICAgICAgIGRh dGFMb2coIlxuIik7CiAjZW5kaWYKQEAgLTQxNCwxNCArNDE0LDE0IEBAIHByaXZhdGU6CiAgICAg ICAgIGZpeFBoaXMoYmxvY2tJbmRleCwgamV0dGlzb25lZEJsb2NrSW5kZXgpOwogICAgIH0KICAg ICAKLSAgICB2b2lkIHJlbW92ZVBvdGVudGlhbGx5RGVhZFBoaVJlZmVyZW5jZShOb2RlSW5kZXgg bXlOb2RlSW5kZXgsIE5vZGUmIHBoaU5vZGUsIHVuc2lnbmVkIGVkZ2VJbmRleCkKKyAgICB2b2lk IHJlbW92ZVBvdGVudGlhbGx5RGVhZFBoaVJlZmVyZW5jZShOb2RlSW5kZXggbXlOb2RlSW5kZXgs IE5vZGUmIHBoaU5vZGUsIHVuc2lnbmVkIGVkZ2VJbmRleCwgYm9vbCBjaGFuZ2VSZWYpCiAgICAg ewogICAgICAgICBpZiAocGhpTm9kZS5jaGlsZHJlbi5jaGlsZChlZGdlSW5kZXgpLmluZGV4VW5j aGVja2VkKCkgIT0gbXlOb2RlSW5kZXgpCiAgICAgICAgICAgICByZXR1cm47CiAjaWYgREZHX0VO QUJMRShERUJVR19QUk9QQUdBVElPTl9WRVJCT1NFKQogICAgICAgICBkYXRhTG9nKCIgUmVtb3Zp bmcgcmVmZXJlbmNlIGF0IGNoaWxkICV1LiIsIGVkZ2VJbmRleCk7CiAjZW5kaWYKLSAgICAgICAg aWYgKHBoaU5vZGUuc2hvdWxkR2VuZXJhdGUoKSkKKyAgICAgICAgaWYgKGNoYW5nZVJlZiAmJiBw aGlOb2RlLnNob3VsZEdlbmVyYXRlKCkpCiAgICAgICAgICAgICBtX2dyYXBoLmRlcmVmKG15Tm9k ZUluZGV4KTsKICAgICAgICAgcGhpTm9kZS5jaGlsZHJlbi5yZW1vdmVFZGdlRnJvbUJhZyhlZGdl SW5kZXgpOwogICAgIH0K