88359 2012-06-05 13:27:35 -0700 [chromium] More than 8 fingers get ignored by touch 2012-06-20 06:12:10 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) All All RESOLVED FIXED P3 Normal --- 1 girard girard abarth dglazkov fishd jamesr rjkroege tkent+wkapi webkit.review.bot oldest_to_newest 641843 0 girard 2012-06-05 13:27:35 -0700 WebTouchEvent::touchesLengthCap is set to 8. On devices that support more than 8 touches, additional touches get ignored. Bump this up to 12. 641859 1 145862 rjkroege 2012-06-05 13:47:10 -0700 Created attachment 145862 Patch 641860 2 rjkroege 2012-06-05 13:47:44 -0700 I think this is sufficient. What do you think? 641865 3 webkit.review.bot 2012-06-05 13:50:41 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 641870 4 girard 2012-06-05 13:59:39 -0700 LGTM 641893 5 jamesr 2012-06-05 14:29:30 -0700 Both of these numbers seem really arbitrary. Is the use case here two-handed polydactylic users? 641907 6 rjkroege 2012-06-05 14:49:07 -0700 fwiw: my justification for 12: it's 1 more than the best commonly available touchscreen hardware and as you observe: more than the normal human finger count. 641949 7 girard 2012-06-05 15:41:56 -0700 Arbitrary, yes. The justification is that we have ten fingers, so eight is clearly too low. The Gesture Recognizer (part of Chromium) assumes 12 points. The iPad supports 11, 3M reportedly makes a 30 touch screen, and my home brew device supports, well, an unlimited number of points. 12 seemed to be a good value since it's in line with the GR. 641971 8 145862 jamesr 2012-06-05 15:56:50 -0700 Comment on attachment 145862 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145862&action=review > Source/WebKit/chromium/public/WebInputEvent.h:388 > + enum { touchesLengthCap = 12 }; Please document where this number is coming from (i.e. this is matching chromium's gesture recognition library). 644804 9 146599 rjkroege 2012-06-08 10:39:29 -0700 Created attachment 146599 Patch 644854 10 146599 webkit.review.bot 2012-06-08 11:15:11 -0700 Comment on attachment 146599 Patch Clearing flags on attachment: 146599 Committed r119843: <http://trac.webkit.org/changeset/119843> 644855 11 webkit.review.bot 2012-06-08 11:15:16 -0700 All reviewed patches have been landed. Closing bug. 653385 12 146599 eric 2012-06-20 06:12:10 -0700 Comment on attachment 146599 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146599&action=review > Source/WebKit/chromium/public/WebInputEvent.h:389 > + // Maximum number of simultaneous touches supported on > + // Ash/Aura. Odd wrapping. Odd names. 145862 2012-06-05 13:47:10 -0700 2012-06-08 10:39:22 -0700 Patch bug-88359-20120605164709.patch text/plain 1269 rjkroege U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NDYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDIwZGM2NmIxOWY5YjhjNDVkYzRmZTY1MmZmMGVmYzUwZmRkNzZmOGUuLjE1MGY2NWY3MmMzZGYx MjNmNjUzZDBiNDcyZmMyZjIzM2Q4YTEwYTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTItMDYtMDUgIFJvYmVydCBLcm9lZ2VyICA8cmprcm9lZ2VAY2hy b21pdW0ub3JnPgorCisgICAgICAgIE1vcmUgdGhhbiA4IGZpbmdlcnMgZ2V0IGlnbm9yZWQgYnkg dG91Y2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4 MzU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBw dWJsaWMvV2ViSW5wdXRFdmVudC5oOiBJbmNyZWFzZSBvZiBUb3VjaFBvaW50cyBwZXIgVG91Y2hF dmVudCBmcm9tIDggdG8gMTIuCisKIDIwMTItMDYtMDQgIERhbmEgSmFuc2VucyAgPGRhbmFrakBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBSZW1vdmUgcmVkdW5kYW50IHNldE5l ZWRzQ29tbWl0IHdoZW4gcHJlcGFyZVRvRHJhdyBmYWlscwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSW5wdXRFdmVudC5oIGIvU291cmNlL1dlYktpdC9jaHJv bWl1bS9wdWJsaWMvV2ViSW5wdXRFdmVudC5oCmluZGV4IGZkOTc3NDZiMjI3MTBjNTRiNzgwYTI0 ZTZjYTEwZmRkZTQwMmY2NjguLjY0MTBlYmVlOWUwMDg5MmRjZDJkN2NlOTJiYTMyMTEwNWVkYmEx YmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklucHV0RXZl bnQuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1dEV2ZW50LmgK QEAgLTM4NSw3ICszODUsNyBAQCBwdWJsaWM6CiAKIGNsYXNzIFdlYlRvdWNoRXZlbnQgOiBwdWJs aWMgV2ViSW5wdXRFdmVudCB7CiBwdWJsaWM6Ci0gICAgZW51bSB7IHRvdWNoZXNMZW5ndGhDYXAg PSA4IH07CisgICAgZW51bSB7IHRvdWNoZXNMZW5ndGhDYXAgPSAxMiB9OwogCiAgICAgdW5zaWdu ZWQgdG91Y2hlc0xlbmd0aDsKICAgICAvLyBMaXN0IG9mIGFsbCB0b3VjaGVzIHdoaWNoIGFyZSBj dXJyZW50bHkgZG93bi4K 146599 2012-06-08 10:39:29 -0700 2012-06-20 06:12:10 -0700 Patch bug-88359-20120608133928.patch text/plain 1390 rjkroege U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NzI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDU1NTg4ZDI3ZWMxNjYzNTg3ZGFlMmFkNGViMjQ1NTQ1OTY3ODY1NGEuLjIwOGVhYjhlZjAyZjFh MzNkYTVhNWY0YTI0NzU1YjljYzI3MGFkZmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTItMDYtMDUgIFJvYmVydCBLcm9lZ2VyICA8cmprcm9lZ2VAY2hy b21pdW0ub3JnPgorCisgICAgICAgIE1vcmUgdGhhbiA4IGZpbmdlcnMgZ2V0IGlnbm9yZWQgYnkg dG91Y2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4 MzU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSmFtZXMgUm9iaW5zb24uCisKKyAgICAgICAgKiBw dWJsaWMvV2ViSW5wdXRFdmVudC5oOiBJbmNyZWFzZSBvZiBUb3VjaFBvaW50cyBwZXIgVG91Y2hF dmVudCBmcm9tIDggdG8gMTIuCisKIDIwMTItMDYtMDYgIERhbmEgSmFuc2VucyAgPGRhbmFrakBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBJbiBlYWNoIGNvbXBvc2l0ZWQgZnJh bWUsIGRpZERyYXcoKSBzaG91bGQgb25seSBiZSBjYWxsZWQgb24gbGF5ZXJzIGZvciB3aGljaCB3 aWxsRHJhdygpIHdhcyBjYWxsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v cHVibGljL1dlYklucHV0RXZlbnQuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dl YklucHV0RXZlbnQuaAppbmRleCBmZDk3NzQ2YjIyNzEwYzU0Yjc4MGEyNGU2Y2ExMGZkZGU0MDJm NjY4Li4xYjZjYTdkNzVlMzczNTNlZDc4NzIyODgwNTY2NGUyMWQ2MDE2M2M2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1dEV2ZW50LmgKKysrIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSW5wdXRFdmVudC5oCkBAIC0zODUsNyArMzg1 LDkgQEAgcHVibGljOgogCiBjbGFzcyBXZWJUb3VjaEV2ZW50IDogcHVibGljIFdlYklucHV0RXZl bnQgewogcHVibGljOgotICAgIGVudW0geyB0b3VjaGVzTGVuZ3RoQ2FwID0gOCB9OworICAgIC8v IE1heGltdW0gbnVtYmVyIG9mIHNpbXVsdGFuZW91cyB0b3VjaGVzIHN1cHBvcnRlZCBvbgorICAg IC8vIEFzaC9BdXJhLgorICAgIGVudW0geyB0b3VjaGVzTGVuZ3RoQ2FwID0gMTIgfTsKIAogICAg IHVuc2lnbmVkIHRvdWNoZXNMZW5ndGg7CiAgICAgLy8gTGlzdCBvZiBhbGwgdG91Y2hlcyB3aGlj aCBhcmUgY3VycmVudGx5IGRvd24uCg==