88353 2012-06-05 11:52:42 -0700 Delete dead code from RenderBox::computeLogicalWidthInRegion 2012-06-05 12:17:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan eric hyatt jchaffraix mitz tony webkit.review.bot oldest_to_newest 641779 0 ojan 2012-06-05 11:52:42 -0700 Delete dead code from RenderBox::computeLogicalWidthInRegion 641780 1 145850 ojan 2012-06-05 11:53:13 -0700 Created attachment 145850 Patch 641785 2 145850 tony 2012-06-05 11:57:31 -0700 Comment on attachment 145850 Patch Seems fine, but can you cc the original author? Maybe they have a plan for this or know of some bug caused by not using this variable? 641792 3 ojan 2012-06-05 12:10:21 -0700 The usage of this variable was removed in http://trac.webkit.org/changeset/113885. Looks like it was just an oversight. 641799 4 ojan 2012-06-05 12:17:07 -0700 Committed r119513: <http://trac.webkit.org/changeset/119513> 145850 2012-06-05 11:53:13 -0700 2012-06-05 11:57:31 -0700 Patch bug-88353-20120605115312.patch text/plain 2523 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTNkMDQ4NTllMDI0NWEw ODE3OGFmNzM3ZWExMmVhNmQyM2Q2ZWIzMS4uMDk1YmJiODg2NzgzZGJiMDAzNWM0OTlhYTI2MDk0 Mzk2NzJlM2M0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA2LTA1ICBPamFu IFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRGVsZXRlIGRlYWQgY29kZSBm cm9tIFJlbmRlckJveDo6Y29tcHV0ZUxvZ2ljYWxXaWR0aEluUmVnaW9uCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODM1MworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBvYnZpb3VzbHkg c2luY2UgdGhpcyBpcyBkZWFkIGNvZGUuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJveDo6Y29tcHV0ZUxvZ2ljYWxXaWR0aElu UmVnaW9uKToKKwogMjAxMi0wNi0wNSAgR3JlZyBCaWxsb2NrICA8Z2JpbGxvY2tAZ29vZ2xlLmNv bT4KIAogICAgICAgICBOZXcgY29uc3RydWN0b3IgZm9yIFdlYkludGVudCB0byBiZSB1c2VkIGZv ciBkZWxpdmVyeQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJv eC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAppbmRleCBhZjE2 MjE1NzBlYzhiODgzYjZkNjRlM2FjNGVkYzA3OThlNWZiZDZlLi5iNWRhMGZhNTU5ZTg3OWNhM2Jl ZDg4MzU3MTg5YmM1N2MwZWNiMzIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyQm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94 LmNwcApAQCAtMTY4OSwyNSArMTY4OSwxOSBAQCB2b2lkIFJlbmRlckJveDo6Y29tcHV0ZUxvZ2lj YWxXaWR0aEluUmVnaW9uKFJlbmRlclJlZ2lvbiogcmVnaW9uLCBMYXlvdXRVbml0IG9mZgogICAg ICAgICAvLyBDYWxjdWxhdGUgTWF4TG9naWNhbFdpZHRoCiAgICAgICAgIGlmICghc3R5bGVUb1Vz ZS0+bG9naWNhbE1heFdpZHRoKCkuaXNVbmRlZmluZWQoKSkgewogICAgICAgICAgICAgTGF5b3V0 VW5pdCBtYXhMb2dpY2FsV2lkdGggPSBjb21wdXRlTG9naWNhbFdpZHRoSW5SZWdpb25Vc2luZyhN YXhMb2dpY2FsV2lkdGgsIGNvbnRhaW5lcldpZHRoSW5JbmxpbmVEaXJlY3Rpb24sIGNiLCByZWdp b24sIG9mZnNldEZyb21Mb2dpY2FsVG9wT2ZGaXJzdFBhZ2UpOwotICAgICAgICAgICAgaWYgKGxv Z2ljYWxXaWR0aCgpID4gbWF4TG9naWNhbFdpZHRoKSB7CisgICAgICAgICAgICBpZiAobG9naWNh bFdpZHRoKCkgPiBtYXhMb2dpY2FsV2lkdGgpCiAgICAgICAgICAgICAgICAgc2V0TG9naWNhbFdp ZHRoKG1heExvZ2ljYWxXaWR0aCk7Ci0gICAgICAgICAgICAgICAgbG9naWNhbFdpZHRoTGVuZ3Ro ID0gc3R5bGVUb1VzZS0+bG9naWNhbE1heFdpZHRoKCk7Ci0gICAgICAgICAgICB9CiAgICAgICAg IH0KIAogICAgICAgICAvLyBDYWxjdWxhdGUgTWluTG9naWNhbFdpZHRoCiAgICAgICAgIExheW91 dFVuaXQgbWluTG9naWNhbFdpZHRoID0gY29tcHV0ZUxvZ2ljYWxXaWR0aEluUmVnaW9uVXNpbmco TWluTG9naWNhbFdpZHRoLCBjb250YWluZXJXaWR0aEluSW5saW5lRGlyZWN0aW9uLCBjYiwgcmVn aW9uLCBvZmZzZXRGcm9tTG9naWNhbFRvcE9mRmlyc3RQYWdlKTsKLSAgICAgICAgaWYgKGxvZ2lj YWxXaWR0aCgpIDwgbWluTG9naWNhbFdpZHRoKSB7CisgICAgICAgIGlmIChsb2dpY2FsV2lkdGgo KSA8IG1pbkxvZ2ljYWxXaWR0aCkKICAgICAgICAgICAgIHNldExvZ2ljYWxXaWR0aChtaW5Mb2dp Y2FsV2lkdGgpOwotICAgICAgICAgICAgbG9naWNhbFdpZHRoTGVuZ3RoID0gc3R5bGVUb1VzZS0+ bG9naWNhbE1pbldpZHRoKCk7Ci0gICAgICAgIH0KICAgICB9CiAKICAgICAvLyBGaWVsZHNldHMg YXJlIGN1cnJlbnRseSB0aGUgb25seSBvYmplY3RzIHRoYXQgc3RyZXRjaCB0byB0aGVpciBtaW5p bXVtIHdpZHRoLgotICAgIGlmIChzdHJldGNoZXNUb01pbkludHJpbnNpY0xvZ2ljYWxXaWR0aCgp KSB7CisgICAgaWYgKHN0cmV0Y2hlc1RvTWluSW50cmluc2ljTG9naWNhbFdpZHRoKCkpCiAgICAg ICAgIHNldExvZ2ljYWxXaWR0aChtYXgobG9naWNhbFdpZHRoKCksIG1pblByZWZlcnJlZExvZ2lj YWxXaWR0aCgpKSk7Ci0gICAgICAgIGxvZ2ljYWxXaWR0aExlbmd0aCA9IExlbmd0aChsb2dpY2Fs V2lkdGgoKSwgRml4ZWQpOwotICAgIH0KIAogICAgIC8vIE1hcmdpbiBjYWxjdWxhdGlvbnMuCiAg ICAgaWYgKGhhc1BlcnBlbmRpY3VsYXJDb250YWluaW5nQmxvY2sgfHwgaXNGbG9hdGluZygpIHx8 IGlzSW5saW5lKCkpIHsK