88352 2012-06-05 11:29:49 -0700 Web Inspector: help/settings screen does not overlay console in split screen mode 2012-06-06 03:48:13 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq eustas.bug apavlov bweinstein eustas.bug joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 641758 0 caseq 2012-06-05 11:29:49 -0700 1. Open Web Inspector 2. Switch to any panel other than Console 3. Press Esc to enable split-screen mode with console at the bottom 4. Press Settings cog in the bottom right corner 5. Reduce height of inspector window if necessary Help/Settings screen used to float on top of the console. Now it fits the upper panel. 642218 1 145943 eustas.bug 2012-06-05 23:35:17 -0700 Created attachment 145943 Patch 642223 2 webkit.review.bot 2012-06-05 23:38:19 -0700 Attachment 145943 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 642277 3 145943 caseq 2012-06-06 01:27:47 -0700 Comment on attachment 145943 Patch LGTM 642287 4 145943 pfeldman 2012-06-06 01:52:30 -0700 Comment on attachment 145943 Patch Please fix the ChangeLog prior to landing. 642341 5 145982 eustas.bug 2012-06-06 03:36:20 -0700 Created attachment 145982 Patch 642343 6 caseq 2012-06-06 03:42:18 -0700 Committed r119581: <http://trac.webkit.org/changeset/119581> 642347 7 145982 vsevik 2012-06-06 03:48:13 -0700 Comment on attachment 145982 Patch Clearing r? 145943 2012-06-05 23:35:17 -0700 2012-06-06 03:36:13 -0700 Patch bug-88352-20120606103516.patch text/plain 2492 eustas.bug U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODZmNGY0NzUzMjBkNjJh Nzc0Yzc2Mjk5MjAxNGE5YzNhM2JmYWVmNy4uNzcyZDc0ZmQwZDUxNTIzNzExNjhiNjY5NDcxY2Zi MjBmMDU2YWRiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA2LTA1ICBFdWdl bmUgS2x5dWNobmlrb3YgIDxldXN0YXMuYnVnQGdtYWlsLmNvbT4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBoZWxwL3NldHRpbmdzIHNjcmVlbiBkb2VzIG5vdCBvdmVybGF5IGNvbnNvbGUgaW4g c3BsaXQgc2NyZWVuIG1vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTg4MzUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLiAoT09QUyEpCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJv bnQtZW5kL0hlbHBTY3JlZW4uanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSGVscFNjcmVlbik6 IE1hcmsgdmlldyBhcyByb290LgorICAgICAgICAoV2ViSW5zcGVjdG9yLkhlbHBTY3JlZW4ucHJv dG90eXBlLnNob3dNb2RhbCk6IENoYW5nZSB2aWV3IHBhcmVudC4KKyAgICAgICAgKiBpbnNwZWN0 b3IvZnJvbnQtZW5kL2hlbHBTY3JlZW4uY3NzOgorICAgICAgICAoLmhlbHAtd2luZG93LW91dGVy KTogQWRkIHBhbmVsIGFuZCBzdGF0dXMgYmFyIGluZGVudC4KKyAgICAgICAgKGJvZHkuY29tcGFj dCAuaGVscC13aW5kb3ctb3V0ZXIpOiBEaXR0by4KKwogMjAxMi0wNi0wNSAgUnlvc3VrZSBOaXdh ICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBCdWlsZCBmaXggYWZ0ZXIgcjExOTUyNy4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSGVscFNjcmVl bi5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSGVscFNjcmVlbi5qcwpp bmRleCA1MmNkMzhjZmNiN2QwODU5NDhhNmFhNGEzZTU3YWNhYzkzOTliNGE0Li4wODU1YTEyNjk3 M2UwMjZiNjcwMGIzNmQzYjEwMDg5MjIzNzdjMTQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlbHBTY3JlZW4uanMKKysrIGIvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9IZWxwU2NyZWVuLmpzCkBAIC0zNiw2ICszNiw3IEBACiBXZWJJ bnNwZWN0b3IuSGVscFNjcmVlbiA9IGZ1bmN0aW9uKHRpdGxlKQogewogICAgIFdlYkluc3BlY3Rv ci5WaWV3LmNhbGwodGhpcyk7CisgICAgdGhpcy5tYXJrQXNSb290KCk7CiAgICAgdGhpcy5yZWdp c3RlclJlcXVpcmVkQ1NTKCJoZWxwU2NyZWVuLmNzcyIpOwogCiAgICAgdGhpcy5lbGVtZW50LmNs YXNzTmFtZSA9ICJoZWxwLXdpbmRvdy1vdXRlciI7CkBAIC03Niw3ICs3Nyw3IEBAIFdlYkluc3Bl Y3Rvci5IZWxwU2NyZWVuLnByb3RvdHlwZSA9IHsKICAgICAgICAgaWYgKHZpc2libGVIZWxwU2Ny ZWVuKQogICAgICAgICAgICAgdmlzaWJsZUhlbHBTY3JlZW4uaGlkZSgpOwogICAgICAgICBXZWJJ bnNwZWN0b3IuSGVscFNjcmVlbi5fdmlzaWJsZVNjcmVlbiA9IHRoaXM7Ci0gICAgICAgIHRoaXMu c2hvdyhXZWJJbnNwZWN0b3IuaW5zcGVjdG9yVmlldy5lbGVtZW50KTsKKyAgICAgICAgdGhpcy5z aG93KGRvY3VtZW50LmJvZHkpOwogICAgICAgICB0aGlzLmZvY3VzKCk7CiAgICAgfSwKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9oZWxwU2NyZWVuLmNz cyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaGVscFNjcmVlbi5jc3MKaW5k ZXggYjFhNWQ0NjIxYWQ2NjYxNTAwODdhNGY3NDgzNzU1ZTU1OWRmMzU3My4uNGQ2YjU4MzQ2M2I3 ZjExNWYxMzdiMDE0OGRhYWRjNDY2YjQwNWY4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9oZWxwU2NyZWVuLmNzcworKysgYi9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL2hlbHBTY3JlZW4uY3NzCkBAIC0xLDE3ICsxLDE3IEBACiAuaGVs cC13aW5kb3ctb3V0ZXIgewogICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKLSAgICB0b3A6IDEycHg7 CisgICAgdG9wOiA2NHB4OwogICAgIGxlZnQ6IDUlOwogICAgIHdpZHRoOiA5MCU7Ci0gICAgYm90 dG9tOiAxMnB4OworICAgIGJvdHRvbTogMzJweDsKICAgICB6LWluZGV4OiAyMDAwOwogfQogCiBi b2R5LmNvbXBhY3QgLmhlbHAtd2luZG93LW91dGVyIHsKLSAgICB0b3A6IDA7CisgICAgdG9wOiAz NHB4OwogICAgIGxlZnQ6IDA7CiAgICAgd2lkdGg6IDEwMCU7Ci0gICAgYm90dG9tOiAwOworICAg IGJvdHRvbTogMjNweDsKIH0KIAogLmhlbHAtd2luZG93LW1haW4gewo= 145982 2012-06-06 03:36:20 -0700 2012-06-06 03:48:13 -0700 Patch bug-88352-20120606143619.patch text/plain 2562 eustas.bug U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODkxN2NhOTQ3Yzg4ZWI4 ZWRiZTZjNmU1OGEwZThmMDAyNjBkOGM5OS4uZDBkMThhYTQ1NTU4OGJjMTRjMjQyMmI0Njk2MTBi NmRkYmQyZTNjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTA2ICBFdWdl bmUgS2x5dWNobmlrb3YgIDxldXN0YXMuYnVnQGdtYWlsLmNvbT4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBoZWxwL3NldHRpbmdzIHNjcmVlbiBkb2VzIG5vdCBvdmVybGF5IGNvbnNvbGUgaW4g c3BsaXQgc2NyZWVuIG1vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTg4MzUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0hlbHBTY3JlZW4uanM6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuSGVscFNjcmVlbik6IE1hcmsgdmlldyBhcyByb290LgorICAgICAgICAoV2Vi SW5zcGVjdG9yLkhlbHBTY3JlZW4ucHJvdG90eXBlLnNob3dNb2RhbCk6IENoYW5nZSB2aWV3IHBh cmVudC4KKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL2hlbHBTY3JlZW4uY3NzOgorICAg ICAgICAoLmhlbHAtd2luZG93LW91dGVyKTogQWRkIHBhbmVsIGFuZCBzdGF0dXMgYmFyIGluZGVu dC4KKyAgICAgICAgKGJvZHkuY29tcGFjdCAuaGVscC13aW5kb3ctb3V0ZXIpOiBEaXR0by4KKwog MjAxMi0wNi0wNSAgTWljaGFsIE1vY255ICA8bW1vY255QGdvb2dsZS5jb20+CiAKICAgICAgICAg W2Nocm9taXVtXSBTZXQgZGVmYXVsdCBtZW1vcnkgYWxsb2NhdGlvbiBsaW1pdCBieXRlcyB3aGVu IEdMX0NIUk9NSVVNX2dwdV9tZW1vcnlfbWFuYWdlciBpcyBub3Qgc3VwcG9ydGVkIGJ5IGdyYXBo aWNzIGNvbnRleHQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL0hlbHBTY3JlZW4uanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hl bHBTY3JlZW4uanMKaW5kZXggNTJjZDM4Y2ZjYjdkMDg1OTQ4YTZhYTRhM2U1N2FjYWM5Mzk5YjRh NC4uMDg1NWExMjY5NzNlMDI2YjY3MDBiMzZkM2IxMDA4OTIyMzc3YzE0OCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWxwU2NyZWVuLmpzCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSGVscFNjcmVlbi5qcwpAQCAtMzYsNiAr MzYsNyBAQAogV2ViSW5zcGVjdG9yLkhlbHBTY3JlZW4gPSBmdW5jdGlvbih0aXRsZSkKIHsKICAg ICBXZWJJbnNwZWN0b3IuVmlldy5jYWxsKHRoaXMpOworICAgIHRoaXMubWFya0FzUm9vdCgpOwog ICAgIHRoaXMucmVnaXN0ZXJSZXF1aXJlZENTUygiaGVscFNjcmVlbi5jc3MiKTsKIAogICAgIHRo aXMuZWxlbWVudC5jbGFzc05hbWUgPSAiaGVscC13aW5kb3ctb3V0ZXIiOwpAQCAtNzYsNyArNzcs NyBAQCBXZWJJbnNwZWN0b3IuSGVscFNjcmVlbi5wcm90b3R5cGUgPSB7CiAgICAgICAgIGlmICh2 aXNpYmxlSGVscFNjcmVlbikKICAgICAgICAgICAgIHZpc2libGVIZWxwU2NyZWVuLmhpZGUoKTsK ICAgICAgICAgV2ViSW5zcGVjdG9yLkhlbHBTY3JlZW4uX3Zpc2libGVTY3JlZW4gPSB0aGlzOwot ICAgICAgICB0aGlzLnNob3coV2ViSW5zcGVjdG9yLmluc3BlY3RvclZpZXcuZWxlbWVudCk7Cisg ICAgICAgIHRoaXMuc2hvdyhkb2N1bWVudC5ib2R5KTsKICAgICAgICAgdGhpcy5mb2N1cygpOwog ICAgIH0sCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv aGVscFNjcmVlbi5jc3MgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2hlbHBT Y3JlZW4uY3NzCmluZGV4IGIxYTVkNDYyMWFkNjY2MTUwMDg3YTRmNzQ4Mzc1NWU1NTlkZjM1NzMu LjRkNmI1ODM0NjNiN2YxMTVmMTM3YjAxNDhkYWFkYzQ2NmI0MDVmOGQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaGVscFNjcmVlbi5jc3MKKysrIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9oZWxwU2NyZWVuLmNzcwpAQCAtMSwxNyAr MSwxNyBAQAogLmhlbHAtd2luZG93LW91dGVyIHsKICAgICBwb3NpdGlvbjogYWJzb2x1dGU7Ci0g ICAgdG9wOiAxMnB4OworICAgIHRvcDogNjRweDsKICAgICBsZWZ0OiA1JTsKICAgICB3aWR0aDog OTAlOwotICAgIGJvdHRvbTogMTJweDsKKyAgICBib3R0b206IDMycHg7CiAgICAgei1pbmRleDog MjAwMDsKIH0KIAogYm9keS5jb21wYWN0IC5oZWxwLXdpbmRvdy1vdXRlciB7Ci0gICAgdG9wOiAw OworICAgIHRvcDogMzRweDsKICAgICBsZWZ0OiAwOwogICAgIHdpZHRoOiAxMDAlOwotICAgIGJv dHRvbTogMDsKKyAgICBib3R0b206IDIzcHg7CiB9CiAKIC5oZWxwLXdpbmRvdy1tYWluIHsK