8835 2006-05-10 11:22:50 -0700 REGRESSION: Line moves but selection highlight stays behind 2006-05-13 08:25:27 -0700 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac OS X 10.4 RESOLVED FIXED Regression P1 Normal --- 1 mitz webkit-unassigned oldest_to_newest 41892 0 mitz 2006-05-10 11:22:50 -0700 When a root line box moves vertically during relayout, its vertical selection bounds aren't updated, so the selection highlight is painted in the old position. This is a regression from the fix for bug 7301. The patch I'm going to attach includes a test case. 41893 1 8223 mitz 2006-05-10 11:35:28 -0700 Created attachment 8223 Adjust m_selectionTop and m_selectionBottom 41894 2 8223 darin 2006-05-10 11:41:19 -0700 Comment on attachment 8223 Adjust m_selectionTop and m_selectionBottom r=me 42151 3 darin 2006-05-12 20:19:32 -0700 Committed revision 14347. 42161 4 mitz 2006-05-13 01:13:42 -0700 Not fixed. I'm not sure why render_line.cpp is still around, but the code this patch should modify is now in RootInlineBox.cpp. 42191 5 ap 2006-05-13 08:25:27 -0700 Applied to RootInlineBox.cpp, removed render_line.cpp - r14354 8223 2006-05-10 11:35:28 -0700 2006-05-10 11:41:19 -0700 Adjust m_selectionTop and m_selectionBottom 8835_r1.patch text/plain 6180 mitz SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE0Mjg2KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDYtMDUtIyMgIE1pdHogUGV0dGVsICA8b3Bl bmRhcndpbi5vcmdAbWl0enBldHRlbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgLSBmaXggaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3Jn L3Nob3dfYnVnLmNnaT9pZD04ODM1CisgICAgICAgICAgUkVHUkVTU0lPTjogTGluZSBtb3ZlcyBi dXQgc2VsZWN0aW9uIGhpZ2hsaWdodCBzdGF5cyBiZWhpbmQKKworICAgICAgICAqIGZhc3QvZHlu YW1pYy9zZWxlY3Rpb24taGlnaGxpZ2h0LWFkanVzdC1leHBlY3RlZC5jaGVja3N1bTogQWRkZWQu CisgICAgICAgICogZmFzdC9keW5hbWljL3NlbGVjdGlvbi1oaWdobGlnaHQtYWRqdXN0LWV4cGVj dGVkLnBuZzogQWRkZWQuCisgICAgICAgICogZmFzdC9keW5hbWljL3NlbGVjdGlvbi1oaWdobGln aHQtYWRqdXN0LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9keW5hbWljL3Nl bGVjdGlvbi1oaWdobGlnaHQtYWRqdXN0Lmh0bWw6IEFkZGVkLgorCiAyMDA2LTA1LTEwICBBbGV4 ZXkgUHJvc2t1cnlha292ICA8YXBAbnlwb3AuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFu ZGVycy4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZHluYW1pYy9zZWxlY3Rpb24taGlnaGxpZ2h0 LWFkanVzdC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9keW5h bWljL3NlbGVjdGlvbi1oaWdobGlnaHQtYWRqdXN0LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkK KysrIExheW91dFRlc3RzL2Zhc3QvZHluYW1pYy9zZWxlY3Rpb24taGlnaGxpZ2h0LWFkanVzdC1l eHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMzIgQEAKK0VESVRJTkcgREVMRUdB VEU6IHdlYlZpZXdEaWRDaGFuZ2VTZWxlY3Rpb246V2ViVmlld0RpZENoYW5nZVNlbGVjdGlvbk5v dGlmaWNhdGlvbgorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgIFJlbmRlckNhbnZhcyBh dCAoMCwwKSBzaXplIDgwMHg2MDAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDE1NgorICBSZW5k ZXJCbG9jayB7SFRNTH0gYXQgKDAsMCkgc2l6ZSA4MDB4MTU2CisgICAgUmVuZGVyQm9keSB7Qk9E WX0gYXQgKDgsMTYpIHNpemUgNzg0eDEzMgorICAgICAgUmVuZGVyQmxvY2sge1B9IGF0ICgwLDAp IHNpemUgNzg0eDM2CisgICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXplIDE3 MngxOAorICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDApIHdpZHRoIDE3MjogIlRoaXMgaXMgYSBy ZWdyZXNzaW9uIHRlc3QgZm9yICIKKyAgICAgICAgUmVuZGVySW5saW5lIHtJfSBhdCAoMCwwKSBz aXplIDc4NHgzNgorICAgICAgICAgIFJlbmRlcklubGluZSB7QX0gYXQgKDAsMCkgc2l6ZSAzNDh4 MTggW2NvbG9yPSMwMDAwRUVdCisgICAgICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDE3 MiwwKSBzaXplIDM0OHgxOAorICAgICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMTcyLDApIHdpZHRo IDM0ODogImh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODgz NSIKKyAgICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDUyMCwwKSBzaXplIDc4NHgzNgor ICAgICAgICAgICAgdGV4dCBydW4gYXQgKDUyMCwwKSB3aWR0aCA0OiAiICIKKyAgICAgICAgICAg IHRleHQgcnVuIGF0ICg1MjQsMCkgd2lkdGggMjYwOiAiUkVHUkVTU0lPTjogTGluZSBtb3ZlcyBi dXQgc2VsZWN0aW9uIgorICAgICAgICAgICAgdGV4dCBydW4gYXQgKDAsMTgpIHdpZHRoIDEzODog ImhpZ2hsaWdodCBzdGF5cyBiZWhpbmQiCisgICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAo MTM4LDE4KSBzaXplIDR4MTgKKyAgICAgICAgICB0ZXh0IHJ1biBhdCAoMTM4LDE4KSB3aWR0aCA0 OiAiLiIKKyAgICAgIFJlbmRlckJsb2NrIHtIUn0gYXQgKDAsNTIpIHNpemUgNzg0eDIgW2JvcmRl cjogKDFweCBpbnNldCAjMDAwMDAwKV0KKyAgICAgIFJlbmRlckJsb2NrIHtESVZ9IGF0ICgwLDYy KSBzaXplIDc4NHg3MAorICAgICAgICBSZW5kZXJJbWFnZSB7SU1HfSBhdCAoMCwwKSBzaXplIDB4 MzAKKyAgICAgICAgUmVuZGVyQlIge0JSfSBhdCAoMCwxNikgc2l6ZSAweDE4CisgICAgICAgIFJl bmRlckJSIHtCUn0gYXQgKDAsMzQpIHNpemUgMHgxOAorICAgICAgICBSZW5kZXJJbmxpbmUge1NQ QU59IGF0ICgwLDApIHNpemUgMzA5eDE4CisgICAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0 ICgwLDUyKSBzaXplIDMwOXgxOAorICAgICAgICAgICAgdGV4dCBydW4gYXQgKDAsNTIpIHdpZHRo IDMwOTogIlRoZSBoaWdobGlnaHQgc2hvdWxkIGJlIG9uIHRoaXMgbGluZSwgbm90IGFib3ZlIGl0 LiIKKyAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgzMDksNTIpIHNpemUgNHgxOAorICAg ICAgICAgIHRleHQgcnVuIGF0ICgzMDksNTIpIHdpZHRoIDQ6ICIgIgorICAgICAgICBSZW5kZXJC UiB7QlJ9IGF0ICgzMTMsNTIpIHNpemUgMHgxOAorc2VsZWN0aW9uIHN0YXJ0OiBwb3NpdGlvbiAw IG9mIGNoaWxkIDAgeyN0ZXh0fSBvZiBjaGlsZCA2IHtTUEFOfSBvZiBjaGlsZCA1IHtESVZ9IG9m IGNoaWxkIDEge0JPRFl9IG9mIGNoaWxkIDAge0hUTUx9IG9mIGRvY3VtZW50CitzZWxlY3Rpb24g ZW5kOiAgIHBvc2l0aW9uIDUxIG9mIGNoaWxkIDAgeyN0ZXh0fSBvZiBjaGlsZCA2IHtTUEFOfSBv ZiBjaGlsZCA1IHtESVZ9IG9mIGNoaWxkIDEge0JPRFl9IG9mIGNoaWxkIDAge0hUTUx9IG9mIGRv Y3VtZW50CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2R5bmFtaWMvc2VsZWN0aW9uLWhpZ2hsaWdo dC1hZGp1c3QuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2R5bmFtaWMvc2Vs ZWN0aW9uLWhpZ2hsaWdodC1hZGp1c3QuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3Rz L2Zhc3QvZHluYW1pYy9zZWxlY3Rpb24taGlnaGxpZ2h0LWFkanVzdC5odG1sCShyZXZpc2lvbiAw KQpAQCAtMCwwICsxLDI4IEBACis8IURPQ1RZUEUgSFRNTD4KKzxodG1sPgorPGhlYWQ+CisgICAg PHRpdGxlPjwvdGl0bGU+CisgICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgorICAg ICAgICBmdW5jdGlvbiB0ZXN0KCkKKyAgICAgICAgeworICAgICAgICAgICAgdmFyIHNwYW4gPSBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgnc3BhbicpOworICAgICAgICAgICAgd2luZG93LmdldFNl bGVjdGlvbigpLnNldEJhc2VBbmRFeHRlbnQoc3BhbiwgMCwgc3BhbiwgMSk7CisgICAgICAgICAg ICB2YXIgaW1hZ2UgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnaW1hZ2UnKTsKKyAgICAgICAg ICAgIGltYWdlLnN0eWxlLmhlaWdodCA9ICIzMHB4IjsKKyAgICAgICAgfQorICAgIDwvc2NyaXB0 PgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSJ0ZXN0KCkiPgorPHA+CisgICAgVGhpcyBpcyBhIHJl Z3Jlc3Npb24gdGVzdCBmb3IgPGk+PGEgaHJlZj0iaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4u b3JnL3Nob3dfYnVnLmNnaT9pZD04ODM1Ij5odHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcv c2hvd19idWcuY2dpP2lkPTg4MzU8L2E+CisgICAgUkVHUkVTU0lPTjogTGluZSBtb3ZlcyBidXQg c2VsZWN0aW9uIGhpZ2hsaWdodCBzdGF5cyBiZWhpbmQ8L2k+LgorPC9wPgorPGhyPgorPGRpdj4K KzxpbWcgc3R5bGU9ImhlaWdodDogMnB4OyIgaWQ9ImltYWdlIj48YnI+Cis8YnI+Cis8c3BhbiBp ZD0ic3BhbiI+VGhlIGhpZ2hsaWdodCBzaG91bGQgYmUgb24gdGhpcyBsaW5lLCBub3QgYWJvdmUg aXQuPC9zcGFuPgorPGJyPgorPC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+CkluZGV4OiBMYXlvdXRU ZXN0cy9mYXN0L2R5bmFtaWMvc2VsZWN0aW9uLWhpZ2hsaWdodC1hZGp1c3QtZXhwZWN0ZWQucG5n Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KQ2Fubm90IGRpc3BsYXk6IGZpbGUgbWFya2VkIGFzIGEgYmluYXJ5IHR5cGUu CnN2bjptaW1lLXR5cGUgPSBhcHBsaWNhdGlvbi9vY3RldC1zdHJlYW0KClByb3BlcnR5IGNoYW5n ZXMgb246IHNlbGVjdGlvbi1oaWdobGlnaHQtYWRqdXN0LWV4cGVjdGVkLnBuZwpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Ck5hbWU6IHN2bjptaW1lLXR5cGUKICAgKyBhcHBsaWNhdGlvbi9vY3RldC1zdHJlYW0KCkluZGV4 OiBMYXlvdXRUZXN0cy9mYXN0L2R5bmFtaWMvc2VsZWN0aW9uLWhpZ2hsaWdodC1hZGp1c3QtZXhw ZWN0ZWQuY2hlY2tzdW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9keW5hbWljL3Nl bGVjdGlvbi1oaWdobGlnaHQtYWRqdXN0LWV4cGVjdGVkLmNoZWNrc3VtCShyZXZpc2lvbiAwKQor KysgTGF5b3V0VGVzdHMvZmFzdC9keW5hbWljL3NlbGVjdGlvbi1oaWdobGlnaHQtYWRqdXN0LWV4 cGVjdGVkLmNoZWNrc3VtCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxIEBACitlNTZjNjhkOTJhY2E0 N2JiN2ZiMTM2NTk4M2ZiNTM5MApcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKSW5kZXg6IFdl YkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lv biAxNDI4NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEs MTYgQEAKKzIwMDYtMDUtIyMgIE1pdHogUGV0dGVsICA8b3BlbmRhcndpbi5vcmdAbWl0enBldHRl bC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg LSBmaXggaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD04ODM1 CisgICAgICAgICAgUkVHUkVTU0lPTjogTGluZSBtb3ZlcyBidXQgc2VsZWN0aW9uIGhpZ2hsaWdo dCBzdGF5cyBiZWhpbmQKKworICAgICAgICBUZXN0OiBmYXN0L2R5bmFtaWMvc2VsZWN0aW9uLWhp Z2hsaWdodC1hZGp1c3QuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL3JlbmRlcl9saW5lLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJvb3RJbmxpbmVCb3g6OmFkanVzdFBvc2l0aW9uKTogQWRq dXN0IG1fc2VsZWN0aW9uVG9wCisgICAgICAgIGFuZCBtX3NlbGVjdGlvbkJvdHRvbS4KKwogMjAw Ni0wNS0xMCAgRGF2aWQgQ2Fyc29uIDxkYWNhcnNvbkBnbWFpbC5jb20+CiAKICAgICAgICAgLSBG aXggZm9yIGJ1ZyA4ODMzLiBSZW1vdmVkIGlubGluZSBrZXl3b3JkIGZyb20gZnVuY3Rpb25zIGRl Y2xhcmVkCkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9yZW5kZXJfbGluZS5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvcmVuZGVyX2xpbmUuY3BwCShyZXZpc2lvbiAxNDI4NCkK KysrIFdlYkNvcmUvcmVuZGVyaW5nL3JlbmRlcl9saW5lLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MTIxNSw2ICsxMjE1LDggQEAgdm9pZCBSb290SW5saW5lQm94OjphZGp1c3RQb3NpdGlvbihpbnQg ZAogICAgIG1fdG9wT3ZlcmZsb3cgKz0gZHk7CiAgICAgbV9ib3R0b21PdmVyZmxvdyArPSBkeTsK ICAgICBtX2Jsb2NrSGVpZ2h0ICs9IGR5OworICAgIG1fc2VsZWN0aW9uVG9wICs9IGR5OworICAg IG1fc2VsZWN0aW9uQm90dG9tICs9IGR5OwogfQogCiB2b2lkIFJvb3RJbmxpbmVCb3g6OmNoaWxk UmVtb3ZlZChJbmxpbmVCb3gqIGJveCkK