88342 2012-06-05 10:15:24 -0700 [BlackBerry]Differentiate options and group options by TypeOption and TypeOptionInGroup 2012-06-05 18:58:21 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 haizhang webkit-unassigned tonikitoo webkit.review.bot oldest_to_newest 641677 0 haizhang 2012-06-05 10:15:24 -0700 We set all options' type as TypeOption, which can't tell if an option belongs to a group, introduce TypeOptionInGroup to fix it. 641694 1 145833 haizhang 2012-06-05 10:32:03 -0700 Created attachment 145833 patch 641697 2 145833 rwlbuis 2012-06-05 10:35:40 -0700 Comment on attachment 145833 patch Please add PR number, Also not webkit style. 641703 3 145836 haizhang 2012-06-05 10:45:24 -0700 Created attachment 145836 updated patch 641709 4 145836 rwlbuis 2012-06-05 10:48:03 -0700 Comment on attachment 145836 updated patch LGTM. 641740 5 145836 buildbot 2012-06-05 11:19:59 -0700 Comment on attachment 145836 updated patch Attachment 145836 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12892702 642092 6 145836 webkit.review.bot 2012-06-05 18:58:14 -0700 Comment on attachment 145836 updated patch Clearing flags on attachment: 145836 Committed r119549: <http://trac.webkit.org/changeset/119549> 642093 7 webkit.review.bot 2012-06-05 18:58:21 -0700 All reviewed patches have been landed. Closing bug. 145833 2012-06-05 10:32:03 -0700 2012-06-05 10:45:24 -0700 patch 0001-2012-06-05-Crystal-Zhang-haizhang-rim.com.patch text/plain 2500 haizhang RnJvbSAyNzEyYTQ0NGYwZDMwMTg3ZjNjNWFmMjNiZjI0ZDRlMmJhNjM1YzBmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDcnlzdGFsIFpoYW5nIDxoYWl6aGFuZ0ByaW0uY29tPgpEYXRl OiBUdWUsIDUgSnVuIDIwMTIgMTM6MzA6NTUgLTA0MDAKU3ViamVjdDogW1BBVENIXSAyMDEyLTA2 LTA1ICBDcnlzdGFsIFpoYW5nICA8aGFpemhhbmdAcmltLmNvbT4KCiAgICAgICAgW0JsYWNrQmVy cnldRGlmZmVyZW50aWF0ZSBvcHRpb25zIGFuZCBncm91cCBvcHRpb25zIGJ5IFR5cGVPcHRpb24g YW5kIFR5cGVPcHRpb25Jbkdyb3VwCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTg4MzQyCgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoK ICAgICAgICAqIFdlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcDoKICAgICAgICAoQmxhY2tC ZXJyeTo6V2ViS2l0OjpJbnB1dEhhbmRsZXI6Om9wZW5TZWxlY3RQb3B1cCk6Ci0tLQogU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICB8ICAgMTMg KysrKysrKysrKysrKwogU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5w dXRIYW5kbGVyLmNwcCB8ICAgIDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IGU3NjY5 ZGIuLmE1YTBkZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTA2LTA1ICBDcnlzdGFsIFpoYW5nICA8aGFpemhhbmdAcmltLmNvbT4KKworICAg ICAgICBbQmxhY2tCZXJyeV1EaWZmZXJlbnRpYXRlIG9wdGlvbnMgYW5kIGdyb3VwIG9wdGlvbnMg YnkgVHlwZU9wdGlvbiBhbmQgVHlwZU9wdGlvbkluR3JvdXAKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4MzQyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ugc2V0IGFsbCBvcHRpb25zJyB0eXBlIHRvIFR5 cGVPcHRpb24sIHdoaWNoIGNhbid0IHRlbGwgaWYgYW4gb3B0aW9uIGJlbG9uZ3MgdG8gYSBncm91 cCwgCisgICAgICAgIGludHJvZHVjZSBUeXBlT3B0aW9uSW5Hcm91cCB0byBmaXggaXQuCisKKyAg ICAgICAgKiBXZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHA6CisgICAgICAgIChCbGFja0Jl cnJ5OjpXZWJLaXQ6OklucHV0SGFuZGxlcjo6b3BlblNlbGVjdFBvcHVwKToKKwogMjAxMi0wNi0w NSAgS29ucmFkIFBpYXNjaWsgIDxrcGlhc2Npa0ByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0Jl cnJ5XVdlYiBJbnNwZWN0b3IgaGlnaGxpZ2h0IGlzIHNsb3cKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwCmluZGV4IDVk NTkwNmMuLjA4OTkxZmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJL aXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcApAQCAtMTE1OCw3ICsxMTU4LDcgQEAgYm9v bCBJbnB1dEhhbmRsZXI6Om9wZW5TZWxlY3RQb3B1cChIVE1MU2VsZWN0RWxlbWVudCogc2VsZWN0 KQogICAgICAgICAgICAgICAgIGxhYmVsc1tpXSA9IG9wdGlvbi0+dGV4dEluZGVudGVkVG9SZXNw ZWN0R3JvdXBMYWJlbCgpOwogICAgICAgICAgICAgICAgIGVuYWJsZWRzW2ldID0gb3B0aW9uLT5k aXNhYmxlZCgpID8gMCA6IDE7CiAgICAgICAgICAgICAgICAgc2VsZWN0ZWRzW2ldID0gb3B0aW9u LT5zZWxlY3RlZCgpOwotICAgICAgICAgICAgICAgIGl0ZW1UeXBlc1tpXSA9IFR5cGVPcHRpb247 CisgICAgICAgICAgICAgICAgaXRlbVR5cGVzW2ldID0gb3B0aW9uLT5wYXJlbnROb2RlKCkgJiYg b3B0aW9uLT5wYXJlbnROb2RlKCktPmhhc1RhZ05hbWUoSFRNTE5hbWVzOjpvcHRncm91cFRhZyk/ IFR5cGVPcHRpb25Jbkdyb3VwOiBUeXBlT3B0aW9uOwogICAgICAgICAgICAgfSBlbHNlIGlmIChs aXN0SXRlbXNbaV0tPmhhc1RhZ05hbWUoSFRNTE5hbWVzOjpvcHRncm91cFRhZykpIHsKICAgICAg ICAgICAgICAgICBIVE1MT3B0R3JvdXBFbGVtZW50KiBvcHRHcm91cCA9IHN0YXRpY19jYXN0PEhU TUxPcHRHcm91cEVsZW1lbnQqPihsaXN0SXRlbXNbaV0pOwogICAgICAgICAgICAgICAgIGxhYmVs c1tpXSA9IG9wdEdyb3VwLT5ncm91cExhYmVsVGV4dCgpOwotLSAKMS43LjEwLjEKCg== 145836 2012-06-05 10:45:24 -0700 2012-06-05 18:58:14 -0700 updated patch 0001-2012-06-05-Crystal-Zhang-haizhang-rim.com.patch text/plain 2575 haizhang RnJvbSA1NTc3ZDgxYTlhYTIzYzM5OTBhNmFlZDk0ZjIzYTkwNjY3MmY2NWIwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDcnlzdGFsIFpoYW5nIDxoYWl6aGFuZ0ByaW0uY29tPgpEYXRl OiBUdWUsIDUgSnVuIDIwMTIgMTM6MzA6NTUgLTA0MDAKU3ViamVjdDogW1BBVENIXSAyMDEyLTA2 LTA1ICBDcnlzdGFsIFpoYW5nICA8aGFpemhhbmdAcmltLmNvbT4KCiAgICAgICAgW0JsYWNrQmVy cnldRGlmZmVyZW50aWF0ZSBvcHRpb25zIGFuZCBncm91cCBvcHRpb25zIGJ5IFR5cGVPcHRpb24g YW5kIFR5cGVPcHRpb25Jbkdyb3VwCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTg4MzQyCgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoK ICAgICAgICAqIFdlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcDoKICAgICAgICAoQmxhY2tC ZXJyeTo6V2ViS2l0OjpJbnB1dEhhbmRsZXI6Om9wZW5TZWxlY3RQb3B1cCk6Ci0tLQogU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgfCAgIDE3ICsr KysrKysrKysrKysrKysrCiAuLi4vV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1 dEhhbmRsZXIuY3BwICB8ICAgIDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IGU3NjY5 ZGIuLjQ5MzQ4YWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDEyLTA2LTA1ICBDcnlzdGFsIFpoYW5nICA8aGFpemhhbmdAcmltLmNvbT4KKworICAg ICAgICBbQmxhY2tCZXJyeV1EaWZmZXJlbnRpYXRlIG9wdGlvbnMgYW5kIGdyb3VwIG9wdGlvbnMg YnkgVHlwZU9wdGlvbiBhbmQgVHlwZU9wdGlvbkluR3JvdXAKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4MzQyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUklNIFBSOiAxNjMxNDEKKworICAgICAgICBSZXZp ZXdlZCBpbnRlcm5hbGx5IGJ5IE1pa2UgRmVudG9uLgorCisgICAgICAgIFdlIHNldCBhbGwgb3B0 aW9ucycgdHlwZSB0byBUeXBlT3B0aW9uLCB3aGljaCBjYW4ndCB0ZWxsIGlmIGFuIG9wdGlvbiBi ZWxvbmdzIHRvIGEgZ3JvdXAsIAorICAgICAgICBpbnRyb2R1Y2UgVHlwZU9wdGlvbkluR3JvdXAg dG8gZml4IGl0LgorCisgICAgICAgICogV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwOgor ICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpJbnB1dEhhbmRsZXI6Om9wZW5TZWxlY3RQb3B1 cCk6CisKIDIwMTItMDYtMDUgIEtvbnJhZCBQaWFzY2lrICA8a3BpYXNjaWtAcmltLmNvbT4KIAog ICAgICAgICBbQmxhY2tCZXJyeV1XZWIgSW5zcGVjdG9yIGhpZ2hsaWdodCBpcyBzbG93CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRs ZXIuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5k bGVyLmNwcAppbmRleCA1ZDU5MDZjLi45NWI5N2IyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAKQEAgLTExNTgs NyArMTE1OCw3IEBAIGJvb2wgSW5wdXRIYW5kbGVyOjpvcGVuU2VsZWN0UG9wdXAoSFRNTFNlbGVj dEVsZW1lbnQqIHNlbGVjdCkKICAgICAgICAgICAgICAgICBsYWJlbHNbaV0gPSBvcHRpb24tPnRl eHRJbmRlbnRlZFRvUmVzcGVjdEdyb3VwTGFiZWwoKTsKICAgICAgICAgICAgICAgICBlbmFibGVk c1tpXSA9IG9wdGlvbi0+ZGlzYWJsZWQoKSA/IDAgOiAxOwogICAgICAgICAgICAgICAgIHNlbGVj dGVkc1tpXSA9IG9wdGlvbi0+c2VsZWN0ZWQoKTsKLSAgICAgICAgICAgICAgICBpdGVtVHlwZXNb aV0gPSBUeXBlT3B0aW9uOworICAgICAgICAgICAgICAgIGl0ZW1UeXBlc1tpXSA9IG9wdGlvbi0+ cGFyZW50Tm9kZSgpICYmIG9wdGlvbi0+cGFyZW50Tm9kZSgpLT5oYXNUYWdOYW1lKEhUTUxOYW1l czo6b3B0Z3JvdXBUYWcpID8gVHlwZU9wdGlvbkluR3JvdXAgOiBUeXBlT3B0aW9uOwogICAgICAg ICAgICAgfSBlbHNlIGlmIChsaXN0SXRlbXNbaV0tPmhhc1RhZ05hbWUoSFRNTE5hbWVzOjpvcHRn cm91cFRhZykpIHsKICAgICAgICAgICAgICAgICBIVE1MT3B0R3JvdXBFbGVtZW50KiBvcHRHcm91 cCA9IHN0YXRpY19jYXN0PEhUTUxPcHRHcm91cEVsZW1lbnQqPihsaXN0SXRlbXNbaV0pOwogICAg ICAgICAgICAgICAgIGxhYmVsc1tpXSA9IG9wdEdyb3VwLT5ncm91cExhYmVsVGV4dCgpOwotLSAK MS43LjEwLjEKCg==