88331 2012-06-05 08:09:38 -0700 [BlackBerry]Web Inspector highlight is slow 2012-06-05 09:24:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kpiascik kpiascik anilsson webkit.review.bot oldest_to_newest 641561 0 kpiascik 2012-06-05 08:09:38 -0700 [BlackBerry]Web Inspector highlight is slow 641567 1 145800 kpiascik 2012-06-05 08:12:44 -0700 Created attachment 145800 Patch 641574 2 anilsson 2012-06-05 08:15:29 -0700 Looks good to me, internal review: R+ 641575 3 145800 rwlbuis 2012-06-05 08:15:46 -0700 Comment on attachment 145800 Patch LGTM. 641636 4 145800 webkit.review.bot 2012-06-05 09:23:58 -0700 Comment on attachment 145800 Patch Clearing flags on attachment: 145800 Committed r119496: <http://trac.webkit.org/changeset/119496> 641637 5 webkit.review.bot 2012-06-05 09:24:10 -0700 All reviewed patches have been landed. Closing bug. 145800 2012-06-05 08:12:44 -0700 2012-06-05 09:23:58 -0700 Patch bug-88331-20120605111309.patch text/plain 5286 kpiascik U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MzQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAyMDlmZDVlNzQ4N2Q2OThhYzcwMTkwNTg2MWIwYWVhMDRjMzgxMzQ2Li41NWQ2YzcyODgz ZjE0Y2I0ZTNjZjQ0MGMwZjViZGQxYzY1YThiZjBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMi0wNi0wNSAgS29ucmFkIFBpYXNjaWsgIDxrcGlh c2Npa0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XVdlYiBJbnNwZWN0b3IgaGlnaGxp Z2h0IGlzIHNsb3cKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg4MzMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgSGlnaGxpZ2h0IGlzIHNsb3cgb24gbGFyZ2UgcGFnZXMgYmVjYXVzZSBvZiBjb25zdGFudCBy ZXBhaW50IGNhbGxzLgorICAgICAgICBDaGFuZ2UgdG8gdXNlIHRoZSBhY2NlbGVyYXRlZCBsYXll ciBoaWdobGlnaHQgYWxsIHRoZSB0aW1lLgorCisgICAgICAgICogQXBpL0JhY2tpbmdTdG9yZS5j cHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OkJhY2tpbmdTdG9yZVByaXZhdGU6OnJl bmRlckNvbnRlbnRzKToKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9JbnNwZWN0b3JDbGllbnRC bGFja0JlcnJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckNsaWVudEJsYWNrQmVy cnk6OmhpZ2hsaWdodCk6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDbGllbnRCbGFja0Jl cnJ5OjpoaWRlSGlnaGxpZ2h0KToKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9JbnNwZWN0b3JP dmVybGF5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3Rvck92ZXJsYXk6OmNsZWFyKToK KyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3Rvck92ZXJsYXk6OnVwZGF0ZSk6CisKIDIwMTItMDYt MDEgIEpvbmF0aGFuIERvbmcgIDxqb25hdGhhbi5kb25nQHRvcmNobW9iaWxlLmNvbS5jbj4KIAog ICAgICAgICBbQmxhY2tCZXJyeV0gQWRkIGVuZCBlZGl0aW5nIGhhbmRsaW5nIGludG8gQXV0b2Zp bGxNYW5hZ2VyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0JhY2tp bmdTdG9yZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0JhY2tpbmdTdG9yZS5j cHAKaW5kZXggZWJhZTAyZGI4YWNhZWNjMDkyMWVlZWI2ZTViMzI0NDA1YWRlOWQwNC4uZGRlZWU5 ZmQ2MmFmZWVmYzE3NGY4NDYwMmE2YzQ3YTZkMTk1YTViMyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0FwaS9CYWNraW5nU3RvcmUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlLmNwcApAQCAtMjQ0OCwxNSArMjQ0OCw2IEBAIHZv aWQgQmFja2luZ1N0b3JlUHJpdmF0ZTo6cmVuZGVyQ29udGVudHMoQmxhY2tCZXJyeTo6UGxhdGZv cm06OkdyYXBoaWNzOjpCdWZmZXIqCiAgICAgICAgIC8vIExldCBXZWJDb3JlIHJlbmRlciB0aGUg cGFnZSBjb250ZW50cyBpbnRvIHRoZSBkcmF3aW5nIHN1cmZhY2UuCiAgICAgICAgIG1fY2xpZW50 LT5mcmFtZSgpLT52aWV3KCktPnBhaW50Q29udGVudHMoJmdyYXBoaWNzQ29udGV4dCwgdW50cmFu c2Zvcm1lZENvbnRlbnRzUmVjdCk7CiAKLSNpZiBFTkFCTEUoSU5TUEVDVE9SKQotICAgICAgICBp ZiAobV93ZWJQYWdlLT5kLT5tX3BhZ2UtPmluc3BlY3RvckNvbnRyb2xsZXIoKS0+ZW5hYmxlZCgp KSB7Ci0gICAgICAgICAgICBXZWJDb3JlOjpJbnRQb2ludCBzY3JvbGxQb3NpdGlvbiA9IG1fY2xp ZW50LT5mcmFtZSgpLT52aWV3KCktPnNjcm9sbFBvc2l0aW9uKCk7Ci0gICAgICAgICAgICBncmFw aGljc0NvbnRleHQudHJhbnNsYXRlKHNjcm9sbFBvc2l0aW9uLngoKSwgc2Nyb2xsUG9zaXRpb24u eSgpKTsKLSAgICAgICAgICAgIGlmIChtX3dlYlBhZ2UtPmQtPm1faW5zcGVjdG9yT3ZlcmxheSkK LSAgICAgICAgICAgICAgICBtX3dlYlBhZ2UtPmQtPm1faW5zcGVjdG9yT3ZlcmxheS0+cGFpbnRX ZWJGcmFtZShncmFwaGljc0NvbnRleHQpOwotICAgICAgICB9Ci0jZW5kaWYKLQogICAgICAgICBn cmFwaGljc0NvbnRleHQucmVzdG9yZSgpOwogICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0luc3BlY3RvckNsaWVudEJsYWNrQmVycnku Y3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0luc3BlY3RvckNs aWVudEJsYWNrQmVycnkuY3BwCmluZGV4IDFkZjc3NjQ2MjM0NmM2M2M4ZWM5ZTdlNDljOTIwYzVk YWI3ZTIxZjMuLmRiYjVmMDgwN2FiZmZiYzFjNjY5MDRmYzEyNjRiMjJmMjZiYmYxOTYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9JbnNwZWN0b3JD bGllbnRCbGFja0JlcnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29y ZVN1cHBvcnQvSW5zcGVjdG9yQ2xpZW50QmxhY2tCZXJyeS5jcHAKQEAgLTQ2LDE1ICs0NiwxMSBA QCB2b2lkIEluc3BlY3RvckNsaWVudEJsYWNrQmVycnk6Omluc3BlY3RvckRlc3Ryb3llZCgpCiB2 b2lkIEluc3BlY3RvckNsaWVudEJsYWNrQmVycnk6OmhpZ2hsaWdodCgpCiB7CiAgICAgbV93ZWJQ YWdlUHJpdmF0ZS0+c2V0SW5zcGVjdG9yT3ZlcmxheUNsaWVudCh0aGlzKTsKLSAgICBpZiAoIW1f d2ViUGFnZVByaXZhdGUtPmlzQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0FjdGl2ZSgpKQotICAgICAg ICBtX3dlYlBhZ2VQcml2YXRlLT5tYWluRnJhbWUoKS0+ZG9jdW1lbnQoKS0+ZG9jdW1lbnRFbGVt ZW50KCktPnJlbmRlcmVyKCktPnJlcGFpbnQodHJ1ZSk7CiB9CiAKIHZvaWQgSW5zcGVjdG9yQ2xp ZW50QmxhY2tCZXJyeTo6aGlkZUhpZ2hsaWdodCgpCiB7CiAgICAgbV93ZWJQYWdlUHJpdmF0ZS0+ c2V0SW5zcGVjdG9yT3ZlcmxheUNsaWVudCgwKTsKLSAgICBpZiAoIW1fd2ViUGFnZVByaXZhdGUt PmlzQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0FjdGl2ZSgpKQotICAgICAgICBtX3dlYlBhZ2VQcml2 YXRlLT5tYWluRnJhbWUoKS0+ZG9jdW1lbnQoKS0+ZG9jdW1lbnRFbGVtZW50KCktPnJlbmRlcmVy KCktPnJlcGFpbnQodHJ1ZSk7CiB9CiAKIHZvaWQgSW5zcGVjdG9yQ2xpZW50QmxhY2tCZXJyeTo6 b3Blbkluc3BlY3RvckZyb250ZW5kKEluc3BlY3RvckNvbnRyb2xsZXIqKQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0luc3BlY3Rvck92ZXJsYXku Y3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0luc3BlY3Rvck92 ZXJsYXkuY3BwCmluZGV4IGM1NjhmMTM0MTlhZTE0NTRmYTI5ZjFkODk3ZmQ3MjdmZTU1ZDI1MGMu LmZhNDhjZDZhYTgzMDFlODNiNTE1ODFjOWUwYjIwMTcyNDY4NWZjZWEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9JbnNwZWN0b3JPdmVybGF5LmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvSW5zcGVjdG9y T3ZlcmxheS5jcHAKQEAgLTc3LDggKzc3LDYgQEAgSW5zcGVjdG9yT3ZlcmxheTo6fkluc3BlY3Rv ck92ZXJsYXkoKSB7IH0KIAogdm9pZCBJbnNwZWN0b3JPdmVybGF5OjpjbGVhcigpCiB7Ci0gICAg aW52YWxpZGF0ZVdlYkZyYW1lKCk7Ci0KICNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcp CiAgICAgaWYgKG1fb3ZlcmxheSkgewogICAgICAgICBtX292ZXJsYXktPnJlbW92ZUZyb21QYXJl bnQoKTsKQEAgLTg5LDEyICs4NywxMCBAQCB2b2lkIEluc3BlY3Rvck92ZXJsYXk6OmNsZWFyKCkK IAogdm9pZCBJbnNwZWN0b3JPdmVybGF5Ojp1cGRhdGUoKQogewotICAgIGludmFsaWRhdGVXZWJG cmFtZSgpOwotCiAjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogICAgIGlmICghbV9v dmVybGF5KSB7CiAgICAgICAgIG1fb3ZlcmxheSA9IGFkb3B0UHRyKG5ldyBCbGFja0JlcnJ5OjpX ZWJLaXQ6OldlYk92ZXJsYXkodGhpcykpOwotICAgICAgICBjb25zdCBJbnRTaXplIHNpemUgPSBt X3dlYlBhZ2UtPnZpZXdwb3J0U2l6ZSgpOworICAgICAgICBjb25zdCBJbnRTaXplIHNpemUgPSBt X3dlYlBhZ2UtPmNvbnRlbnRzU2l6ZSgpOwogICAgICAgICBtX292ZXJsYXktPnNldFNpemUoRmxv YXRTaXplKHNpemUud2lkdGgoKSwgc2l6ZS5oZWlnaHQoKSkpOwogICAgICAgICBtX3dlYlBhZ2Ut Pm1fd2ViUGFnZS0+YWRkT3ZlcmxheShtX292ZXJsYXkuZ2V0KCkpOwogICAgIH0KQEAgLTEwNSwy NCArMTAxLDQgQEAgdm9pZCBJbnNwZWN0b3JPdmVybGF5Ojp1cGRhdGUoKQogI2VuZGlmCiB9CiAK LXZvaWQgSW5zcGVjdG9yT3ZlcmxheTo6cGFpbnRXZWJGcmFtZShHcmFwaGljc0NvbnRleHQmIGdj KQotewotICAgIGlmICghbV93ZWJQYWdlLT5pc0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdBY3RpdmUo KSkKLSAgICAgICAgbV9jbGllbnQtPnBhaW50SW5zcGVjdG9yT3ZlcmxheShnYyk7Ci19Ci0KLXZv aWQgSW5zcGVjdG9yT3ZlcmxheTo6aW52YWxpZGF0ZVdlYkZyYW1lKCkKLXsKLSAgICAvLyBJbnNw ZWN0b3JPdmVybGF5Q2xpZW50IGRvZXMgdGhlIGFjdHVhbCBwYWludGluZyBvZiB0aGUgb3Zlcmxh eS4KLSAgICAvLyBIZXJlIHdlIGp1c3QgbWFrZSBzdXJlIHRvIGludmFsaWRhdGUuCi0gICAgaWYg KCFtX3dlYlBhZ2UtPmlzQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0FjdGl2ZSgpKSB7Ci0gICAgICAg IC8vIEZJWE1FOiBhYmxlIHRvIGludmFsaWRhdGUgYSBzbWFsbGVyIHJlY3QuCi0gICAgICAgIC8v IEZJWE1FOiBJcyBpdCBpbXBvcnRhbnQgdG8ganVzdCBpbnZhbGlkYXRlIGEgc21hbGxlciByZWN0 IGdpdmVuIHRoYXQKLSAgICAgICAgLy8gdGhpcyBpcyBub3Qgb24gYSBjcml0aWNhbCBjb2RlcGF0 aD8gSW4gb3JkZXIgdG8gZG8gc28sIHdlJ2QKLSAgICAgICAgLy8gaGF2ZSB0byB0YWtlIHNjcm9s bGluZyBpbnRvIGFjY291bnQuCi0gICAgICAgIGNvbnN0IEludFNpemUgc2l6ZSA9IG1fd2ViUGFn ZS0+dmlld3BvcnRTaXplKCk7Ci0gICAgICAgIEludFJlY3QgZGFtYWdlZFJlY3QoMCwgMCwgc2l6 ZS53aWR0aCgpLCBzaXplLmhlaWdodCgpKTsKLSAgICB9Ci19Ci0KIH0K