88296 2012-06-04 23:28:00 -0700 REGRESSION (r118197): PluginStrategy should be used even if ENABLE(NETSCAPE_PLUGIN_API) is false 2012-06-05 11:28:56 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Regression P2 Normal --- 87096 1 aestes aestes oldest_to_newest 641210 0 aestes 2012-06-04 23:28:00 -0700 <http://trac.webkit.org/changeset/118197> changed PluginData to only call into PluginStrategy if ENABLE(NETSCAPE_PLUGIN_API) is true. This isn't correct, since some ports support non-Netscape plug-ins and still use PluginStrategy (e.g. Apple's OS X port). 641234 1 145707 aestes 2012-06-05 00:08:43 -0700 Created attachment 145707 Patch 641246 2 145707 mitz 2012-06-05 00:30:28 -0700 Comment on attachment 145707 Patch r=me if it doesn’t break any builds 641755 3 aestes 2012-06-05 11:28:56 -0700 Committed r119506: <http://trac.webkit.org/changeset/119506> 145707 2012-06-05 00:08:43 -0700 2012-06-05 00:30:28 -0700 Patch bug-88296-20120605000842.patch text/plain 1972 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NDYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjI4YThjZGE2MWI3ZDNm NTI5NzY2NDY3MTNkY2Y4NGNjM2Y5NTNhZC4uNDBiMGE4MWZmMmFmNjFmYTVmZTQ3NTI3MzY5OWI5 MDlkNTY0ZDYwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA2LTA1ICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTE4MTk3 KTogUGx1Z2luU3RyYXRlZ3kgc2hvdWxkIGJlIHVzZWQgZXZlbiBpZiBFTkFCTEUoTkVUU0NBUEVf UExVR0lOX0FQSSkgaXMgZmFsc2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTg4Mjk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgcmVmcmVzaCgpIGFuZCBpbml0UGx1Z2lucygpIHNob3VsZCBjYWxsIGludG8g UGx1Z2luU3RyYXRlZ3kgZXZlbiBpZgorICAgICAgICBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQ SSkgaXMgZmFsc2UuIFNvbWUgcG9ydHMgc3VwcG9ydCBub24tTmV0c2NhcGUKKyAgICAgICAgcGx1 Zy1pbnMsIHNvIFBsdWdpblN0cmF0ZWd5IHNob3VsZCBiZSBjb25zdWx0ZWQgZXZlbiBpZiBOZXRz Y2FwZQorICAgICAgICBwbHVnLWlucyBzcGVjaWZpY2FsbHkgYXJlIGRpc2FibGVkLgorCisgICAg ICAgIFBvcnRzIHRoYXQgc3VwcG9ydCBwbGF0Zm9ybSBzdHJhdGVnaWVzIGJ1dCBub3QgTmV0c2Nh cGUgcGx1Zy1pbnMgc2hvdWxkCisgICAgICAgIGhhbmRsZSB0aGlzIGluc2lkZSB0aGVpciBQbHVn aW5TdHJhdGVneSByYXRoZXIgdGhhbiBtb2RpZnlpbmcgZ2VuZXJpYworICAgICAgICBwbHVnLWlu IGNvZGUuCisKKyAgICAgICAgKiBwbHVnaW5zL1BsdWdpbkRhdGEuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UGx1Z2luRGF0YTo6cmVmcmVzaCk6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5EYXRh Ojppbml0UGx1Z2lucyk6CisKIDIwMTItMDYtMDQgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNl ckBhcHBsZS5jb20+CiAKICAgICAgICAgTGVha2luZyBDbGlwUmVjdHMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luRGF0YS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbHVn aW5zL1BsdWdpbkRhdGEuY3BwCmluZGV4IGZlYTVmODA5MWM2ZGUwZGRlOWNiZmNhNDdkMzAxMzVl OWQxYTc3NzIuLmI4ZTc1MWRmMzMxZTA2NDdjMzlmYmRlNTJlNzYzYTBhMWY5NWU0MjkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luRGF0YS5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5EYXRhLmNwcApAQCAtNjcsMjAgKzY3LDE0IEBAIFN0cmlu ZyBQbHVnaW5EYXRhOjpwbHVnaW5OYW1lRm9yTWltZVR5cGUoY29uc3QgU3RyaW5nJiBtaW1lVHlw ZSkgY29uc3QKICNpZiBVU0UoUExBVEZPUk1fU1RSQVRFR0lFUykKIHZvaWQgUGx1Z2luRGF0YTo6 cmVmcmVzaCgpCiB7Ci0jaWYgRU5BQkxFKE5FVFNDQVBFX1BMVUdJTl9BUEkpCiAgICAgcGxhdGZv cm1TdHJhdGVnaWVzKCktPnBsdWdpblN0cmF0ZWd5KCktPnJlZnJlc2hQbHVnaW5zKCk7Ci0jZW5k aWYKIH0KIAogdm9pZCBQbHVnaW5EYXRhOjppbml0UGx1Z2lucyhjb25zdCBQYWdlKiBwYWdlKQog ewotI2lmIEVOQUJMRShORVRTQ0FQRV9QTFVHSU5fQVBJKQogICAgIEFTU0VSVChtX3BsdWdpbnMu aXNFbXB0eSgpKTsKICAgICAKICAgICBwbGF0Zm9ybVN0cmF0ZWdpZXMoKS0+cGx1Z2luU3RyYXRl Z3koKS0+Z2V0UGx1Z2luSW5mbyhwYWdlLCBtX3BsdWdpbnMpOwotI2Vsc2UKLSAgICBVTlVTRURf UEFSQU0ocGFnZSk7Ci0jZW5kaWYKIH0KICNlbmRpZgogCg==