88292 2012-06-04 23:08:00 -0700 [GTK] Build fix for Accelerated Compositing with OpenGL 2012-06-06 00:29:57 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joone webkit-unassigned alex mrobinson webkit.review.bot zeno oldest_to_newest 641201 0 joone 2012-06-04 23:08:00 -0700 Currently, WebKitGtk+ doesn't need to include "GraphicsSurface.h" because USE(GRAPHICS_SURFACE) is not implemented. 641240 1 145709 joone 2012-06-05 00:20:49 -0700 Created attachment 145709 Proposed Patch 641562 2 145709 mrobinson 2012-06-05 08:10:04 -0700 Comment on attachment 145709 Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145709&action=review Looks good, but please fix the include order when landing. > Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.h:28 > + > +#if USE(GRAPHICS_SURFACE) > #include "GraphicsSurface.h" > +#endif > + You should now move this include below the rest of them, so it should be like: #include "FloatRect.h" #include "Image.h" #include "TextureMapper.h" #include "TextureMapperPlatformLayer.h" #include <wtf/RefPtr.h> #if USE(GRAPHICS_SURFACE) #include "GraphicsSurface.h" #endif > Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:28 > #include "GraphicsContext.h" > + > +#if USE(GRAPHICS_SURFACE) > #include "GraphicsSurface.h" > +#endif > + The same thing is necessary here. 641805 3 145854 joone 2012-06-05 12:33:28 -0700 Created attachment 145854 Updated Patch Thanks for the review! 642250 4 145854 webkit.review.bot 2012-06-06 00:29:51 -0700 Comment on attachment 145854 Updated Patch Clearing flags on attachment: 145854 Committed r119567: <http://trac.webkit.org/changeset/119567> 642251 5 webkit.review.bot 2012-06-06 00:29:57 -0700 All reviewed patches have been landed. Closing bug. 145709 2012-06-05 00:20:49 -0700 2012-06-05 12:33:28 -0700 Proposed Patch fixbreak_ac.patch text/plain 2538 joone ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmMjhhOGNkLi5mYmQ5NzgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTItMDYtMDQgIEpvb25lIEh1ciAgPGpvb25lQHdlYmtpdC5vcmc+CisKKyAgICAgICAg W0dUS10gQnVpbGQgZml4IGZvciBBY2NlbGVyYXRlZCBDb21wb3NpdGluZyB3aXRoIE9wZW5HTAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODgyOTIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCdWlsZCBmaXgg YWZ0ZXIgcjExOTI0Ny4KKyAgICAgICAgRG8gbm90IGluY2x1ZGUgR3JhcGhpY3NTdXJmYWNlLmgg d2hlbiBub3QgYnVpbGRpbmcKKyAgICAgICAgd2l0aCBHUkFQSElDU19TVVJGQUNFLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cy4gVGhpcyBpcyBvbmx5IGEgYnVpbGQgZml4LgorCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJCYWNraW5nU3RvcmUuY3BwOgor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyQmFja2luZ1N0 b3JlLmg6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJH TC5jcHA6CisKIDIwMTItMDYtMDQgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5j b20+CiAKICAgICAgICAgTGVha2luZyBDbGlwUmVjdHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyQmFja2luZ1N0b3JlLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVy QmFja2luZ1N0b3JlLmNwcAppbmRleCAwZWEzMzYwLi5iMDNiZTBhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckJhY2tpbmdT dG9yZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1Rl eHR1cmVNYXBwZXJCYWNraW5nU3RvcmUuY3BwCkBAIC0yMSwxMSArMjEsMTEgQEAKICNpbmNsdWRl ICJUZXh0dXJlTWFwcGVyQmFja2luZ1N0b3JlLmgiCiAKICNpbmNsdWRlICJHcmFwaGljc0xheWVy LmgiCi0jaW5jbHVkZSAiR3JhcGhpY3NTdXJmYWNlLmgiCiAjaW5jbHVkZSAiSW1hZ2VCdWZmZXIu aCIKICNpbmNsdWRlICJUZXh0dXJlTWFwcGVyLmgiCiAKICNpZiBVU0UoR1JBUEhJQ1NfU1VSRkFD RSkKKyNpbmNsdWRlICJHcmFwaGljc1N1cmZhY2UuaCIKICNpbmNsdWRlICJUZXh0dXJlTWFwcGVy R0wuaCIKICNlbmRpZgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckJhY2tpbmdTdG9yZS5oIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJCYWNraW5nU3RvcmUuaAppbmRl eCA2OTFjYzlhLi5jZDM5MGE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckJhY2tpbmdTdG9yZS5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyQmFja2luZ1N0b3Jl LmgKQEAgLTIxLDcgKzIxLDExIEBACiAjZGVmaW5lIFRleHR1cmVNYXBwZXJCYWNraW5nU3RvcmVf aAogCiAjaW5jbHVkZSAiRmxvYXRSZWN0LmgiCisKKyNpZiBVU0UoR1JBUEhJQ1NfU1VSRkFDRSkK ICNpbmNsdWRlICJHcmFwaGljc1N1cmZhY2UuaCIKKyNlbmRpZgorCiAjaW5jbHVkZSAiSW1hZ2Uu aCIKICNpbmNsdWRlICJUZXh0dXJlTWFwcGVyLmgiCiAjaW5jbHVkZSAiVGV4dHVyZU1hcHBlclBs YXRmb3JtTGF5ZXIuaCIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyR0wuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJHTC5jcHAKaW5kZXggZTI3YTZkYS4uNDQxNzhj MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1Rl eHR1cmVNYXBwZXJHTC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv dGV4bWFwL1RleHR1cmVNYXBwZXJHTC5jcHAKQEAgLTIxLDcgKzIxLDExIEBACiAjaW5jbHVkZSAi VGV4dHVyZU1hcHBlckdMLmgiCiAKICNpbmNsdWRlICJHcmFwaGljc0NvbnRleHQuaCIKKworI2lm IFVTRShHUkFQSElDU19TVVJGQUNFKQogI2luY2x1ZGUgIkdyYXBoaWNzU3VyZmFjZS5oIgorI2Vu ZGlmCisKICNpbmNsdWRlICJJbWFnZS5oIgogI2luY2x1ZGUgIlRleHR1cmVNYXBwZXJTaGFkZXJN YW5hZ2VyLmgiCiAjaW5jbHVkZSAiVGltZXIuaCIK 145854 2012-06-05 12:33:28 -0700 2012-06-06 00:29:51 -0700 Updated Patch fixbreak_ac.patch text/plain 2824 joone ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmMjhhOGNkLi4yZGRjNzk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTItMDYtMDQgIEpvb25lIEh1ciAgPGpvb25lLmh1ckBpbnRlbC5jb20+CisKKyAgICAg ICAgW0dUS10gQnVpbGQgZml4IGZvciBBY2NlbGVyYXRlZCBDb21wb3NpdGluZyB3aXRoIE9wZW5H TAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODgyOTIK KworICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24uCisKKyAgICAgICAgQnVpbGQg Zml4IGFmdGVyIHIxMTkyNDcuCisgICAgICAgIERvIG5vdCBpbmNsdWRlIEdyYXBoaWNzU3VyZmFj ZS5oIHdoZW4gbm90IGJ1aWxkaW5nCisgICAgICAgIHdpdGggR1JBUEhJQ1NfU1VSRkFDRS4KKwor ICAgICAgICBObyBuZXcgdGVzdHMuIFRoaXMgaXMgb25seSBhIGJ1aWxkIGZpeC4KKworICAgICAg ICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyQmFja2luZ1N0b3JlLmNw cDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckJhY2tp bmdTdG9yZS5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFw cGVyR0wuY3BwOgorCiAyMDEyLTA2LTA0ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBw bGUuY29tPgogCiAgICAgICAgIExlYWtpbmcgQ2xpcFJlY3RzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckJhY2tpbmdTdG9y ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1h cHBlckJhY2tpbmdTdG9yZS5jcHAKaW5kZXggMGVhMzM2MC4uYjAzYmUwYSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJCYWNr aW5nU3RvcmUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1h cC9UZXh0dXJlTWFwcGVyQmFja2luZ1N0b3JlLmNwcApAQCAtMjEsMTEgKzIxLDExIEBACiAjaW5j bHVkZSAiVGV4dHVyZU1hcHBlckJhY2tpbmdTdG9yZS5oIgogCiAjaW5jbHVkZSAiR3JhcGhpY3NM YXllci5oIgotI2luY2x1ZGUgIkdyYXBoaWNzU3VyZmFjZS5oIgogI2luY2x1ZGUgIkltYWdlQnVm ZmVyLmgiCiAjaW5jbHVkZSAiVGV4dHVyZU1hcHBlci5oIgogCiAjaWYgVVNFKEdSQVBISUNTX1NV UkZBQ0UpCisjaW5jbHVkZSAiR3JhcGhpY3NTdXJmYWNlLmgiCiAjaW5jbHVkZSAiVGV4dHVyZU1h cHBlckdMLmgiCiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJCYWNraW5nU3RvcmUuaCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyQmFja2luZ1N0b3JlLmgK aW5kZXggNjkxY2M5YS4uOTVhYmU1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJCYWNraW5nU3RvcmUuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckJhY2tpbmdT dG9yZS5oCkBAIC0yMSwxMyArMjEsMTUgQEAKICNkZWZpbmUgVGV4dHVyZU1hcHBlckJhY2tpbmdT dG9yZV9oCiAKICNpbmNsdWRlICJGbG9hdFJlY3QuaCIKLSNpbmNsdWRlICJHcmFwaGljc1N1cmZh Y2UuaCIKICNpbmNsdWRlICJJbWFnZS5oIgogI2luY2x1ZGUgIlRleHR1cmVNYXBwZXIuaCIKICNp bmNsdWRlICJUZXh0dXJlTWFwcGVyUGxhdGZvcm1MYXllci5oIgotCiAjaW5jbHVkZSA8d3RmL1Jl ZlB0ci5oPgogCisjaWYgVVNFKEdSQVBISUNTX1NVUkZBQ0UpCisjaW5jbHVkZSAiR3JhcGhpY3NT dXJmYWNlLmgiCisjZW5kaWYKKwogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBjbGFzcyBHcmFwaGlj c0xheWVyOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4 bWFwL1RleHR1cmVNYXBwZXJHTC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmNwcAppbmRleCBlMjdhNmRhLi42NThkZTQ4IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1h cHBlckdMLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAv VGV4dHVyZU1hcHBlckdMLmNwcApAQCAtMjEsNyArMjEsNiBAQAogI2luY2x1ZGUgIlRleHR1cmVN YXBwZXJHTC5oIgogCiAjaW5jbHVkZSAiR3JhcGhpY3NDb250ZXh0LmgiCi0jaW5jbHVkZSAiR3Jh cGhpY3NTdXJmYWNlLmgiCiAjaW5jbHVkZSAiSW1hZ2UuaCIKICNpbmNsdWRlICJUZXh0dXJlTWFw cGVyU2hhZGVyTWFuYWdlci5oIgogI2luY2x1ZGUgIlRpbWVyLmgiCkBAIC0zMSw2ICszMCwxMCBA QAogI2luY2x1ZGUgPHd0Zi9QYXNzUmVmUHRyLmg+CiAjaW5jbHVkZSA8d3RmL1JlZkNvdW50ZWQu aD4KIAorI2lmIFVTRShHUkFQSElDU19TVVJGQUNFKQorI2luY2x1ZGUgIkdyYXBoaWNzU3VyZmFj ZS5oIgorI2VuZGlmCisKICNpZiBQTEFURk9STShRVCkKICNpZiBRVF9WRVJTSU9OID49IDB4MDUw MDAwCiAjaW5jbHVkZSA8UU9wZW5HTENvbnRleHQ+Cg==