88282 2012-06-04 20:29:39 -0700 Leaking ClipRects 2012-06-20 07:28:38 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser darin eric jchaffraix msaboff simon.fraser webkit-bug-importer webkit.review.bot oldest_to_newest 641140 0 simon.fraser 2012-06-04 20:29:39 -0700 We're leaking ClipRects, via: | WebCore::ThreadTimers::sharedTimerFired() ThreadTimers.cpp:94 | WebCore::ThreadTimers::sharedTimerFiredInternal() ThreadTimers.cpp:118 | WebCore::Timer<WebCore::FrameView>::fired() Timer.h:100 | WebCore::FrameView::layoutTimerFired(WebCore::Timer<WebCore::FrameView>*) FrameView.cpp:2034 | WebCore::FrameView::layout(bool) FrameView.cpp:1157 | WebCore::FrameView::performPostLayoutTasks() FrameView.cpp:2379 | WebCore::RenderView::updateWidgetPositions() RenderView.cpp:695 | WebCore::RenderWidget::updateWidgetPosition() RenderWidget.cpp:342 | WebCore::RenderWidget::updateWidgetGeometry() RenderWidget.cpp:186 | WebCore::RenderWidget::setWidgetGeometry(WebCore::FractionalLayoutRect const&) RenderWidget.cpp:156 | WebCore::RenderLayer::childrenClipRect() const RenderLayer.cpp:3970 | WebCore::RenderLayer::calculateRects(WebCore::RenderLayer const*, WebCore::RenderRegion*, WebCore::ClipRectsType, WebCore::FractionalLayoutRect const&, WebCore::FractionalLayoutRect&, WebCore::ClipRect&, WebCore::ClipRect&, WebCore::ClipRect&, WebCore::OverlayScrollbarSizeRelevancy) const RenderLayer.cpp:3913 | WebCore::RenderLayer::backgroundClipRect(WebCore::RenderLayer const*, WebCore::RenderRegion*, WebCore::ClipRectsType, WebCore::OverlayScrollbarSizeRelevancy) const RenderLayer.cpp:3898 | WebCore::RenderLayer::parentClipRects(WebCore::RenderLayer const*, WebCore::RenderRegion*, WebCore::ClipRectsType, WebCore::ClipRects&, WebCore::OverlayScrollbarSizeRelevancy) const RenderLayer.cpp:3879 | WebCore::RenderLayer::updateClipRects(WebCore::RenderLayer const*, WebCore::RenderRegion*, WebCore::ClipRectsType, WebCore::OverlayScrollbarSizeRelevancy) RenderLayer.cpp:3784 | WebCore::RenderLayer::updateClipRects(WebCore::RenderLayer const*, WebCore::RenderRegion*, WebCore::ClipRectsType, WebCore::OverlayScrollbarSizeRelevancy) RenderLayer.cpp:3784 | WebCore::RenderLayer::updateClipRects(WebCore::RenderLayer const*, WebCore::RenderRegion*, WebCore::ClipRectsType, WebCore::OverlayScrollbarSizeRelevancy) RenderLayer.cpp:3795 | WebCore::ClipRects::create(WebCore::ClipRects const&) RenderLayer.h:139 | WTF::fastMalloc(unsigned long) Probably a regression from r118562. 641141 1 webkit-bug-importer 2012-06-04 20:30:21 -0700 <rdar://problem/11594358> 641178 2 145692 simon.fraser 2012-06-04 21:42:24 -0700 Created attachment 145692 Patch 641182 3 145692 mitz 2012-06-04 21:53:59 -0700 Comment on attachment 145692 Patch You can probably just make ClipRects a use RefCounted. 641185 4 simon.fraser 2012-06-04 22:02:31 -0700 http://trac.webkit.org/changeset/119458 641728 5 darin 2012-06-05 11:07:11 -0700 (In reply to comment #3) > You can probably just make ClipRects a use RefCounted. Can, and should! 145692 2012-06-04 21:42:24 -0700 2012-06-04 21:53:59 -0700 Patch bug-88282-20120604214224.patch text/plain 2547 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MzA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzY4ZmQxOTYwMWQxMzBi MmIyYjcxYzkxNzMxN2JlZjgyN2NiZDRhMC4uZmViZGNiMmRhOTAyNDJlMWRhNDEwYWRkMDg3ODQ0 YTdiMTEyNmYyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA2LTA0ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIExlYWtpbmcgQ2xp cFJlY3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 ODI4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElu IHIxMTg1NjIgSSBtYWRlIHRoZSBDbGlwUmVjdHNDYWNoZSB1c2UgUmVmUHRyPENsaXBSZWN0cz4u IEhvd2V2ZXIsIENsaXBSZWN0cworICAgICAgICB3YXMgaW5pdGlhbGl6ZWQgd2l0aCBtX3JlZkNu dD0wLCBub3QgMSBhcyBhZG9wdFJlZigpIGFuZCBmcmllbmRzIGV4cGVjdC4gQWxzbywKKyAgICAg ICAgdGhlcmUgd2FzIGEgbWFudWFsIHJlZigpIGluIFJlbmRlckxheWVyOjp1cGRhdGVDbGlwUmVj dHMoKSB3aGljaCB0aGlzIHBhdGNoIHJlbW92ZXMuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVu ZGVyTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OnVwZGF0ZUNsaXBS ZWN0cyk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmg6CisgICAgICAgIChXZWJD b3JlOjpDbGlwUmVjdHM6OkNsaXBSZWN0cyk6CisKIDIwMTItMDYtMDEgIFRpbSBIb3J0b24gIDx0 aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgQ2xlYW51cCBHZW5lcmF0b3JHZW5l cmF0ZWRJbWFnZS9HcmFkaWVudCBjaGFuZ2VzIGZyb20gcjExNzg1OApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJMYXllci5jcHAKaW5kZXggZTBiNTZlN2U1OWEyMzdkNTU5Y2U5M2NhNTYx ZTM3ZGFjZTI0MzdkZC4uMDVkOWJhNTc3ZTI2YjQ5NzBkZTRlMGM0ZjEyYzMzNzMxYTQxNTIzOCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCkBAIC0zNzk0LDcgKzM3 OTQsNiBAQCB2b2lkIFJlbmRlckxheWVyOjp1cGRhdGVDbGlwUmVjdHMoY29uc3QgUmVuZGVyTGF5 ZXIqIHJvb3RMYXllciwgUmVuZGVyUmVnaW9uKiByZQogICAgIGVsc2UKICAgICAgICAgbV9jbGlw UmVjdHNDYWNoZS0+bV9jbGlwUmVjdHNbY2xpcFJlY3RzVHlwZV0gPSBDbGlwUmVjdHM6OmNyZWF0 ZShjbGlwUmVjdHMpOwogCi0gICAgbV9jbGlwUmVjdHNDYWNoZS0+bV9jbGlwUmVjdHNbY2xpcFJl Y3RzVHlwZV0tPnJlZigpOwogI2lmbmRlZiBOREVCVUcKICAgICBtX2NsaXBSZWN0c0NhY2hlLT5t X2NsaXBSZWN0c1Jvb3RbY2xpcFJlY3RzVHlwZV0gPSByb290TGF5ZXI7CiAjZW5kaWYKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5oIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgKaW5kZXggYWQyM2FmNzA4OGMyYThlN2UwYzE3 Zjg3NTUxM2I0YjQ2MWVhOTU4MS4uNDg1MmZmMGI0YWQwOGMyMGMzZjVlOGY0YTJlNmE3ZWFhYjQ4 YzFiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgK KysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgKQEAgLTE0MCw3ICsx NDAsNyBAQCBwdWJsaWM6CiAgICAgfQogCiAgICAgQ2xpcFJlY3RzKCkKLSAgICAgICAgOiBtX3Jl ZkNudCgwKQorICAgICAgICA6IG1fcmVmQ250KDEpCiAgICAgICAgICwgbV9maXhlZChmYWxzZSkK ICAgICB7CiAgICAgfQpAQCAtMTk0LDcgKzE5NCw3IEBAIHByaXZhdGU6CiAgICAgICAgIDogbV9v dmVyZmxvd0NsaXBSZWN0KHIpCiAgICAgICAgICwgbV9maXhlZENsaXBSZWN0KHIpCiAgICAgICAg ICwgbV9wb3NDbGlwUmVjdChyKQotICAgICAgICAsIG1fcmVmQ250KDApCisgICAgICAgICwgbV9y ZWZDbnQoMSkKICAgICAgICAgLCBtX2ZpeGVkKGZhbHNlKQogICAgIHsKICAgICB9CkBAIC0yMDMs NyArMjAzLDcgQEAgcHJpdmF0ZToKICAgICAgICAgOiBtX292ZXJmbG93Q2xpcFJlY3Qob3RoZXIu b3ZlcmZsb3dDbGlwUmVjdCgpKQogICAgICAgICAsIG1fZml4ZWRDbGlwUmVjdChvdGhlci5maXhl ZENsaXBSZWN0KCkpCiAgICAgICAgICwgbV9wb3NDbGlwUmVjdChvdGhlci5wb3NDbGlwUmVjdCgp KQotICAgICAgICAsIG1fcmVmQ250KDApCisgICAgICAgICwgbV9yZWZDbnQoMSkKICAgICAgICAg LCBtX2ZpeGVkKG90aGVyLmZpeGVkKCkpCiAgICAgewogICAgIH0K