88255 2012-06-04 14:18:49 -0700 [GTK] Fix two more memory leaks in DRT 2012-06-05 09:19:08 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis mrobinson webkit.review.bot oldest_to_newest 640829 0 naginenis 2012-06-04 14:18:49 -0700 cairo surface is leaking here http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/gtk/PixelDumpSupportGtk.cpp#L51 ==12917== 1,920,640 (368 direct, 1,920,272 indirect) bytes in 1 blocks are definitely lost in loss record 9,776 of 9,776 ==12917== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==12917== by 0xC65BB1F: _cairo_image_surface_create_for_pixman_image (cairo-image-surface.c:158) ==12917== by 0xC65E448: _cairo_image_surface_create_with_pixman_format (cairo-image-surface.c:335) ==12917== by 0x4684EF: createBitmapContextFromWebView(bool, bool, bool, bool) (PixelDumpSupportGtk.cpp:54) ==12917== by 0x4575A9: dumpWebViewAsPixelsAndCompareWithExpected(std::string const&) (PixelDumpSupport.cpp:56) ==12917== by 0x45E6EF: dump() (DumpRenderTree.cpp:583) ==12917== by 0x45FB31: topLoadingFrameLoadFinished() (DumpRenderTree.cpp:1031) ==12917== by 0x45FC6E: webFrameLoadStatusNotified(_WebKitWebFrame*, void*) (DumpRenderTree.cpp:1061) ==12917== by 0xC0FECA1: g_closure_invoke (gclosure.c:777) ==12917== by 0xC10FD70: signal_emit_unlocked_R (gsignal.c:3547) ==12917== by 0xC118098: g_signal_emit_valist (gsignal.c:3296) ==12917== by 0xC118241: g_signal_emit (gsignal.c:3352) ==12917== by 0xC103956: g_object_dispatch_properties_changed (gobject.c:1041) ==12917== by 0xC105232: g_object_notify (gobject.c:1133) ==12917== by 0x6C919C1: WebKit::notifyStatus(_WebKitWebFrame*, WebKitLoadStatus) (FrameLoaderClientGtk.cpp:130) ==12917== by 0x6C91A59: WebKit::loadDone(_WebKitWebFrame*, bool) (FrameLoaderClientGtk.cpp:143) ==12917== by 0x6C93EBE: WebKit::FrameLoaderClient::dispatchDidFinishLoad() (FrameLoaderClientGtk.cpp:621) ==12917== by 0x7450A35: WebCore::FrameLoader::checkLoadCompleteForThisFrame() (FrameLoader.cpp:2112) ==12917== by 0x7451647: WebCore::FrameLoader::checkLoadComplete() (FrameLoader.cpp:2290) ==12917== by 0x7449FF0: WebCore::FrameLoader::checkCompleted() (FrameLoader.cpp:713) ==12917== by 0x7449D8B: WebCore::FrameLoader::loadDone() (FrameLoader.cpp:653) ==12917== by 0x7429A92: WebCore::CachedResourceLoader::loadDone() (CachedResourceLoader.cpp:663) ==12917== by 0x749AAA9: WebCore::SubresourceLoader::releaseResources() (SubresourceLoader.cpp:317) ==12917== by 0x74904E1: WebCore::ResourceLoader::didFinishLoading(double) (ResourceLoader.cpp:298) ==12917== by 0x749A696: WebCore::SubresourceLoader::didFinishLoading(double) (SubresourceLoader.cpp:278) ==12917== by 0x7490C56: WebCore::ResourceLoader::didFinishLoading(WebCore::ResourceHandle*, double) (ResourceLoader.cpp:435) ==12917== by 0x7633F1B: WebCore::readCallback(_GObject*, _GAsyncResult*, void*) (ResourceHandleSoup.cpp:864) ==12917== by 0xBDFA918: async_ready_callback_wrapper (ginputstream.c:470) ==12917== by 0xBE0CF56: g_simple_async_result_complete (gsimpleasyncresult.c:767) ==12917== by 0xBE0CFD7: complete_in_idle_cb_for_thread (gsimpleasyncresult.c:835) ==12917== by 0xC385C99: g_main_context_dispatch (gmain.c:2515) ==12917== by 0xC38605F: g_main_context_iterate.isra.23 (gmain.c:3123) ==12917== by 0xC386459: g_main_loop_run (gmain.c:3317) ==12917== by 0xB18725C: gtk_main (gtkmain.c:1165) ==12917== by 0x45EC6E: runTest(std::string const&) (DumpRenderTree.cpp:704) ==12917== by 0x46133A: main (DumpRenderTree.cpp:1390) 640859 1 naginenis 2012-06-04 14:52:06 -0700 I found an another leak in DRT dumpHistoryItem() while fixing the one in bug description. ==12884== 2 bytes in 2 blocks are definitely lost in loss record 22 of 12,928 ==12884== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==12884== by 0xC3B2A38: g_malloc (gmem.c:159) ==12884== by 0xC3C729D: g_strdup (gstrfuncs.c:356) ==12884== by 0x6CC14AD: webkit_web_history_item_get_target (webkitwebhistoryitem.cpp:471) ==12884== by 0x45D6DE: dumpHistoryItem(_WebKitWebHistoryItem*, int, bool) (DumpRenderTree.cpp:294) ==12884== by 0x45D9AF: dumpBackForwardListForWebView(_WebKitWebView*) (DumpRenderTree.cpp:345) ==12884== by 0x45DA10: dumpBackForwardListForAllWebViews() (DumpRenderTree.cpp:356) ==12884== by 0x45E419: dump() (DumpRenderTree.cpp:561) ==12884== by 0x45F951: topLoadingFrameLoadFinished() (DumpRenderTree.cpp:1027) ==12884== by 0x45FA8E: webFrameLoadStatusNotified(_WebKitWebFrame*, void*) (DumpRenderTree.cpp:1057) 641540 2 145794 naginenis 2012-06-05 07:43:07 -0700 Created attachment 145794 Patch Fixed memory leaks in DRT code. 641631 3 145794 webkit.review.bot 2012-06-05 09:18:57 -0700 Comment on attachment 145794 Patch Clearing flags on attachment: 145794 Committed r119495: <http://trac.webkit.org/changeset/119495> 641632 4 webkit.review.bot 2012-06-05 09:19:08 -0700 All reviewed patches have been landed. Closing bug. 145794 2012-06-05 07:43:07 -0700 2012-06-05 09:18:57 -0700 Patch 88255.patch text/plain 2152 naginenis ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhMGE4 YzQzLi5kM2VjN2MyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDYtMDUgIFN1ZGFyc2FuYSBOYWdpbmVuaSAg PHN1ZGFyc2FuYS5uYWdpbmVuaUBsaW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0dUS10gRml4 IHR3byBtb3JlIG1lbW9yeSBsZWFrcyBpbiBEUlQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTg4MjU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgRml4ZWQgbWVtb3J5IGxlYWtzIGluIEdUSydzIERSVCBjb2Rl LgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcDoKKyAg ICAgICAgKGR1bXBIaXN0b3J5SXRlbSk6IHdlYmtpdF93ZWJfaGlzdG9yeV9pdGVtX2dldF90YXJn ZXQoKSByZXR1cm5zIGEKKyAgICAgICAgZ19zdHJkdXAoKSdkIHN0cmluZy4gU28sIHVzZSBHT3du UHRyIHRvIG1hbmFnZSBtZW1vcnkgYXV0b21hdGljYWxseS4KKyAgICAgICAgKiBEdW1wUmVuZGVy VHJlZS9ndGsvUGl4ZWxEdW1wU3VwcG9ydEd0ay5jcHA6CisgICAgICAgIChjcmVhdGVCaXRtYXBD b250ZXh0RnJvbVdlYlZpZXcpOiBGcmVlIHRoZSBjYWlybyBzdXJmYWNlLgorCiAyMDEyLTA2LTA0 ICBDaGFzZSBQaGlsbGlwcyAgPGNtcEBnb29nbGUuY29tPgogCiAgICAgICAgIE1ha2UgYSBidWls ZGVyIGdyb3VwIHN1cHBvcnQrZXhwZWN0IG11bHRpcGxlIGxvYWRzLgpkaWZmIC0tZ2l0IGEvVG9v bHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcCBiL1Rvb2xzL0R1bXBSZW5k ZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAKaW5kZXggM2Q2YjBlNS4uNGJkY2ExMyAxMDA2 NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcAorKysg Yi9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwCkBAIC0yOTUsOSAr Mjk1LDkgQEAgc3RhdGljIHZvaWQgZHVtcEhpc3RvcnlJdGVtKFdlYktpdFdlYkhpc3RvcnlJdGVt KiBpdGVtLCBpbnQgaW5kZW50LCBib29sIGN1cnJlbnQKIAogICAgIGdfZnJlZSh1cmlTY2hlbWUp OwogCi0gICAgY29uc3QgZ2NoYXIqIHRhcmdldCA9IHdlYmtpdF93ZWJfaGlzdG9yeV9pdGVtX2dl dF90YXJnZXQoaXRlbSk7Ci0gICAgaWYgKHRhcmdldCAmJiBzdHJsZW4odGFyZ2V0KSA+IDApCi0g ICAgICAgIHByaW50ZigiIChpbiBmcmFtZSBcIiVzXCIpIiwgdGFyZ2V0KTsKKyAgICBHT3duUHRy PGdjaGFyPiB0YXJnZXQod2Via2l0X3dlYl9oaXN0b3J5X2l0ZW1fZ2V0X3RhcmdldChpdGVtKSk7 CisgICAgaWYgKHRhcmdldC5nZXQoKSAmJiBzdHJsZW4odGFyZ2V0LmdldCgpKSA+IDApCisgICAg ICAgIHByaW50ZigiIChpbiBmcmFtZSBcIiVzXCIpIiwgdGFyZ2V0LmdldCgpKTsKICAgICBpZiAo d2Via2l0X3dlYl9oaXN0b3J5X2l0ZW1faXNfdGFyZ2V0X2l0ZW0oaXRlbSkpCiAgICAgICAgIHBy aW50ZigiICAqKm5hdiB0YXJnZXQqKiIpOwogICAgIHB1dGNoYXIoJ1xuJyk7CmRpZmYgLS1naXQg YS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvUGl4ZWxEdW1wU3VwcG9ydEd0ay5jcHAgYi9Ub29s cy9EdW1wUmVuZGVyVHJlZS9ndGsvUGl4ZWxEdW1wU3VwcG9ydEd0ay5jcHAKaW5kZXggM2VhYmZk OS4uNGQxOTNiZCAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL1BpeGVsRHVt cFN1cHBvcnRHdGsuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9QaXhlbER1bXBT dXBwb3J0R3RrLmNwcApAQCAtNjksNSArNjksNiBAQCBQYXNzUmVmUHRyPEJpdG1hcENvbnRleHQ+ IGNyZWF0ZUJpdG1hcENvbnRleHRGcm9tV2ViVmlldyhib29sLCBib29sLCBib29sLCBib29sCiAg ICAgICAgIGNhaXJvX3N0cm9rZShjb250ZXh0KTsKICAgICB9CiAKKyAgICBjYWlyb19zdXJmYWNl X2Rlc3Ryb3koaW1hZ2VTdXJmYWNlKTsKICAgICByZXR1cm4gQml0bWFwQ29udGV4dDo6Y3JlYXRl QnlBZG9wdGluZ0JpdG1hcEFuZENvbnRleHQoMCwgY29udGV4dCk7CiB9Cg==