88247 2012-06-04 12:34:23 -0700 [Qt][WK2] Use Component.onCompleted in API tests for single and multi file upload tests. 2012-06-05 22:32:49 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dinu.jacob webkit-unassigned cmarcelo menard vestbo webkit.review.bot zoltan oldest_to_newest 640753 0 dinu.jacob 2012-06-04 12:34:23 -0700 With 855a3ec2, there is no need for the Timer hack in single file upload and multi-file upload API tests. 640768 1 145618 dinu.jacob 2012-06-04 12:48:45 -0700 Created attachment 145618 Patch 641771 2 145618 cmarcelo 2012-06-05 11:42:39 -0700 Comment on attachment 145618 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145618&action=review > Source/WebKit2/ChangeLog:8 > + With commit 855a3ec2, Component.onCompleted can be used for callback instead of the To which repository does this commit refer? 641775 3 dinu.jacob 2012-06-05 11:45:10 -0700 (In reply to comment #2) > (From update of attachment 145618 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=145618&action=review > > > Source/WebKit2/ChangeLog:8 > > + With commit 855a3ec2, Component.onCompleted can be used for callback instead of the > > To which repository does this commit refer? ah, the git repository. I guess I should use the revision number instead! 641777 4 145849 dinu.jacob 2012-06-05 11:49:35 -0700 Created attachment 145849 Patch Updated the ChangeLog to use the revision number instead of the git commit id. 642183 5 145849 webkit.review.bot 2012-06-05 22:32:43 -0700 Comment on attachment 145849 Patch Clearing flags on attachment: 145849 Committed r119559: <http://trac.webkit.org/changeset/119559> 642184 6 webkit.review.bot 2012-06-05 22:32:49 -0700 All reviewed patches have been landed. Closing bug. 145618 2012-06-04 12:48:45 -0700 2012-06-05 11:49:35 -0700 Patch 88247.patch text/plain 3163 dinu.jacob ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkYTk1Y2FkLi43NzA1ZDhlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDYtMDQgIERpbnUgSmFjb2IgIDxkaW51LmphY29iQG5va2lhLmNvbT4KKworICAg ICAgICBbUXRdW1dLMl0gVXNlIENvbXBvbmVudC5vbkNvbXBsZXRlZCBpbiBBUEkgdGVzdHMgZm9y IHNpbmdsZSBhbmQgbXVsdGkgZmlsZSB1cGxvYWQgdGVzdHMuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODI0NworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdpdGggY29tbWl0IDg1NWEzZWMyLCBDb21wb25l bnQub25Db21wbGV0ZWQgY2FuIGJlIHVzZWQgZm9yIGNhbGxiYWNrIGluc3RlYWQgb2YgdGhlCisg ICAgICAgIDFzIHRpbWVyIGluIHNpbmdsZSBhbmQgbXVsdGkgZmlsZSB1cGxvYWQgdGVzdHMuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL1dlYlZpZXcvdHN0X211 bHRpRmlsZVVwbG9hZC5xbWw6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0 ZXN0cy9XZWJWaWV3L3RzdF9zaW5nbGVGaWxlVXBsb2FkLnFtbDoKKwogMjAxMi0wNi0wNCAgQWxs YW4gU2FuZGZlbGQgSmVuc2VuICA8YWxsYW4uamVuc2VuQG5va2lhLmNvbT4KIAogICAgICAgICBb UXRdIFRhcC10by16b29tIG92ZXJzaG9vdCBhbmltYXRpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL1dlYlZpZXcvdHN0X211bHRp RmlsZVVwbG9hZC5xbWwgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3Ft bHRlc3RzL1dlYlZpZXcvdHN0X211bHRpRmlsZVVwbG9hZC5xbWwKaW5kZXggNzNlYTcwOC4uMTVi YjBiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9x bWx0ZXN0cy9XZWJWaWV3L3RzdF9tdWx0aUZpbGVVcGxvYWQucW1sCisrKyBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvV2ViVmlldy90c3RfbXVsdGlGaWxl VXBsb2FkLnFtbApAQCAtMTMsMTYgKzEzLDEyIEBAIFRlc3RXZWJWaWV3IHsKICAgICBwcm9wZXJ0 eSBib29sIHNlbGVjdEZpbGUKIAogICAgIGV4cGVyaW1lbnRhbC5maWxlUGlja2VyOiBJdGVtIHsK LSAgICAgICAgVGltZXIgewotICAgICAgICAgICAgcnVubmluZzogdHJ1ZQotICAgICAgICAgICAg aW50ZXJ2YWw6IDEKLSAgICAgICAgICAgIG9uVHJpZ2dlcmVkOiB7Ci0gICAgICAgICAgICAgICAg dmFyIHNlbGVjdGVkRmlsZXMgPSBbImZpbGVuYW1lMSIsICJmaWxlbmFtZTIiXQotICAgICAgICAg ICAgICAgIGlmIChzZWxlY3RGaWxlKQotICAgICAgICAgICAgICAgICAgICBtb2RlbC5hY2NlcHQo c2VsZWN0ZWRGaWxlcykKLSAgICAgICAgICAgICAgICBlbHNlCi0gICAgICAgICAgICAgICAgICAg IG1vZGVsLnJlamVjdCgpOwotICAgICAgICAgICAgfQorICAgICAgICBDb21wb25lbnQub25Db21w bGV0ZWQ6IHsKKyAgICAgICAgICAgIHZhciBzZWxlY3RlZEZpbGVzID0gWyJmaWxlbmFtZTEiLCAi ZmlsZW5hbWUyIl0KKyAgICAgICAgICAgIGlmIChzZWxlY3RGaWxlKQorICAgICAgICAgICAgICAg IG1vZGVsLmFjY2VwdChzZWxlY3RlZEZpbGVzKQorICAgICAgICAgICAgZWxzZQorICAgICAgICAg ICAgICAgIG1vZGVsLnJlamVjdCgpOwogICAgICAgICB9CiAgICAgfQogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL1dlYlZpZXcvdHN0 X3NpbmdsZUZpbGVVcGxvYWQucW1sIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90 ZXN0cy9xbWx0ZXN0cy9XZWJWaWV3L3RzdF9zaW5nbGVGaWxlVXBsb2FkLnFtbAppbmRleCBiZTE0 MDliLi42YmNkODAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0 L3Rlc3RzL3FtbHRlc3RzL1dlYlZpZXcvdHN0X3NpbmdsZUZpbGVVcGxvYWQucW1sCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvV2ViVmlldy90c3Rf c2luZ2xlRmlsZVVwbG9hZC5xbWwKQEAgLTE0LDIwICsxNCwxNiBAQCBUZXN0V2ViVmlldyB7CiAg ICAgcHJvcGVydHkgYm9vbCBhY2NlcHRNdWx0aXBsZTogZmFsc2UKIAogICAgIGV4cGVyaW1lbnRh bC5maWxlUGlja2VyOiBJdGVtIHsKLSAgICAgICAgVGltZXIgewotICAgICAgICAgICAgcnVubmlu ZzogdHJ1ZQotICAgICAgICAgICAgaW50ZXJ2YWw6IDEKLSAgICAgICAgICAgIG9uVHJpZ2dlcmVk OiB7Ci0gICAgICAgICAgICAgICAgdmFyIHNlbGVjdGVkRmlsZXMgPSBbImZpbGVuYW1lMSIsICJm aWxlbmFtZTIiXQotICAgICAgICAgICAgICAgIGlmIChzZWxlY3RGaWxlKSB7Ci0gICAgICAgICAg ICAgICAgICAgIGlmIChhY2NlcHRNdWx0aXBsZSkKLSAgICAgICAgICAgICAgICAgICAgICAgIG1v ZGVsLmFjY2VwdChzZWxlY3RlZEZpbGVzKQotICAgICAgICAgICAgICAgICAgICBlbHNlCi0gICAg ICAgICAgICAgICAgICAgICAgICBtb2RlbC5hY2NlcHQoImFjY2VwdGVkZmlsZW5hbWUiKTsKLSAg ICAgICAgICAgICAgICB9CisgICAgICAgIENvbXBvbmVudC5vbkNvbXBsZXRlZDogeworICAgICAg ICAgICAgdmFyIHNlbGVjdGVkRmlsZXMgPSBbImZpbGVuYW1lMSIsICJmaWxlbmFtZTIiXQorICAg ICAgICAgICAgaWYgKHNlbGVjdEZpbGUpIHsKKyAgICAgICAgICAgICAgICBpZiAoYWNjZXB0TXVs dGlwbGUpCisgICAgICAgICAgICAgICAgICAgIG1vZGVsLmFjY2VwdChzZWxlY3RlZEZpbGVzKQog ICAgICAgICAgICAgICAgIGVsc2UKLSAgICAgICAgICAgICAgICAgICAgbW9kZWwucmVqZWN0KCk7 CisgICAgICAgICAgICAgICAgICAgIG1vZGVsLmFjY2VwdCgiYWNjZXB0ZWRmaWxlbmFtZSIpOwog ICAgICAgICAgICAgfQorICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgIG1vZGVsLnJl amVjdCgpOwogICAgICAgICB9CiAgICAgfQogCg== 145849 2012-06-05 11:49:35 -0700 2012-06-05 22:32:43 -0700 Patch 88247.patch text/plain 3155 dinu.jacob ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkYTk1Y2FkLi43NzA1ZDhlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDYtMDQgIERpbnUgSmFjb2IgIDxkaW51LmphY29iQG5va2lhLmNvbT4KKworICAg ICAgICBbUXRdW1dLMl0gVXNlIENvbXBvbmVudC5vbkNvbXBsZXRlZCBpbiBBUEkgdGVzdHMgZm9y IHNpbmdsZSBhbmQgbXVsdGkgZmlsZSB1cGxvYWQgdGVzdHMuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODI0NworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdpdGggcjExNjkzNiwgQ29tcG9uZW50Lm9uQ29t cGxldGVkIGNhbiBiZSB1c2VkIGZvciBjYWxsYmFjayBpbnN0ZWFkIG9mIHRoZQorICAgICAgICAx cyB0aW1lciBpbiBzaW5nbGUgYW5kIG11bHRpIGZpbGUgdXBsb2FkIHRlc3RzLgorCisgICAgICAg ICogVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9XZWJWaWV3L3RzdF9tdWx0aUZpbGVV cGxvYWQucW1sOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvV2Vi Vmlldy90c3Rfc2luZ2xlRmlsZVVwbG9hZC5xbWw6CisKIDIwMTItMDYtMDQgIEFsbGFuIFNhbmRm ZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBub2tpYS5jb20+CiAKICAgICAgICAgW1F0XSBUYXAt dG8tem9vbSBvdmVyc2hvb3QgYW5pbWF0aW9uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9XZWJWaWV3L3RzdF9tdWx0aUZpbGVVcGxv YWQucW1sIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9X ZWJWaWV3L3RzdF9tdWx0aUZpbGVVcGxvYWQucW1sCmluZGV4IDczZWE3MDguLjE1YmIwYmYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMv V2ViVmlldy90c3RfbXVsdGlGaWxlVXBsb2FkLnFtbAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL1dlYlZpZXcvdHN0X211bHRpRmlsZVVwbG9hZC5x bWwKQEAgLTEzLDE2ICsxMywxMiBAQCBUZXN0V2ViVmlldyB7CiAgICAgcHJvcGVydHkgYm9vbCBz ZWxlY3RGaWxlCiAKICAgICBleHBlcmltZW50YWwuZmlsZVBpY2tlcjogSXRlbSB7Ci0gICAgICAg IFRpbWVyIHsKLSAgICAgICAgICAgIHJ1bm5pbmc6IHRydWUKLSAgICAgICAgICAgIGludGVydmFs OiAxCi0gICAgICAgICAgICBvblRyaWdnZXJlZDogewotICAgICAgICAgICAgICAgIHZhciBzZWxl Y3RlZEZpbGVzID0gWyJmaWxlbmFtZTEiLCAiZmlsZW5hbWUyIl0KLSAgICAgICAgICAgICAgICBp ZiAoc2VsZWN0RmlsZSkKLSAgICAgICAgICAgICAgICAgICAgbW9kZWwuYWNjZXB0KHNlbGVjdGVk RmlsZXMpCi0gICAgICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAgICAgICAgICBtb2RlbC5y ZWplY3QoKTsKLSAgICAgICAgICAgIH0KKyAgICAgICAgQ29tcG9uZW50Lm9uQ29tcGxldGVkOiB7 CisgICAgICAgICAgICB2YXIgc2VsZWN0ZWRGaWxlcyA9IFsiZmlsZW5hbWUxIiwgImZpbGVuYW1l MiJdCisgICAgICAgICAgICBpZiAoc2VsZWN0RmlsZSkKKyAgICAgICAgICAgICAgICBtb2RlbC5h Y2NlcHQoc2VsZWN0ZWRGaWxlcykKKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICBt b2RlbC5yZWplY3QoKTsKICAgICAgICAgfQogICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9XZWJWaWV3L3RzdF9zaW5nbGVG aWxlVXBsb2FkLnFtbCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1s dGVzdHMvV2ViVmlldy90c3Rfc2luZ2xlRmlsZVVwbG9hZC5xbWwKaW5kZXggYmUxNDA5Yi4uNmJj ZDgwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9x bWx0ZXN0cy9XZWJWaWV3L3RzdF9zaW5nbGVGaWxlVXBsb2FkLnFtbAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL1dlYlZpZXcvdHN0X3NpbmdsZUZp bGVVcGxvYWQucW1sCkBAIC0xNCwyMCArMTQsMTYgQEAgVGVzdFdlYlZpZXcgewogICAgIHByb3Bl cnR5IGJvb2wgYWNjZXB0TXVsdGlwbGU6IGZhbHNlCiAKICAgICBleHBlcmltZW50YWwuZmlsZVBp Y2tlcjogSXRlbSB7Ci0gICAgICAgIFRpbWVyIHsKLSAgICAgICAgICAgIHJ1bm5pbmc6IHRydWUK LSAgICAgICAgICAgIGludGVydmFsOiAxCi0gICAgICAgICAgICBvblRyaWdnZXJlZDogewotICAg ICAgICAgICAgICAgIHZhciBzZWxlY3RlZEZpbGVzID0gWyJmaWxlbmFtZTEiLCAiZmlsZW5hbWUy Il0KLSAgICAgICAgICAgICAgICBpZiAoc2VsZWN0RmlsZSkgewotICAgICAgICAgICAgICAgICAg ICBpZiAoYWNjZXB0TXVsdGlwbGUpCi0gICAgICAgICAgICAgICAgICAgICAgICBtb2RlbC5hY2Nl cHQoc2VsZWN0ZWRGaWxlcykKLSAgICAgICAgICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAg ICAgICAgICAgICAgbW9kZWwuYWNjZXB0KCJhY2NlcHRlZGZpbGVuYW1lIik7Ci0gICAgICAgICAg ICAgICAgfQorICAgICAgICBDb21wb25lbnQub25Db21wbGV0ZWQ6IHsKKyAgICAgICAgICAgIHZh ciBzZWxlY3RlZEZpbGVzID0gWyJmaWxlbmFtZTEiLCAiZmlsZW5hbWUyIl0KKyAgICAgICAgICAg IGlmIChzZWxlY3RGaWxlKSB7CisgICAgICAgICAgICAgICAgaWYgKGFjY2VwdE11bHRpcGxlKQor ICAgICAgICAgICAgICAgICAgICBtb2RlbC5hY2NlcHQoc2VsZWN0ZWRGaWxlcykKICAgICAgICAg ICAgICAgICBlbHNlCi0gICAgICAgICAgICAgICAgICAgIG1vZGVsLnJlamVjdCgpOworICAgICAg ICAgICAgICAgICAgICBtb2RlbC5hY2NlcHQoImFjY2VwdGVkZmlsZW5hbWUiKTsKICAgICAgICAg ICAgIH0KKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICBtb2RlbC5yZWplY3QoKTsK ICAgICAgICAgfQogICAgIH0KIAo=