88243 2012-06-04 11:53:01 -0700 Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag. 2012-06-04 20:01:41 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hugo.lima hugo.lima abarth cdumez rakuco vestbo webkit.review.bot oldest_to_newest 640720 0 hugo.lima 2012-06-04 11:53:01 -0700 Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag, as it better fits into ENABLE flag definition. 640721 1 145613 hugo.lima 2012-06-04 11:57:15 -0700 Created attachment 145613 Patch 640723 2 145613 abarth 2012-06-04 12:00:05 -0700 Comment on attachment 145613 Patch Is LEGACY_VIEWPORT_ADAPTION only mentioned in the cmake build system? I would have expected you to change some of the other build systems as well. 640729 3 hugo.lima 2012-06-04 12:08:14 -0700 Yes, I only added it on qmake and cmake (false by default), but as the default value should be false on other ports until the respective maintainers take the decision to turn it on this shall be no problem. 640731 4 hugo.lima 2012-06-04 12:10:47 -0700 Continuing..., as the feature is off by default, better to delegate the implementation of this flag on other build system to people that really understand those build systems, when and if they decide to use this feature. 640796 5 145613 rakuco 2012-06-04 13:20:37 -0700 Comment on attachment 145613 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145613&action=review > Source/cmake/WebKitFeatures.cmake:59 > + WEBKIT_OPTION_DEFINE(ENABLE_LEGACY_VIEWPORT_ADAPTION "Toogle legacy viewport adaption" OFF) BTW, for CMake you also need to change Source/cmakeconfig.h.cmake. 640854 6 hugo.lima 2012-06-04 14:43:34 -0700 (In reply to comment #5) > (From update of attachment 145613 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=145613&action=review > > > Source/cmake/WebKitFeatures.cmake:59 > > + WEBKIT_OPTION_DEFINE(ENABLE_LEGACY_VIEWPORT_ADAPTION "Toogle legacy viewport adaption" OFF) > > BTW, for CMake you also need to change Source/cmakeconfig.h.cmake. I saw the file, but I was not sure if adding the flag there would enable the feature, so for the sake of not mess with other ports I didn't touch the file. rakuko, could you complete the addition of this feature flag for cmake? 641131 7 145613 webkit.review.bot 2012-06-04 20:01:36 -0700 Comment on attachment 145613 Patch Clearing flags on attachment: 145613 Committed r119452: <http://trac.webkit.org/changeset/119452> 641132 8 webkit.review.bot 2012-06-04 20:01:41 -0700 All reviewed patches have been landed. Closing bug. 145613 2012-06-04 11:57:15 -0700 2012-06-04 20:01:36 -0700 Patch bug-88243-20120604155706.patch text/plain 6464 hugo.lima U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NDA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTkzMzI2MWJiMTJkZWFl NmNiMmI2ZWMzOTUwM2YyNTI3MzA3YmE5MS4uODk0OWQyYTQwMTliMWM2NzMyMGI3OTVhMjY2NjE3 NjM4MGJiZDc5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA2LTA0ICBIdWdv IFBhcmVudGUgTGltYSAgPGh1Z28ubGltYUBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFR1cm4g TEVHQUNZX1ZJRVdQT1JUX0FEQVBUSU9OIFVTRSBmbGFnIGludG8gYW4gRU5BQkxFIGZsYWcuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODI0MworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cyBuZWVkZWQsIHRoaXMganVzdCByZW5hbWUgYSBjb21waWxlciBmbGFnLgorCisgICAgICAgICog ZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpzZXREb2NUeXBl KToKKyAgICAgICAgKiBkb20vVmlld3BvcnRBcmd1bWVudHMuaDoKKyAgICAgICAgKiBodG1sL0hU TUxNZXRhRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWV0YUVsZW1lbnQ6OnBy b2Nlc3MpOgorCiAyMDEyLTA2LTA0ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdt YWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTE5MzkzLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2RvbS9Eb2N1bWVudC5jcHAKaW5kZXggMmM5NmMxZTM0MTdhYzVlNmZmNDQ5N2FiZDE0ZmMwMjE5 OWVmNjQxNC4uMjQwM2JkYjEzYWEwZDQ2OTA1NDdjZDM2ZmU4MmVlYmMwZmQwNjZjNSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9kb20vRG9jdW1lbnQuY3BwCkBAIC03ODgsNyArNzg4LDcgQEAgdm9pZCBEb2N1bWVudDo6c2V0 RG9jVHlwZShQYXNzUmVmUHRyPERvY3VtZW50VHlwZT4gZG9jVHlwZSkKICAgICBtX2RvY1R5cGUg PSBkb2NUeXBlOwogICAgIGlmIChtX2RvY1R5cGUpIHsKICAgICAgICAgdGhpcy0+YWRvcHRJZk5l ZWRlZChtX2RvY1R5cGUuZ2V0KCkpOwotI2lmIFVTRShMRUdBQ1lfVklFV1BPUlRfQURBUFRJT04p CisjaWYgRU5BQkxFKExFR0FDWV9WSUVXUE9SVF9BREFQVElPTikKICAgICAgICAgQVNTRVJUKG1f dmlld3BvcnRBcmd1bWVudHMudHlwZSA9PSBWaWV3cG9ydEFyZ3VtZW50czo6SW1wbGljaXQpOwog ICAgICAgICBpZiAobV9kb2NUeXBlLT5wdWJsaWNJZCgpLnN0YXJ0c1dpdGgoIi0vL3dhcGZvcnVt Ly9kdGQgeGh0bWwgbW9iaWxlIDEuIiwgLyogY2FzZVNlbnNpdGl2ZSAqLyBmYWxzZSkpCiAgICAg ICAgICAgICBwcm9jZXNzVmlld3BvcnQoIndpZHRoPWRldmljZS13aWR0aCwgaGVpZ2h0PWRldmlj ZS1oZWlnaHQiLCBWaWV3cG9ydEFyZ3VtZW50czo6WEhUTUxNb2JpbGVQcm9maWxlKTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9WaWV3cG9ydEFyZ3VtZW50cy5oIGIvU291cmNlL1dl YkNvcmUvZG9tL1ZpZXdwb3J0QXJndW1lbnRzLmgKaW5kZXggOTNlM2I4ZGUzMjFkODY5ZmZjYjA5 NmMxYWE4MmE3NjY4ODYyMzYwNy4uYTM2NzhkYjE5NjJlZmI4ZThlZDhhZWU2ZjMxZDdhZDNiMDYz N2U1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1ZpZXdwb3J0QXJndW1lbnRzLmgK KysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1ZpZXdwb3J0QXJndW1lbnRzLmgKQEAgLTU5LDcgKzU5 LDcgQEAgc3RydWN0IFZpZXdwb3J0QXJndW1lbnRzIHsKICAgICBlbnVtIFR5cGUgewogICAgICAg ICAvLyBUaGVzZSBhcmUgb3JkZXJlZCBpbiBpbmNyZWFzaW5nIGltcG9ydGFuY2UuCiAgICAgICAg IEltcGxpY2l0LAotI2lmIFVTRShMRUdBQ1lfVklFV1BPUlRfQURBUFRJT04pCisjaWYgRU5BQkxF KExFR0FDWV9WSUVXUE9SVF9BREFQVElPTikKICAgICAgICAgWEhUTUxNb2JpbGVQcm9maWxlLAog ICAgICAgICBIYW5kaGVsZEZyaWVuZGx5TWV0YSwKICAgICAgICAgTW9iaWxlT3B0aW1pemVkTWV0 YSwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1ldGFFbGVtZW50LmNwcCBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1ldGFFbGVtZW50LmNwcAppbmRleCBjZjExNGY2N2Fi ODM5YzQ0YTFhMjM0ZTdkODQxMDk4MzkwNDQwYTZkLi4wZTBkMjdiN2FlZWY2MThkNTk3ZWEyNzA3 NGJlOWZkOGQyODBkNTliIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZXRh RWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWV0YUVsZW1lbnQuY3Bw CkBAIC03NSw3ICs3NSw3IEBAIHZvaWQgSFRNTE1ldGFFbGVtZW50Ojpwcm9jZXNzKCkKICAgICAg ICAgZG9jdW1lbnQoKS0+cHJvY2Vzc1ZpZXdwb3J0KGNvbnRlbnRWYWx1ZSwgVmlld3BvcnRBcmd1 bWVudHM6OlZpZXdwb3J0TWV0YSk7CiAgICAgZWxzZSBpZiAoZXF1YWxJZ25vcmluZ0Nhc2UobmFt ZSgpLCAicmVmZXJyZXIiKSkKICAgICAgICAgZG9jdW1lbnQoKS0+cHJvY2Vzc1JlZmVycmVyUG9s aWN5KGNvbnRlbnRWYWx1ZSk7Ci0jaWYgVVNFKExFR0FDWV9WSUVXUE9SVF9BREFQVElPTikKKyNp ZiBFTkFCTEUoTEVHQUNZX1ZJRVdQT1JUX0FEQVBUSU9OKQogICAgIGVsc2UgaWYgKGVxdWFsSWdu b3JpbmdDYXNlKG5hbWUoKSwgImhhbmRoZWxkZnJpZW5kbHkiKSAmJiBlcXVhbElnbm9yaW5nQ2Fz ZShjb250ZW50VmFsdWUsICJ0cnVlIikpCiAgICAgICAgIGRvY3VtZW50KCktPnByb2Nlc3NWaWV3 cG9ydCgid2lkdGg9ZGV2aWNlLXdpZHRoIiwgVmlld3BvcnRBcmd1bWVudHM6OkhhbmRoZWxkRnJp ZW5kbHlNZXRhKTsKICAgICBlbHNlIGlmIChlcXVhbElnbm9yaW5nQ2FzZShuYW1lKCksICJtb2Jp bGVvcHRpbWl6ZWQiKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5j bWFrZSBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFrZQppbmRleCAzNGY5MjYxYTBh MjQ1MTBkMWUyOWFmZTUyM2MzODhlZTE5MTI2NDcxLi5kNjk1MzUzYjFmZDA0ZDk1NzJhYzA4Mzhl MDJmODNkNWQ1YTY4YTBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMu Y21ha2UKKysrIGIvU291cmNlL2NtYWtlL1dlYktpdEZlYXR1cmVzLmNtYWtlCkBAIC01Niw2ICs1 Niw3IEBAIE1BQ1JPIChXRUJLSVRfT1BUSU9OX0JFR0lOKQogICAgIFdFQktJVF9PUFRJT05fREVG SU5FKEVOQUJMRV9KQVZBU0NSSVBUX0RFQlVHR0VSICJUb2dnbGUgSmF2YVNjcmlwdCBEZWJ1Z2dl ci9Qcm9maWxlciBzdXBwb3J0IiBPTikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVf SklUICJFbmFibGUgSnVzdEluVGltZSBqYXZhc2NyaXB0IHN1cHBvcnQiIE9OKQogICAgIFdFQktJ VF9PUFRJT05fREVGSU5FKEVOQUJMRV9MRUdBQ1lfTk9USUZJQ0FUSU9OUyAiVG9nZ2xlIExlZ2Fj eSBEZXNrdG9wIE5vdGlmaWNhdGlvbnMgU3VwcG9ydCIgT0ZGKQorICAgIFdFQktJVF9PUFRJT05f REVGSU5FKEVOQUJMRV9MRUdBQ1lfVklFV1BPUlRfQURBUFRJT04gIlRvb2dsZSBsZWdhY3kgdmll d3BvcnQgYWRhcHRpb24iIE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfTEVH QUNZX1dFQktJVF9CTE9CX0JVSUxERVIgIlRvZ2dsZSBMZWdhY3kgV2ViS2l0IEJsb2IgQnVpbGRl ciBTdXBwb3J0IiBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0xJTktfUFJF RkVUQ0ggIlRvZ2dsZSBwcmUgZmV0Y2hpbmcgc3VwcG9ydCIgT0ZGKQogICAgIFdFQktJVF9PUFRJ T05fREVGSU5FKEVOQUJMRV9NQVRITUwgIlRvZ2dsZSBNYXRoTUwgc3VwcG9ydCIgT04pCkBAIC0x MDAsNyArMTAxLDYgQEAgTUFDUk8gKFdFQktJVF9PUFRJT05fQkVHSU4pCiAgICAgV0VCS0lUX09Q VElPTl9ERUZJTkUoRU5BQkxFX1hTTFQgIlRvZ2dsZSBYU0xUIHN1cHBvcnQiIE9OKQogICAgIFdF QktJVF9PUFRJT05fREVGSU5FKFVTRV9TWVNURU1fTUFMTE9DICJUb2dnbGUgc3lzdGVtIGFsbG9j YXRvciBpbnN0ZWFkIG9mIFRDbWFsbG9jIiBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUo VVNFX1RJTEVEX0JBQ0tJTkdfU1RPUkUgIlRvZ2dsZSBUaWxlZCBCYWNraW5nIFN0b3JlIHN1cHBv cnQiIE9GRikKLSAgICBXRUJLSVRfT1BUSU9OX0RFRklORShVU0VfTEVHQUNZX1ZJRVdQT1JUX0FE QVBUSU9OICJUb29nbGUgbGVnYWN5IHZpZXdwb3J0IGFkYXB0aW9uIiBPRkYpCiAgICAgV0VCS0lU X09QVElPTl9ERUZJTkUoVVNFX1dURlVSTCAiVG9vZ2xlIHRoZSB1c2Ugb2YgV1RGVVJMIGZvciBV UkwgcGFyc2luZyIgT0ZGKQogRU5ETUFDUk8gKCkKIApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdl TG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGNlNTgzMThiMDJiYjQ3NzA3ZTM2ODk5YzUxNWZm YzU1YjRmNDFjZjAuLjQ0YjFkYjQ5MmM0YTk5YWNlM2MyNmJhZjdiNzc3NGZiMWYzNzYzMjkgMTAw NjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxMiBAQAorMjAxMi0wNi0wNCAgSHVnbyBQYXJlbnRlIExpbWEgIDxodWdvLmxpbWFAb3BlbmJv c3NhLm9yZz4KKworICAgICAgICBUdXJuIExFR0FDWV9WSUVXUE9SVF9BREFQVElPTiBVU0UgZmxh ZyBpbnRvIGFuIEVOQUJMRSBmbGFnLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODgyNDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHFtYWtlL21rc3BlY3MvZmVhdHVyZXMvZmVhdHVyZXMucHJmOgorCiAy MDEyLTA2LTA0ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KIAog ICAgICAgICBbR1RLXVtXSzJdIEltcGxlbWVudCBnZW9sb2NhdGlvbiBwcm92aWRlciBmb3IgdGhl IEdUSyBwb3J0CmRpZmYgLS1naXQgYS9Ub29scy9xbWFrZS9ta3NwZWNzL2ZlYXR1cmVzL2ZlYXR1 cmVzLnByZiBiL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZmVhdHVyZXMucHJmCmluZGV4 IDJkMzg1Y2FlNjcwY2QxZGEzNGQ4YzQ3Mzc4YzkzODk4N2QxYWI3YjIuLjgzMDEwY2MzZTQzMDM0 NDcyZWJmYWE4MmRlNGJhMTBmODllYjE5YmIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL3FtYWtlL21rc3Bl Y3MvZmVhdHVyZXMvZmVhdHVyZXMucHJmCisrKyBiL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVy ZXMvZmVhdHVyZXMucHJmCkBAIC03OSw3ICs3OSw3IEBAIGhhdmVRdCg1KSB7CiAhY29udGFpbnMo REVGSU5FUywgV1RGX1VTRV9USUxFRF9CQUNLSU5HX1NUT1JFPS4pOiBERUZJTkVTICs9IFdURl9V U0VfVElMRURfQkFDS0lOR19TVE9SRT0xCiAKICMgVHVybiBvbiBsZWdhY3kgdmlld3BvcnQgYWRh cHRpb24KLSFjb250YWlucyhERUZJTkVTLCBXVEZfVVNFX0xFR0FDWV9WSUVXUE9SVF9BREFQVElP Tj0uKTogREVGSU5FUyArPSBXVEZfVVNFX0xFR0FDWV9WSUVXUE9SVF9BREFQVElPTj0xCishY29u dGFpbnMoREVGSU5FUywgRU5BQkxFX0xFR0FDWV9WSUVXUE9SVF9BREFQVElPTj0uKTogREVGSU5F UyArPSBFTkFCTEVfTEVHQUNZX1ZJRVdQT1JUX0FEQVBUSU9OPTEKIAogIyBOZXNjYXBlIHBsdWdp bnMgc3VwcG9ydCAoTlBBUEkpCiAhY29udGFpbnMoREVGSU5FUywgRU5BQkxFX05FVFNDQVBFX1BM VUdJTl9BUEk9LikgewpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDg5 OWQyNWYwYTNjZDc4ZjExODczYmI1YjE2YTEzODNmNTFlNGI4YTUuLjVmZDY0MGI0ZDVmZTI5N2Y3 MGI1MGRhYmUwNDhkMjI4YTZjMmYwMTUgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMi0wNi0wNCAgSHVnbyBQYXJlbnRlIExpbWEgIDxo dWdvLmxpbWFAb3BlbmJvc3NhLm9yZz4KKworICAgICAgICBUdXJuIExFR0FDWV9WSUVXUE9SVF9B REFQVElPTiBVU0UgZmxhZyBpbnRvIGFuIEVOQUJMRSBmbGFnLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODgyNDMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJl cy5jbWFrZToKKwogMjAxMi0wNi0wNCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gVXBkYXRlIE5FV1MgYW5kIGNvbmZpZ3Vy ZS5hYyBmb3IgMS45LjMgcmVsZWFzZQo=