88235 2012-06-04 08:09:27 -0700 [Microdata] An element with an empty itemprop='' should not get listed in the .properties list 2012-06-08 05:17:30 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 68609 1 arko webkit-unassigned rniwa oldest_to_newest 640595 0 arko 2012-06-04 08:09:27 -0700 According to the latest specification http://www.whatwg.org/specs/web-apps/current-work/multipage/microdata.html, an element with an empty itemprop='' should not get listed in the .properties list. Please check : http://html5.org/r/6854 for the spec change. 640620 1 145593 arko 2012-06-04 08:46:28 -0700 Created attachment 145593 Patch 644408 2 145593 rniwa 2012-06-08 00:07:52 -0700 Comment on attachment 145593 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145593&action=review > LayoutTests/fast/dom/MicroData/element-with-empty-itemprop.html:18 > + Why the blank line? 644587 3 arko 2012-06-08 05:17:30 -0700 Committed r119822: <http://trac.webkit.org/changeset/119822> 145593 2012-06-04 08:46:28 -0700 2012-06-08 00:07:51 -0700 Patch patch_88235.diff text/plain 4057 arko SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExOTM5OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA2LTA0ICBBcmtvIFNh aGEgIDxhcmtvQG1vdG9yb2xhLmNvbT4KKworICAgICAgICBNaWNyb2RhdGE6IEFuIGVsZW1lbnQg d2l0aCBhbiBlbXB0eSBpdGVtcHJvcD0nJyBzaG91bGQgbm90IGdldCBsaXN0ZWQgaW4gdGhlIC5w cm9wZXJ0aWVzIGxpc3QuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04ODIzNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFzIHBlciB0aGUgc3BlY2lmaWNhdGlvbiBjaGFuZ2UgaHR0cDovL2h0bWw1Lm9yZy9y LzY4NTQsIGFuIGVsZW1lbnQgc2hvdWxkIGJlIGxpc3RlZCBpbiAucHJvcGVydGllcworICAgICAg ICBpZiB0aGUgZWxlbGVtZW50IGhhcyBhbiBhdHRyaWJ1dGUgaXRlbXByb3Agc3BlY2lmaWVkIGFu ZCB0aGUgZWxlbWVudCBoYXMgb25lIG9yIG1vcmUgcHJvcGVydHkgbmFtZXMuCisKKyAgICAgICAg VGVzdDogZmFzdC9kb20vTWljcm9EYXRhL2VsZW1lbnQtd2l0aC1lbXB0eS1pdGVtcHJvcC5odG1s CisKKyAgICAgICAgKiBodG1sL0hUTUxQcm9wZXJ0aWVzQ29sbGVjdGlvbi5jcHA6CisgICAgICAg IChXZWJDb3JlOjpIVE1MUHJvcGVydGllc0NvbGxlY3Rpb246Oml0ZW1BZnRlcik6CisKIDIwMTIt MDYtMDQgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBsaW51eC5pbnRl bC5jb20+CiAKICAgICAgICAgW0dUS10gTWVtb3J5IGxlYWsgaW4gUGFzdGVib2FyZEhlbHBlcgpJ bmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUHJvcGVydGllc0NvbGxlY3Rpb24uY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFByb3BlcnRpZXNDb2xsZWN0aW9u LmNwcAkocmV2aXNpb24gMTE5MjI2KQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUHJvcGVy dGllc0NvbGxlY3Rpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjgsNyArMTI4LDcgQEAgRWxl bWVudCogSFRNTFByb3BlcnRpZXNDb2xsZWN0aW9uOjppdGVtQQogICAgICAgICBpZiAoIWN1cnJl bnQtPmlzSFRNTEVsZW1lbnQoKSkKICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICBIVE1M RWxlbWVudCogZWxlbWVudCA9IHRvSFRNTEVsZW1lbnQoY3VycmVudCk7Ci0gICAgICAgIGlmIChl bGVtZW50LT5mYXN0SGFzQXR0cmlidXRlKGl0ZW1wcm9wQXR0cikpIHsKKyAgICAgICAgaWYgKGVs ZW1lbnQtPmZhc3RIYXNBdHRyaWJ1dGUoaXRlbXByb3BBdHRyKSAmJiBlbGVtZW50LT5pdGVtUHJv cCgpLT5sZW5ndGgoKSkgewogICAgICAgICAgICAgcmV0dXJuIGVsZW1lbnQ7CiAgICAgICAgIH0K ICAgICB9CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTkzOTgpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0wNi0wNCAgQXJrbyBTYWhh ICA8YXJrb0Btb3Rvcm9sYS5jb20+CisKKyAgICAgICAgTWljcm9kYXRhOiBBbiBlbGVtZW50IHdp dGggYW4gZW1wdHkgaXRlbXByb3A9Jycgc2hvdWxkIG5vdCBnZXQgbGlzdGVkIGluIHRoZSAucHJv cGVydGllcyBsaXN0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODgyMzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGZhc3QvZG9tL01pY3JvRGF0YS9lbGVtZW50LXdpdGgtZW1wdHktaXRlbXByb3AtZXhw ZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9NaWNyb0RhdGEvZWxlbWVudC13 aXRoLWVtcHR5LWl0ZW1wcm9wLmh0bWw6IEFkZGVkLgorCiAyMDEyLTA2LTA0ICBKdXN0aW4gTm92 b3NhZCAgPGp1bm92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBDYW52YXMgMkQgLSBTb3VyY2Ug cmVjdGFuZ2xlcyB0aGF0IG92ZXJsYXAgdGhlIHNvdXJjZSBpbWFnZSBib3VuZGFyeSwgbm90IHN1 cHBvcnRlZCBieSBkcmF3SW1hZ2UKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL01pY3JvRGF0 YS9lbGVtZW50LXdpdGgtZW1wdHktaXRlbXByb3AtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL2Zhc3QvZG9tL01pY3JvRGF0YS9lbGVtZW50LXdpdGgtZW1wdHktaXRlbXBy b3AtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vTWlj cm9EYXRhL2VsZW1lbnQtd2l0aC1lbXB0eS1pdGVtcHJvcC1leHBlY3RlZC50eHQJKHJldmlzaW9u IDApCkBAIC0wLDAgKzEsOSBAQAorVGhpcyB0ZXN0IGVuc3VyZXMgdGhhdCBhbiBlbGVtZW50IHdp dGggZW1wdHkgaXRlbXByb3A9IiIgZG9lc24ndCBnZXQgbGlzdGVkIGluIHRoZSAucHJvcGVydGll cyBsaXN0LgorCitQQVNTIGl0ZW0ucHJvcGVydGllcy5sZW5ndGggaXMgMQorUEFTUyBpdGVtLmNo aWxkcmVuWzFdLml0ZW1Qcm9wLmFkZCgnYnV6Jyk7IGl0ZW0ucHJvcGVydGllcy5sZW5ndGggaXMg MgorUEFTUyBpdGVtLmNoaWxkcmVuWzFdLml0ZW1Qcm9wLnJlbW92ZSgnYnV6Jyk7IGl0ZW0ucHJv cGVydGllcy5sZW5ndGggaXMgMQorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitU RVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL01pY3JvRGF0YS9lbGVt ZW50LXdpdGgtZW1wdHktaXRlbXByb3AuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9m YXN0L2RvbS9NaWNyb0RhdGEvZWxlbWVudC13aXRoLWVtcHR5LWl0ZW1wcm9wLmh0bWwJKHJldmlz aW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9NaWNyb0RhdGEvZWxlbWVudC13aXRoLWVt cHR5LWl0ZW1wcm9wLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjIgQEAKKzwhRE9DVFlQ RSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMv anMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8cD5UaGlzIHRlc3Qg ZW5zdXJlcyB0aGF0IGFuIGVsZW1lbnQgd2l0aCBlbXB0eSBpdGVtcHJvcD0iIiBkb2Vzbid0IGdl dCBsaXN0ZWQgaW4gdGhlIC5wcm9wZXJ0aWVzIGxpc3QuPC9wPgorPGRpdiBpdGVtc2NvcGUgaWQ9 Im1pY3JvZGF0YS1pdGVtIj4KKzxkaXYgaXRlbXByb3A9ImZvbyI+PC9kaXY+Cis8ZGl2IGl0ZW1w cm9wPSIiPjwvZGl2PgorPC9kaXY+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQ+ Cit2YXIgaXRlbSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdtaWNyb2RhdGEtaXRlbScpOwor c2hvdWxkQmUoIml0ZW0ucHJvcGVydGllcy5sZW5ndGgiLCAiMSIpOworc2hvdWxkQmUoIml0ZW0u Y2hpbGRyZW5bMV0uaXRlbVByb3AuYWRkKCdidXonKTsgaXRlbS5wcm9wZXJ0aWVzLmxlbmd0aCIs ICIyIik7CitzaG91bGRCZSgiaXRlbS5jaGlsZHJlblsxXS5pdGVtUHJvcC5yZW1vdmUoJ2J1eicp OyBpdGVtLnByb3BlcnRpZXMubGVuZ3RoIiwgIjEiKTsKKworPC9zY3JpcHQ+Cis8c2NyaXB0IHNy Yz0iLi4vLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+ Cis8L2h0bWw+Cg==