88234 2012-06-04 08:06:46 -0700 Don't mark main frame layer opaque if the frame view is transparent 2012-06-17 19:28:33 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 anilsson anilsson andersca eric simon.fraser tonikitoo webkit.review.bot oldest_to_newest 640589 0 anilsson 2012-06-04 08:06:46 -0700 In the BlackBerry port, we sometimes use an AC layer to draw the contents of the "root" layer, i.e. the output of the main frame's FrameView::drawContents(). We also use the GraphicsLayer::contentsOpaque() (and other factors) to figure out whether to enable GL blending when compositing that layer. I found some code that sets the main frame renderview's layer opaque (unconditionally) which looks like it could break things when the main frame's FrameView has a transparent background color, because it will cause us to turn off blending for that layer. This should be seen in context of bug #88233. 640592 1 anilsson 2012-06-04 08:07:47 -0700 Change component 640598 2 145589 anilsson 2012-06-04 08:14:26 -0700 Created attachment 145589 Patch 640600 3 anilsson 2012-06-04 08:15:16 -0700 We use void FrameView::updateBackgroundRecursively(const Color&, bool) to set the background color and isTransparent. 640603 4 145589 anilsson 2012-06-04 08:16:08 -0700 Comment on attachment 145589 Patch I'm putting this patch up to get a sanity check from the Mac port and some feedback on whether this is testable on Mac (or any other) platform. 640606 5 145589 simon.fraser 2012-06-04 08:28:27 -0700 Comment on attachment 145589 Patch I think this is OK. 640613 6 145589 anilsson 2012-06-04 08:39:48 -0700 Comment on attachment 145589 Patch Thanks Simon, I've verified that this fixes the bug on our platform, let's see how it fares in the commit queue... 651111 7 145589 webkit.review.bot 2012-06-17 19:28:27 -0700 Comment on attachment 145589 Patch Clearing flags on attachment: 145589 Committed r120561: <http://trac.webkit.org/changeset/120561> 651113 8 webkit.review.bot 2012-06-17 19:28:33 -0700 All reviewed patches have been landed. Closing bug. 145589 2012-06-04 08:14:26 -0700 2012-06-17 19:28:27 -0700 Patch bug-88234-20120604171424.patch text/plain 1566 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MTg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODcxNjJkNTIwNTBhMjQx ZDRkNDQ4N2MxZTI5MDQ4ZmI3OTA5OTNmMy4uZTg3OTI0MzIwNThhNDE4Y2ZhMGRiZmQxNzg1NzE3 MzExMGI1ZDA4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA2LTA0ICBBcnZp ZCBOaWxzc29uICA8YW5pbHNzb25AcmltLmNvbT4KKworICAgICAgICBEb24ndCBtYXJrIG1haW4g ZnJhbWUgbGF5ZXIgb3BhcXVlIGlmIHRoZSBmcmFtZSB2aWV3IGlzIHRyYW5zcGFyZW50CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODIzNAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlckxheWVyQmFja2luZy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckJhY2tp bmc6OmNyZWF0ZVByaW1hcnlHcmFwaGljc0xheWVyKToKKwogMjAxMi0wNS0zMCAgSm9lIE1hc29u ICA8am1hc29uQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIFJlbW92ZSB1c2VsZXNz IHN0cmluZy0+Y2hhciotPnN0cmluZyBjb252ZXJzaW9uIGluIE5ldHdvcmtKb2IuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCmluZGV4IGJkYzVm OTZjYWRlYjg1MDVhMTMxYTAxZTg4MDU5NDY2ZTNhZTMxZDIuLmJjZTViMGZmMTUxYzA3OGE5Y2Fk YTI1Y2E1Y2ExMzkxMDc2Y2M0M2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJMYXllckJhY2tpbmcuY3BwCkBAIC0xNDcsNyArMTQ3LDExIEBAIHZvaWQgUmVuZGVyTGF5 ZXJCYWNraW5nOjpjcmVhdGVQcmltYXJ5R3JhcGhpY3NMYXllcigpCiAgICAgbV9ncmFwaGljc0xh eWVyID0gY3JlYXRlR3JhcGhpY3NMYXllcihsYXllck5hbWUpOwogCiAgICAgaWYgKG1faXNNYWlu RnJhbWVSZW5kZXJWaWV3TGF5ZXIpIHsKLSAgICAgICAgbV9ncmFwaGljc0xheWVyLT5zZXRDb250 ZW50c09wYXF1ZSh0cnVlKTsKKyAgICAgICAgYm9vbCBpc1RyYW5zcGFyZW50ID0gZmFsc2U7Cisg ICAgICAgIGlmIChGcmFtZVZpZXcqIGZyYW1lVmlldyA9IHRvUmVuZGVyVmlldyhyZW5kZXJlcigp KS0+ZnJhbWVWaWV3KCkpCisgICAgICAgICAgICBpc1RyYW5zcGFyZW50ID0gZnJhbWVWaWV3LT5p c1RyYW5zcGFyZW50KCk7CisKKyAgICAgICAgbV9ncmFwaGljc0xheWVyLT5zZXRDb250ZW50c09w YXF1ZSghaXNUcmFuc3BhcmVudCk7CiAgICAgICAgIG1fZ3JhcGhpY3NMYXllci0+c2V0QXBwbGll c1BhZ2VTY2FsZSgpOwogICAgIH0KICAgICAK