88229 2012-06-04 05:28:50 -0700 Web Inspector: aggregate all events before first frame into a fake frame 2012-06-05 07:50:23 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 caseq caseq apavlov bweinstein keishi loislo pfeldman pmuellr rik yurys oldest_to_newest 640505 0 caseq 2012-06-04 05:28:50 -0700 Timeline's frame mode currently displays all events before first didBeginFrame() call as independent events. This may appear confusing, so let's regard first event we receive as a frame start marker. 640516 1 145570 caseq 2012-06-04 05:41:00 -0700 Created attachment 145570 Patch 640518 2 145570 loislo 2012-06-04 05:48:33 -0700 Comment on attachment 145570 Patch lgtm 641543 3 145570 caseq 2012-06-05 07:50:16 -0700 Comment on attachment 145570 Patch Clearing flags on attachment: 145570 Committed r119485: <http://trac.webkit.org/changeset/119485> 641544 4 caseq 2012-06-05 07:50:23 -0700 All reviewed patches have been landed. Closing bug. 145570 2012-06-04 05:41:00 -0700 2012-06-05 07:50:16 -0700 Patch bug-88229-20120604164058.patch text/plain 3833 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MDk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDRkYjExMjEyNDI0NWJk ODIwY2MzMDVjOTlmNDg4ZDY0ZDAzNWUzYy4uODY3NzAzYmRhZmZiMGViZDMwMTI2ZDQwYzRjYzc5 Y2UxMDU4YWE5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA2LTA0ICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogYWdncmVnYXRlIGFsbCBldmVudHMgYmVmb3JlIGZpcnN0IGZyYW1lIGludG8gYSBmYWtlIGZy YW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODIy OQorCisgICAgICAgIC0gaW4gVGltZWxpbmUncyBmcmFtZSBtb2RlLCBzdGFydCBhZ2dyZWdhdGlu ZyBldmVudHMgYnkgZnJhbWUgZXZlbiBiZWZvcmUgd2UgZ2V0IGZpcnN0IGZyYW1lIG1hcmtlci4K KworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVGcmFtZUNvbnRyb2xsZXIu anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVGcmFtZUNvbnRyb2xsZXIucHJvdG90 eXBlLl9hZGRSZWNvcmQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lRnJhbWVDb250 cm9sbGVyLnByb3RvdHlwZS5fZmx1c2hGcmFtZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGlt ZWxpbmVGcmFtZUNvbnRyb2xsZXIucHJvdG90eXBlLl9jcmVhdGVGcmFtZSk6CisKIDIwMTItMDUt MzEgIFRvciBBcm5lIFZlc3Riw7ggIDx0b3IuYXJuZS52ZXN0Ym9Abm9raWEuY29tPgogCiAgICAg ICAgIFtRdF0gU2ltcGxpZnkgUVRfVkVSU0lPTl9DSEVDS1MgZm9yIFF0NSBieSBpbnRyb2R1Y2lu ZyBIQVZFKFFUNSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvVGltZWxpbmVGcmFtZUNvbnRyb2xsZXIuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL1RpbWVsaW5lRnJhbWVDb250cm9sbGVyLmpzCmluZGV4IGI4NTQwYjYzNGU3MmNj MDVjNDVmMDc3YTQ0ZGMwNGViZGFjNGY2NTcuLjRlNDFlMjQzNTNiNGJjZjU0ZGUzZjA5Mjg4ODdm YmUxMGEyNTRjMTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvVGltZWxpbmVGcmFtZUNvbnRyb2xsZXIuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9UaW1lbGluZUZyYW1lQ29udHJvbGxlci5qcwpAQCAtNjEsNDAgKzYxLDMw IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZUZyYW1lQ29udHJvbGxlci5wcm90b3R5cGUgPSB7CiAK ICAgICBfYWRkUmVjb3JkOiBmdW5jdGlvbihyZWNvcmQpCiAgICAgewotICAgICAgICBpZiAocmVj b3JkLnR5cGUgPT09IFdlYkluc3BlY3Rvci5UaW1lbGluZU1vZGVsLlJlY29yZFR5cGUuQmVnaW5G cmFtZSkKKyAgICAgICAgaWYgKHJlY29yZC50eXBlID09PSBXZWJJbnNwZWN0b3IuVGltZWxpbmVN b2RlbC5SZWNvcmRUeXBlLkJlZ2luRnJhbWUgJiYgdGhpcy5fbGFzdEZyYW1lKQogICAgICAgICAg ICAgdGhpcy5fZmx1c2hGcmFtZShyZWNvcmQpOwotICAgICAgICBlbHNlIGlmICh0aGlzLl9sYXN0 RnJhbWUpIHsKKyAgICAgICAgZWxzZSB7CisgICAgICAgICAgICBpZiAoIXRoaXMuX2xhc3RGcmFt ZSkKKyAgICAgICAgICAgICAgICB0aGlzLl9sYXN0RnJhbWUgPSB0aGlzLl9jcmVhdGVGcmFtZShy ZWNvcmQpOwogICAgICAgICAgICAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lTW9kZWwuYWdncmVnYXRl VGltZUZvclJlY29yZCh0aGlzLl9sYXN0RnJhbWUudGltZUJ5Q2F0ZWdvcnksIHJlY29yZCk7CiAg ICAgICAgICAgICB0aGlzLl9sYXN0RnJhbWUuY3B1VGltZSArPSBXZWJJbnNwZWN0b3IuVGltZWxp bmVNb2RlbC5kdXJhdGlvbkluU2Vjb25kcyhyZWNvcmQpOwotICAgICAgICB9IGVsc2UgewotICAg ICAgICAgICAgLy8gTm8gZnJhbWUgcmVjb3JkcyBzbyBmYXIgLS0gZ2VuZXJhdGUgYSBzeW50aGV0 aWMgZnJhbWUgcGVyIGVhY2ggdG9wLWxldmVsIHJlY29yZCwgYnV0IG9ubHkKLSAgICAgICAgICAg IC8vIGRpc3BhdGNoIHRoZXNlIHRvIHRoZSBvdmVydmlldy4KLSAgICAgICAgICAgIHRoaXMuX292 ZXJ2aWV3UGFuZS5hZGRGcmFtZSh0aGlzLl9jcmVhdGVTeW50aGV0aWNGcmFtZShyZWNvcmQpKTsK ICAgICAgICAgfQogICAgIH0sCiAKICAgICBfZmx1c2hGcmFtZTogZnVuY3Rpb24ocmVjb3JkKQog ICAgIHsKLSAgICAgICAgdmFyIGZyYW1lQmVnaW5UaW1lID0gV2ViSW5zcGVjdG9yLlRpbWVsaW5l TW9kZWwuc3RhcnRUaW1lSW5TZWNvbmRzKHJlY29yZCk7Ci0gICAgICAgIGlmICh0aGlzLl9sYXN0 RnJhbWUpIHsKLSAgICAgICAgICAgIHRoaXMuX2xhc3RGcmFtZS5lbmRUaW1lID0gZnJhbWVCZWdp blRpbWU7Ci0gICAgICAgICAgICB0aGlzLl9sYXN0RnJhbWUuZHVyYXRpb24gPSB0aGlzLl9sYXN0 RnJhbWUuZW5kVGltZSAtIHRoaXMuX2xhc3RGcmFtZS5zdGFydFRpbWU7Ci0gICAgICAgICAgICB0 aGlzLl9vdmVydmlld1BhbmUuYWRkRnJhbWUodGhpcy5fbGFzdEZyYW1lKTsKLSAgICAgICAgICAg IHRoaXMuX3ByZXNlbnRhdGlvbk1vZGVsLmFkZEZyYW1lKHRoaXMuX2xhc3RGcmFtZSk7Ci0gICAg ICAgIH0KLSAgICAgICAgdGhpcy5fbGFzdEZyYW1lID0gbmV3IFdlYkluc3BlY3Rvci5UaW1lbGlu ZUZyYW1lKCk7Ci0gICAgICAgIHRoaXMuX2xhc3RGcmFtZS5zdGFydFRpbWUgPSBmcmFtZUJlZ2lu VGltZTsKLSAgICAgICAgdGhpcy5fbGFzdEZyYW1lLnN0YXJ0VGltZU9mZnNldCA9IHRoaXMuX21v ZGVsLnJlY29yZE9mZnNldEluU2Vjb25kcyhyZWNvcmQpOworICAgICAgICB0aGlzLl9sYXN0RnJh bWUuZW5kVGltZSA9IFdlYkluc3BlY3Rvci5UaW1lbGluZU1vZGVsLnN0YXJ0VGltZUluU2Vjb25k cyhyZWNvcmQpOworICAgICAgICB0aGlzLl9sYXN0RnJhbWUuZHVyYXRpb24gPSB0aGlzLl9sYXN0 RnJhbWUuZW5kVGltZSAtIHRoaXMuX2xhc3RGcmFtZS5zdGFydFRpbWU7CisgICAgICAgIHRoaXMu X292ZXJ2aWV3UGFuZS5hZGRGcmFtZSh0aGlzLl9sYXN0RnJhbWUpOworICAgICAgICB0aGlzLl9w cmVzZW50YXRpb25Nb2RlbC5hZGRGcmFtZSh0aGlzLl9sYXN0RnJhbWUpOworICAgICAgICB0aGlz Ll9sYXN0RnJhbWUgPSB0aGlzLl9jcmVhdGVGcmFtZShyZWNvcmQpOwogICAgIH0sCiAKLSAgICBf Y3JlYXRlU3ludGhldGljRnJhbWU6IGZ1bmN0aW9uKHJlY29yZCkKKyAgICBfY3JlYXRlRnJhbWU6 IGZ1bmN0aW9uKHJlY29yZCkKICAgICB7CiAgICAgICAgIHZhciBmcmFtZSA9IG5ldyBXZWJJbnNw ZWN0b3IuVGltZWxpbmVGcmFtZSgpOwogICAgICAgICBmcmFtZS5zdGFydFRpbWUgPSBXZWJJbnNw ZWN0b3IuVGltZWxpbmVNb2RlbC5zdGFydFRpbWVJblNlY29uZHMocmVjb3JkKTsKICAgICAgICAg ZnJhbWUuc3RhcnRUaW1lT2Zmc2V0ID0gdGhpcy5fbW9kZWwucmVjb3JkT2Zmc2V0SW5TZWNvbmRz KHJlY29yZCk7Ci0gICAgICAgIGZyYW1lLmVuZFRpbWUgPSBXZWJJbnNwZWN0b3IuVGltZWxpbmVN b2RlbC5lbmRUaW1lSW5TZWNvbmRzKHJlY29yZCk7Ci0gICAgICAgIGZyYW1lLmR1cmF0aW9uID0g V2ViSW5zcGVjdG9yLlRpbWVsaW5lTW9kZWwuZHVyYXRpb25JblNlY29uZHMocmVjb3JkKTsKLSAg ICAgICAgZnJhbWUuY3B1VGltZSA9IGZyYW1lLmR1cmF0aW9uOwogICAgICAgICByZXR1cm4gZnJh bWU7CiAgICAgfSwKIAo=