88216 2012-06-04 00:29:06 -0700 [GTK] Memory leak in PasteboardHelper 2012-06-04 08:18:42 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis cgarcia gustavo mrobinson pnormand webkit.review.bot oldest_to_newest 640373 0 naginenis 2012-06-04 00:29:06 -0700 Valgrind reports the following memory leak in PasteboardHelper. ==18696== 752 (32 direct, 720 indirect) bytes in 2 blocks are definitely lost in loss record 35,564 of 40,079 ==18696== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==18696== by 0xB413A38: g_malloc (gmem.c:159) ==18696== by 0xB426C62: g_slice_alloc (gslice.c:1003) ==18696== by 0xA71EF02: gtk_target_list_new (gtkselection.c:228) ==18696== by 0x756EBE4: WebCore::PasteboardHelper::dropAtomsForContext(_GtkWidget*, _GdkDragContext*) (PasteboardHelper.cpp:263) ==18696== by 0x7560138: WebCore::queryNewDropContextData(WebCore::DroppingContext*, _GtkWidget*, unsigned int) (GtkDragAndDropHelper.cpp:128) ==18696== by 0x75602CB: WebCore::GtkDragAndDropHelper::handleDragMotion(_GdkDragContext*, WebCore::IntPoint const&, unsigned int) (GtkDragAndDropHelper.cpp:141) ==18696== by 0x61F7C58: webkit_web_view_drag_motion(_GtkWidget*, _GdkDragContext*, int, int, unsigned int) (webkitwebview.cpp:1512) ==18696== by 0xA6B1433: _gtk_marshal_BOOLEAN__OBJECT_INT_INT_UINT (gtkmarshalers.c:808) ==18696== by 0xB186CA1: g_closure_invoke (gclosure.c:777) ==18696== by 0xB198338: signal_emit_unlocked_R (gsignal.c:3585) ==18696== by 0xB19FD7D: g_signal_emit_valist (gsignal.c:3306) ==18696== by 0xB1A0753: g_signal_emit_by_name (gsignal.c:3389) ==18696== by 0xA8007D6: gtk_drag_dest_motion (gtkdnd.c:2312) ==18696== by 0xA800113: _gtk_drag_dest_handle_event (gtkdnd.c:1992) ==18696== by 0xA6AFF72: gtk_main_do_event (gtkmain.c:1750) ==18696== by 0xDD7AD11: gdk_event_source_dispatch (gdkeventsource.c:358) ==18696== by 0xB40DC99: g_main_context_dispatch (gmain.c:2515) ==18696== by 0xB40E05F: g_main_context_iterate.isra.23 (gmain.c:3123) ==18696== by 0xB40E459: g_main_loop_run (gmain.c:3317) ==18696== by 0xA6AF25C: gtk_main (gtkmain.c:1165) ==18696== by 0x40546C: main (main.c:534) ==18696== 640494 1 145563 naginenis 2012-06-04 05:17:21 -0700 Created attachment 145563 Patch Fixed memory leak in PasteboardHelper. Somehow I missed this leak fixing in r119063. 640604 2 145563 webkit.review.bot 2012-06-04 08:18:37 -0700 Comment on attachment 145563 Patch Clearing flags on attachment: 145563 Committed r119398: <http://trac.webkit.org/changeset/119398> 640605 3 webkit.review.bot 2012-06-04 08:18:42 -0700 All reviewed patches have been landed. Closing bug. 145563 2012-06-04 05:17:21 -0700 2012-06-04 08:18:37 -0700 Patch 88216.patch text/plain 1599 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiZWM4ZGUyLi4yMzRkMjcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMDYtMDQgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBs aW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0dUS10gTWVtb3J5IGxlYWsgaW4gUGFzdGVib2Fy ZEhlbHBlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODgyMTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG aXhlZCBhIG1lbW9yeSBsZWFrIGluIFBhc3RlYm9hcmRIZWxwZXIgYnkgdXNpbmcgYWRvcHRSZWYg aW5zdGVhZAorICAgICAgICBvZiBqdXN0IGdldHRpbmcgYSBuZXcgcmVmZXJlbmNlIG9mIFRhcmdl dExpc3QuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2Ugb2Ygbm8gYmVoYXZpb3IgY2hh bmdlcy4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9QYXN0ZWJvYXJkSGVscGVyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlBhc3RlYm9hcmRIZWxwZXI6OmRyb3BBdG9tc0ZvckNvbnRleHQpOgor CiAyMDEyLTA1LTMxICBLaW51a28gWWFzdWRhICA8a2ludWtvQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBbY2hyb21pdW1dIERhdGFUcmFuc2Zlckl0ZW0ud2Via2l0R2V0QXNFbnRyeSgpIHNob3Vs ZCBzeW5jaHJvbm91c2x5IHJldHVybiBlbnRyeQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3RrL1Bhc3RlYm9hcmRIZWxwZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3RrL1Bhc3RlYm9hcmRIZWxwZXIuY3BwCmluZGV4IDkxMGI2M2IuLjc2YTk3NTQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9QYXN0ZWJvYXJkSGVscGVyLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUGFzdGVib2FyZEhlbHBlci5jcHAKQEAg LTI1OCw3ICsyNTgsNyBAQCBWZWN0b3I8R2RrQXRvbT4gUGFzdGVib2FyZEhlbHBlcjo6ZHJvcEF0 b21zRm9yQ29udGV4dChHdGtXaWRnZXQqIHdpZGdldCwgR2RrRHJhZwogICAgIGRyb3BBdG9tcy5h cHBlbmQobmV0c2NhcGVVUkxBdG9tKTsKIAogICAgIC8vIEZvciBpbWFnZXMsIHRyeSB0byBmaW5k IHRoZSBtb3N0IGFwcGxpY2FibGUgaW1hZ2UgdHlwZS4KLSAgICBHUmVmUHRyPEd0a1RhcmdldExp c3Q+IGxpc3QoZ3RrX3RhcmdldF9saXN0X25ldygwLCAwKSk7CisgICAgR1JlZlB0cjxHdGtUYXJn ZXRMaXN0PiBsaXN0ID0gYWRvcHRHUmVmKGd0a190YXJnZXRfbGlzdF9uZXcoMCwgMCkpOwogICAg IGd0a190YXJnZXRfbGlzdF9hZGRfaW1hZ2VfdGFyZ2V0cyhsaXN0LmdldCgpLCBUYXJnZXRUeXBl SW1hZ2UsIFRSVUUpOwogICAgIEdka0F0b20gYXRvbSA9IGd0a19kcmFnX2Rlc3RfZmluZF90YXJn ZXQod2lkZ2V0LCBjb250ZXh0LCBsaXN0LmdldCgpKTsKICAgICBpZiAoYXRvbSAhPSBHREtfTk9O RSkK