88215 2012-06-04 00:24:21 -0700 [GTK] Memory leaks in AccessibilityUIElementGtk.cpp 2012-06-04 13:10:56 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis cgarcia gustavo mrobinson webkit.review.bot oldest_to_newest 640372 0 naginenis 2012-06-04 00:24:21 -0700 The following two memory leaks found in AccessibilityUIElementGtk.cpp ==6395== 18 bytes in 1 blocks are definitely lost in loss record 1,979 of 10,539 ==6395== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==6395== by 0xC38BA38: g_malloc (gmem.c:159) ==6395== by 0xC3A05B4: g_strconcat (gstrfuncs.c:581) ==6395== by 0x45A0F3: attributeSetToString(_GSList*) (AccessibilityUIElementGtk.cpp:144) ==6395== by 0x45A245: AccessibilityUIElement::allAttributes() (AccessibilityUIElementGtk.cpp:158) ==6395== by 0x44722A: allAttributesCallback(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**) (AccessibilityUIElement.cpp:41) ==6395== by 0x5244E27: JSC::JSCallbackFunction::call(JSC::ExecState*) (JSCallbackFunction.cpp:73) ==6395== by 0x54007D9: cti_op_call_NotJSFunction (JITStubs.cpp:2308) ==6395== by 0x53FBE00: JSC::JITThunks::tryCacheGetByID(JSC::ExecState*, JSC::CodeBlock*, JSC::ReturnAddressPtr, JSC::JSValue, JSC::Identifier const&, JSC::PropertySlot const&, JSC::StructureStubInfo*) ( ==6395== by 0x7FEFFDE0F: ??? ==6395== by 0x414E83F: ??? ==6395== by 0x27B0FD2F: ??? ==6395== by 0x416FA7F: ??? ==6395== ==6395== 32 bytes in 1 blocks are definitely lost in loss record 3,319 of 10,539 ==6395== at 0x4C2B7B2: realloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==6395== by 0xC38BAF6: g_realloc (gmem.c:224) ==6395== by 0xC3A25C6: g_string_maybe_expand (gstring.c:102) ==6395== by 0xC3A28D6: g_string_insert_len (gstring.c:444) ==6395== by 0x45A105: attributeSetToString(_GSList*) (AccessibilityUIElementGtk.cpp:144) ==6395== by 0x45A245: AccessibilityUIElement::allAttributes() (AccessibilityUIElementGtk.cpp:158) ==6395== by 0x44722A: allAttributesCallback(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**) (AccessibilityUIElement.cpp:41) ==6395== by 0x5244E27: JSC::JSCallbackFunction::call(JSC::ExecState*) (JSCallbackFunction.cpp:73) ==6395== by 0x54007D9: cti_op_call_NotJSFunction (JITStubs.cpp:2308) ==6395== by 0x53FBE00: JSC::JITThunks::tryCacheGetByID(JSC::ExecState*, JSC::CodeBlock*, JSC::ReturnAddressPtr, JSC::JSValue, JSC::Identifier const&, JSC::PropertySlot const&, JSC::StructureStubInfo*) ( ==6395== by 0x7FEFFDE0F: ??? ==6395== by 0x414F1BF: ??? ==6395== by 0x27B0FD2F: ??? ==6395== by 0x416FA7F: ??? 640525 1 145571 naginenis 2012-06-04 06:06:59 -0700 Created attachment 145571 Patch Fixed memory leaks in AccessibilityUIElementGtk.cpp 640681 2 145606 naginenis 2012-06-04 10:51:43 -0700 Created attachment 145606 Patch Fixed two leaks in AccessibilityUIElementGtk.cpp 640788 3 145606 webkit.review.bot 2012-06-04 13:10:51 -0700 Comment on attachment 145606 Patch Clearing flags on attachment: 145606 Committed r119422: <http://trac.webkit.org/changeset/119422> 640789 4 webkit.review.bot 2012-06-04 13:10:56 -0700 All reviewed patches have been landed. Closing bug. 145571 2012-06-04 06:06:59 -0700 2012-06-04 10:51:43 -0700 Patch 88215.patch text/plain 2163 naginenis ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjZmNh ZjBlLi5mNzM0ZDVhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDYtMDQgIFN1ZGFyc2FuYSBOYWdpbmVuaSAg PHN1ZGFyc2FuYS5uYWdpbmVuaUBsaW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0dUS10gTWVt b3J5IGxlYWtzIGluIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnRHdGsuY3BwCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODIxNQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVkIG1lbW9yeSBsZWFrcyBpbiBB Y2Nlc3NpYmlsaXR5VUlFbGVtZW50IGJ5IHVzaW5nIEdPd25QdHIKKyAgICAgICAgZm9yIG5ld2x5 IGFsbG9jYXRlZCBzdHJpbmdzLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZ3RrL0FjY2Vz c2liaWxpdHlVSUVsZW1lbnRHdGsuY3BwOgorICAgICAgICAoYXR0cmlidXRlU2V0VG9TdHJpbmcp OgorICAgICAgICAoQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6YWxsQXR0cmlidXRlcyk6CisKIDIw MTItMDYtMDMgIFZhcnVuIEphaW4gIDx2YXJ1bmphaW5AZ29vZ2xlLmNvbT4KIAogICAgICAgICBb Y2hyb21pdW1dIEFkZCBuZXcgZ2VzdHVyZSB0eXBlICh0d28gZmluZ2VyIHRhcCkgdGhhdCB0cmln Z2VycyBjb250ZXh0IG1lbnUuCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsv QWNjZXNzaWJpbGl0eVVJRWxlbWVudEd0ay5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsv QWNjZXNzaWJpbGl0eVVJRWxlbWVudEd0ay5jcHAKaW5kZXggY2VkYWNkYi4uODE5ZTE3MSAxMDA2 NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRH dGsuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9BY2Nlc3NpYmlsaXR5VUlFbGVt ZW50R3RrLmNwcApAQCAtMTQwLDcgKzE0MCw4IEBAIGdjaGFyKiBhdHRyaWJ1dGVTZXRUb1N0cmlu ZyhBdGtBdHRyaWJ1dGVTZXQqIGF0dHJpYnV0ZVNldCkKICAgICBHU3RyaW5nKiBzdHIgPSBnX3N0 cmluZ19uZXcoMCk7CiAgICAgZm9yIChHU0xpc3QqIGF0dHJpYnV0ZXMgPSBhdHRyaWJ1dGVTZXQ7 IGF0dHJpYnV0ZXM7IGF0dHJpYnV0ZXMgPSBhdHRyaWJ1dGVzLT5uZXh0KSB7CiAgICAgICAgIEF0 a0F0dHJpYnV0ZSogYXR0cmlidXRlID0gc3RhdGljX2Nhc3Q8QXRrQXR0cmlidXRlKj4oYXR0cmli dXRlcy0+ZGF0YSk7Ci0gICAgICAgIGdfc3RyaW5nX2FwcGVuZChzdHIsIGdfc3RyY29uY2F0KGF0 dHJpYnV0ZS0+bmFtZSwgIjoiLCBhdHRyaWJ1dGUtPnZhbHVlLCBOVUxMKSk7CisgICAgICAgIEdP d25QdHI8Z2NoYXI+IGF0dHJpYnV0ZVN0cihnX3N0cmNvbmNhdChhdHRyaWJ1dGUtPm5hbWUsICI6 IiwgYXR0cmlidXRlLT52YWx1ZSwgTlVMTCkpOworICAgICAgICBnX3N0cmluZ19hcHBlbmQoc3Ry LCBhdHRyaWJ1dGVTdHIuZ2V0KCkpOwogICAgICAgICBpZiAoYXR0cmlidXRlcy0+bmV4dCkKICAg ICAgICAgICAgIGdfc3RyaW5nX2FwcGVuZChzdHIsICIsICIpOwogICAgIH0KQEAgLTE1NCw3ICsx NTUsOCBAQCBKU1N0cmluZ1JlZiBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50OjphbGxBdHRyaWJ1dGVz KCkKICAgICAgICAgcmV0dXJuIEpTU3RyaW5nQ3JlYXRlV2l0aENoYXJhY3RlcnMoMCwgMCk7CiAK ICAgICBBU1NFUlQoQVRLX0lTX09CSkVDVChtX2VsZW1lbnQpKTsKLSAgICByZXR1cm4gSlNTdHJp bmdDcmVhdGVXaXRoVVRGOENTdHJpbmcoYXR0cmlidXRlU2V0VG9TdHJpbmcoYXRrX29iamVjdF9n ZXRfYXR0cmlidXRlcyhBVEtfT0JKRUNUKG1fZWxlbWVudCkpKSk7CisgICAgR093blB0cjxnY2hh cj4gYXR0cmlidXRlU3RyKGF0dHJpYnV0ZVNldFRvU3RyaW5nKGF0a19vYmplY3RfZ2V0X2F0dHJp YnV0ZXMoQVRLX09CSkVDVChtX2VsZW1lbnQpKSkpOworICAgIHJldHVybiBKU1N0cmluZ0NyZWF0 ZVdpdGhVVEY4Q1N0cmluZyhhdHRyaWJ1dGVTdHIuZ2V0KCkpOwogfQogCiBKU1N0cmluZ1JlZiBB Y2Nlc3NpYmlsaXR5VUlFbGVtZW50OjphdHRyaWJ1dGVzT2ZMaW5rZWRVSUVsZW1lbnRzKCkK 145606 2012-06-04 10:51:43 -0700 2012-06-04 13:10:51 -0700 Patch 88215.patch text/plain 2167 naginenis ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjZmNh ZjBlLi5mNzM0ZDVhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDYtMDQgIFN1ZGFyc2FuYSBOYWdpbmVuaSAg PHN1ZGFyc2FuYS5uYWdpbmVuaUBsaW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0dUS10gTWVt b3J5IGxlYWtzIGluIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnRHdGsuY3BwCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODIxNQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVkIG1lbW9yeSBsZWFrcyBpbiBB Y2Nlc3NpYmlsaXR5VUlFbGVtZW50IGJ5IHVzaW5nIEdPd25QdHIKKyAgICAgICAgZm9yIG5ld2x5 IGFsbG9jYXRlZCBzdHJpbmdzLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZ3RrL0FjY2Vz c2liaWxpdHlVSUVsZW1lbnRHdGsuY3BwOgorICAgICAgICAoYXR0cmlidXRlU2V0VG9TdHJpbmcp OgorICAgICAgICAoQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6YWxsQXR0cmlidXRlcyk6CisKIDIw MTItMDYtMDMgIFZhcnVuIEphaW4gIDx2YXJ1bmphaW5AZ29vZ2xlLmNvbT4KIAogICAgICAgICBb Y2hyb21pdW1dIEFkZCBuZXcgZ2VzdHVyZSB0eXBlICh0d28gZmluZ2VyIHRhcCkgdGhhdCB0cmln Z2VycyBjb250ZXh0IG1lbnUuCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsv QWNjZXNzaWJpbGl0eVVJRWxlbWVudEd0ay5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsv QWNjZXNzaWJpbGl0eVVJRWxlbWVudEd0ay5jcHAKaW5kZXggY2VkYWNkYi4uZDU0M2Q0OCAxMDA2 NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRH dGsuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9BY2Nlc3NpYmlsaXR5VUlFbGVt ZW50R3RrLmNwcApAQCAtMTQwLDcgKzE0MCw4IEBAIGdjaGFyKiBhdHRyaWJ1dGVTZXRUb1N0cmlu ZyhBdGtBdHRyaWJ1dGVTZXQqIGF0dHJpYnV0ZVNldCkKICAgICBHU3RyaW5nKiBzdHIgPSBnX3N0 cmluZ19uZXcoMCk7CiAgICAgZm9yIChHU0xpc3QqIGF0dHJpYnV0ZXMgPSBhdHRyaWJ1dGVTZXQ7 IGF0dHJpYnV0ZXM7IGF0dHJpYnV0ZXMgPSBhdHRyaWJ1dGVzLT5uZXh0KSB7CiAgICAgICAgIEF0 a0F0dHJpYnV0ZSogYXR0cmlidXRlID0gc3RhdGljX2Nhc3Q8QXRrQXR0cmlidXRlKj4oYXR0cmli dXRlcy0+ZGF0YSk7Ci0gICAgICAgIGdfc3RyaW5nX2FwcGVuZChzdHIsIGdfc3RyY29uY2F0KGF0 dHJpYnV0ZS0+bmFtZSwgIjoiLCBhdHRyaWJ1dGUtPnZhbHVlLCBOVUxMKSk7CisgICAgICAgIEdP d25QdHI8Z2NoYXI+IGF0dHJpYnV0ZURhdGEoZ19zdHJjb25jYXQoYXR0cmlidXRlLT5uYW1lLCAi OiIsIGF0dHJpYnV0ZS0+dmFsdWUsIE5VTEwpKTsKKyAgICAgICAgZ19zdHJpbmdfYXBwZW5kKHN0 ciwgYXR0cmlidXRlRGF0YS5nZXQoKSk7CiAgICAgICAgIGlmIChhdHRyaWJ1dGVzLT5uZXh0KQog ICAgICAgICAgICAgZ19zdHJpbmdfYXBwZW5kKHN0ciwgIiwgIik7CiAgICAgfQpAQCAtMTU0LDcg KzE1NSw4IEBAIEpTU3RyaW5nUmVmIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmFsbEF0dHJpYnV0 ZXMoKQogICAgICAgICByZXR1cm4gSlNTdHJpbmdDcmVhdGVXaXRoQ2hhcmFjdGVycygwLCAwKTsK IAogICAgIEFTU0VSVChBVEtfSVNfT0JKRUNUKG1fZWxlbWVudCkpOwotICAgIHJldHVybiBKU1N0 cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZyhhdHRyaWJ1dGVTZXRUb1N0cmluZyhhdGtfb2JqZWN0 X2dldF9hdHRyaWJ1dGVzKEFUS19PQkpFQ1QobV9lbGVtZW50KSkpKTsKKyAgICBHT3duUHRyPGdj aGFyPiBhdHRyaWJ1dGVEYXRhKGF0dHJpYnV0ZVNldFRvU3RyaW5nKGF0a19vYmplY3RfZ2V0X2F0 dHJpYnV0ZXMoQVRLX09CSkVDVChtX2VsZW1lbnQpKSkpOworICAgIHJldHVybiBKU1N0cmluZ0Ny ZWF0ZVdpdGhVVEY4Q1N0cmluZyhhdHRyaWJ1dGVEYXRhLmdldCgpKTsKIH0KIAogSlNTdHJpbmdS ZWYgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6YXR0cmlidXRlc09mTGlua2VkVUlFbGVtZW50cygp Cg==