88213 2012-06-03 23:58:42 -0700 [GTK] Memory leaks in DumpRenderTree.cpp 2012-06-04 12:31:18 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis cgarcia gustavo mrobinson pnormand webkit.review.bot oldest_to_newest 640358 0 naginenis 2012-06-03 23:58:42 -0700 The following two memory leaks found in DumpRenderTree.cpp ==769== 10 bytes in 2 blocks are definitely lost in loss record 574 of 10,697 ==769== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==769== by 0xC5D2A38: g_malloc (gmem.c:159) ==769== by 0xC5E7348: g_strndup (gstrfuncs.c:420) ==769== by 0x45D4C7: dumpHistoryItem(_WebKitWebHistoryItem*, int, bool) (DumpRenderTree.cpp:278) ==769== by 0x45D8B9: dumpBackForwardListForWebView(_WebKitWebView*) (DumpRenderTree.cpp:348) ==769== by 0x45D91A: dumpBackForwardListForAllWebViews() (DumpRenderTree.cpp:359) ==769== by 0x45E323: dump() (DumpRenderTree.cpp:564) ==769== by 0x45F841: topLoadingFrameLoadFinished() (DumpRenderTree.cpp:1029) ==769== by 0x45F97E: webFrameLoadStatusNotified(_WebKitWebFrame*, void*) (DumpRenderTree.cpp:1059) ==769== by 0xC345CA1: g_closure_invoke (gclosure.c:777) ==769== by 0xC356D70: signal_emit_unlocked_R (gsignal.c:3547) ==769== by 0xC35F098: g_signal_emit_valist (gsignal.c:3296) ==769== by 0xC35F241: g_signal_emit (gsignal.c:3352) ==769== by 0xC34A956: g_object_dispatch_properties_changed (gobject.c:1041) ==769== by 0xC34C232: g_object_notify (gobject.c:1133) ==769== by 0x6CF2DC1: WebKit::notifyStatus(_WebKitWebFrame*, WebKitLoadStatus) (FrameLoaderClientGtk.cpp:130) ==769== by 0x6CF2E59: WebKit::loadDone(_WebKitWebFrame*, bool) (FrameLoaderClientGtk.cpp:143) ==769== by 0x6CF52BE: WebKit::FrameLoaderClient::dispatchDidFinishLoad() (FrameLoaderClientGtk.cpp:621) ==769== by 0x74B3111: WebCore::FrameLoader::checkLoadCompleteForThisFrame() (FrameLoader.cpp:2112) ==769== by 0x74B3D23: WebCore::FrameLoader::checkLoadComplete() (FrameLoader.cpp:2290) ==769== by 0x749B077: WebCore::DocumentLoader::finishedLoading() (DocumentLoader.cpp:303) ==769== by 0x74E79CA: WebCore::MainResourceLoader::didFinishLoading(double) (MainResourceLoader.cpp:544) ==769== by 0x74F3332: WebCore::ResourceLoader::didFinishLoading(WebCore::ResourceHandle*, double) (ResourceLoader.cpp:435) ==769== by 0x769668B: WebCore::readCallback(_GObject*, _GAsyncResult*, void*) (ResourceHandleSoup.cpp:864) ==769== by 0xC041918: async_ready_callback_wrapper (ginputstream.c:470) ==769== by 0xC053F56: g_simple_async_result_complete (gsimpleasyncresult.c:767) ==769== by 0xC053FD7: complete_in_idle_cb_for_thread (gsimpleasyncresult.c:835) ==769== by 0xC5CCC99: g_main_context_dispatch (gmain.c:2515) ==769== by 0xC5CD05F: g_main_context_iterate.isra.23 (gmain.c:3123) ==769== by 0xC5CD459: g_main_loop_run (gmain.c:3317) ==769== by 0xB3CE25C: gtk_main (gtkmain.c:1165) ==769== by 0x45E97E: runTest(std::string const&) (DumpRenderTree.cpp:702) ==769== by 0x46104A: main (DumpRenderTree.cpp:1388) ==769== 125 bytes in 1 blocks are definitely lost in loss record 8,905 of 10,697 ==769== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==769== by 0xD393A57: __vasprintf_chk (vasprintf_chk.c:82) ==769== by 0xC607D7A: g_vasprintf (stdio2.h:199) ==769== by 0xC5E745C: g_strdup_vprintf (gstrfuncs.c:509) ==769== by 0xC5E74FB: g_strdup_printf (gstrfuncs.c:535) ==769== by 0x45D2AC: dumpFramesAsText(_WebKitWebFrame*) (DumpRenderTree.cpp:244) ==769== by 0x45D2EF: dumpFramesAsText(_WebKitWebFrame*) (DumpRenderTree.cpp:250) ==769== by 0x45E198: dump() (DumpRenderTree.cpp:532) ==769== by 0x45F841: topLoadingFrameLoadFinished() (DumpRenderTree.cpp:1029) ==769== by 0x45F97E: webFrameLoadStatusNotified(_WebKitWebFrame*, void*) (DumpRenderTree.cpp:1059) ==769== by 0xC345CA1: g_closure_invoke (gclosure.c:777) ==769== by 0xC356D70: signal_emit_unlocked_R (gsignal.c:3547) ==769== by 0xC35F098: g_signal_emit_valist (gsignal.c:3296) ==769== by 0xC35F241: g_signal_emit (gsignal.c:3352) ==769== by 0xC34A956: g_object_dispatch_properties_changed (gobject.c:1041) ==769== by 0xC34C232: g_object_notify (gobject.c:1133) ==769== by 0x6CF2DC1: WebKit::notifyStatus(_WebKitWebFrame*, WebKitLoadStatus) (FrameLoaderClientGtk.cpp:130) ==769== by 0x6CF2E59: WebKit::loadDone(_WebKitWebFrame*, bool) (FrameLoaderClientGtk.cpp:143) ==769== by 0x6CF52BE: WebKit::FrameLoaderClient::dispatchDidFinishLoad() (FrameLoaderClientGtk.cpp:621) ==769== by 0x74B3111: WebCore::FrameLoader::checkLoadCompleteForThisFrame() (FrameLoader.cpp:2112) ==769== by 0x74B3D23: WebCore::FrameLoader::checkLoadComplete() (FrameLoader.cpp:2290) ==769== by 0x749B077: WebCore::DocumentLoader::finishedLoading() (DocumentLoader.cpp:303) ==769== by 0x74E79CA: WebCore::MainResourceLoader::didFinishLoading(double) (MainResourceLoader.cpp:544) ==769== by 0x74F3332: WebCore::ResourceLoader::didFinishLoading(WebCore::ResourceHandle*, double) (ResourceLoader.cpp:435) ==769== by 0x769668B: WebCore::readCallback(_GObject*, _GAsyncResult*, void*) (ResourceHandleSoup.cpp:864) ==769== by 0xC041918: async_ready_callback_wrapper (ginputstream.c:470) ==769== by 0xC053F56: g_simple_async_result_complete (gsimpleasyncresult.c:767) ==769== by 0xC053FD7: complete_in_idle_cb_for_thread (gsimpleasyncresult.c:835) ==769== by 0xC5CCC99: g_main_context_dispatch (gmain.c:2515) ==769== by 0xC5CD05F: g_main_context_iterate.isra.23 (gmain.c:3123) ==769== by 0xC5CD459: g_main_loop_run (gmain.c:3317) ==769== by 0xB3CE25C: gtk_main (gtkmain.c:1165) ==769== by 0x45E97E: runTest(std::string const&) (DumpRenderTree.cpp:702) ==769== by 0x46104A: main (DumpRenderTree.cpp:1388) 640394 1 145534 naginenis 2012-06-04 01:19:36 -0700 Created attachment 145534 Patch Fixed memory leaks in DumpRenderTree.cpp. 640580 2 145534 mrobinson 2012-06-04 07:45:48 -0700 Comment on attachment 145534 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145534&action=review Looks good, though I think there should be one change... > Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:139 > + g_free(string); I think it makes sense for this function to accept a const char* as the second argument and have the caller responsible for cleaning up the string. 640646 3 145599 naginenis 2012-06-04 09:57:30 -0700 Created attachment 145599 Patch Fixed review comment #2. Thanks for your review Martin. 640748 4 145599 webkit.review.bot 2012-06-04 12:31:08 -0700 Comment on attachment 145599 Patch Clearing flags on attachment: 145599 Committed r119416: <http://trac.webkit.org/changeset/119416> 640749 5 webkit.review.bot 2012-06-04 12:31:18 -0700 All reviewed patches have been landed. Closing bug. 145534 2012-06-04 01:19:36 -0700 2012-06-04 09:57:30 -0700 Patch 88213.patch text/plain 1731 naginenis ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjZmNh ZjBlLi4wYTIxZjVjIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDYtMDQgIFN1ZGFyc2FuYSBOYWdpbmVuaSAg PHN1ZGFyc2FuYS5uYWdpbmVuaUBsaW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0dUS10gTWVt b3J5IGxlYWtzIGluIER1bXBSZW5kZXJUcmVlLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODgyMTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlZCB0d28gbWVtb3J5IGxlYWtzIGluIER1bXBSZW5k ZXJUcmVlLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNw cDoKKyAgICAgICAgKGFwcGVuZFN0cmluZyk6IEZyZWUgdGhlIHN0cmluZyByZXR1cm5lZCBieSBn X3N0cmR1cF9wcmludGYoKS4KKyAgICAgICAgKGR1bXBIaXN0b3J5SXRlbSk6IEZyZWUgdGhlIHN0 cmluZyByZXR1cm5lZCBieSBnX3VyaV9wYXJzZV9zY2hlbWUoKS4KKwogMjAxMi0wNi0wMyAgVmFy dW4gSmFpbiAgPHZhcnVuamFpbkBnb29nbGUuY29tPgogCiAgICAgICAgIFtjaHJvbWl1bV0gQWRk IG5ldyBnZXN0dXJlIHR5cGUgKHR3byBmaW5nZXIgdGFwKSB0aGF0IHRyaWdnZXJzIGNvbnRleHQg bWVudS4KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJl ZS5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwCmluZGV4 IDE4YWFmYWYuLmU2MmNjOWYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9E dW1wUmVuZGVyVHJlZS5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5k ZXJUcmVlLmNwcApAQCAtMTM2LDYgKzEzNiw3IEBAIHN0YXRpYyB2b2lkIGFwcGVuZFN0cmluZyhn Y2hhciomIHRhcmdldCwgZ2NoYXIqIHN0cmluZykKICAgICBnY2hhciogb2xkU3RyaW5nID0gdGFy Z2V0OwogICAgIHRhcmdldCA9IGdfc3RyY29uY2F0KHRhcmdldCwgc3RyaW5nLCBOVUxMKTsKICAg ICBnX2ZyZWUob2xkU3RyaW5nKTsKKyAgICBnX2ZyZWUoc3RyaW5nKTsKIH0KIAogc3RhdGljIHZv aWQgaW5pdGlhbGl6ZUd0a0ZvbnRTZXR0aW5ncyhjb25zdCBjaGFyKiB0ZXN0VVJMKQpAQCAtMjc4 LDggKzI3OSwxMCBAQCBzdGF0aWMgdm9pZCBkdW1wSGlzdG9yeUl0ZW0oV2ViS2l0V2ViSGlzdG9y eUl0ZW0qIGl0ZW0sIGludCBpbmRlbnQsIGJvb2wgY3VycmVudAogICAgIGdjaGFyKiB1cmlTY2hl bWUgPSBnX3VyaV9wYXJzZV9zY2hlbWUodXJpKTsKICAgICBpZiAoZ19zdHJjbXAwKHVyaVNjaGVt ZSwgImZpbGUiKSA9PSAwKSB7CiAgICAgICAgIGdjaGFyKiBwb3MgPSBnX3N0cnN0cl9sZW4odXJp LCAtMSwgIi9MYXlvdXRUZXN0cy8iKTsKLSAgICAgICAgaWYgKCFwb3MpCisgICAgICAgIGlmICgh cG9zKSB7CisgICAgICAgICAgICBnX2ZyZWUodXJpU2NoZW1lKTsKICAgICAgICAgICAgIHJldHVy bjsKKyAgICAgICAgfQogCiAgICAgICAgIEdTdHJpbmcqIHJlc3VsdCA9IGdfc3RyaW5nX3NpemVk X25ldyhzdHJsZW4odXJpKSk7CiAgICAgICAgIHJlc3VsdCA9IGdfc3RyaW5nX2FwcGVuZChyZXN1 bHQsICIoZmlsZSB0ZXN0KToiKTsK 145599 2012-06-04 09:57:30 -0700 2012-06-04 12:31:07 -0700 Patch 88213.patch text/plain 2505 naginenis ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjZmNh ZjBlLi44N2FhYjBlIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDYtMDQgIFN1ZGFyc2FuYSBOYWdpbmVuaSAg PHN1ZGFyc2FuYS5uYWdpbmVuaUBsaW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0dUS10gTWVt b3J5IGxlYWtzIGluIER1bXBSZW5kZXJUcmVlLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODgyMTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlZCBtZW1vcnkgbGVha3MgaW4gRHVtcFJlbmRlclRy ZWUuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwOgor ICAgICAgICAoYXBwZW5kU3RyaW5nKTogQWNjZXB0cyBjb25zdCBnY2hhciogYXMgdGhlIHNlY29u ZCBhcmd1bWVudC4KKyAgICAgICAgKGR1bXBGcmFtZXNBc1RleHQpOiBGcmVlIHRoZSBzdHJpbmcg cmV0dXJuZWQgYnkgZ19zdHJkdXBfcHJpbnRmKCkuCisgICAgICAgIChkdW1wSGlzdG9yeUl0ZW0p OiBGcmVlIHRoZSBzdHJpbmcgcmV0dXJuZWQgYnkgZ191cmlfcGFyc2Vfc2NoZW1lKCkuCisKIDIw MTItMDYtMDMgIFZhcnVuIEphaW4gIDx2YXJ1bmphaW5AZ29vZ2xlLmNvbT4KIAogICAgICAgICBb Y2hyb21pdW1dIEFkZCBuZXcgZ2VzdHVyZSB0eXBlICh0d28gZmluZ2VyIHRhcCkgdGhhdCB0cmln Z2VycyBjb250ZXh0IG1lbnUuCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsv RHVtcFJlbmRlclRyZWUuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJU cmVlLmNwcAppbmRleCAxOGFhZmFmLi4zZDZiMGU1IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVu ZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAKQEAgLTEzMSw3ICsxMzEsNyBAQCB2b2lkIGRpc3BsYXlX ZWJWaWV3KCkKICAgICBndGtfd2lkZ2V0X3F1ZXVlX2RyYXcoR1RLX1dJREdFVCh3ZWJWaWV3KSk7 CiB9CiAKLXN0YXRpYyB2b2lkIGFwcGVuZFN0cmluZyhnY2hhciomIHRhcmdldCwgZ2NoYXIqIHN0 cmluZykKK3N0YXRpYyB2b2lkIGFwcGVuZFN0cmluZyhnY2hhciomIHRhcmdldCwgY29uc3QgZ2No YXIqIHN0cmluZykKIHsKICAgICBnY2hhciogb2xkU3RyaW5nID0gdGFyZ2V0OwogICAgIHRhcmdl dCA9IGdfc3RyY29uY2F0KHRhcmdldCwgc3RyaW5nLCBOVUxMKTsKQEAgLTI0Niw4ICsyNDYsMTAg QEAgc3RhdGljIGdjaGFyKiBkdW1wRnJhbWVzQXNUZXh0KFdlYktpdFdlYkZyYW1lKiBmcmFtZSkK IAogICAgIGlmIChnTGF5b3V0VGVzdENvbnRyb2xsZXItPmR1bXBDaGlsZEZyYW1lc0FzVGV4dCgp KSB7CiAgICAgICAgIEdTTGlzdCogY2hpbGRyZW4gPSBEdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGs6 OmdldEZyYW1lQ2hpbGRyZW4oZnJhbWUpOwotICAgICAgICBmb3IgKEdTTGlzdCogY2hpbGQgPSBj aGlsZHJlbjsgY2hpbGQ7IGNoaWxkID0gZ19zbGlzdF9uZXh0KGNoaWxkKSkKLSAgICAgICAgICAg IGFwcGVuZFN0cmluZyhyZXN1bHQsIGR1bXBGcmFtZXNBc1RleHQoc3RhdGljX2Nhc3Q8V2ViS2l0 V2ViRnJhbWUqID4oY2hpbGQtPmRhdGEpKSk7CisgICAgICAgIGZvciAoR1NMaXN0KiBjaGlsZCA9 IGNoaWxkcmVuOyBjaGlsZDsgY2hpbGQgPSBnX3NsaXN0X25leHQoY2hpbGQpKSB7CisgICAgICAg ICAgICBHT3duUHRyPGdjaGFyPiBjaGlsZERhdGEoZHVtcEZyYW1lc0FzVGV4dChzdGF0aWNfY2Fz dDxXZWJLaXRXZWJGcmFtZSo+KGNoaWxkLT5kYXRhKSkpOworICAgICAgICAgICAgYXBwZW5kU3Ry aW5nKHJlc3VsdCwgY2hpbGREYXRhLmdldCgpKTsKKyAgICAgICAgfQogICAgICAgICBnX3NsaXN0 X2ZyZWUoY2hpbGRyZW4pOwogICAgIH0KIApAQCAtMjc4LDggKzI4MCwxMCBAQCBzdGF0aWMgdm9p ZCBkdW1wSGlzdG9yeUl0ZW0oV2ViS2l0V2ViSGlzdG9yeUl0ZW0qIGl0ZW0sIGludCBpbmRlbnQs IGJvb2wgY3VycmVudAogICAgIGdjaGFyKiB1cmlTY2hlbWUgPSBnX3VyaV9wYXJzZV9zY2hlbWUo dXJpKTsKICAgICBpZiAoZ19zdHJjbXAwKHVyaVNjaGVtZSwgImZpbGUiKSA9PSAwKSB7CiAgICAg ICAgIGdjaGFyKiBwb3MgPSBnX3N0cnN0cl9sZW4odXJpLCAtMSwgIi9MYXlvdXRUZXN0cy8iKTsK LSAgICAgICAgaWYgKCFwb3MpCisgICAgICAgIGlmICghcG9zKSB7CisgICAgICAgICAgICBnX2Zy ZWUodXJpU2NoZW1lKTsKICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQogCiAgICAgICAg IEdTdHJpbmcqIHJlc3VsdCA9IGdfc3RyaW5nX3NpemVkX25ldyhzdHJsZW4odXJpKSk7CiAgICAg ICAgIHJlc3VsdCA9IGdfc3RyaW5nX2FwcGVuZChyZXN1bHQsICIoZmlsZSB0ZXN0KToiKTsK