88209 2012-06-03 20:55:17 -0700 Use SelectorQuery in Element::webkitMatchesSelector() 2012-06-04 01:52:30 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 87625 1 haraken haraken cmarcelo darin koivisto webkit.review.bot oldest_to_newest 640291 0 haraken 2012-06-03 20:55:17 -0700 By using SelectorQuery in Element::webkitMatchesSelector(), we can not only simplify the code but also improve the performance thanks to the cache mechanism of SelectorQuery which was implemented in bug 87942. 640292 1 145511 haraken 2012-06-03 20:58:25 -0700 Created attachment 145511 Patch 640293 2 haraken 2012-06-03 20:59:07 -0700 I've found that SelectorDataList::matches() had been used by nobody before this patch:) 640405 3 145511 koivisto 2012-06-04 01:39:37 -0700 Comment on attachment 145511 Patch r=me 640414 4 145511 webkit.review.bot 2012-06-04 01:52:24 -0700 Comment on attachment 145511 Patch Clearing flags on attachment: 145511 Committed r119375: <http://trac.webkit.org/changeset/119375> 640415 5 webkit.review.bot 2012-06-04 01:52:30 -0700 All reviewed patches have been landed. Closing bug. 145511 2012-06-03 20:58:25 -0700 2012-06-04 01:52:24 -0700 Patch bug-88209-20120604125824.patch text/plain 4120 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MzY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTZkYmFhZGZkYmY1YzA2 MzZmYzM4YzU5ZjkwNGVmZWRkYzYxN2QyNy4uMzM0MjYzYTVlZjc5NmI0MDRjZGRiODhkZTY4NjU1 NzVmYjlhZGY0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA2LTAzICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBVc2UgU2VsZWN0b3JR dWVyeSBpbiBFbGVtZW50Ojp3ZWJraXRNYXRjaGVzU2VsZWN0b3IoKQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODgyMDkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCeSB1c2luZyBTZWxlY3RvclF1ZXJ5IGlu IEVsZW1lbnQ6OndlYmtpdE1hdGNoZXNTZWxlY3RvcigpLAorICAgICAgICB3ZSBjYW4gbm90IG9u bHkgc2ltcGxpZnkgdGhlIGNvZGUgYnV0IGFsc28gaW1wcm92ZSB0aGUgcGVyZm9ybWFuY2UKKyAg ICAgICAgdGhhbmtzIHRvIHRoZSBjYWNoZSBtZWNoYW5pc20gb2YgU2VsZWN0b3JRdWVyeSB3aGlj aCB3YXMgaW1wbGVtZW50ZWQKKyAgICAgICAgaW4gYnVnIDg3OTQyLgorCisgICAgICAgIFRlc3Rz OiBmYXN0L2RvbS9TZWxlY3RvckFQSS8qLiBObyBjaGFuZ2UgaW4gdGVzdCByZXN1bHRzLgorCisg ICAgICAgICogZG9tL0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudDo6d2Vi a2l0TWF0Y2hlc1NlbGVjdG9yKToKKyAgICAgICAgKiBkb20vU2VsZWN0b3JRdWVyeS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpTZWxlY3RvclF1ZXJ5OjptYXRjaGVzKToKKyAgICAgICAgKFdlYkNv cmUpOgorICAgICAgICAqIGRvbS9TZWxlY3RvclF1ZXJ5Lmg6CisgICAgICAgIChTZWxlY3RvclF1 ZXJ5KToKKwogMjAxMi0wNi0wMyAgSGF5YXRvIEl0byAgPGhheWF0b0BjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgU3VwcG9ydHMgdHJhdmVyc2luZyBub2RlcyBpbiBhbiBvcnBoYW5lZCBzaGFkb3cg c3VidHJlZSBpbiBDb21wb3NlZFNoYWRvd1RyZWVQYXJlbnRXYWxrZXIuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVu dC5jcHAKaW5kZXggMjIyY2E5MDk4NDI1ZWZiNTk2N2RmNzFkNjZhYjgwZTEwODVkZjNkMi4uMjgw NDc0NjhmOTIzNzc5N2IwYzEwNTI1YzE1Mjg5YjcxOGMwYzZiMiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50 LmNwcApAQCAtNjAsNiArNjAsNyBAQAogI2luY2x1ZGUgIlJlbmRlclJlZ2lvbi5oIgogI2luY2x1 ZGUgIlJlbmRlclZpZXcuaCIKICNpbmNsdWRlICJSZW5kZXJXaWRnZXQuaCIKKyNpbmNsdWRlICJT ZWxlY3RvclF1ZXJ5LmgiCiAjaW5jbHVkZSAiU2V0dGluZ3MuaCIKICNpbmNsdWRlICJTaGFkb3dS b290LmgiCiAjaW5jbHVkZSAiU3R5bGVSZXNvbHZlci5oIgpAQCAtMTc2NCwyOSArMTc2NSwxMSBA QCBib29sIEVsZW1lbnQ6OndlYmtpdE1hdGNoZXNTZWxlY3Rvcihjb25zdCBTdHJpbmcmIHNlbGVj dG9yLCBFeGNlcHRpb25Db2RlJiBlYykKICAgICAgICAgZWMgPSBTWU5UQVhfRVJSOwogICAgICAg ICByZXR1cm4gZmFsc2U7CiAgICAgfQotICAgIENTU1BhcnNlckNvbnRleHQgcGFyc2VyQ29udGV4 dChkb2N1bWVudCgpKTsKLSAgICBDU1NQYXJzZXIgcGFyc2VyKHBhcnNlckNvbnRleHQpOwotICAg IENTU1NlbGVjdG9yTGlzdCBzZWxlY3Rvckxpc3Q7Ci0gICAgcGFyc2VyLnBhcnNlU2VsZWN0b3Io c2VsZWN0b3IsIHNlbGVjdG9yTGlzdCk7CiAKLSAgICBpZiAoIXNlbGVjdG9yTGlzdC5maXJzdCgp KSB7Ci0gICAgICAgIGVjID0gU1lOVEFYX0VSUjsKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotICAg IH0KLQotICAgIC8vIFRocm93IGEgTkFNRVNQQUNFX0VSUiBpZiB0aGUgc2VsZWN0b3IgaW5jbHVk ZXMgYW55IG5hbWVzcGFjZSBwcmVmaXhlcy4KLSAgICBpZiAoc2VsZWN0b3JMaXN0LnNlbGVjdG9y c05lZWROYW1lc3BhY2VSZXNvbHV0aW9uKCkpIHsKLSAgICAgICAgZWMgPSBOQU1FU1BBQ0VfRVJS OworICAgIFNlbGVjdG9yUXVlcnkqIHNlbGVjdG9yUXVlcnkgPSBkb2N1bWVudCgpLT5zZWxlY3Rv clF1ZXJ5Q2FjaGUoKS0+YWRkKHNlbGVjdG9yLCBkb2N1bWVudCgpLCBlYyk7CisgICAgaWYgKCFz ZWxlY3RvclF1ZXJ5KQogICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgfQotCi0gICAgU2VsZWN0 b3JDaGVja2VyIHNlbGVjdG9yQ2hlY2tlcihkb2N1bWVudCgpLCBwYXJzZXJDb250ZXh0Lm1vZGUg PT0gQ1NTU3RyaWN0TW9kZSk7Ci0gICAgZm9yIChDU1NTZWxlY3Rvciogc2VsZWN0b3IgPSBzZWxl Y3Rvckxpc3QuZmlyc3QoKTsgc2VsZWN0b3I7IHNlbGVjdG9yID0gQ1NTU2VsZWN0b3JMaXN0Ojpu ZXh0KHNlbGVjdG9yKSkgewotICAgICAgICBpZiAoc2VsZWN0b3JDaGVja2VyLmNoZWNrU2VsZWN0 b3Ioc2VsZWN0b3IsIHRoaXMpKQotICAgICAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgfQotCi0g ICAgcmV0dXJuIGZhbHNlOworICAgIHJldHVybiBzZWxlY3RvclF1ZXJ5LT5tYXRjaGVzKHRoaXMp OwogfQogCiBET01Ub2tlbkxpc3QqIEVsZW1lbnQ6OmNsYXNzTGlzdCgpCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9kb20vU2VsZWN0b3JRdWVyeS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20v U2VsZWN0b3JRdWVyeS5jcHAKaW5kZXggZmFkNjJhNWY2MzY1NTI3NzY4ZDE4MGEyNmM1YmZlYjYz MGVmNDE0Yi4uZTgwMTE2NmI0Y2RiZGVjM2NlNWU2ZDg3NTQ0YWI5NDgwMWMzZjEwOSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1NlbGVjdG9yUXVlcnkuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9TZWxlY3RvclF1ZXJ5LmNwcApAQCAtMTQ4LDYgKzE0OCwxMiBAQCB2b2lkIFNl bGVjdG9yUXVlcnk6OmluaXRpYWxpemUoY29uc3QgQ1NTU2VsZWN0b3JMaXN0JiBzZWxlY3Rvckxp c3QpCiAgICAgbV9zZWxlY3RvcnMuaW5pdGlhbGl6ZShzZWxlY3Rvckxpc3QpOwogfQogCitib29s IFNlbGVjdG9yUXVlcnk6Om1hdGNoZXMoRWxlbWVudCogZWxlbWVudCkgY29uc3QKK3sKKyAgICBT ZWxlY3RvckNoZWNrZXIgc2VsZWN0b3JDaGVja2VyKGVsZW1lbnQtPmRvY3VtZW50KCksICFlbGVt ZW50LT5kb2N1bWVudCgpLT5pblF1aXJrc01vZGUoKSk7CisgICAgcmV0dXJuIG1fc2VsZWN0b3Jz Lm1hdGNoZXMoc2VsZWN0b3JDaGVja2VyLCBlbGVtZW50KTsKK30KKwogUGFzc1JlZlB0cjxOb2Rl TGlzdD4gU2VsZWN0b3JRdWVyeTo6cXVlcnlBbGwoTm9kZSogcm9vdE5vZGUpIGNvbnN0CiB7CiAg ICAgU2VsZWN0b3JDaGVja2VyIHNlbGVjdG9yQ2hlY2tlcihyb290Tm9kZS0+ZG9jdW1lbnQoKSwg IXJvb3ROb2RlLT5kb2N1bWVudCgpLT5pblF1aXJrc01vZGUoKSk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9kb20vU2VsZWN0b3JRdWVyeS5oIGIvU291cmNlL1dlYkNvcmUvZG9tL1NlbGVj dG9yUXVlcnkuaAppbmRleCBiZTFhODE5NDIwMWU2YzMxMWQ2ZGY1ZWU2NzhkYTM3NTI5ZjdlZGU2 Li45MzkwZjAwNjBkMTdmZTBhMTMwMjIwYTg1NjE4MzkxZTgxMjc4Y2ZkIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9kb20vU2VsZWN0b3JRdWVyeS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Rv bS9TZWxlY3RvclF1ZXJ5LmgKQEAgLTcwLDYgKzcwLDcgQEAgY2xhc3MgU2VsZWN0b3JRdWVyeSB7 CiBwdWJsaWM6CiAgICAgU2VsZWN0b3JRdWVyeSgpIHsgfTsKICAgICB2b2lkIGluaXRpYWxpemUo Y29uc3QgQ1NTU2VsZWN0b3JMaXN0Jik7CisgICAgYm9vbCBtYXRjaGVzKEVsZW1lbnQqKSBjb25z dDsKICAgICBQYXNzUmVmUHRyPE5vZGVMaXN0PiBxdWVyeUFsbChOb2RlKiByb290Tm9kZSkgY29u c3Q7CiAgICAgUGFzc1JlZlB0cjxFbGVtZW50PiBxdWVyeUZpcnN0KE5vZGUqIHJvb3ROb2RlKSBj b25zdDsKIHByaXZhdGU6Cg==