88206 2012-06-03 19:30:49 -0700 DFG arguments simplification should have rationalized handling of TearOffArguments 2012-06-04 17:29:03 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo webkit-unassigned oldest_to_newest 640268 0 fpizlo 2012-06-03 19:30:49 -0700 Here's what should happen: the existence of TearOffArguments should have no effect on the conclusion reached by arguments simplification. Optimally, arguments simplification should eliminate the TearOffArguments opcode in those cases where it eliminates arguments creation. But that's not necessary for correctness. Currently, arguments simplification completely ignores TearOffArguments because it neglects to consider accesses to the unmodified arguments register. By some manner of dumb luck, this ends up "just working" because TearOffArguments is the only opcode that would explicitly read the unmodified arguments register. Of course, it works in a sub-optimal way, because the TearOffArguments op ends up still being emitted. This code should be rationalized and made to work in a sensible way. 640272 1 145506 fpizlo 2012-06-03 19:39:36 -0700 Created attachment 145506 the patch 640319 2 145506 ggaren 2012-06-03 22:29:03 -0700 Comment on attachment 145506 the patch r=me 641027 3 fpizlo 2012-06-04 17:29:03 -0700 Landed in http://trac.webkit.org/changeset/119444 145506 2012-06-03 19:39:36 -0700 2012-06-03 22:29:03 -0700 the patch cleanupargs_patch_1.diff text/plain 4051 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTE5MzY2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDEyLTA2LTAzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHIGFyZ3VtZW50cyBzaW1wbGlmaWNhdGlvbiBzaG91bGQgaGF2ZSByYXRpb25hbGl6ZWQgaGFu ZGxpbmcgb2YgVGVhck9mZkFyZ3VtZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODgyMDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKyAgICAgICAgCisgICAgICAgIC0gQWNjZXNzZXMgdG8gdGhlIHVubW9kaWZpZWQgYXJn dW1lbnRzIHJlZ2lzdGVyIG91Z2h0IHRvIGhhdmUgdGhlIHNhbWUgZWZmZWN0IG9uCisgICAgICAg ICAgYWxpYXMvZXNjYXBlIGFuYWx5c2lzIG9mIGFyZ3VtZW50cyBhcyBhY2Nlc3NlcyB0byB0aGUg bXV0YWJsZSBhcmd1bWVudHMgcmVnaXN0ZXIuCisgICAgICAgIAorICAgICAgICAtIFRoZSBleGlz dGVuY2Ugb2YgVGVhck9mZkFyZ3VtZW50cyBzaG91bGQgbm90IGdldCBpbiB0aGUgd2F5IG9mIGFy Z3VtZW50cyBhbGlhc2luZy4KKyAgICAgICAgCisgICAgICAgIC0gVGVhck9mZkFyZ3VtZW50cyBz aG91bGQgYmUgZWxpbWluYXRlZCBpZiBDcmVhdGVBcmd1bWVudHMgaXMgZWxpbWluYXRlZC4KKwor ICAgICAgICAqIGRmZy9ERkdBcmd1bWVudHNTaW1wbGlmaWNhdGlvblBoYXNlLmNwcDoKKyAgICAg ICAgKEpTQzo6REZHOjpBcmd1bWVudHNTaW1wbGlmaWNhdGlvblBoYXNlOjpydW4pOgorICAgICAg ICAoSlNDOjpERkc6OkFyZ3VtZW50c1NpbXBsaWZpY2F0aW9uUGhhc2U6Om9ic2VydmVCYWRBcmd1 bWVudHNVc2UpOgorCiAyMDEyLTA2LTAyICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5j b20+CiAKICAgICAgICAgV2VhayBwb2ludGVyIGZpbmFsaXphdGlvbiBzaG91bGQgYmUgbGF6eQpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBcmd1bWVudHNTaW1wbGlmaWNhdGlv blBoYXNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fy Z3VtZW50c1NpbXBsaWZpY2F0aW9uUGhhc2UuY3BwCShyZXZpc2lvbiAxMTkzNjYpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0FyZ3VtZW50c1NpbXBsaWZpY2F0aW9uUGhhc2UuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0xNzAsNiArMTcwLDEyIEBAIHB1YmxpYzoKICAgICAgICAgICAg ICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgICAgICAK KyAgICAgICAgICAgICAgICBjYXNlIFRlYXJPZmZBcmd1bWVudHM6IHsKKyAgICAgICAgICAgICAg ICAgICAgLy8gSWdub3JlIGFyZ3VtZW50cyB0ZWFyIG9mZiwgYmVjYXVzZSBpdCdzIG9ubHkgcmVs ZXZhbnQgaWYgd2UgYWN0dWFsbHkKKyAgICAgICAgICAgICAgICAgICAgLy8gbmVlZCB0byBjcmVh dGUgdGhlIGFyZ3VtZW50cy4KKyAgICAgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAg ICAgICAgfQorICAgICAgICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICBjYXNlIFNldExv Y2FsOiB7CiAgICAgICAgICAgICAgICAgICAgIE5vZGUmIHNvdXJjZSA9IG1fZ3JhcGhbbm9kZS5j aGlsZDEoKV07CiAgICAgICAgICAgICAgICAgICAgIFZhcmlhYmxlQWNjZXNzRGF0YSogdmFyaWFi bGVBY2Nlc3NEYXRhID0gbm9kZS52YXJpYWJsZUFjY2Vzc0RhdGEoKTsKQEAgLTE5Myw5ICsxOTks MTAgQEAgcHVibGljOgogICAgICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgICAg IGludCBhcmd1bWVudHNSZWdpc3RlciA9CiAgICAgICAgICAgICAgICAgICAgICAgICBtX2dyYXBo LnVuY2hlY2tlZEFyZ3VtZW50c1JlZ2lzdGVyRm9yKG5vZGUuY29kZU9yaWdpbik7Ci0gICAgICAg ICAgICAgICAgICAgIGlmICh2YXJpYWJsZUFjY2Vzc0RhdGEtPmxvY2FsKCkgPT0gYXJndW1lbnRz UmVnaXN0ZXIKLSAgICAgICAgICAgICAgICAgICAgICAgIHx8IHZhcmlhYmxlQWNjZXNzRGF0YS0+ bG9jYWwoKSA9PQotICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVubW9kaWZpZWRBcmd1bWVu dHNSZWdpc3Rlcihhcmd1bWVudHNSZWdpc3RlcikpIHsKKyAgICAgICAgICAgICAgICAgICAgaWYg KGFyZ3VtZW50c1JlZ2lzdGVyICE9IEludmFsaWRWaXJ0dWFsUmVnaXN0ZXIKKyAgICAgICAgICAg ICAgICAgICAgICAgICYmICh2YXJpYWJsZUFjY2Vzc0RhdGEtPmxvY2FsKCkgPT0gYXJndW1lbnRz UmVnaXN0ZXIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICB8fCB2YXJpYWJsZUFjY2Vzc0Rh dGEtPmxvY2FsKCkgPT0KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5tb2RpZmll ZEFyZ3VtZW50c1JlZ2lzdGVyKGFyZ3VtZW50c1JlZ2lzdGVyKSkpIHsKICAgICAgICAgICAgICAg ICAgICAgICAgIGlmIChub2RlLmNvZGVPcmlnaW4uaW5saW5lQ2FsbEZyYW1lID09IHNvdXJjZS5j b2RlT3JpZ2luLmlubGluZUNhbGxGcmFtZSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBi cmVhazsKICAgICAgICAgICAgICAgICAgICAgICAgIG1fY3JlYXRlc0FyZ3VtZW50cy5hZGQoc291 cmNlLmNvZGVPcmlnaW4uaW5saW5lQ2FsbEZyYW1lKTsKQEAgLTU3Myw2ICs1ODAsMTYgQEAgcHVi bGljOgogICAgICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgICAgICB9CiAgICAg ICAgICAgICAgICAgICAgIAorICAgICAgICAgICAgICAgIGNhc2UgVGVhck9mZkFyZ3VtZW50czog eworICAgICAgICAgICAgICAgICAgICBpZiAobV9jcmVhdGVzQXJndW1lbnRzLmNvbnRhaW5zKG5v ZGUuY29kZU9yaWdpbi5pbmxpbmVDYWxsRnJhbWUpKQorICAgICAgICAgICAgICAgICAgICAgICAg Y29udGludWU7CisgICAgICAgICAgICAgICAgICAgIAorICAgICAgICAgICAgICAgICAgICBub2Rl LnNldE9wQW5kRGVmYXVsdEZsYWdzKE5vcCk7CisgICAgICAgICAgICAgICAgICAgIG1fZ3JhcGgu Y2xlYXJBbmREZXJlZkNoaWxkMShub2RlKTsKKyAgICAgICAgICAgICAgICAgICAgbm9kZS5zZXRS ZWZDb3VudCgwKTsKKyAgICAgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICAgICAg fQorICAgICAgICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICBkZWZhdWx0OgogICAgICAg ICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgICAgICB9CkBAIC02MzYsNyArNjUzLDEw IEBAIHByaXZhdGU6CiAgICAgICAgIH0KICAgICAgICAgICAgIAogICAgICAgICBjYXNlIEdldExv Y2FsOiB7Ci0gICAgICAgICAgICBpZiAoY2hpbGQubG9jYWwoKSA9PSBtX2dyYXBoLnVuY2hlY2tl ZEFyZ3VtZW50c1JlZ2lzdGVyRm9yKGNoaWxkLmNvZGVPcmlnaW4pKSB7CisgICAgICAgICAgICBp bnQgYXJndW1lbnRzUmVnaXN0ZXIgPSBtX2dyYXBoLnVuY2hlY2tlZEFyZ3VtZW50c1JlZ2lzdGVy Rm9yKGNoaWxkLmNvZGVPcmlnaW4pOworICAgICAgICAgICAgaWYgKGFyZ3VtZW50c1JlZ2lzdGVy ICE9IEludmFsaWRWaXJ0dWFsUmVnaXN0ZXIKKyAgICAgICAgICAgICAgICAmJiAoY2hpbGQubG9j YWwoKSA9PSBhcmd1bWVudHNSZWdpc3RlcgorICAgICAgICAgICAgICAgICAgICB8fCBjaGlsZC5s b2NhbCgpID09IHVubW9kaWZpZWRBcmd1bWVudHNSZWdpc3Rlcihhcmd1bWVudHNSZWdpc3Rlcikp KSB7CiAgICAgICAgICAgICAgICAgbV9jcmVhdGVzQXJndW1lbnRzLmFkZChjaGlsZC5jb2RlT3Jp Z2luLmlubGluZUNhbGxGcmFtZSk7CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAg ICB9Cg==