88205 2012-06-03 19:27:06 -0700 get_argument_by_val should be profiled everywhere 2012-06-04 16:33:19 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo webkit-unassigned oldest_to_newest 640266 0 fpizlo 2012-06-03 19:27:06 -0700 The JSVALUE64 JIT does it on fast and slow paths. The 32_64 JIT does it on fast paths only. The LLInt does it on fast paths only. All implementations of this opcode ought to be profiled. 640273 1 145507 fpizlo 2012-06-03 19:40:20 -0700 Created attachment 145507 the patch 640318 2 145507 ggaren 2012-06-03 22:27:41 -0700 Comment on attachment 145507 the patch r=me 640979 3 fpizlo 2012-06-04 16:33:19 -0700 Landed in http://trac.webkit.org/changeset/119438 145507 2012-06-03 19:40:20 -0700 2012-06-03 22:27:41 -0700 the patch profilegetargbyval_patch_1.diff text/plain 1884 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTE5MzY2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEyLTA2LTAzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg Z2V0X2FyZ3VtZW50X2J5X3ZhbCBzaG91bGQgYmUgcHJvZmlsZWQgZXZlcnl3aGVyZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODgyMDUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGppdC9KSVRPcGNvZGVz MzJfNjQuY3BwOgorICAgICAgICAoSlNDOjpKSVQ6OmVtaXRTbG93X29wX2dldF9hcmd1bWVudF9i eV92YWwpOgorICAgICAgICAqIGxsaW50L0xMSW50U2xvd1BhdGhzLmNwcDoKKyAgICAgICAgKEpT Qzo6TExJbnQ6OkxMSU5UX1NMT1dfUEFUSF9ERUNMKToKKwogMjAxMi0wNi0wMiAgR2VvZmZyZXkg R2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYWsgcG9pbnRlciBmaW5hbGl6 YXRpb24gc2hvdWxkIGJlIGxhenkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklU T3Bjb2RlczMyXzY0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0 L0pJVE9wY29kZXMzMl82NC5jcHAJKHJldmlzaW9uIDExOTMxMykKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9qaXQvSklUT3Bjb2RlczMyXzY0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTY3Miw3 ICsxNjcyLDcgQEAgdm9pZCBKSVQ6OmVtaXRTbG93X29wX2dldF9hcmd1bWVudF9ieV92YQogICAg IEpJVFN0dWJDYWxsIHN0dWJDYWxsKHRoaXMsIGN0aV9vcF9nZXRfYnlfdmFsKTsKICAgICBzdHVi Q2FsbC5hZGRBcmd1bWVudChhcmd1bWVudHMpOwogICAgIHN0dWJDYWxsLmFkZEFyZ3VtZW50KHBy b3BlcnR5KTsKLSAgICBzdHViQ2FsbC5jYWxsKGRzdCk7CisgICAgc3R1YkNhbGwuY2FsbFdpdGhW YWx1ZVByb2ZpbGluZyhkc3QpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBKU0MKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9sbGludC9MTEludFNsb3dQYXRocy5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xMSW50U2xvd1BhdGhzLmNwcAkocmV2aXNpb24g MTE5MzEzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xMSW50U2xvd1BhdGhzLmNw cAkod29ya2luZyBjb3B5KQpAQCAtOTg3LDcgKzk4Nyw3IEBAIExMSU5UX1NMT1dfUEFUSF9ERUNM KHNsb3dfcGF0aF9nZXRfYXJndW0KICAgICAgICAgZXhlYy0+dW5jaGVja2VkUih1bm1vZGlmaWVk QXJndW1lbnRzUmVnaXN0ZXIocGNbMl0udS5vcGVyYW5kKSkgPSBhcmd1bWVudHM7CiAgICAgfQog ICAgIAotICAgIExMSU5UX1JFVFVSTihnZXRCeVZhbChleGVjLCBhcmd1bWVudHMsIExMSU5UX09Q X0MoMykuanNWYWx1ZSgpKSk7CisgICAgTExJTlRfUkVUVVJOX1BST0ZJTEVEKG9wX2dldF9hcmd1 bWVudF9ieV92YWwsIGdldEJ5VmFsKGV4ZWMsIGFyZ3VtZW50cywgTExJTlRfT1BfQygzKS5qc1Zh bHVlKCkpKTsKIH0KIAogTExJTlRfU0xPV19QQVRIX0RFQ0woc2xvd19wYXRoX2dldF9ieV9wbmFt ZSkK