88203 2012-06-03 18:19:57 -0700 [perf-test] Make query-selector-last.html more realistic 2012-06-03 21:02:32 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 87625 1 haraken haraken rniwa webkit.review.bot oldest_to_newest 640254 0 haraken 2012-06-03 18:19:57 -0700 query-selector-last.html tests querySelector() for an element that appears after 1000 div elements, all of which have the same id and class. To test the performance of querySelector() under a lot of ids and classes, we should make the ids and classes of the 1000 elements different. 640256 1 145500 haraken 2012-06-03 18:24:52 -0700 Created attachment 145500 Patch 640258 2 145500 rniwa 2012-06-03 18:36:40 -0700 Comment on attachment 145500 Patch Conversely, should we have a test where we have lots of duplicate ids as well? 640261 3 haraken 2012-06-03 19:17:01 -0700 (In reply to comment #2) > (From update of attachment 145500 [details]) > Conversely, should we have a test where we have lots of duplicate ids as well? Good point. For example, getElementById() (which is internally called by querySelector()) traces different call paths for duplicated ids. I'll add the test in another patch. 640263 4 145500 webkit.review.bot 2012-06-03 19:25:07 -0700 Comment on attachment 145500 Patch Clearing flags on attachment: 145500 Committed r119366: <http://trac.webkit.org/changeset/119366> 640264 5 webkit.review.bot 2012-06-03 19:25:10 -0700 All reviewed patches have been landed. Closing bug. 640294 6 haraken 2012-06-03 21:02:32 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 145500 [details] [details]) > > Conversely, should we have a test where we have lots of duplicate ids as well? > > Good point. For example, getElementById() (which is internally called by querySelector()) traces different call paths for duplicated ids. I'll add the test in another patch. Hmm, it might not be worth adding. DOM/GetElement.html already tests duplicate id cases. 145500 2012-06-03 18:24:52 -0700 2012-06-03 19:25:06 -0700 Patch bug-88203-20120604102451.patch text/plain 3567 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MzY1CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDFmY2M1NmEzNjlm YWMxMDRjNTFmOGE1ZmQ0MTk0ZTZlNDNjNjA3MTkuLjVlZDM1NzMxZTU1MDA1MDA1M2ZiMDZmYTIw YWI1NDdhN2ViMTU3ZTUgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsNTMgQEAKKzIwMTItMDYt MDMgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtwZXJm LXRlc3RdIE1ha2UgcXVlcnktc2VsZWN0b3ItbGFzdC5odG1sIG1vcmUgcmVhbGlzdGljCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODIwMworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHF1ZXJ5LXNlbGVjdG9y LWxhc3QuaHRtbCB0ZXN0cyBxdWVyeVNlbGVjdG9yKCkgZm9yIGFuIGVsZW1lbnQKKyAgICAgICAg dGhhdCBhcHBlYXJzIGFmdGVyIDEwMDAgZGl2IGVsZW1lbnRzLCBhbGwgb2Ygd2hpY2ggaGF2ZSB0 aGUgc2FtZQorICAgICAgICBpZCBhbmQgY2xhc3MuIFRvIHRlc3QgdGhlIHBlcmZvcm1hbmNlIG9m IHF1ZXJ5U2VsZWN0b3IoKSB1bmRlcgorICAgICAgICBhIGxvdCBvZiBpZHMgYW5kIGNsYXNzZXMs IHdlIHNob3VsZCBtYWtlIHRoZSBpZHMgYW5kIGNsYXNzZXMgb2YKKyAgICAgICAgdGhlIDEwMDAg ZWxlbWVudHMgZGlmZmVyZW50LgorCisgICAgICAgIFRoaXMgcGF0Y2ggZGVncmFkZXMgdGhlIHBl cmZvcm1hbmNlIG9mIHF1ZXJ5LXNlbGVjdG9yLWxhc3QuaHRtbAorICAgICAgICBieSAzLjYlLgor CisgICAgICAgIFtCZWZvcmVdCisgICAgICAgIFJFU1VMVCBQYXJzZXI6IHF1ZXJ5LXNlbGVjdG9y LWxhc3Q9IDQ3Ni4zODIyNzQxNTIgcnVucy9zCisgICAgICAgIG1lZGlhbj0gNDc2LjgyMTE5MjA1 MyBydW5zL3MsIHN0ZGV2PSAxLjE0NTc4ODc1ODE0IHJ1bnMvcywgbWluPSA0NzQuMzA4MzAwMzk1 IHJ1bnMvcywgbWF4PSA0NzguMDg3NjQ5NDAyIHJ1bnMvcworCisgICAgICAgIFJFU1VMVCBQYXJz ZXI6IHF1ZXJ5LXNlbGVjdG9yLWxhc3Q9IDQ3OC40MjMwNjE4NjEgcnVucy9zCisgICAgICAgIG1l ZGlhbj0gNDc4LjcyMzQwNDI1NSBydW5zL3MsIHN0ZGV2PSAxLjU0ODc2ODY3MjU1IHJ1bnMvcywg bWluPSA0NzMuNjg0MjEwNTI2IHJ1bnMvcywgbWF4PSA0ODEuMzQ3NzczNzY3IHJ1bnMvcworCisg ICAgICAgIFJFU1VMVCBQYXJzZXI6IHF1ZXJ5LXNlbGVjdG9yLWxhc3Q9IDQ3OS44NDkyODcxNzQg cnVucy9zCisgICAgICAgIG1lZGlhbj0gNDgwLjAgcnVucy9zLCBzdGRldj0gMS42OTg0OTc1MjQ5 OCBydW5zL3MsIG1pbj0gNDc1LjU2MTQyNjY4NCBydW5zL3MsIG1heD0gNDgxLjkyNzcxMDg0MyBy dW5zL3MKKworICAgICAgICBSRVNVTFQgUGFyc2VyOiBxdWVyeS1zZWxlY3Rvci1sYXN0PSA0NzYu NzY1NDM4ODQ2IHJ1bnMvcworICAgICAgICBtZWRpYW49IDQ3Ny40NTM1ODA5MDIgcnVucy9zLCBz dGRldj0gMS44NzI0NDg4NjY0IHJ1bnMvcywgbWluPSA0NzEuODIxNzU2MjI1IHJ1bnMvcywgbWF4 PSA0NzguNzIzNDA0MjU1IHJ1bnMvcworCisgICAgICAgIFJFU1VMVCBQYXJzZXI6IHF1ZXJ5LXNl bGVjdG9yLWxhc3Q9IDQ4MS43MTUzNDA2NDQgcnVucy9zCisgICAgICAgIG1lZGlhbj0gNDgxLjYz Nzc0MjMwNSBydW5zL3MsIHN0ZGV2PSAxLjgxNDQ2MzYxMTQ1IHJ1bnMvcywgbWluPSA0NzUuNTYx NDI2Njg0IHJ1bnMvcywgbWF4PSA0ODMuNjc1OTM3MTIyIHJ1bnMvcworCisgICAgICAgIFtBZnRl cl0KKyAgICAgICAgUkVTVUxUIFBhcnNlcjogcXVlcnktc2VsZWN0b3ItbGFzdD0gNDU4Ljg2NjYy MzU4MiBydW5zL3MKKyAgICAgICAgbWVkaWFuPSA0NTkuMTgzNjczNDY5IHJ1bnMvcywgc3RkZXY9 IDEuNDg4ODE0NjQ3MzcgcnVucy9zLCBtaW49IDQ1My45NzIyNTcyNTEgcnVucy9zLCBtYXg9IDQ2 MC45NDc1MDMyMDEgcnVucy9zCisKKyAgICAgICAgUkVTVUxUIFBhcnNlcjogcXVlcnktc2VsZWN0 b3ItbGFzdD0gNDYwLjM2MzUzMjg5NyBydW5zL3MKKyAgICAgICAgbWVkaWFuPSA0NjAuMzU4MDU2 MjY2IHJ1bnMvcywgc3RkZXY9IDEuNTg1MTIwNTY5OTUgcnVucy9zLCBtaW49IDQ1Ni4yNzM3NjQy NTkgcnVucy9zLCBtYXg9IDQ2Mi4xMzA5MzcwOTkgcnVucy9zCisKKyAgICAgICAgUkVTVUxUIFBh cnNlcjogcXVlcnktc2VsZWN0b3ItbGFzdD0gNDU3LjcyNzQ0ODQ1MSBydW5zL3MKKyAgICAgICAg bWVkaWFuPSA0NTguMDE1MjY3MTc2IHJ1bnMvcywgc3RkZXY9IDEuMjM2ODE5MTU1MTYgcnVucy9z LCBtaW49IDQ1My45NzIyNTcyNTEgcnVucy9zLCBtYXg9IDQ1OS4xODM2NzM0NjkgcnVucy9zCisK KyAgICAgICAgUkVTVUxUIFBhcnNlcjogcXVlcnktc2VsZWN0b3ItbGFzdD0gNDY1LjU3MzM2ODUz IHJ1bnMvcworICAgICAgICBtZWRpYW49IDQ2NS43MTc5ODE4ODkgcnVucy9zLCBzdGRldj0gMS42 NjE2OTI1Mzc0IHJ1bnMvcywgbWluPSA0NjAuOTQ3NTAzMjAxIHJ1bnMvcywgbWF4PSA0NjcuNTMy NDY3NTMyIHJ1bnMvcworCisgICAgICAgIFJFU1VMVCBQYXJzZXI6IHF1ZXJ5LXNlbGVjdG9yLWxh c3Q9IDQ1OS44MzYyNTIwMTkgcnVucy9zCisgICAgICAgIG1lZGlhbj0gNDU5Ljc3MDExNDk0MyBy dW5zL3MsIHN0ZGV2PSAxLjg0NDg1NjMwNTA1IHJ1bnMvcywgbWluPSA0NTUuNjk2MjAyNTMyIHJ1 bnMvcywgbWF4PSA0NjIuNzI0OTM1NzMzIHJ1bnMvcworCisgICAgICAgICogUGFyc2VyL3F1ZXJ5 LXNlbGVjdG9yLWxhc3QuaHRtbDoKKwogMjAxMi0wNi0wMSAgUnlvc3VrZSBOaXdhICA8cm5pd2FA d2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgcHVibGljIHBhZ2UgbG9hZGluZyBwZXJmb3JtYW5j ZSB0ZXN0cyB1c2luZyB3ZWItcGFnZS1yZXBsYXkKZGlmZiAtLWdpdCBhL1BlcmZvcm1hbmNlVGVz dHMvUGFyc2VyL3F1ZXJ5LXNlbGVjdG9yLWxhc3QuaHRtbCBiL1BlcmZvcm1hbmNlVGVzdHMvUGFy c2VyL3F1ZXJ5LXNlbGVjdG9yLWxhc3QuaHRtbAppbmRleCA4YTg0ZTU3YWFjNDU2NzBmZjg5YzM5 YmEzMTk4MWM4ZTA1NzMzMGYwLi5hMjRjYTU1ZDU1ZjQ4N2U0NTRjMmU3ZDBkNWE2MzJjZGFmZWYx ZDZiIDEwMDY0NAotLS0gYS9QZXJmb3JtYW5jZVRlc3RzL1BhcnNlci9xdWVyeS1zZWxlY3Rvci1s YXN0Lmh0bWwKKysrIGIvUGVyZm9ybWFuY2VUZXN0cy9QYXJzZXIvcXVlcnktc2VsZWN0b3ItbGFz dC5odG1sCkBAIC01LDggKzUsOCBAQAogPHNjcmlwdD4KIGZvciAodmFyIGkgPSAwOyBpIDwgMTAw MDsgaSsrKSB7CiAgICAgdmFyIGRpdiA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwot ICAgIGRpdi5pZCA9ICJmb28iOwotICAgIGRpdi5jbGFzc05hbWUgPSAiYmFyIjsKKyAgICBkaXYu aWQgPSAiZm9vIiArIGk7CisgICAgZGl2LmNsYXNzTmFtZSA9ICJiYXIiICsgaTsKICAgICBkb2N1 bWVudC5ib2R5LmFwcGVuZENoaWxkKGRpdik7CiB9CiAK