88202 2012-06-03 18:05:09 -0700 [perf-test] Add a benchmark of querySelector() for an element that appears in the depths in the document 2012-06-03 20:23:32 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 87625 1 haraken haraken rniwa webkit.review.bot oldest_to_newest 640248 0 haraken 2012-06-03 18:05:09 -0700 query-selector-first.html tests querySelector() for an element that appears at the head of the document. query-selector-last.html tests querySelector() for an element that appears at the tail of the document. In addition, we want a benchmark of querySelector() for an element that appears in the depths in the document. 640250 1 145497 haraken 2012-06-03 18:12:02 -0700 Created attachment 145497 Patch 640262 2 145497 rniwa 2012-06-03 19:20:31 -0700 Comment on attachment 145497 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145497&action=review > PerformanceTests/Parser/query-selector-deep.html:28 > +}}); Shouldn't we indent this by 4 spaces? 640265 3 145502 haraken 2012-06-03 19:26:24 -0700 Created attachment 145502 patch for landing 640285 4 145502 webkit.review.bot 2012-06-03 20:14:38 -0700 Comment on attachment 145502 patch for landing Clearing flags on attachment: 145502 Committed r119368: <http://trac.webkit.org/changeset/119368> 145497 2012-06-03 18:12:02 -0700 2012-06-03 20:23:23 -0700 Patch bug-88202-20120604101201.patch text/plain 3198 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MzY1CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDFmY2M1NmEzNjlm YWMxMDRjNTFmOGE1ZmQ0MTk0ZTZlNDNjNjA3MTkuLjUwZWI4NDUyNzgwODk2YjU4ZDA0ZWE4NTZj OGE0NDc2NmNlYmY3MmQgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzUgQEAKKzIwMTItMDYt MDMgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtwZXJm LXRlc3RdIEFkZCBhIGJlbmNobWFyayBvZiBxdWVyeVNlbGVjdG9yKCkgZm9yIGFuIGVsZW1lbnQg dGhhdCBhcHBlYXJzIGluIHRoZSBkZXB0aHMgaW4gdGhlIGRvY3VtZW50CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODIwMgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHF1ZXJ5LXNlbGVjdG9yLWZpcnN0Lmh0 bWwgdGVzdHMgcXVlcnlTZWxlY3RvcigpIGZvciBhbiBlbGVtZW50CisgICAgICAgIHRoYXQgYXBw ZWFycyBhdCB0aGUgaGVhZCBvZiB0aGUgZG9jdW1lbnQuIHF1ZXJ5LXNlbGVjdG9yLWxhc3QuaHRt bAorICAgICAgICB0ZXN0cyBxdWVyeVNlbGVjdG9yKCkgZm9yIGFuIGVsZW1lbnQgdGhhdCBhcHBl YXJzIGF0IHRoZSB0YWlsIG9mCisgICAgICAgIHRoZSBkb2N1bWVudC4gSW4gYWRkaXRpb24sIHdl IHdhbnQgYSBiZW5jaG1hcmsgb2YgcXVlcnlTZWxlY3RvcigpCisgICAgICAgIGZvciBhbiBlbGVt ZW50IHRoYXQgYXBwZWFycyBpbiB0aGUgZGVwdGhzIGluIHRoZSBkb2N1bWVudC4KKworICAgICAg ICBUZXN0IHJlc3VsdHMgaW4gbXkgTGludXggZGVza3RvcDoKKworICAgICAgICBSRVNVTFQgUGFy c2VyOiBxdWVyeS1zZWxlY3Rvci1kZWVwPSA0NjAuNzc2OTgwNjExIHJ1bnMvcworICAgICAgICBt ZWRpYW49IDQ2MC45NDc1MDMyMDEgcnVucy9zLCBzdGRldj0gMS43MjI3NDk0MTk0MiBydW5zL3Ms IG1pbj0gNDU1LjY5NjIwMjUzMiBydW5zL3MsIG1heD0gNDYzLjMyMDQ2MzMyIHJ1bnMvcworCisg ICAgICAgIFJFU1VMVCBQYXJzZXI6IHF1ZXJ5LXNlbGVjdG9yLWRlZXA9IDQ1OC45MjUwNTA5MTUg cnVucy9zCisgICAgICAgIG1lZGlhbj0gNDU5LjE4MzY3MzQ2OSBydW5zL3MsIHN0ZGV2PSAxLjQ3 OTMwMTI0MTM5IHJ1bnMvcywgbWluPSA0NTQuNTQ1NDU0NTQ1IHJ1bnMvcywgbWF4PSA0NjAuOTQ3 NTAzMjAxIHJ1bnMvcworCisgICAgICAgIFJFU1VMVCBQYXJzZXI6IHF1ZXJ5LXNlbGVjdG9yLWRl ZXA9IDQ2MS44NjY5ODE0OTEgcnVucy9zCisgICAgICAgIG1lZGlhbj0gNDYxLjUzODQ2MTUzOCBy dW5zL3MsIHN0ZGV2PSAxLjE0NjEzMTIzMzU5IHJ1bnMvcywgbWluPSA0NTkuMTgzNjczNDY5IHJ1 bnMvcywgbWF4PSA0NjMuOTE3NTI1NzczIHJ1bnMvcworCisgICAgICAgIFJFU1VMVCBQYXJzZXI6 IHF1ZXJ5LXNlbGVjdG9yLWRlZXA9IDQ1My45MjIwMTA3ODggcnVucy9zCisgICAgICAgIG1lZGlh bj0gNDU0LjI1ODg1NTg5OCBydW5zL3MsIHN0ZGV2PSAxLjc3Mjc5MTIzMzE3IHJ1bnMvcywgbWlu PSA0NDcuMjA0OTY4OTQ0IHJ1bnMvcywgbWF4PSA0NTUuNjk2MjAyNTMyIHJ1bnMvcworCisgICAg ICAgIFJFU1VMVCBQYXJzZXI6IHF1ZXJ5LXNlbGVjdG9yLWRlZXA9IDQ1NC42NjYzMjEyMjEgcnVu cy9zCisgICAgICAgIG1lZGlhbj0gNDU0LjU0NTQ1NDU0NSBydW5zL3MsIHN0ZGV2PSAxLjY1Nzc1 NjY3NDE3IHJ1bnMvcywgbWluPSA0NTEuMTI3ODE5NTQ5IHJ1bnMvcywgbWF4PSA0NTYuODUyNzkx ODc4IHJ1bnMvcworCisgICAgICAgICogUGFyc2VyL3F1ZXJ5LXNlbGVjdG9yLWRlZXAuaHRtbDog QWRkZWQuCisKIDIwMTItMDYtMDEgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgQWRkIHB1YmxpYyBwYWdlIGxvYWRpbmcgcGVyZm9ybWFuY2UgdGVzdHMgdXNpbmcg d2ViLXBhZ2UtcmVwbGF5CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3RzL1BhcnNlci9xdWVy eS1zZWxlY3Rvci1kZWVwLmh0bWwgYi9QZXJmb3JtYW5jZVRlc3RzL1BhcnNlci9xdWVyeS1zZWxl Y3Rvci1kZWVwLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNzJkNzNkZDlmNmQ5ZGYzMjA4OThmYzg4ZjY3MTYy NTlmNzc1YWExNgotLS0gL2Rldi9udWxsCisrKyBiL1BlcmZvcm1hbmNlVGVzdHMvUGFyc2VyL3F1 ZXJ5LXNlbGVjdG9yLWRlZXAuaHRtbApAQCAtMCwwICsxLDMxIEBACis8IURPQ1RZUEUgaHRtbD4K KzxodG1sPgorPGJvZHk+Cis8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL3J1bm5lci5qcyI+PC9z Y3JpcHQ+Cis8c2NyaXB0PgordmFyIHBhcmVudERpdiA9IGRvY3VtZW50LmJvZHk7Citmb3IgKHZh ciBpID0gMDsgaSA8IDEwMDA7IGkrKykgeworICAgIHZhciBkaXYgPSBkb2N1bWVudC5jcmVhdGVF bGVtZW50KCJkaXYiKTsKKyAgICBkaXYuaWQgPSAiZm9vIiArIGk7CisgICAgZGl2LmNsYXNzTmFt ZSA9ICJiYXIiICsgaTsKKyAgICBwYXJlbnREaXYuYXBwZW5kQ2hpbGQoZGl2KTsKKyAgICBwYXJl bnREaXYgPSBkaXY7Cit9CisKK3ZhciBoMSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImgxIik7 CitoMS5pZCA9ICJpZCI7CitoMS5jbGFzc05hbWUgPSAiY2xhc3MiOworcGFyZW50RGl2LmFwcGVu ZENoaWxkKGgxKTsKKworUGVyZlRlc3RSdW5uZXIucnVuUGVyU2Vjb25kKHsKKyAgICBkZXNjcmlw dGlvbjogIlRoaXMgYmVuY2htYXJrIHRlc3RzIHF1ZXJ5U2VsZWN0b3IoKSBmb3IgYW4gZWxlbWVu dCB0aGF0IGFwcGVhcnMgaW4gdGhlIGRlcHRocyBpbiB0aGUgZG9jdW1lbnQiLAorICAgIHJ1bjog ZnVuY3Rpb24oKSB7CisgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgMTAwOyBpKyspIHsKKyAg ICAgICAgICAgIGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoImgxIik7CisgICAgICAgICAgICBkb2N1 bWVudC5xdWVyeVNlbGVjdG9yKCIjaWQiKTsKKyAgICAgICAgICAgIGRvY3VtZW50LnF1ZXJ5U2Vs ZWN0b3IoIi5jbGFzcyIpOworICAgICAgICB9Cit9fSk7Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwv aHRtbD4K 145502 2012-06-03 19:26:24 -0700 2012-06-03 20:14:38 -0700 patch for landing bug-88202-20120604112623.patch text/plain 4232 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MzY1CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDFmY2M1NmEzNjlm YWMxMDRjNTFmOGE1ZmQ0MTk0ZTZlNDNjNjA3MTkuLmRhZWM5M2JkZjNjMTExMmYzZDJlNzc4NjFk OTg5MDJhOWMyNWFhMmYgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzUgQEAKKzIwMTItMDYt MDMgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtwZXJm LXRlc3RdIEFkZCBhIGJlbmNobWFyayBvZiBxdWVyeVNlbGVjdG9yKCkgZm9yIGFuIGVsZW1lbnQg dGhhdCBhcHBlYXJzIGluIHRoZSBkZXB0aHMgaW4gdGhlIGRvY3VtZW50CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODIwMgorCisgICAgICAgIFJldmll d2VkIGJ5IFJ5b3N1a2UgTml3YS4KKworICAgICAgICBxdWVyeS1zZWxlY3Rvci1maXJzdC5odG1s IHRlc3RzIHF1ZXJ5U2VsZWN0b3IoKSBmb3IgYW4gZWxlbWVudAorICAgICAgICB0aGF0IGFwcGVh cnMgYXQgdGhlIGhlYWQgb2YgdGhlIGRvY3VtZW50LiBxdWVyeS1zZWxlY3Rvci1sYXN0Lmh0bWwK KyAgICAgICAgdGVzdHMgcXVlcnlTZWxlY3RvcigpIGZvciBhbiBlbGVtZW50IHRoYXQgYXBwZWFy cyBhdCB0aGUgdGFpbCBvZgorICAgICAgICB0aGUgZG9jdW1lbnQuIEluIGFkZGl0aW9uLCB3ZSB3 YW50IGEgYmVuY2htYXJrIG9mIHF1ZXJ5U2VsZWN0b3IoKQorICAgICAgICBmb3IgYW4gZWxlbWVu dCB0aGF0IGFwcGVhcnMgaW4gdGhlIGRlcHRocyBpbiB0aGUgZG9jdW1lbnQuCisKKyAgICAgICAg VGVzdCByZXN1bHRzIGluIG15IExpbnV4IGRlc2t0b3A6CisKKyAgICAgICAgUkVTVUxUIFBhcnNl cjogcXVlcnktc2VsZWN0b3ItZGVlcD0gNDYwLjc3Njk4MDYxMSBydW5zL3MKKyAgICAgICAgbWVk aWFuPSA0NjAuOTQ3NTAzMjAxIHJ1bnMvcywgc3RkZXY9IDEuNzIyNzQ5NDE5NDIgcnVucy9zLCBt aW49IDQ1NS42OTYyMDI1MzIgcnVucy9zLCBtYXg9IDQ2My4zMjA0NjMzMiBydW5zL3MKKworICAg ICAgICBSRVNVTFQgUGFyc2VyOiBxdWVyeS1zZWxlY3Rvci1kZWVwPSA0NTguOTI1MDUwOTE1IHJ1 bnMvcworICAgICAgICBtZWRpYW49IDQ1OS4xODM2NzM0NjkgcnVucy9zLCBzdGRldj0gMS40Nzkz MDEyNDEzOSBydW5zL3MsIG1pbj0gNDU0LjU0NTQ1NDU0NSBydW5zL3MsIG1heD0gNDYwLjk0NzUw MzIwMSBydW5zL3MKKworICAgICAgICBSRVNVTFQgUGFyc2VyOiBxdWVyeS1zZWxlY3Rvci1kZWVw PSA0NjEuODY2OTgxNDkxIHJ1bnMvcworICAgICAgICBtZWRpYW49IDQ2MS41Mzg0NjE1MzggcnVu cy9zLCBzdGRldj0gMS4xNDYxMzEyMzM1OSBydW5zL3MsIG1pbj0gNDU5LjE4MzY3MzQ2OSBydW5z L3MsIG1heD0gNDYzLjkxNzUyNTc3MyBydW5zL3MKKworICAgICAgICBSRVNVTFQgUGFyc2VyOiBx dWVyeS1zZWxlY3Rvci1kZWVwPSA0NTMuOTIyMDEwNzg4IHJ1bnMvcworICAgICAgICBtZWRpYW49 IDQ1NC4yNTg4NTU4OTggcnVucy9zLCBzdGRldj0gMS43NzI3OTEyMzMxNyBydW5zL3MsIG1pbj0g NDQ3LjIwNDk2ODk0NCBydW5zL3MsIG1heD0gNDU1LjY5NjIwMjUzMiBydW5zL3MKKworICAgICAg ICBSRVNVTFQgUGFyc2VyOiBxdWVyeS1zZWxlY3Rvci1kZWVwPSA0NTQuNjY2MzIxMjIxIHJ1bnMv cworICAgICAgICBtZWRpYW49IDQ1NC41NDU0NTQ1NDUgcnVucy9zLCBzdGRldj0gMS42NTc3NTY2 NzQxNyBydW5zL3MsIG1pbj0gNDUxLjEyNzgxOTU0OSBydW5zL3MsIG1heD0gNDU2Ljg1Mjc5MTg3 OCBydW5zL3MKKworICAgICAgICAqIFBhcnNlci9xdWVyeS1zZWxlY3Rvci1kZWVwLmh0bWw6IEFk ZGVkLgorCiAyMDEyLTA2LTAxICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAg ICAgICAgIEFkZCBwdWJsaWMgcGFnZSBsb2FkaW5nIHBlcmZvcm1hbmNlIHRlc3RzIHVzaW5nIHdl Yi1wYWdlLXJlcGxheQpkaWZmIC0tZ2l0IGEvUGVyZm9ybWFuY2VUZXN0cy9QYXJzZXIvcXVlcnkt c2VsZWN0b3ItZGVlcC5odG1sIGIvUGVyZm9ybWFuY2VUZXN0cy9QYXJzZXIvcXVlcnktc2VsZWN0 b3ItZGVlcC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjUwYjY0YzQ5MjEwOTVmZmI5NTE0YTk3YmVmYmQ1NTM5 YmJiNzYyYzIKLS0tIC9kZXYvbnVsbAorKysgYi9QZXJmb3JtYW5jZVRlc3RzL1BhcnNlci9xdWVy eS1zZWxlY3Rvci1kZWVwLmh0bWwKQEAgLTAsMCArMSwzMSBAQAorPCFET0NUWVBFIGh0bWw+Cis8 aHRtbD4KKzxib2R5PgorPHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNlcy9ydW5uZXIuanMiPjwvc2Ny aXB0PgorPHNjcmlwdD4KK3ZhciBwYXJlbnREaXYgPSBkb2N1bWVudC5ib2R5OworZm9yICh2YXIg aSA9IDA7IGkgPCAxMDAwOyBpKyspIHsKKyAgICB2YXIgZGl2ID0gZG9jdW1lbnQuY3JlYXRlRWxl bWVudCgiZGl2Iik7CisgICAgZGl2LmlkID0gImZvbyIgKyBpOworICAgIGRpdi5jbGFzc05hbWUg PSAiYmFyIiArIGk7CisgICAgcGFyZW50RGl2LmFwcGVuZENoaWxkKGRpdik7CisgICAgcGFyZW50 RGl2ID0gZGl2OworfQorCit2YXIgaDEgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJoMSIpOwor aDEuaWQgPSAiaWQiOworaDEuY2xhc3NOYW1lID0gImNsYXNzIjsKK3BhcmVudERpdi5hcHBlbmRD aGlsZChoMSk7CisKK1BlcmZUZXN0UnVubmVyLnJ1blBlclNlY29uZCh7CisgICAgZGVzY3JpcHRp b246ICJUaGlzIGJlbmNobWFyayB0ZXN0cyBxdWVyeVNlbGVjdG9yKCkgZm9yIGFuIGVsZW1lbnQg dGhhdCBhcHBlYXJzIGluIHRoZSBkZXB0aHMgaW4gdGhlIGRvY3VtZW50IiwKKyAgICBydW46IGZ1 bmN0aW9uKCkgeworICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IDEwMDsgaSsrKSB7CisgICAg ICAgICAgICBkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCJoMSIpOworICAgICAgICAgICAgZG9jdW1l bnQucXVlcnlTZWxlY3RvcigiI2lkIik7CisgICAgICAgICAgICBkb2N1bWVudC5xdWVyeVNlbGVj dG9yKCIuY2xhc3MiKTsKKyAgICAgICAgfQorICAgIH19KTsKKzwvc2NyaXB0PgorPC9ib2R5Pgor PC9odG1sPgpkaWZmIC0tZ2l0IGEvUGVyZm9ybWFuY2VUZXN0cy9QYXJzZXIvcXVlcnktc2VsZWN0 b3ItZmlyc3QuaHRtbCBiL1BlcmZvcm1hbmNlVGVzdHMvUGFyc2VyL3F1ZXJ5LXNlbGVjdG9yLWZp cnN0Lmh0bWwKaW5kZXggMjUzMWY4Y2QzOGZmMmNkOTg4MjUzYzQ3OGQ2ZjRlYzExZTYzNjY4NC4u YWEyMjRlNWI5MmFlOTU4NmU1NGJmZTZlZGExNjlmNzA3Zjg3OTM3MyAxMDA2NDQKLS0tIGEvUGVy Zm9ybWFuY2VUZXN0cy9QYXJzZXIvcXVlcnktc2VsZWN0b3ItZmlyc3QuaHRtbAorKysgYi9QZXJm b3JtYW5jZVRlc3RzL1BhcnNlci9xdWVyeS1zZWxlY3Rvci1maXJzdC5odG1sCkBAIC0xMiw3ICsx Miw3IEBAIFBlcmZUZXN0UnVubmVyLnJ1blBlclNlY29uZCh7CiAgICAgICAgICAgICBkb2N1bWVu dC5xdWVyeVNlbGVjdG9yKCIjaWQiKTsKICAgICAgICAgICAgIGRvY3VtZW50LnF1ZXJ5U2VsZWN0 b3IoIi5jbGFzcyIpOwogICAgICAgICB9Ci19fSk7CisgICAgfX0pOwogPC9zY3JpcHQ+CiA8L2Jv ZHk+CiA8L2h0bWw+CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3RzL1BhcnNlci9xdWVyeS1z ZWxlY3Rvci1sYXN0Lmh0bWwgYi9QZXJmb3JtYW5jZVRlc3RzL1BhcnNlci9xdWVyeS1zZWxlY3Rv ci1sYXN0Lmh0bWwKaW5kZXggOGE4NGU1N2FhYzQ1NjcwZmY4OWMzOWJhMzE5ODFjOGUwNTczMzBm MC4uMGM5NjgzM2E5YmZjOGQ5MWUxNDBkYjQ1MjRlZWY0MGJiYTFmYzIzMSAxMDA2NDQKLS0tIGEv UGVyZm9ybWFuY2VUZXN0cy9QYXJzZXIvcXVlcnktc2VsZWN0b3ItbGFzdC5odG1sCisrKyBiL1Bl cmZvcm1hbmNlVGVzdHMvUGFyc2VyL3F1ZXJ5LXNlbGVjdG9yLWxhc3QuaHRtbApAQCAtMjMsNyAr MjMsNyBAQCBQZXJmVGVzdFJ1bm5lci5ydW5QZXJTZWNvbmQoewogICAgICAgICAgICAgZG9jdW1l bnQucXVlcnlTZWxlY3RvcigiI2lkIik7CiAgICAgICAgICAgICBkb2N1bWVudC5xdWVyeVNlbGVj dG9yKCIuY2xhc3MiKTsKICAgICAgICAgfQotfX0pOworICAgIH19KTsKIDwvc2NyaXB0PgogPC9i b2R5PgogPC9odG1sPgo=