88201 2012-06-03 17:30:59 -0700 REGRESSION (r118039): Incorrect formatting of pdf when printing from Reader view 2012-06-05 18:51:15 -0700 1 1 1 Unclassified WebKit Printing 528+ (Nightly build) Mac (Intel) OS X 10.7 RESOLVED FIXED InRadar, Regression P1 Major --- 1 skepticus webkit-unassigned ap bdakin beidson darin eric vitalybuka webkit.review.bot oldest_to_newest 640245 0 145496 skepticus 2012-06-03 17:30:59 -0700 Created attachment 145496 screenshot of resulting incorrect formatting regardless of site, when the Reader function is used and I try to print, the resulting pdf is formatted horribly incorrectly, making a two page document a 200 page document, for instance. 640246 1 skepticus 2012-06-03 17:32:58 -0700 forgot to mention- 'official' version of Safari is not showing same error. 640933 2 ap 2012-06-04 15:58:36 -0700 <rdar://problem/11569133> 640958 3 beidson 2012-06-04 16:17:13 -0700 This is about iframes, and broke in http://trac.webkit.org/changeset/118039 641020 4 vitalybuka 2012-06-04 17:14:57 -0700 Is it possible to export to html Reader result? Or create layout test with broken feature? 641022 5 skepticus 2012-06-04 17:24:33 -0700 additional point- from the Reader view, the formatting for the email function is just fine. It is only the PDF export that formats incorrectly. 641024 6 skepticus 2012-06-04 17:26:34 -0700 additional point- from the Reader view, the formatting for the email function is just fine. It is only the PDF export that formats incorrectly. 641038 7 beidson 2012-06-04 17:37:12 -0700 (In reply to comment #5) > additional point- from the Reader view, the formatting for the email function is just fine. It is only the PDF export that formats incorrectly. For the sake of the WebKit engineers, "PDF export" is not specifically interesting. "Printing mode" is what is interesting. 641058 8 vitalybuka 2012-06-04 17:55:45 -0700 Does any one work on this? I can try to localize, but there is probability that Reader does something to compensate bug fixed in my patch. 641077 9 ap 2012-06-04 18:11:00 -0700 > I can try to localize, but there is probability that Reader does something to compensate bug fixed in my patch. I don't know if Reader does something unusual here, but it certainly doesn't try to compensate for bug 85118 - simply because Safari never shipped with a version of WebKit that had this problem. 641088 10 vitalybuka 2012-06-04 18:27:31 -0700 (In reply to comment #9) > > I can try to localize, but there is probability that Reader does something to compensate bug fixed in my patch. > > I don't know if Reader does something unusual here, but it certainly doesn't try to compensate for bug 85118 - simply because Safari never shipped with a version of WebKit that had this problem. My CL fixed two independent issues: 1. Source/WebCore/page/Frame.cpp. It was not shipped with with Safari. And it's unrelated to this issue. 2. Source/WebCore/rendering/RenderView.cpp. It was shipped and present for a long time. For most sites it's just a little strange iframe content when printing. But http://code.google.com/p/chromium/source/search is not printed at all. If you revert just RenderView.cpp or just use official Safari you'll see difference on layout tests attached to that bug. Content of iframes alined incorrectly after printing. 641094 11 vitalybuka 2012-06-04 18:36:32 -0700 > If you revert just RenderView.cpp or just use official Safari you'll see difference on layout tests attached to that bug. Content of iframes alined incorrectly after printing. Actually I am not so sure. I need to experiment with this a little more. 641162 12 vitalybuka 2012-06-04 21:06:28 -0700 I believe I understand the issue. Base assumption of my CL was that only root frame should handle page size. It ok for regular printing. However Reader requests to print subframe only. So correct condition should be to check page size in closest to root printed frame. I'll send patch for review soon. 641260 13 145716 vitalybuka 2012-06-05 01:02:58 -0700 Created attachment 145716 Regression fix for Reader printing. 641263 14 webkit.review.bot 2012-06-05 01:04:35 -0700 Attachment 145716 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/page/Frame.cpp:539: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WebCore/page/Frame.cpp:540: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 641267 15 145717 vitalybuka 2012-06-05 01:08:17 -0700 Created attachment 145717 Regression fix for Reader printing. 641594 16 145717 beidson 2012-06-05 08:40:03 -0700 Comment on attachment 145717 Regression fix for Reader printing. View in context: https://bugs.webkit.org/attachment.cgi?id=145717&action=review > Source/WebCore/page/Frame.cpp:542 > + // Only top frame being printed should be fit to page > + // size. Subframes should be constrained by parents only. > + return m_doc->printing() && (!tree()->parent() || !tree()->parent()->m_doc->printing()); This is the OCD in me; To clean up this comment please move "size." that starts the second line up to the end of the first line 641794 17 145853 vitalybuka 2012-06-05 12:11:00 -0700 Created attachment 145853 Regression fix for Reader printing. 641796 18 145717 vitalybuka 2012-06-05 12:11:42 -0700 Comment on attachment 145717 Regression fix for Reader printing. View in context: https://bugs.webkit.org/attachment.cgi?id=145717&action=review >> Source/WebCore/page/Frame.cpp:542 >> + return m_doc->printing() && (!tree()->parent() || !tree()->parent()->m_doc->printing()); > > This is the OCD in me; To clean up this comment please move "size." that starts the second line up to the end of the first line Done 642088 19 darin 2012-06-05 18:51:15 -0700 Committed r119548: <http://trac.webkit.org/changeset/119548> 145496 2012-06-03 17:30:59 -0700 2012-06-03 17:30:59 -0700 screenshot of resulting incorrect formatting click 2012-06-03 at 20.24.38 .jpg image/jpeg 0 skepticus 145716 2012-06-05 01:02:58 -0700 2012-06-05 01:08:17 -0700 Regression fix for Reader printing. reader.patch text/plain 3633 vitalybuka SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExOTQ2NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA2LTA1ICBWaXRhbHkg QnVrYSAgPHZpdGFseWJ1a2FAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFNwZWNpYWwgbGF5b3V0 IGhhbmRsZXIgc2hvdWxkIGJlIGRvbmUgb24gdG9wIGZyYW1lIGJlaW5nIHByaW50ZWQuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODIwMQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4g Um9vdCBjYXNlIGlzIGFscmVhZHkgY292ZXJlZCBieSB0ZXN0cy4KKyAgICAgICAgQ2FzZSBkZXNj cmliZWQgaW4gdGhlIGlzc3VlIGNhbiBiZSByZXByb2R1Y2VkIG9ubHkgYnkgZGlyZWN0IGNhbGwK KyAgICAgICAgdG8gRnJhbWU6OnNldFByaW50aW5nIG9mIHN1YmZyYW1lLiBQcm9iYWJseSBpdCdz IG5vdCBwb3NzaWJsZSB3aXRoCisgICAgICAgIGxheW91dCB0ZXN0cy4KKworICAgICAgICAqIHBh Z2UvRnJhbWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWU6OnNldFByaW50aW5nKToKKyAg ICAgICAgVXNlIHNob3VsZFVzZVByaW50aW5nTGF5b3V0IHRvIGNob29zZSBwcm9wZXIgdmVyc2lv biBvZiBmb3JjZUxheW91dCgpLgorICAgICAgICAoV2ViQ29yZTo6RnJhbWU6OnNob3VsZFVzZVBy aW50aW5nTGF5b3V0KToKKyAgICAgICAgQ2hlY2tzIGlmIGN1cnJlbnQgZnJhbWUgaXMgdGhlIHRv cCBmcmFtZSBiZWluZyBwcmludGVkLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJWaWV3LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclZpZXc6OnNob3VsZFVzZVByaW50aW5nTGF5b3V0 KTogRm9yd2FyZCB0byBGcmFtZS4KKwogMjAxMi0wNi0wNSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3 ZWJraXQub3JnPgogCiAgICAgICAgIEV2ZW50SGFuZGxlciBzaG91bGRuJ3QgZGlzcGF0Y2ggZmFr ZSBtb3VzZW1vdmUgZXZlbnRzIHdoZW4gc2Nyb2xsaW5nIG9uIGRldmljZXMgdGhhdCBkb24ndCBo YXZlIGEgbW91c2UKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCShyZXZpc2lvbiAxMTk0NjQpCisr KyBTb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTIyLDcg KzUyMiw3IEBAIHZvaWQgRnJhbWU6OnNldFByaW50aW5nKGJvb2wgcHJpbnRpbmcsIGMKICAgICB2 aWV3KCktPmFkanVzdE1lZGlhVHlwZUZvclByaW50aW5nKHByaW50aW5nKTsKIAogICAgIG1fZG9j LT5zdHlsZVJlc29sdmVyQ2hhbmdlZChSZWNhbGNTdHlsZUltbWVkaWF0ZWx5KTsKLSAgICBpZiAo cHJpbnRpbmcgJiYgIXRyZWUoKS0+cGFyZW50KCkpIHsKKyAgICBpZiAoc2hvdWxkVXNlUHJpbnRp bmdMYXlvdXQoKSkgewogICAgICAgICAvLyBPbmx5IHJvb3QgZnJhbWUgc2hvdWxkIGJlIGZpdCB0 byBwYWdlIHNpemUuIFN1YmZyYW1lcyBzaG91bGQgYmUgY29uc3RyYWluZWQgYnkgcGFyZW50cyBv bmx5LgogICAgICAgICB2aWV3KCktPmZvcmNlTGF5b3V0Rm9yUGFnaW5hdGlvbihwYWdlU2l6ZSwg b3JpZ2luYWxQYWdlU2l6ZSwgbWF4aW11bVNocmlua1JhdGlvLCBzaG91bGRBZGp1c3RWaWV3U2l6 ZSk7CiAgICAgfSBlbHNlIHsKQEAgLTUzNiw2ICs1MzYsMTAgQEAgdm9pZCBGcmFtZTo6c2V0UHJp bnRpbmcoYm9vbCBwcmludGluZywgYwogICAgICAgICBjaGlsZC0+c2V0UHJpbnRpbmcocHJpbnRp bmcsIEZsb2F0U2l6ZSgpLCBGbG9hdFNpemUoKSwgMCwgc2hvdWxkQWRqdXN0Vmlld1NpemUpOwog fQogCitib29sIEZyYW1lOjpzaG91bGRVc2VQcmludGluZ0xheW91dCgpIGNvbnN0IHsKKyAgcmV0 dXJuIG1fZG9jLT5wcmludGluZygpICYmICghdHJlZSgpLT5wYXJlbnQoKSB8fCAhdHJlZSgpLT5w YXJlbnQoKS0+bV9kb2MtPnByaW50aW5nKCkpOworfQorCiBGbG9hdFNpemUgRnJhbWU6OnJlc2l6 ZVBhZ2VSZWN0c0tlZXBpbmdSYXRpbyhjb25zdCBGbG9hdFNpemUmIG9yaWdpbmFsU2l6ZSwgY29u c3QgRmxvYXRTaXplJiBleHBlY3RlZFNpemUpCiB7CiAgICAgRmxvYXRTaXplIHJlc3VsdFNpemU7 CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvcGFnZS9GcmFtZS5oCShyZXZpc2lvbiAxMTk0NjQpCisrKyBTb3VyY2UvV2ViQ29y ZS9wYWdlL0ZyYW1lLmgJKHdvcmtpbmcgY29weSkKQEAgLTE0MSw2ICsxNDEsNyBAQCBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAgICAgICAgIFNldHRpbmdzKiBzZXR0aW5ncygpIGNvbnN0OyAvLyBjYW4g YmUgTlVMTAogCiAgICAgICAgIHZvaWQgc2V0UHJpbnRpbmcoYm9vbCBwcmludGluZywgY29uc3Qg RmxvYXRTaXplJiBwYWdlU2l6ZSwgY29uc3QgRmxvYXRTaXplJiBvcmlnaW5hbFBhZ2VTaXplLCBm bG9hdCBtYXhpbXVtU2hyaW5rUmF0aW8sIEFkanVzdFZpZXdTaXplT3JOb3QpOworICAgICAgICBi b29sIHNob3VsZFVzZVByaW50aW5nTGF5b3V0KCkgY29uc3Q7CiAgICAgICAgIEZsb2F0U2l6ZSBy ZXNpemVQYWdlUmVjdHNLZWVwaW5nUmF0aW8oY29uc3QgRmxvYXRTaXplJiBvcmlnaW5hbFNpemUs IGNvbnN0IEZsb2F0U2l6ZSYgZXhwZWN0ZWRTaXplKTsKIAogICAgICAgICBib29sIGluVmlld1Nv dXJjZU1vZGUoKSBjb25zdDsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJW aWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmll dy5jcHAJKHJldmlzaW9uIDExOTQ2NCkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjU2LDggKzY1Niw3IEBAIGJvb2wgUmVuZGVy Vmlldzo6c2hvdWxkVXNlUHJpbnRpbmdMYXlvdXQKICAgICBpZiAoIXByaW50aW5nKCkgfHwgIW1f ZnJhbWVWaWV3KQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgRnJhbWUqIGZyYW1lID0gbV9m cmFtZVZpZXctPmZyYW1lKCk7Ci0gICAgLy8gT25seSByb290IGZyYW1lIHNob3VsZCBoYXZlIHNw ZWNpYWwgaGFuZGxpbmcgZm9yIHByaW50aW5nLgotICAgIHJldHVybiBmcmFtZSAmJiAhZnJhbWUt PnRyZWUoKS0+cGFyZW50KCk7CisgICAgcmV0dXJuIGZyYW1lICYmIGZyYW1lLT5zaG91bGRVc2VQ cmludGluZ0xheW91dCgpOwogfQogCiBzaXplX3QgUmVuZGVyVmlldzo6Z2V0UmV0YWluZWRXaWRn ZXRzKFZlY3RvcjxSZW5kZXJXaWRnZXQqPiYgcmVuZGVyV2lkZ2V0cykK 145717 2012-06-05 01:08:17 -0700 2012-06-05 12:11:42 -0700 Regression fix for Reader printing. reader.patch text/plain 3790 vitalybuka SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExOTQ2NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA2LTA1ICBWaXRhbHkg QnVrYSAgPHZpdGFseWJ1a2FAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFNwZWNpYWwgbGF5b3V0 IGhhbmRsZXIgc2hvdWxkIGJlIGRvbmUgb24gdG9wIGZyYW1lIGJlaW5nIHByaW50ZWQuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODIwMQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4g Um9vdCBjYXNlIGlzIGFscmVhZHkgY292ZXJlZCBieSB0ZXN0cy4KKyAgICAgICAgQ2FzZSBkZXNj cmliZWQgaW4gdGhlIGlzc3VlIGNhbiBiZSByZXByb2R1Y2VkIG9ubHkgYnkgZGlyZWN0IGNhbGwK KyAgICAgICAgdG8gRnJhbWU6OnNldFByaW50aW5nIG9mIHN1YmZyYW1lLiBQcm9iYWJseSBpdCdz IG5vdCBwb3NzaWJsZSB3aXRoCisgICAgICAgIGxheW91dCB0ZXN0cy4KKworICAgICAgICAqIHBh Z2UvRnJhbWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWU6OnNldFByaW50aW5nKToKKyAg ICAgICAgVXNlIHNob3VsZFVzZVByaW50aW5nTGF5b3V0IHRvIGNob29zZSBwcm9wZXIgdmVyc2lv biBvZiBmb3JjZUxheW91dCgpLgorICAgICAgICAoV2ViQ29yZTo6RnJhbWU6OnNob3VsZFVzZVBy aW50aW5nTGF5b3V0KToKKyAgICAgICAgQ2hlY2tzIGlmIGN1cnJlbnQgZnJhbWUgaXMgdGhlIHRv cCBmcmFtZSBiZWluZyBwcmludGVkLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJWaWV3LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclZpZXc6OnNob3VsZFVzZVByaW50aW5nTGF5b3V0 KTogRm9yd2FyZCB0byBGcmFtZS4KKwogMjAxMi0wNi0wNSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3 ZWJraXQub3JnPgogCiAgICAgICAgIEV2ZW50SGFuZGxlciBzaG91bGRuJ3QgZGlzcGF0Y2ggZmFr ZSBtb3VzZW1vdmUgZXZlbnRzIHdoZW4gc2Nyb2xsaW5nIG9uIGRldmljZXMgdGhhdCBkb24ndCBo YXZlIGEgbW91c2UKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCShyZXZpc2lvbiAxMTk0NjQpCisr KyBTb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTIyLDgg KzUyMiw3IEBAIHZvaWQgRnJhbWU6OnNldFByaW50aW5nKGJvb2wgcHJpbnRpbmcsIGMKICAgICB2 aWV3KCktPmFkanVzdE1lZGlhVHlwZUZvclByaW50aW5nKHByaW50aW5nKTsKIAogICAgIG1fZG9j LT5zdHlsZVJlc29sdmVyQ2hhbmdlZChSZWNhbGNTdHlsZUltbWVkaWF0ZWx5KTsKLSAgICBpZiAo cHJpbnRpbmcgJiYgIXRyZWUoKS0+cGFyZW50KCkpIHsKLSAgICAgICAgLy8gT25seSByb290IGZy YW1lIHNob3VsZCBiZSBmaXQgdG8gcGFnZSBzaXplLiBTdWJmcmFtZXMgc2hvdWxkIGJlIGNvbnN0 cmFpbmVkIGJ5IHBhcmVudHMgb25seS4KKyAgICBpZiAoc2hvdWxkVXNlUHJpbnRpbmdMYXlvdXQo KSkgewogICAgICAgICB2aWV3KCktPmZvcmNlTGF5b3V0Rm9yUGFnaW5hdGlvbihwYWdlU2l6ZSwg b3JpZ2luYWxQYWdlU2l6ZSwgbWF4aW11bVNocmlua1JhdGlvLCBzaG91bGRBZGp1c3RWaWV3U2l6 ZSk7CiAgICAgfSBlbHNlIHsKICAgICAgICAgdmlldygpLT5mb3JjZUxheW91dCgpOwpAQCAtNTM2 LDYgKzUzNSwxMyBAQCB2b2lkIEZyYW1lOjpzZXRQcmludGluZyhib29sIHByaW50aW5nLCBjCiAg ICAgICAgIGNoaWxkLT5zZXRQcmludGluZyhwcmludGluZywgRmxvYXRTaXplKCksIEZsb2F0U2l6 ZSgpLCAwLCBzaG91bGRBZGp1c3RWaWV3U2l6ZSk7CiB9CiAKK2Jvb2wgRnJhbWU6OnNob3VsZFVz ZVByaW50aW5nTGF5b3V0KCkgY29uc3QKK3sKKyAgICAvLyBPbmx5IHRvcCBmcmFtZSBiZWluZyBw cmludGVkIHNob3VsZCBiZSBmaXQgdG8gcGFnZQorICAgIC8vIHNpemUuIFN1YmZyYW1lcyBzaG91 bGQgYmUgY29uc3RyYWluZWQgYnkgcGFyZW50cyBvbmx5LgorICAgIHJldHVybiBtX2RvYy0+cHJp bnRpbmcoKSAmJiAoIXRyZWUoKS0+cGFyZW50KCkgfHwgIXRyZWUoKS0+cGFyZW50KCktPm1fZG9j LT5wcmludGluZygpKTsKK30KKwogRmxvYXRTaXplIEZyYW1lOjpyZXNpemVQYWdlUmVjdHNLZWVw aW5nUmF0aW8oY29uc3QgRmxvYXRTaXplJiBvcmlnaW5hbFNpemUsIGNvbnN0IEZsb2F0U2l6ZSYg ZXhwZWN0ZWRTaXplKQogewogICAgIEZsb2F0U2l6ZSByZXN1bHRTaXplOwpJbmRleDogU291cmNl L1dlYkNvcmUvcGFnZS9GcmFtZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2Uv RnJhbWUuaAkocmV2aXNpb24gMTE5NDY0KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5o CSh3b3JraW5nIGNvcHkpCkBAIC0xNDEsNiArMTQxLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog ICAgICAgICBTZXR0aW5ncyogc2V0dGluZ3MoKSBjb25zdDsgLy8gY2FuIGJlIE5VTEwKIAogICAg ICAgICB2b2lkIHNldFByaW50aW5nKGJvb2wgcHJpbnRpbmcsIGNvbnN0IEZsb2F0U2l6ZSYgcGFn ZVNpemUsIGNvbnN0IEZsb2F0U2l6ZSYgb3JpZ2luYWxQYWdlU2l6ZSwgZmxvYXQgbWF4aW11bVNo cmlua1JhdGlvLCBBZGp1c3RWaWV3U2l6ZU9yTm90KTsKKyAgICAgICAgYm9vbCBzaG91bGRVc2VQ cmludGluZ0xheW91dCgpIGNvbnN0OwogICAgICAgICBGbG9hdFNpemUgcmVzaXplUGFnZVJlY3Rz S2VlcGluZ1JhdGlvKGNvbnN0IEZsb2F0U2l6ZSYgb3JpZ2luYWxTaXplLCBjb25zdCBGbG9hdFNp emUmIGV4cGVjdGVkU2l6ZSk7CiAKICAgICAgICAgYm9vbCBpblZpZXdTb3VyY2VNb2RlKCkgY29u c3Q7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuY3BwCShyZXZpc2lv biAxMTk0NjQpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTY1Niw4ICs2NTYsNyBAQCBib29sIFJlbmRlclZpZXc6OnNob3VsZFVz ZVByaW50aW5nTGF5b3V0CiAgICAgaWYgKCFwcmludGluZygpIHx8ICFtX2ZyYW1lVmlldykKICAg ICAgICAgcmV0dXJuIGZhbHNlOwogICAgIEZyYW1lKiBmcmFtZSA9IG1fZnJhbWVWaWV3LT5mcmFt ZSgpOwotICAgIC8vIE9ubHkgcm9vdCBmcmFtZSBzaG91bGQgaGF2ZSBzcGVjaWFsIGhhbmRsaW5n IGZvciBwcmludGluZy4KLSAgICByZXR1cm4gZnJhbWUgJiYgIWZyYW1lLT50cmVlKCktPnBhcmVu dCgpOworICAgIHJldHVybiBmcmFtZSAmJiBmcmFtZS0+c2hvdWxkVXNlUHJpbnRpbmdMYXlvdXQo KTsKIH0KIAogc2l6ZV90IFJlbmRlclZpZXc6OmdldFJldGFpbmVkV2lkZ2V0cyhWZWN0b3I8UmVu ZGVyV2lkZ2V0Kj4mIHJlbmRlcldpZGdldHMpCg== 145853 2012-06-05 12:11:00 -0700 2012-06-05 13:00:41 -0700 Regression fix for Reader printing. reader.patch text/plain 3790 vitalybuka SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExOTQ2NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA2LTA1ICBWaXRhbHkg QnVrYSAgPHZpdGFseWJ1a2FAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFNwZWNpYWwgbGF5b3V0 IGhhbmRsZXIgc2hvdWxkIGJlIGRvbmUgb24gdG9wIGZyYW1lIGJlaW5nIHByaW50ZWQuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODIwMQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4g Um9vdCBjYXNlIGlzIGFscmVhZHkgY292ZXJlZCBieSB0ZXN0cy4KKyAgICAgICAgQ2FzZSBkZXNj cmliZWQgaW4gdGhlIGlzc3VlIGNhbiBiZSByZXByb2R1Y2VkIG9ubHkgYnkgZGlyZWN0IGNhbGwK KyAgICAgICAgdG8gRnJhbWU6OnNldFByaW50aW5nIG9mIHN1YmZyYW1lLiBQcm9iYWJseSBpdCdz IG5vdCBwb3NzaWJsZSB3aXRoCisgICAgICAgIGxheW91dCB0ZXN0cy4KKworICAgICAgICAqIHBh Z2UvRnJhbWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWU6OnNldFByaW50aW5nKToKKyAg ICAgICAgVXNlIHNob3VsZFVzZVByaW50aW5nTGF5b3V0IHRvIGNob29zZSBwcm9wZXIgdmVyc2lv biBvZiBmb3JjZUxheW91dCgpLgorICAgICAgICAoV2ViQ29yZTo6RnJhbWU6OnNob3VsZFVzZVBy aW50aW5nTGF5b3V0KToKKyAgICAgICAgQ2hlY2tzIGlmIGN1cnJlbnQgZnJhbWUgaXMgdGhlIHRv cCBmcmFtZSBiZWluZyBwcmludGVkLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJWaWV3LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclZpZXc6OnNob3VsZFVzZVByaW50aW5nTGF5b3V0 KTogRm9yd2FyZCB0byBGcmFtZS4KKwogMjAxMi0wNi0wNSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3 ZWJraXQub3JnPgogCiAgICAgICAgIEV2ZW50SGFuZGxlciBzaG91bGRuJ3QgZGlzcGF0Y2ggZmFr ZSBtb3VzZW1vdmUgZXZlbnRzIHdoZW4gc2Nyb2xsaW5nIG9uIGRldmljZXMgdGhhdCBkb24ndCBo YXZlIGEgbW91c2UKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCShyZXZpc2lvbiAxMTk0NjQpCisr KyBTb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTIyLDgg KzUyMiw3IEBAIHZvaWQgRnJhbWU6OnNldFByaW50aW5nKGJvb2wgcHJpbnRpbmcsIGMKICAgICB2 aWV3KCktPmFkanVzdE1lZGlhVHlwZUZvclByaW50aW5nKHByaW50aW5nKTsKIAogICAgIG1fZG9j LT5zdHlsZVJlc29sdmVyQ2hhbmdlZChSZWNhbGNTdHlsZUltbWVkaWF0ZWx5KTsKLSAgICBpZiAo cHJpbnRpbmcgJiYgIXRyZWUoKS0+cGFyZW50KCkpIHsKLSAgICAgICAgLy8gT25seSByb290IGZy YW1lIHNob3VsZCBiZSBmaXQgdG8gcGFnZSBzaXplLiBTdWJmcmFtZXMgc2hvdWxkIGJlIGNvbnN0 cmFpbmVkIGJ5IHBhcmVudHMgb25seS4KKyAgICBpZiAoc2hvdWxkVXNlUHJpbnRpbmdMYXlvdXQo KSkgewogICAgICAgICB2aWV3KCktPmZvcmNlTGF5b3V0Rm9yUGFnaW5hdGlvbihwYWdlU2l6ZSwg b3JpZ2luYWxQYWdlU2l6ZSwgbWF4aW11bVNocmlua1JhdGlvLCBzaG91bGRBZGp1c3RWaWV3U2l6 ZSk7CiAgICAgfSBlbHNlIHsKICAgICAgICAgdmlldygpLT5mb3JjZUxheW91dCgpOwpAQCAtNTM2 LDYgKzUzNSwxMyBAQCB2b2lkIEZyYW1lOjpzZXRQcmludGluZyhib29sIHByaW50aW5nLCBjCiAg ICAgICAgIGNoaWxkLT5zZXRQcmludGluZyhwcmludGluZywgRmxvYXRTaXplKCksIEZsb2F0U2l6 ZSgpLCAwLCBzaG91bGRBZGp1c3RWaWV3U2l6ZSk7CiB9CiAKK2Jvb2wgRnJhbWU6OnNob3VsZFVz ZVByaW50aW5nTGF5b3V0KCkgY29uc3QKK3sKKyAgICAvLyBPbmx5IHRvcCBmcmFtZSBiZWluZyBw cmludGVkIHNob3VsZCBiZSBmaXQgdG8gcGFnZSBzaXplLgorICAgIC8vIFN1YmZyYW1lcyBzaG91 bGQgYmUgY29uc3RyYWluZWQgYnkgcGFyZW50cyBvbmx5LgorICAgIHJldHVybiBtX2RvYy0+cHJp bnRpbmcoKSAmJiAoIXRyZWUoKS0+cGFyZW50KCkgfHwgIXRyZWUoKS0+cGFyZW50KCktPm1fZG9j LT5wcmludGluZygpKTsKK30KKwogRmxvYXRTaXplIEZyYW1lOjpyZXNpemVQYWdlUmVjdHNLZWVw aW5nUmF0aW8oY29uc3QgRmxvYXRTaXplJiBvcmlnaW5hbFNpemUsIGNvbnN0IEZsb2F0U2l6ZSYg ZXhwZWN0ZWRTaXplKQogewogICAgIEZsb2F0U2l6ZSByZXN1bHRTaXplOwpJbmRleDogU291cmNl L1dlYkNvcmUvcGFnZS9GcmFtZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2Uv RnJhbWUuaAkocmV2aXNpb24gMTE5NDY0KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5o CSh3b3JraW5nIGNvcHkpCkBAIC0xNDEsNiArMTQxLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog ICAgICAgICBTZXR0aW5ncyogc2V0dGluZ3MoKSBjb25zdDsgLy8gY2FuIGJlIE5VTEwKIAogICAg ICAgICB2b2lkIHNldFByaW50aW5nKGJvb2wgcHJpbnRpbmcsIGNvbnN0IEZsb2F0U2l6ZSYgcGFn ZVNpemUsIGNvbnN0IEZsb2F0U2l6ZSYgb3JpZ2luYWxQYWdlU2l6ZSwgZmxvYXQgbWF4aW11bVNo cmlua1JhdGlvLCBBZGp1c3RWaWV3U2l6ZU9yTm90KTsKKyAgICAgICAgYm9vbCBzaG91bGRVc2VQ cmludGluZ0xheW91dCgpIGNvbnN0OwogICAgICAgICBGbG9hdFNpemUgcmVzaXplUGFnZVJlY3Rz S2VlcGluZ1JhdGlvKGNvbnN0IEZsb2F0U2l6ZSYgb3JpZ2luYWxTaXplLCBjb25zdCBGbG9hdFNp emUmIGV4cGVjdGVkU2l6ZSk7CiAKICAgICAgICAgYm9vbCBpblZpZXdTb3VyY2VNb2RlKCkgY29u c3Q7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuY3BwCShyZXZpc2lv biAxMTk0NjQpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTY1Niw4ICs2NTYsNyBAQCBib29sIFJlbmRlclZpZXc6OnNob3VsZFVz ZVByaW50aW5nTGF5b3V0CiAgICAgaWYgKCFwcmludGluZygpIHx8ICFtX2ZyYW1lVmlldykKICAg ICAgICAgcmV0dXJuIGZhbHNlOwogICAgIEZyYW1lKiBmcmFtZSA9IG1fZnJhbWVWaWV3LT5mcmFt ZSgpOwotICAgIC8vIE9ubHkgcm9vdCBmcmFtZSBzaG91bGQgaGF2ZSBzcGVjaWFsIGhhbmRsaW5n IGZvciBwcmludGluZy4KLSAgICByZXR1cm4gZnJhbWUgJiYgIWZyYW1lLT50cmVlKCktPnBhcmVu dCgpOworICAgIHJldHVybiBmcmFtZSAmJiBmcmFtZS0+c2hvdWxkVXNlUHJpbnRpbmdMYXlvdXQo KTsKIH0KIAogc2l6ZV90IFJlbmRlclZpZXc6OmdldFJldGFpbmVkV2lkZ2V0cyhWZWN0b3I8UmVu ZGVyV2lkZ2V0Kj4mIHJlbmRlcldpZGdldHMpCg==