88197 2012-06-03 13:21:55 -0700 ASSERTION FAILED: ASSERT(!isPercentageIntrinsicSize) in RenderReplaced::computeIntrinsicRatioInformationForRenderBox 2012-06-05 23:53:32 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dbates webkit-unassigned eric joethomas krit rwlbuis thorton webkit.review.bot zimmermann oldest_to_newest 640233 0 dbates 2012-06-03 13:21:55 -0700 Consider a file with the following markup: <style>svg { max-height:5%; }</style> <svg></svg> Opening this file will cause ASSERT(!isPercentageIntrinsicSize) to fail in RenderReplaced::computeIntrinsicRatioInformationForRenderBox(), <http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderReplaced.cpp?rev=117697#L293>. 640234 1 145493 dbates 2012-06-03 13:23:05 -0700 Created attachment 145493 Example (Will cause assertion failure) For convenience, a file that contains the markup described in the bug description. 641611 2 joethomas 2012-06-05 08:59:30 -0700 Looks to me like the assertion ASSERT(!isPercentageIntrinsicSize) is not correct as RenderSVGRoot::computeIntrinsicRatioInformation sets isPercentageIntrinsicSize to true while it handles width/height of Percentage types. I will make a patch to remove this. 641901 3 145870 joethomas 2012-06-05 14:39:59 -0700 Created attachment 145870 patch 641985 4 145870 dbates 2012-06-05 16:11:23 -0700 Comment on attachment 145870 patch View in context: https://bugs.webkit.org/attachment.cgi?id=145870&action=review > Source/WebCore/ChangeLog:9 > + ASSERT(!isPercentageIntrinsicSize) is not correct as RenderSVGRoot::computeIntrinsicRatioInformation sets isPercentageIntrinsicSize > + to true while it handles width/height of Percentage types. It's an undocumented convention that we wrap long lines in change log entries. I suggest adding a new line character after "RenderSVGRoot::computeIntrinsicRatioInformation" in line 8 such that we move the phrase "sets isPercentageIntrinsicSize" onto line 9. You may also want to consider adding a remark that explains that RenderSVGRoot extends RenderReplaced so as to more explicitly imply that RenderSVGRoot overrides RenderReplaced::computeIntrinsicRatioInformation(). Nit: Percentage => percentage (as it's not a proper noun) > Source/WebCore/rendering/RenderReplaced.cpp:-293 > - ASSERT(!isPercentageIntrinsicSize); Would it make sense to assert !isPercentageIntrinsicSize when intrinsicRatio is non-zero? > LayoutTests/ChangeLog:9 > + ASSERT(!isPercentageIntrinsicSize) is not correct as RenderSVGRoot::computeIntrinsicRatioInformation sets isPercentageIntrinsicSize > + to true while it handles width/height of Percentage types. Ditto. > LayoutTests/svg/in-html/svg-assert-failure-percentage.html:7 > +<svg style= "max-height:5%"> </svg> Nit: There's a space after the '=' in this line. I suggest we remove this space so as to be consistent with the spacing (or lack of) on the left side of the equality sign. > LayoutTests/svg/in-html/svg-assert-failure-percentage.html:8 > +NO Assert! This output message isn't formatted well. On another note, maybe the following text would be more description: This test PASSED if it doesn't cause an assertion failure. 642026 5 145899 joethomas 2012-06-05 17:13:32 -0700 Created attachment 145899 Patch-Updated Review comments incorporated 642029 6 joethomas 2012-06-05 17:16:04 -0700 (In reply to comment #4) > (From update of attachment 145870 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=145870&action=review > Thanks for the review. > > Source/WebCore/ChangeLog:9 > > + ASSERT(!isPercentageIntrinsicSize) is not correct as RenderSVGRoot::computeIntrinsicRatioInformation sets isPercentageIntrinsicSize > > + to true while it handles width/height of Percentage types. > > It's an undocumented convention that we wrap long lines in change log entries. I suggest adding a new line character after "RenderSVGRoot::computeIntrinsicRatioInformation" in line 8 such that we move the phrase "sets isPercentageIntrinsicSize" onto line 9. You may also want to consider adding a remark that explains that RenderSVGRoot extends RenderReplaced so as to more explicitly imply that RenderSVGRoot overrides RenderReplaced::computeIntrinsicRatioInformation(). > > Nit: Percentage => percentage > (as it's not a proper noun) > Done > > Source/WebCore/rendering/RenderReplaced.cpp:-293 > > - ASSERT(!isPercentageIntrinsicSize); > > Would it make sense to assert !isPercentageIntrinsicSize when intrinsicRatio is non-zero? > Yes, I think that is better. Changed. > > LayoutTests/ChangeLog:9 > > + ASSERT(!isPercentageIntrinsicSize) is not correct as RenderSVGRoot::computeIntrinsicRatioInformation sets isPercentageIntrinsicSize > > + to true while it handles width/height of Percentage types. > > Ditto. > > > LayoutTests/svg/in-html/svg-assert-failure-percentage.html:7 > > +<svg style= "max-height:5%"> </svg> > > Nit: There's a space after the '=' in this line. I suggest we remove this space so as to be consistent with the spacing (or lack of) on the left side of the equality sign. > > > LayoutTests/svg/in-html/svg-assert-failure-percentage.html:8 > > +NO Assert! > > This output message isn't formatted well. On another note, maybe the following text would be more description: > > This test PASSED if it doesn't cause an assertion failure. Done. 642038 7 145899 dbates 2012-06-05 17:24:17 -0700 Comment on attachment 145899 Patch-Updated Thanks Joe for updating the patch. Looks reasonable to me. 642230 8 145899 webkit.review.bot 2012-06-05 23:53:26 -0700 Comment on attachment 145899 Patch-Updated Clearing flags on attachment: 145899 Committed r119565: <http://trac.webkit.org/changeset/119565> 642231 9 webkit.review.bot 2012-06-05 23:53:32 -0700 All reviewed patches have been landed. Closing bug. 145493 2012-06-03 13:23:05 -0700 2012-06-03 13:23:05 -0700 Example (Will cause assertion failure) example.html text/html 49 dbates PHN0eWxlPnN2ZyB7IG1heC1oZWlnaHQ6NSU7IH08L3N0eWxlPgo8c3ZnPjwvc3ZnPg== 145870 2012-06-05 14:39:59 -0700 2012-06-05 17:13:32 -0700 patch patch text/plain 3504 joethomas SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExOTUxMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA2LTA1ICBKb2UgVGhv bWFzICA8am9ldGhvbWFzQG1vdG9yb2xhLmNvbT4KKworICAgICAgICBBU1NFUlRJT04gRkFJTEVE OiBBU1NFUlQoIWlzUGVyY2VudGFnZUludHJpbnNpY1NpemUpIGluIFJlbmRlclJlcGxhY2VkOjpj b21wdXRlSW50cmluc2ljUmF0aW9JbmZvcm1hdGlvbkZvclJlbmRlckJveAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODgxOTcKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBU1NFUlQoIWlzUGVyY2VudGFnZUlu dHJpbnNpY1NpemUpIGlzIG5vdCBjb3JyZWN0IGFzIFJlbmRlclNWR1Jvb3Q6OmNvbXB1dGVJbnRy aW5zaWNSYXRpb0luZm9ybWF0aW9uIHNldHMgaXNQZXJjZW50YWdlSW50cmluc2ljU2l6ZQorICAg ICAgICB0byB0cnVlIHdoaWxlIGl0IGhhbmRsZXMgd2lkdGgvaGVpZ2h0IG9mIFBlcmNlbnRhZ2Ug dHlwZXMuCisKKyAgICAgICAgVGVzdDogc3ZnL2luLWh0bWwvc3ZnLWFzc2VydC1mYWlsdXJlLXBl cmNlbnRhZ2UuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclJlcGxhY2VkLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclJlcGxhY2VkOjpjb21wdXRlSW50cmluc2ljUmF0aW9J bmZvcm1hdGlvbkZvclJlbmRlckJveCk6CisKIDIwMTItMDYtMDUgIEdyZWcgQmlsbG9jayAgPGdi aWxsb2NrQGdvb2dsZS5jb20+CiAKICAgICAgICAgTmV3IGNvbnN0cnVjdG9yIGZvciBXZWJJbnRl bnQgdG8gYmUgdXNlZCBmb3IgZGVsaXZlcnkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJSZXBsYWNlZC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclJlcGxhY2VkLmNwcAkocmV2aXNpb24gMTE5NTEyKQorKysgU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclJlcGxhY2VkLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjg3LDEw ICsyODcsNyBAQCB2b2lkIFJlbmRlclJlcGxhY2VkOjpjb21wdXRlSW50cmluc2ljUmF0CiAgICAg ICAgICAgICBpbnRyaW5zaWNSYXRpbyA9IDE7CiAgICAgICAgIHJldHVybjsKICAgICB9Ci0KLSAg ICAvLyBUaGlzIGNvZGUgcGF0aCBjYW4ndCB5aWVsZCBwZXJjZW50YWdlIGludHJpbnNpYyBzaXpl cywgYXNzZXJ0IHRoYXQuCiAgICAgY29tcHV0ZUludHJpbnNpY1JhdGlvSW5mb3JtYXRpb24oaW50 cmluc2ljU2l6ZSwgaW50cmluc2ljUmF0aW8sIGlzUGVyY2VudGFnZUludHJpbnNpY1NpemUpOwot ICAgIEFTU0VSVCghaXNQZXJjZW50YWdlSW50cmluc2ljU2l6ZSk7CiB9CiAKIHZvaWQgUmVuZGVy UmVwbGFjZWQ6OmNvbXB1dGVJbnRyaW5zaWNSYXRpb0luZm9ybWF0aW9uKEZsb2F0U2l6ZSYgaW50 cmluc2ljU2l6ZSwgZG91YmxlJiBpbnRyaW5zaWNSYXRpbywgYm9vbCYgaXNQZXJjZW50YWdlSW50 cmluc2ljU2l6ZSkgY29uc3QKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDExOTUxMikKKysrIExheW91dFRl c3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA2LTA1 ICBKb2UgVGhvbWFzICA8am9ldGhvbWFzQG1vdG9yb2xhLmNvbT4KKworICAgICAgICBBU1NFUlRJ T04gRkFJTEVEOiBBU1NFUlQoIWlzUGVyY2VudGFnZUludHJpbnNpY1NpemUpIGluIFJlbmRlclJl cGxhY2VkOjpjb21wdXRlSW50cmluc2ljUmF0aW9JbmZvcm1hdGlvbkZvclJlbmRlckJveAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODgxOTcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBU1NFUlQoIWlzUGVy Y2VudGFnZUludHJpbnNpY1NpemUpIGlzIG5vdCBjb3JyZWN0IGFzIFJlbmRlclNWR1Jvb3Q6OmNv bXB1dGVJbnRyaW5zaWNSYXRpb0luZm9ybWF0aW9uIHNldHMgaXNQZXJjZW50YWdlSW50cmluc2lj U2l6ZQorICAgICAgICB0byB0cnVlIHdoaWxlIGl0IGhhbmRsZXMgd2lkdGgvaGVpZ2h0IG9mIFBl cmNlbnRhZ2UgdHlwZXMuCisKKyAgICAgICAgKiBzdmcvaW4taHRtbC9zdmctYXNzZXJ0LWZhaWx1 cmUtcGVyY2VudGFnZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHN2Zy9pbi1odG1s L3N2Zy1hc3NlcnQtZmFpbHVyZS1wZXJjZW50YWdlLmh0bWw6IEFkZGVkLgorCiAyMDEyLTA2LTA1 ICBFbWlsIEEgRWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBDaGFuZ2UgZmFz dC9zdWItcGl4ZWwvZmxvYXQtY29udGFpbmluZy1ibG9jay13aXRoLW1hcmdpbi5odG1sIHRvIHBp eGVsIHRlc3QKSW5kZXg6IExheW91dFRlc3RzL3N2Zy9pbi1odG1sL3N2Zy1hc3NlcnQtZmFpbHVy ZS1wZXJjZW50YWdlLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9zdmcv aW4taHRtbC9zdmctYXNzZXJ0LWZhaWx1cmUtcGVyY2VudGFnZS1leHBlY3RlZC50eHQJKHJldmlz aW9uIDApCisrKyBMYXlvdXRUZXN0cy9zdmcvaW4taHRtbC9zdmctYXNzZXJ0LWZhaWx1cmUtcGVy Y2VudGFnZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEgQEAKK05PIEFzc2Vy dCEKSW5kZXg6IExheW91dFRlc3RzL3N2Zy9pbi1odG1sL3N2Zy1hc3NlcnQtZmFpbHVyZS1wZXJj ZW50YWdlLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvc3ZnL2luLWh0bWwvc3ZnLWFz c2VydC1mYWlsdXJlLXBlcmNlbnRhZ2UuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3Rz L3N2Zy9pbi1odG1sL3N2Zy1hc3NlcnQtZmFpbHVyZS1wZXJjZW50YWdlLmh0bWwJKHJldmlzaW9u IDApCkBAIC0wLDAgKzEsOSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxzY3JpcHQ+Citp ZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgIGxheW91dFRlc3RDb250cm9sbGVy LmR1bXBBc1RleHQoKTsKKzwvc2NyaXB0PgorPHN2ZyBzdHlsZT0gIm1heC1oZWlnaHQ6NSUiPiA8 L3N2Zz4KK05PIEFzc2VydCEKKzwvaHRtbD4K 145899 2012-06-05 17:13:32 -0700 2012-06-05 23:53:26 -0700 Patch-Updated patch text/plain 3993 joethomas SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExOTUxMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA2LTA1ICBKb2UgVGhv bWFzICA8am9ldGhvbWFzQG1vdG9yb2xhLmNvbT4KKworICAgICAgICBBU1NFUlRJT04gRkFJTEVE OiBBU1NFUlQoIWlzUGVyY2VudGFnZUludHJpbnNpY1NpemUpIGluIFJlbmRlclJlcGxhY2VkOjpj b21wdXRlSW50cmluc2ljUmF0aW9JbmZvcm1hdGlvbkZvclJlbmRlckJveAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODgxOTcKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW5kZXJTVkdSb290IGV4dGVuZHMg UmVuZGVyUmVwbGFjZWQgYW5kIGl0IG92ZXJyaWRlcyB0aGUgY29tcHV0ZUludHJpbnNpY1JhdGlv SW5mb3JtYXRpb24oKSAKKyAgICAgICAgbWV0aG9kIG9mIFJlbmRlclJlcGxhY2VkLiBSZW5kZXJT VkdSb290Ojpjb21wdXRlSW50cmluc2ljUmF0aW9JbmZvcm1hdGlvbgorICAgICAgICBzZXRzIGlz UGVyY2VudGFnZUludHJpbnNpY1NpemUgdG8gdHJ1ZSB3aGlsZSBpdCBoYW5kbGVzIHdpZHRoIGFu ZCBoZWlnaHQgb2YgcGVyY2VudGFnZSB0eXBlcy4KKyAgICAgICAgU28gdGhpcyBhc3NlcnRpb24g c2hvdWxkIGJlIGZpcmVkIG9ubHkgaWYgaW50cmluc2ljUmF0aW8gaXMgbm9uLXplcm8uCisKKyAg ICAgICAgVGVzdDogc3ZnL2luLWh0bWwvc3ZnLWFzc2VydC1mYWlsdXJlLXBlcmNlbnRhZ2UuaHRt bAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclJlcGxhY2VkLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlclJlcGxhY2VkOjpjb21wdXRlSW50cmluc2ljUmF0aW9JbmZvcm1hdGlvbkZv clJlbmRlckJveCk6CisKIDIwMTItMDYtMDUgIEdyZWcgQmlsbG9jayAgPGdiaWxsb2NrQGdvb2ds ZS5jb20+CiAKICAgICAgICAgTmV3IGNvbnN0cnVjdG9yIGZvciBXZWJJbnRlbnQgdG8gYmUgdXNl ZCBmb3IgZGVsaXZlcnkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJSZXBs YWNlZC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclJl cGxhY2VkLmNwcAkocmV2aXNpb24gMTE5NTEyKQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlclJlcGxhY2VkLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjg3LDEwICsyODcsOSBAQCB2 b2lkIFJlbmRlclJlcGxhY2VkOjpjb21wdXRlSW50cmluc2ljUmF0CiAgICAgICAgICAgICBpbnRy aW5zaWNSYXRpbyA9IDE7CiAgICAgICAgIHJldHVybjsKICAgICB9Ci0KLSAgICAvLyBUaGlzIGNv ZGUgcGF0aCBjYW4ndCB5aWVsZCBwZXJjZW50YWdlIGludHJpbnNpYyBzaXplcywgYXNzZXJ0IHRo YXQuCiAgICAgY29tcHV0ZUludHJpbnNpY1JhdGlvSW5mb3JtYXRpb24oaW50cmluc2ljU2l6ZSwg aW50cmluc2ljUmF0aW8sIGlzUGVyY2VudGFnZUludHJpbnNpY1NpemUpOwotICAgIEFTU0VSVCgh aXNQZXJjZW50YWdlSW50cmluc2ljU2l6ZSk7CisgICAgaWYgKGludHJpbnNpY1JhdGlvKQorICAg ICAgICBBU1NFUlQoIWlzUGVyY2VudGFnZUludHJpbnNpY1NpemUpOwogfQogCiB2b2lkIFJlbmRl clJlcGxhY2VkOjpjb21wdXRlSW50cmluc2ljUmF0aW9JbmZvcm1hdGlvbihGbG9hdFNpemUmIGlu dHJpbnNpY1NpemUsIGRvdWJsZSYgaW50cmluc2ljUmF0aW8sIGJvb2wmIGlzUGVyY2VudGFnZUlu dHJpbnNpY1NpemUpIGNvbnN0CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTk1MTIpCisrKyBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxOCBAQAorMjAxMi0wNi0w NSAgSm9lIFRob21hcyAgPGpvZXRob21hc0Btb3Rvcm9sYS5jb20+CisKKyAgICAgICAgQVNTRVJU SU9OIEZBSUxFRDogQVNTRVJUKCFpc1BlcmNlbnRhZ2VJbnRyaW5zaWNTaXplKSBpbiBSZW5kZXJS ZXBsYWNlZDo6Y29tcHV0ZUludHJpbnNpY1JhdGlvSW5mb3JtYXRpb25Gb3JSZW5kZXJCb3gKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4MTk3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVuZGVyU1ZHUm9v dCBleHRlbmRzIFJlbmRlclJlcGxhY2VkIGFuZCBpdCBvdmVycmlkZXMgdGhlIGNvbXB1dGVJbnRy aW5zaWNSYXRpb0luZm9ybWF0aW9uKCkgCisgICAgICAgIG1ldGhvZCBvZiBSZW5kZXJSZXBsYWNl ZC4gUmVuZGVyU1ZHUm9vdDo6Y29tcHV0ZUludHJpbnNpY1JhdGlvSW5mb3JtYXRpb24KKyAgICAg ICAgc2V0cyBpc1BlcmNlbnRhZ2VJbnRyaW5zaWNTaXplIHRvIHRydWUgd2hpbGUgaXQgaGFuZGxl cyB3aWR0aCBhbmQgaGVpZ2h0IG9mIHBlcmNlbnRhZ2UgdHlwZXMuCisgICAgICAgIFNvIHRoaXMg YXNzZXJ0aW9uIHNob3VsZCBiZSBmaXJlZCBvbmx5IGlmIGludHJpbnNpY1JhdGlvIGlzIG5vbi16 ZXJvLgorCisgICAgICAgICogc3ZnL2luLWh0bWwvc3ZnLWFzc2VydC1mYWlsdXJlLXBlcmNlbnRh Z2UtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBzdmcvaW4taHRtbC9zdmctYXNzZXJ0 LWZhaWx1cmUtcGVyY2VudGFnZS5odG1sOiBBZGRlZC4KKwogMjAxMi0wNi0wNSAgRW1pbCBBIEVr bHVuZCAgPGVhZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQ2hhbmdlIGZhc3Qvc3ViLXBpeGVs L2Zsb2F0LWNvbnRhaW5pbmctYmxvY2std2l0aC1tYXJnaW4uaHRtbCB0byBwaXhlbCB0ZXN0Cklu ZGV4OiBMYXlvdXRUZXN0cy9zdmcvaW4taHRtbC9zdmctYXNzZXJ0LWZhaWx1cmUtcGVyY2VudGFn ZS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvc3ZnL2luLWh0bWwvc3Zn LWFzc2VydC1mYWlsdXJlLXBlcmNlbnRhZ2UtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysg TGF5b3V0VGVzdHMvc3ZnL2luLWh0bWwvc3ZnLWFzc2VydC1mYWlsdXJlLXBlcmNlbnRhZ2UtZXhw ZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxIEBACitUaGlzIHRlc3QgUEFTU0VEIGlm IGl0IGRvZXNuJ3QgY2F1c2UgYW4gYXNzZXJ0aW9uIGZhaWx1cmUuCkluZGV4OiBMYXlvdXRUZXN0 cy9zdmcvaW4taHRtbC9zdmctYXNzZXJ0LWZhaWx1cmUtcGVyY2VudGFnZS5odG1sCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL3N2Zy9pbi1odG1sL3N2Zy1hc3NlcnQtZmFpbHVyZS1wZXJjZW50 YWdlLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9zdmcvaW4taHRtbC9zdmctYXNz ZXJ0LWZhaWx1cmUtcGVyY2VudGFnZS5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDkgQEAK KzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0 Q29udHJvbGxlcikKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Cis8L3Nj cmlwdD4KKzxzdmcgc3R5bGU9Im1heC1oZWlnaHQ6NSUiPjwvc3ZnPgorPHA+VGhpcyB0ZXN0IFBB U1NFRCBpZiBpdCBkb2Vzbid0IGNhdXNlIGFuIGFzc2VydGlvbiBmYWlsdXJlLjwvcD4KKzwvaHRt bD4K